124324 2013-11-13 17:32:38 -0800 [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash 2013-11-14 10:19:19 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 giles_joplin giles_joplin commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 950457 0 216881 giles_joplin 2013-11-13 17:32:38 -0800 Created attachment 216881 Test case Polygon shape-inside values with less than three vertices and non-zero shape-padding cause an ASSERT crash. The same is true for shape-outside polygons and shape-margin. 950497 1 216891 giles_joplin 2013-11-13 19:52:13 -0800 Created attachment 216891 Patch PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no longer attempt to compute a new FloatPolygon when the original is empty, i.e. when it has less than three vertices. 950724 2 216891 kling 2013-11-14 09:39:10 -0800 Comment on attachment 216891 Patch r=me 950744 3 216891 commit-queue 2013-11-14 10:19:18 -0800 Comment on attachment 216891 Patch Clearing flags on attachment: 216891 Committed r159291: <http://trac.webkit.org/changeset/159291> 950745 4 commit-queue 2013-11-14 10:19:19 -0800 All reviewed patches have been landed. Closing bug. 216881 2013-11-13 17:32:38 -0800 2013-11-13 17:32:38 -0800 Test case webkit-test-case.html text/html 219 giles_joplin PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHN0eWxlPgojb25lLXZlcnRleC1wYWRkZWQt cG9seWdvbiB7IC13ZWJraXQtc2hhcGUtaW5zaWRlOiBwb2x5Z29uKDFweCAycHgpOyAtd2Via2l0 LXNoYXBlLXBhZGRpbmc6IDVweDsgfQo8L3N0eWxlPgo8Ym9keT4KICA8ZGl2IGlkPSJvbmUtdmVy dGV4LXBhZGRlZC1wb2x5Z29uIj5hIGIgYzwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 216891 2013-11-13 19:52:13 -0800 2013-11-14 10:19:17 -0800 Patch tmp.patch text/plain 6070 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMDk2Yzk4Li5jNDY0ZTE4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEt MTMgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBTaGFw ZXNdIEVtcHR5IHBvbHlnb25zIHdpdGggbm9uLXplcm8gc2hhcGUtcGFkZGluZyBjYXVzZSBhbiBB U1NFUlQgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNDMyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9zaGFwZXMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1lbXB0eS1wb2x5Z29u LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9zaGFwZXMvc2hhcGUt aW5zaWRlL3NoYXBlLWluc2lkZS1lbXB0eS1wb2x5Z29uLWNyYXNoLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxv YXRzLWVtcHR5LXBvbHlnb24tY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1lbXB0 eS1wb2x5Z29uLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEzLTExLTEzICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCBUZXN0IGFuaW1hdGlv bnMvcmVzdW1lLWFmdGVyLXBhZ2UtY2FjaGUuaHRtbCBpcyBmbGFreQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1lbXB0eS1wb2x5 Z29uLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLWlu c2lkZS9zaGFwZS1pbnNpZGUtZW1wdHktcG9seWdvbi1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWQ0MzQ3NQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtZW1wdHkt cG9seWdvbi1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3Qgc2hv dWxkIG5vdCBjcmFzaC4KK1plcm8KK09uZQorVHdvCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3NoYXBlcy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLWVtcHR5LXBvbHlnb24tY3Jhc2gu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUt ZW1wdHktcG9seWdvbi1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLjcwODdlYWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9z aGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLWVtcHR5LXBvbHlnb24tY3Jhc2guaHRtbApAQCAtMCww ICsxLDIyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPCEtLQorVGhpcyBpcyBhIHJlZ3Jl c3Npb24gdGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDMyNAorLS0+Cis8aGVhZD4KKzxzdHlsZT4KKyNwYWRkZWQtZW1wdHktcG9seWdvbi0wdmVydGV4 IHsgLXdlYmtpdC1zaGFwZS1pbnNpZGU6IHBvbHlnb24oKTsgLXdlYmtpdC1zaGFwZS1wYWRkaW5n OiA1cHg7IH0KKyNwYWRkZWQtZW1wdHktcG9seWdvbi0xdmVydGV4IHsgLXdlYmtpdC1zaGFwZS1p bnNpZGU6IHBvbHlnb24oMXB4IDJweCk7IC13ZWJraXQtc2hhcGUtcGFkZGluZzogNXB4OyB9Cisj cGFkZGVkLWVtcHR5LXBvbHlnb24tMnZlcnRleCB7IC13ZWJraXQtc2hhcGUtaW5zaWRlOiBwb2x5 Z29uKDFweCAycHgsIDNweCA0cHgpOyAtd2Via2l0LXNoYXBlLXBhZGRpbmc6IDVweDsgfQorPC9z dHlsZT4KKzxib2R5PgorICA8ZGl2PlRoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLjwvZGl2Pgor ICA8ZGl2IGlkPSJwYWRkZWQtZW1wdHktcG9seWdvbi0wdmVydGV4Ij5aZXJvPC9kaXY+CisgIDxk aXYgaWQ9InBhZGRlZC1lbXB0eS1wb2x5Z29uLTF2ZXJ0ZXgiPk9uZTwvZGl2PgorICA8ZGl2IGlk PSJwYWRkZWQtZW1wdHktcG9seWdvbi0ydmVydGV4Ij5Ud288L2Rpdj4KKyAgPHNjcmlwdD4KKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OworICA8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWVt cHR5LXBvbHlnb24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMv c2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZW1wdHktcG9seWdvbi1j cmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWQ0 MzQ3NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91 dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWVtcHR5LXBvbHlnb24tY3Jhc2gtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0IHNob3VsZCBub3QgY3Jhc2guCita ZXJvCitPbmUKK1R3bwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUt b3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZW1wdHktcG9seWdvbi1jcmFzaC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUt b3V0c2lkZS1mbG9hdHMtZW1wdHktcG9seWdvbi1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjdjYTIxZmMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1l bXB0eS1wb2x5Z29uLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzwhLS0KK1RoaXMgaXMgYSByZWdyZXNzaW9uIHRlc3QgZm9yIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzMjQKKy0tPgorPGhlYWQ+Cis8c3R5bGU+ CisjbWFyZ2luLWVtcHR5LXBvbHlnb24tMHZlcnRleCB7IC13ZWJraXQtc2hhcGUtb3V0c2lkZTog cG9seWdvbigpOyAtd2Via2l0LXNoYXBlLW1hcmdpbjogNXB4OyB9CisjbWFyZ2luLWVtcHR5LXBv bHlnb24tMXZlcnRleCB7IC13ZWJraXQtc2hhcGUtb3V0c2lkZTogcG9seWdvbigxcHggMnB4KTsg LXdlYmtpdC1zaGFwZS1tYXJnaW46IDVweDsgfQorI21hcmdpbi1lbXB0eS1wb2x5Z29uLTJ2ZXJ0 ZXggeyAtd2Via2l0LXNoYXBlLW91dHNpZGU6IHBvbHlnb24oMXB4IDJweCwgM3B4IDRweCk7IC13 ZWJraXQtc2hhcGUtbWFyZ2luOiA1cHg7IH0KKzwvc3R5bGU+Cis8Ym9keT4KKyAgPGRpdj5UaGlz IHRlc3Qgc2hvdWxkIG5vdCBjcmFzaC48L2Rpdj4KKyAgPGRpdiBpZD0ibWFyZ2luLWVtcHR5LXBv bHlnb24tMHZlcnRleCI+WmVybzwvZGl2PgorICA8ZGl2IGlkPSJtYXJnaW4tZW1wdHktcG9seWdv bi0xdmVydGV4Ij5PbmU8L2Rpdj4KKyAgPGRpdiBpZD0ibWFyZ2luLWVtcHR5LXBvbHlnb24tMnZl cnRleCI+VHdvPC9kaXY+CisgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQor ICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgPC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggNTE4NTVmOC4uYjY2ZjA1NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIxIEBACisyMDEzLTExLTEzICBIYW5zIE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgor CisgICAgICAgIFtDU1MgU2hhcGVzXSBFbXB0eSBwb2x5Z29ucyB3aXRoIG5vbi16ZXJvIHNoYXBl LXBhZGRpbmcgY2F1c2UgYW4gQVNTRVJUIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQb2x5Z29uU2hhcGU6OnNoYXBlUGFkZGluZ0JvdW5kcygp IGFuZCBQb2x5Z29uU2hhcGU6OnNoYXBlTWFyZ2luQm91bmRzKCkgbm8KKyAgICAgICAgbG9uZ2Vy IGF0dGVtcHQgdG8gY29tcHV0ZSBhIG5ldyBGbG9hdFBvbHlnb24gd2hlbiB0aGUgb3JpZ2luYWwg aXMgZW1wdHksIGkuZS4KKyAgICAgICAgd2hlbiBpdCBoYXMgbGVzcyB0aGFuIHRocmVlIHZlcnRp Y2VzLgorCisgICAgICAgIFRlc3RzOiBmYXN0L3NoYXBlcy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5z aWRlLWVtcHR5LXBvbHlnb24tY3Jhc2guaHRtbAorICAgICAgICAgICAgICAgZmFzdC9zaGFwZXMv c2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtZW1wdHktcG9seWdvbi1j cmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvc2hhcGVzL1BvbHlnb25TaGFwZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQb2x5Z29uU2hhcGU6OnNoYXBlUGFkZGluZ0JvdW5kcyk6IERv bid0IGNvbXB1dGUgYSBwYWRkaW5nIEZsb2F0UG9seWdvbiBpZiB0aGUgb3JpZ2luYWwgcG9seWdv biBpcyBlbXB0eS4KKyAgICAgICAgKFdlYkNvcmU6OlBvbHlnb25TaGFwZTo6c2hhcGVNYXJnaW5C b3VuZHMpOiBEb24ndCBjb21wdXRlIGEgbWFyZ2luIEZsb2F0UG9seWdvbiBpZiB0aGUgb3JpZ2lu YWwgcG9seWdvbiBpcyBlbXB0eS4KKwogMjAxMy0xMS0xMyAgQW5keSBFc3RlcyAgPGFlc3Rlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgVXNlIE5TQ2FsZW5kYXJJZGVudGlmaWVyR3JlZ29yaWFuIGlu c3RlYWQgb2YgTlNHcmVnb3JpYW5DYWxlbmRhciBvbiBPUyBYIDEwLjkgYW5kIGlPUwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9Qb2x5Z29uU2hhcGUuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9Qb2x5Z29uU2hhcGUuY3BwCmluZGV4IGQz ZjkwZWIuLjQ4MGUyMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFw ZXMvUG9seWdvblNoYXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVz L1BvbHlnb25TaGFwZS5jcHAKQEAgLTE4MSw3ICsxODEsNyBAQCBzdGF0aWMgaW5saW5lIFBhc3NP d25QdHI8RmxvYXRQb2x5Z29uPiBjb21wdXRlU2hhcGVNYXJnaW5Cb3VuZHMoY29uc3QgRmxvYXRQ b2x5ZwogY29uc3QgRmxvYXRQb2x5Z29uJiBQb2x5Z29uU2hhcGU6OnNoYXBlUGFkZGluZ0JvdW5k cygpIGNvbnN0CiB7CiAgICAgQVNTRVJUKHNoYXBlUGFkZGluZygpID49IDApOwotICAgIGlmICgh c2hhcGVQYWRkaW5nKCkpCisgICAgaWYgKCFzaGFwZVBhZGRpbmcoKSB8fCBtX3BvbHlnb24uaXNF bXB0eSgpKQogICAgICAgICByZXR1cm4gbV9wb2x5Z29uOwogCiAgICAgaWYgKCFtX3BhZGRpbmdC b3VuZHMpCkBAIC0xOTMsNyArMTkzLDcgQEAgY29uc3QgRmxvYXRQb2x5Z29uJiBQb2x5Z29uU2hh cGU6OnNoYXBlUGFkZGluZ0JvdW5kcygpIGNvbnN0CiBjb25zdCBGbG9hdFBvbHlnb24mIFBvbHln b25TaGFwZTo6c2hhcGVNYXJnaW5Cb3VuZHMoKSBjb25zdAogewogICAgIEFTU0VSVChzaGFwZU1h cmdpbigpID49IDApOwotICAgIGlmICghc2hhcGVNYXJnaW4oKSkKKyAgICBpZiAoIXNoYXBlTWFy Z2luKCkgfHwgbV9wb2x5Z29uLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIG1fcG9seWdvbjsK IAogICAgIGlmICghbV9tYXJnaW5Cb3VuZHMpCg==