124309 2013-11-13 14:03:38 -0800 Remove deprecated download delegates. 2013-11-13 15:18:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac (Intel) OS X 10.9 RESOLVED FIXED InRadar P2 Normal --- 1 gordon_sheridan gordon_sheridan commit-queue mark.lam oldest_to_newest 950351 0 gordon_sheridan 2013-11-13 14:03:38 -0800 The following delegate methods are deprecated and reportedly haven't been used by MacOS as far back as Tiger. - (NSURLRequest *)download:(NSURLDownload *)download shouldBeginChildDownloadOfSource:(NSURLRequest *)child delegate:(id *)childDelegate; - (void)download:(NSURLDownload *)parent didBeginChildDownload:(NSURLDownload *)child; 950386 1 216866 gordon_sheridan 2013-11-13 14:39:11 -0800 Created attachment 216866 Patch 950389 2 gordon_sheridan 2013-11-13 14:47:42 -0800 <rdar://problem/13570414> 950391 3 216867 gordon_sheridan 2013-11-13 14:51:18 -0800 Created attachment 216867 Patch 950410 4 216867 commit-queue 2013-11-13 15:18:20 -0800 Comment on attachment 216867 Patch Clearing flags on attachment: 216867 Committed r159249: <http://trac.webkit.org/changeset/159249> 950411 5 commit-queue 2013-11-13 15:18:22 -0800 All reviewed patches have been landed. Closing bug. 216866 2013-11-13 14:39:11 -0800 2013-11-13 14:51:17 -0800 Patch bug-124309-20131113143910.patch text/plain 2217 gordon_sheridan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYzk2NGU1NDU4 OGUyNGZhOWZmYzg4NDYzNDI4ZmY1NDY0MTljNGI1Ny4uZTJkMTk1M2Y5ZmJlYjJiYzMwNTU3MDM4 Mzg4ODBjZmE4NDQ4ZmQxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEz LTExLTEzICBHb3Jkb24gU2hlcmlkYW4gIDxnb3Jkb25fc2hlcmlkYW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJlbW92ZWQgZGVwcmVjYXRlZCBkb3dubG9hZCBkZWxlZ2F0ZXMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzMDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pc2MvV2ViRG93bmxvYWQu bW06CisgICAgICAgICgtW1dlYkRvd25sb2FkSW50ZXJuYWwgcmVzcG9uZHNUb1NlbGVjdG9yOl0p OgorICAgICAgICBSZW1vdmVkIGRvd25sb2FkOnNob3VsZEJlZ2luQ2hpbGREb3dubG9hZE9mU291 cmNlOmRlbGVnYXRlIGFuZAorICAgICAgICBkb3dubG9hZDpkaWRCZWdpbkNoaWxkRG93bmxvYWQu CisKIDIwMTMtMTEtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAg ICAgICAgRGlzYWJsZSBXZWJDcnlwdG8gb24gTW91bnRhaW4gTGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJEb3dubG9hZC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL01p c2MvV2ViRG93bmxvYWQubW0KaW5kZXggOGFmMGI3YWE1ZjY5ZmM3OWQwMWY2NGIyM2VkNDdmNDc4 ZDVlODgxZi4uNDRhNDYxZTc5ZTRiMjMzYjY2NmU2NGExNmEwMDJhMzYxNmMwOTE4ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJEb3dubG9hZC5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L21hYy9NaXNjL1dlYkRvd25sb2FkLm1tCkBAIC0xMDYsOSArMTA2LDcgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiAgICAgICAgIHNlbGVjdG9yID09IEBzZWxlY3Rvcihkb3dubG9h ZDpkZWNpZGVEZXN0aW5hdGlvbldpdGhTdWdnZXN0ZWRGaWxlbmFtZTopIHx8CiAgICAgICAgIHNl bGVjdG9yID09IEBzZWxlY3Rvcihkb3dubG9hZDpkaWRDcmVhdGVEZXN0aW5hdGlvbjopIHx8CiAg ICAgICAgIHNlbGVjdG9yID09IEBzZWxlY3Rvcihkb3dubG9hZERpZEZpbmlzaDopIHx8Ci0gICAg ICAgIHNlbGVjdG9yID09IEBzZWxlY3Rvcihkb3dubG9hZDpkaWRGYWlsV2l0aEVycm9yOikgfHwK LSAgICAgICAgc2VsZWN0b3IgPT0gQHNlbGVjdG9yKGRvd25sb2FkOnNob3VsZEJlZ2luQ2hpbGRE b3dubG9hZE9mU291cmNlOmRlbGVnYXRlOikgfHwKLSAgICAgICAgc2VsZWN0b3IgPT0gQHNlbGVj dG9yKGRvd25sb2FkOmRpZEJlZ2luQ2hpbGREb3dubG9hZDopKSB7CisgICAgICAgIHNlbGVjdG9y ID09IEBzZWxlY3Rvcihkb3dubG9hZDpkaWRGYWlsV2l0aEVycm9yOikpIHsKICAgICAgICAgcmV0 dXJuIFtyZWFsRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOnNlbGVjdG9yXTsKICAgICB9CiAK QEAgLTE5MiwxNiArMTkwLDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAgICAgW3JlYWxE ZWxlZ2F0ZSBkb3dubG9hZDpkb3dubG9hZCBkaWRGYWlsV2l0aEVycm9yOmVycm9yXTsKIH0KIAot LSAoTlNVUkxSZXF1ZXN0ICopZG93bmxvYWQ6KE5TVVJMRG93bmxvYWQgKilkb3dubG9hZCBzaG91 bGRCZWdpbkNoaWxkRG93bmxvYWRPZlNvdXJjZTooTlNVUkxSZXF1ZXN0ICopY2hpbGQgZGVsZWdh dGU6KGlkICopY2hpbGREZWxlZ2F0ZQotewotICAgIHJldHVybiBbcmVhbERlbGVnYXRlIGRvd25s b2FkOmRvd25sb2FkIHNob3VsZEJlZ2luQ2hpbGREb3dubG9hZE9mU291cmNlOmNoaWxkIGRlbGVn YXRlOmNoaWxkRGVsZWdhdGVdOwotfQotCi0tICh2b2lkKWRvd25sb2FkOihOU1VSTERvd25sb2Fk ICopcGFyZW50IGRpZEJlZ2luQ2hpbGREb3dubG9hZDooTlNVUkxEb3dubG9hZCAqKWNoaWxkCi17 Ci0gICAgW3JlYWxEZWxlZ2F0ZSBkb3dubG9hZDpwYXJlbnQgZGlkQmVnaW5DaGlsZERvd25sb2Fk OmNoaWxkXTsKLX0KLQogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViRG93bmxvYWQK 216867 2013-11-13 14:51:18 -0800 2013-11-13 15:18:20 -0800 Patch bug-124309-20131113145118.patch text/plain 2252 gordon_sheridan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYzk2NGU1NDU4 OGUyNGZhOWZmYzg4NDYzNDI4ZmY1NDY0MTljNGI1Ny4uNDAzN2UxNTY2YmQ3Zjc4MGExOTlmODY0 ODNkMDVlOWE4NTY4NWQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEz LTExLTEzICBHb3Jkb24gU2hlcmlkYW4gIDxnb3Jkb25fc2hlcmlkYW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJlbW92ZWQgZGVwcmVjYXRlZCBkb3dubG9hZCBkZWxlZ2F0ZXMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzMDkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzEzNTcwNDE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTWlzYy9XZWJEb3dubG9hZC5tbToKKyAgICAgICAgKC1bV2ViRG93 bmxvYWRJbnRlcm5hbCByZXNwb25kc1RvU2VsZWN0b3I6XSk6CisgICAgICAgIFJlbW92ZWQgZG93 bmxvYWQ6c2hvdWxkQmVnaW5DaGlsZERvd25sb2FkT2ZTb3VyY2U6ZGVsZWdhdGUgYW5kCisgICAg ICAgIGRvd25sb2FkOmRpZEJlZ2luQ2hpbGREb3dubG9hZC4KKwogMjAxMy0xMS0xMiAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIFdlYkNyeXB0 byBvbiBNb3VudGFpbiBMaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dl YkRvd25sb2FkLm1tIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJEb3dubG9hZC5tbQppbmRl eCA4YWYwYjdhYTVmNjlmYzc5ZDAxZjY0YjIzZWQ0N2Y0NzhkNWU4ODFmLi40NGE0NjFlNzllNGIy MzNiNjY2ZTY0YTE2YTAwMmEzNjE2YzA5MThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21h Yy9NaXNjL1dlYkRvd25sb2FkLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViRG93 bmxvYWQubW0KQEAgLTEwNiw5ICsxMDYsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAg ICAgICAgc2VsZWN0b3IgPT0gQHNlbGVjdG9yKGRvd25sb2FkOmRlY2lkZURlc3RpbmF0aW9uV2l0 aFN1Z2dlc3RlZEZpbGVuYW1lOikgfHwKICAgICAgICAgc2VsZWN0b3IgPT0gQHNlbGVjdG9yKGRv d25sb2FkOmRpZENyZWF0ZURlc3RpbmF0aW9uOikgfHwKICAgICAgICAgc2VsZWN0b3IgPT0gQHNl bGVjdG9yKGRvd25sb2FkRGlkRmluaXNoOikgfHwKLSAgICAgICAgc2VsZWN0b3IgPT0gQHNlbGVj dG9yKGRvd25sb2FkOmRpZEZhaWxXaXRoRXJyb3I6KSB8fAotICAgICAgICBzZWxlY3RvciA9PSBA c2VsZWN0b3IoZG93bmxvYWQ6c2hvdWxkQmVnaW5DaGlsZERvd25sb2FkT2ZTb3VyY2U6ZGVsZWdh dGU6KSB8fAotICAgICAgICBzZWxlY3RvciA9PSBAc2VsZWN0b3IoZG93bmxvYWQ6ZGlkQmVnaW5D aGlsZERvd25sb2FkOikpIHsKKyAgICAgICAgc2VsZWN0b3IgPT0gQHNlbGVjdG9yKGRvd25sb2Fk OmRpZEZhaWxXaXRoRXJyb3I6KSkgewogICAgICAgICByZXR1cm4gW3JlYWxEZWxlZ2F0ZSByZXNw b25kc1RvU2VsZWN0b3I6c2VsZWN0b3JdOwogICAgIH0KIApAQCAtMTkyLDE2ICsxOTAsNiBAQCB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICBbcmVhbERlbGVnYXRlIGRvd25sb2FkOmRvd25s b2FkIGRpZEZhaWxXaXRoRXJyb3I6ZXJyb3JdOwogfQogCi0tIChOU1VSTFJlcXVlc3QgKilkb3du bG9hZDooTlNVUkxEb3dubG9hZCAqKWRvd25sb2FkIHNob3VsZEJlZ2luQ2hpbGREb3dubG9hZE9m U291cmNlOihOU1VSTFJlcXVlc3QgKiljaGlsZCBkZWxlZ2F0ZTooaWQgKiljaGlsZERlbGVnYXRl Ci17Ci0gICAgcmV0dXJuIFtyZWFsRGVsZWdhdGUgZG93bmxvYWQ6ZG93bmxvYWQgc2hvdWxkQmVn aW5DaGlsZERvd25sb2FkT2ZTb3VyY2U6Y2hpbGQgZGVsZWdhdGU6Y2hpbGREZWxlZ2F0ZV07Ci19 Ci0KLS0gKHZvaWQpZG93bmxvYWQ6KE5TVVJMRG93bmxvYWQgKilwYXJlbnQgZGlkQmVnaW5DaGls ZERvd25sb2FkOihOU1VSTERvd25sb2FkICopY2hpbGQKLXsKLSAgICBbcmVhbERlbGVnYXRlIGRv d25sb2FkOnBhcmVudCBkaWRCZWdpbkNoaWxkRG93bmxvYWQ6Y2hpbGRdOwotfQotCiBAZW5kCiAK IEBpbXBsZW1lbnRhdGlvbiBXZWJEb3dubG9hZAo=