124291 2013-11-13 10:02:10 -0800 Move provisional load state handling to FrameLoadState 2013-11-13 10:49:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 950224 0 andersca 2013-11-13 10:02:10 -0800 Move provisional load state handling to FrameLoadState 950227 1 216817 andersca 2013-11-13 10:04:56 -0800 Created attachment 216817 Patch 950228 2 216817 mitz 2013-11-13 10:06:57 -0800 Comment on attachment 216817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216817&action=review > Source/WebKit2/UIProcess/FrameLoadState.cpp:43 > + m_loadState = FrameLoadState::LoadStateProvisional; Why FrameLoadState:: here… > Source/WebKit2/UIProcess/FrameLoadState.cpp:56 > + m_loadState = LoadStateFinished; …but not here? 950239 3 andersca 2013-11-13 10:49:47 -0800 Committed r159209: <http://trac.webkit.org/changeset/159209> 216817 2013-11-13 10:04:56 -0800 2013-11-13 10:06:56 -0800 Patch bug-124291-20131113100511.patch text/plain 4275 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2M5MzZlNjk1MDUyNjA3 OTE4ODMzMmI5ODJiYWNmYTlhNWMxZDkzZS4uZGExYjMyMGU0MWE0MTQ3YjMzNDZjNmIzNGNhMmZl NjYxYjVkZGVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTExLTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBwcm92aXNp b25hbCBsb2FkIHN0YXRlIGhhbmRsaW5nIHRvIEZyYW1lTG9hZFN0YXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQyOTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9GcmFtZUxvYWRT dGF0ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZFN0YXRlOjpkaWRTdGFydFByb3Zp c2lvbmFsTG9hZCk6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZFN0YXRlOjpkaWRSZWNlaXZl U2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbExvYWQpOgorICAgICAgICAoV2ViS2l0OjpGcmFt ZUxvYWRTdGF0ZTo6ZGlkRmFpbFByb3Zpc2lvbmFsTG9hZCk6CisgICAgICAgICogVUlQcm9jZXNz L0ZyYW1lTG9hZFN0YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZVByb3h5OjpkaWRTdGFydFByb3Zpc2lvbmFsTG9h ZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6OmRpZFJlY2VpdmVTZXJ2ZXJSZWRp cmVjdEZvclByb3Zpc2lvbmFsTG9hZCk6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6 OmRpZEZhaWxQcm92aXNpb25hbExvYWQpOgorCiAyMDEzLTExLTEzICBUYW1hcyBHZXJnZWx5ICA8 Z2VydG9tQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZW1vdmUgcHJlZml4ZWQgdGVtcGxh dGUgY2xhc3MgcHJvY2Vzc2luZyBmcm9tIG1lc3NhZ2UgcmVjZWl2ZXIgZ2VuZXJhdG9yLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0ZyYW1lTG9hZFN0YXRlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9GcmFtZUxvYWRTdGF0ZS5jcHAKaW5kZXggZmJjZmM5NzE0 ODZiZmEyMTg3Mjk5ZDdjYWY3YzQ5N2M5ZjRhOWFlZS4uMjAwMmM3YmJjMGYzNTFiZTRkYjFkYWI5 NjY4MDdjOTI5ZWE3ZjhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Zy YW1lTG9hZFN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRnJhbWVMb2Fk U3RhdGUuY3BwCkBAIC0zNyw0ICszNywyNSBAQCBGcmFtZUxvYWRTdGF0ZTo6fkZyYW1lTG9hZFN0 YXRlKCkKIHsKIH0KIAordm9pZCBGcmFtZUxvYWRTdGF0ZTo6ZGlkU3RhcnRQcm92aXNpb25hbExv YWQoY29uc3QgU3RyaW5nJiB1cmwpCit7CisgICAgQVNTRVJUKG1fcHJvdmlzaW9uYWxVUkwuaXNF bXB0eSgpKTsKKyAgICBtX2xvYWRTdGF0ZSA9IEZyYW1lTG9hZFN0YXRlOjpMb2FkU3RhdGVQcm92 aXNpb25hbDsKKyAgICBtX3Byb3Zpc2lvbmFsVVJMID0gdXJsOworfQorCit2b2lkIEZyYW1lTG9h ZFN0YXRlOjpkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbExvYWQoY29uc3Qg U3RyaW5nJiB1cmwpCit7CisgICAgQVNTRVJUKG1fbG9hZFN0YXRlID09IEZyYW1lTG9hZFN0YXRl OjpMb2FkU3RhdGVQcm92aXNpb25hbCk7CisgICAgbV9wcm92aXNpb25hbFVSTCA9IHVybDsKK30K Kwordm9pZCBGcmFtZUxvYWRTdGF0ZTo6ZGlkRmFpbFByb3Zpc2lvbmFsTG9hZCgpCit7CisgICAg QVNTRVJUKG1fbG9hZFN0YXRlID09IEZyYW1lTG9hZFN0YXRlOjpMb2FkU3RhdGVQcm92aXNpb25h bCk7CisgICAgbV9sb2FkU3RhdGUgPSBMb2FkU3RhdGVGaW5pc2hlZDsKKyAgICBtX3Byb3Zpc2lv bmFsVVJMID0gU3RyaW5nKCk7CisgICAgbV91bnJlYWNoYWJsZVVSTCA9IG1fbGFzdFVucmVhY2hh YmxlVVJMOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9GcmFtZUxvYWRTdGF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0ZyYW1lTG9hZFN0YXRlLmgKaW5kZXggMmUzNTQzNmIxMzIxMmY3MGMyOTcyNTgwMjFhMDlh MGU3YjgxNjFlZC4uMWZjYWM3NmYwOGEyNjE3N2ZjZjVhNGUwYWE4MDNkNjM4N2RkOGMyZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0ZyYW1lTG9hZFN0YXRlLmgKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0ZyYW1lTG9hZFN0YXRlLmgKQEAgLTQxLDYgKzQxLDEw IEBAIHB1YmxpYzoKICAgICAgICAgTG9hZFN0YXRlRmluaXNoZWQKICAgICB9OwogCisgICAgdm9p ZCBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZChjb25zdCBTdHJpbmcmIHVybCk7CisgICAgdm9pZCBk aWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbExvYWQoY29uc3QgU3RyaW5nJiB1 cmwpOworICAgIHZvaWQgZGlkRmFpbFByb3Zpc2lvbmFsTG9hZCgpOworCiAgICAgLy8gRklYTUU6 IFRoZXNlIHNob3VsZCBhbGwgYmUgcHJpdmF0ZSwgYW5kIEZyYW1lTG9hZFN0YXRlIHNob3VsZAog ICAgIC8vIHByb3ZpZGUgc3RhdGUgdHJhbnNpdGlvbiBtZW1iZXIgZnVuY3Rpb25zLgogICAgIExv YWRTdGF0ZSBtX2xvYWRTdGF0ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJGcmFtZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVBy b3h5LmNwcAppbmRleCBjODBjODIwNDI3Zjc3ZmNiNjI1MDQxNmE3MGI0MTI4MWRiNjVlODRkLi44 ODM3MTNjMmQ5NTc0NzdjZTg4YTcyYmE5ZmUxZTQ4YTE3ZWUwYTg1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuY3BwCkBAIC0xMTgsMjMgKzExOCwxNyBAQCBib29s IFdlYkZyYW1lUHJveHk6OmlzRGlzcGxheWluZ1BERkRvY3VtZW50KCkgY29uc3QKIAogdm9pZCBX ZWJGcmFtZVByb3h5OjpkaWRTdGFydFByb3Zpc2lvbmFsTG9hZChjb25zdCBTdHJpbmcmIHVybCkK IHsKLSAgICBBU1NFUlQobV9mcmFtZUxvYWRTdGF0ZS5tX3Byb3Zpc2lvbmFsVVJMLmlzRW1wdHko KSk7Ci0gICAgbV9mcmFtZUxvYWRTdGF0ZS5tX2xvYWRTdGF0ZSA9IEZyYW1lTG9hZFN0YXRlOjpM b2FkU3RhdGVQcm92aXNpb25hbDsKLSAgICBtX2ZyYW1lTG9hZFN0YXRlLm1fcHJvdmlzaW9uYWxV UkwgPSB1cmw7CisgICAgbV9mcmFtZUxvYWRTdGF0ZS5kaWRTdGFydFByb3Zpc2lvbmFsTG9hZCh1 cmwpOwogfQogCiB2b2lkIFdlYkZyYW1lUHJveHk6OmRpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZv clByb3Zpc2lvbmFsTG9hZChjb25zdCBTdHJpbmcmIHVybCkKIHsKLSAgICBBU1NFUlQobV9mcmFt ZUxvYWRTdGF0ZS5tX2xvYWRTdGF0ZSA9PSBGcmFtZUxvYWRTdGF0ZTo6TG9hZFN0YXRlUHJvdmlz aW9uYWwpOwotICAgIG1fZnJhbWVMb2FkU3RhdGUubV9wcm92aXNpb25hbFVSTCA9IHVybDsKKyAg ICBtX2ZyYW1lTG9hZFN0YXRlLmRpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZvclByb3Zpc2lvbmFs TG9hZCh1cmwpOwogfQogCiB2b2lkIFdlYkZyYW1lUHJveHk6OmRpZEZhaWxQcm92aXNpb25hbExv YWQoKQogewotICAgIEFTU0VSVChtX2ZyYW1lTG9hZFN0YXRlLm1fbG9hZFN0YXRlID09IEZyYW1l TG9hZFN0YXRlOjpMb2FkU3RhdGVQcm92aXNpb25hbCk7Ci0gICAgbV9mcmFtZUxvYWRTdGF0ZS5t X2xvYWRTdGF0ZSA9IEZyYW1lTG9hZFN0YXRlOjpMb2FkU3RhdGVGaW5pc2hlZDsKLSAgICBtX2Zy YW1lTG9hZFN0YXRlLm1fcHJvdmlzaW9uYWxVUkwgPSBTdHJpbmcoKTsKLSAgICBtX2ZyYW1lTG9h ZFN0YXRlLm1fdW5yZWFjaGFibGVVUkwgPSBtX2ZyYW1lTG9hZFN0YXRlLm1fbGFzdFVucmVhY2hh YmxlVVJMOworICAgIG1fZnJhbWVMb2FkU3RhdGUuZGlkRmFpbFByb3Zpc2lvbmFsTG9hZCgpOwog fQogCiB2b2lkIFdlYkZyYW1lUHJveHk6OmRpZENvbW1pdExvYWQoY29uc3QgU3RyaW5nJiBjb250 ZW50VHlwZSwgY29uc3QgUGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8mIGNlcnRpZmljYXRlSW5mbykK