<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>124270</bug_id>
          
          <creation_ts>2013-11-13 00:39:21 -0800</creation_ts>
          <short_desc>Make remaining CSSPrimitiveValue constructors return PassRef.</short_desc>
          <delta_ts>2013-11-13 03:36:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>macpherson</cc>
    
    <cc>menard</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>950064</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-11-13 00:39:21 -0800</bug_when>
    <thetext>Make remaining CSSPrimitiveValue constructors return PassRef.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>950065</commentid>
    <comment_count>1</comment_count>
      <attachid>216777</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-11-13 00:40:12 -0800</bug_when>
    <thetext>Created attachment 216777
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>950105</commentid>
    <comment_count>2</comment_count>
      <attachid>216777</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-13 03:36:08 -0800</bug_when>
    <thetext>Comment on attachment 216777
Patch

Clearing flags on attachment: 216777

Committed r159184: &lt;http://trac.webkit.org/changeset/159184&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>950106</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-13 03:36:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>216777</attachid>
            <date>2013-11-13 00:40:12 -0800</date>
            <delta_ts>2013-11-13 03:36:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-124270.diff</filename>
            <type>text/plain</type>
            <size>3812</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBkNDRmMGRmLi42YThmNWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTMtMTEtMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg
ICAgIE1ha2UgcmVtYWluaW5nIENTU1ByaW1pdGl2ZVZhbHVlIGNvbnN0cnVjdG9ycyByZXR1cm4g
UGFzc1JlZi4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNDI3MD4KKworICAgICAg
ICAuLmFuZCBzYW1lIHdpdGggdGhlIGNvcnJlc3BvbmRpbmcgQ1NTVmFsdWVQb29sIGZ1bmN0aW9u
cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogMjAxMy0xMS0xMiAg
QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIFdl
YkNyeXB0byBvbiBNb3VudGFpbiBMaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv
Q1NTUHJpbWl0aXZlVmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1
ZS5oCmluZGV4IDcxNWQ5YjEuLjMyZjc1OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz
cy9DU1NQcmltaXRpdmVWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRp
dmVWYWx1ZS5oCkBAIC0yMTMsMjcgKzIxMywyNyBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgUGFz
c1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlSWRlbnRpZmllcihDU1NWYWx1ZUlEIHZhbHVl
SUQpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ1NTUHJpbWl0aXZlVmFsdWUodmFsdWVJRCkpOyB9
CiAgICAgc3RhdGljIFBhc3NSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZUlkZW50aWZpZXIo
Q1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IENTU1ByaW1p
dGl2ZVZhbHVlKHByb3BlcnR5SUQpKTsgfQotICAgIHN0YXRpYyBQYXNzUmVmUHRyPENTU1ByaW1p
dGl2ZVZhbHVlPiBjcmVhdGVQYXJzZXJPcGVyYXRvcihpbnQgcGFyc2VyT3BlcmF0b3IpIHsgcmV0
dXJuIGFkb3B0UmVmKG5ldyBDU1NQcmltaXRpdmVWYWx1ZShwYXJzZXJPcGVyYXRvcikpOyB9Cisg
ICAgc3RhdGljIFBhc3NSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZVBhcnNlck9wZXJhdG9y
KGludCBwYXJzZXJPcGVyYXRvcikgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBDU1NQcmltaXRpdmVW
YWx1ZShwYXJzZXJPcGVyYXRvcikpOyB9CiAKICAgICBzdGF0aWMgUGFzc1JlZjxDU1NQcmltaXRp
dmVWYWx1ZT4gY3JlYXRlQ29sb3IodW5zaWduZWQgcmdiVmFsdWUpIHsgcmV0dXJuIGFkb3B0UmVm
KCpuZXcgQ1NTUHJpbWl0aXZlVmFsdWUocmdiVmFsdWUpKTsgfQogICAgIHN0YXRpYyBQYXNzUmVm
PENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGUoZG91YmxlIHZhbHVlLCBVbml0VHlwZXMgdHlwZSkg
eyByZXR1cm4gYWRvcHRSZWYoKm5ldyBDU1NQcmltaXRpdmVWYWx1ZSh2YWx1ZSwgdHlwZSkpOyB9
CiAgICAgc3RhdGljIFBhc3NSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZShjb25zdCBTdHJp
bmcmIHZhbHVlLCBVbml0VHlwZXMgdHlwZSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBDU1NQcmlt
aXRpdmVWYWx1ZSh2YWx1ZSwgdHlwZSkpOyB9CiAgICAgc3RhdGljIFBhc3NSZWY8Q1NTUHJpbWl0
aXZlVmFsdWU+IGNyZWF0ZShjb25zdCBMZW5ndGgmIHZhbHVlLCBjb25zdCBSZW5kZXJTdHlsZSog
c3R5bGUpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ1NTUHJpbWl0aXZlVmFsdWUodmFsdWUsIHN0
eWxlKSk7IH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyBQYXNzUmVmUHRyPENT
U1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGUoVCB2YWx1ZSkKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU
PiBzdGF0aWMgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlKFQgdmFsdWUpCiAgICAg
ewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlKSk7
CisgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlKSk7
CiAgICAgfQogCiAgICAgLy8gVGhpcyB2YWx1ZSBpcyB1c2VkIHRvIGhhbmRsZSBxdWlya3kgbWFy
Z2lucyBpbiByZWZsb3cgcm9vdHMgKGJvZHksIHRkLCBhbmQgdGgpIGxpa2UgV2luSUUuCiAgICAg
Ly8gVGhlIGJhc2ljIGlkZWEgaXMgdGhhdCBhIHN0eWxlc2hlZXQgY2FuIHVzZSB0aGUgdmFsdWUg
X19xZW0gKGZvciBxdWlya3kgZW0pIGluc3RlYWQgb2YgZW0uCiAgICAgLy8gV2hlbiB0aGUgcXVp
cmt5IHZhbHVlIGlzIHVzZWQsIGlmIHlvdSdyZSBpbiBxdWlya3MgbW9kZSwgdGhlIG1hcmdpbiB3
aWxsIGNvbGxhcHNlIGF3YXkKICAgICAvLyBpbnNpZGUgYSB0YWJsZSBjZWxsLgotICAgIHN0YXRp
YyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGVBbGxvd2luZ01hcmdpblF1aXJr
KGRvdWJsZSB2YWx1ZSwgVW5pdFR5cGVzIHR5cGUpCisgICAgc3RhdGljIFBhc3NSZWY8Q1NTUHJp
bWl0aXZlVmFsdWU+IGNyZWF0ZUFsbG93aW5nTWFyZ2luUXVpcmsoZG91YmxlIHZhbHVlLCBVbml0
VHlwZXMgdHlwZSkKICAgICB7CiAgICAgICAgIENTU1ByaW1pdGl2ZVZhbHVlKiBxdWlya1ZhbHVl
ID0gbmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlLCB0eXBlKTsKICAgICAgICAgcXVpcmtWYWx1
ZS0+bV9pc1F1aXJrVmFsdWUgPSB0cnVlOwotICAgICAgICByZXR1cm4gYWRvcHRSZWYocXVpcmtW
YWx1ZSk7CisgICAgICAgIHJldHVybiBhZG9wdFJlZigqcXVpcmtWYWx1ZSk7CiAgICAgfQogCiAg
ICAgfkNTU1ByaW1pdGl2ZVZhbHVlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv
Q1NTVmFsdWVQb29sLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29sLmgKaW5kZXgg
Y2RiYTg4Ny4uNTcyODIwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVl
UG9vbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuaApAQCAtNTMsNyAr
NTMsNyBAQCBwdWJsaWM6CiAgICAgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlVmFs
dWUoZG91YmxlIHZhbHVlLCBDU1NQcmltaXRpdmVWYWx1ZTo6VW5pdFR5cGVzKTsKICAgICBQYXNz
UmVmPENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVhdGVWYWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlLCBD
U1NQcmltaXRpdmVWYWx1ZTo6VW5pdFR5cGVzIHR5cGUpIHsgcmV0dXJuIENTU1ByaW1pdGl2ZVZh
bHVlOjpjcmVhdGUodmFsdWUsIHR5cGUpOyB9CiAgICAgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1
ZT4gY3JlYXRlVmFsdWUoY29uc3QgTGVuZ3RoJiB2YWx1ZSwgY29uc3QgUmVuZGVyU3R5bGUqIHN0
eWxlKSB7IHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHZhbHVlLCBzdHlsZSk7IH0K
LSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0aWMgUGFzc1JlZlB0cjxDU1NQcmltaXRpdmVW
YWx1ZT4gY3JlYXRlVmFsdWUoVCB2YWx1ZSkgeyByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6OmNy
ZWF0ZSh2YWx1ZSk7IH0KKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0aWMgUGFzc1JlZjxD
U1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlVmFsdWUoVCB2YWx1ZSkgeyByZXR1cm4gQ1NTUHJpbWl0
aXZlVmFsdWU6OmNyZWF0ZSh2YWx1ZSk7IH0KIAogICAgIHZvaWQgZHJhaW4oKTsKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>