124239 2013-11-12 15:24:30 -0800 WKMutableArrayRef should be an ImmutableArray 2013-11-12 15:35:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 949898 0 andersca 2013-11-12 15:24:30 -0800 WKMutableArrayRef should be an ImmutableArray 949899 1 216731 andersca 2013-11-12 15:26:05 -0800 Created attachment 216731 Patch 949900 2 216731 sam 2013-11-12 15:26:55 -0800 Comment on attachment 216731 Patch Immutable is the mutable! 949901 3 commit-queue 2013-11-12 15:27:09 -0800 Attachment 216731 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm', u'Source/WebKit2/Shared/API/c/WKMutableArray.cpp', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1 Source/WebKit2/Shared/API/c/WKSharedAPICast.h:117: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 949906 4 andersca 2013-11-12 15:35:56 -0800 Committed r159155: <http://trac.webkit.org/changeset/159155> 216731 2013-11-12 15:26:05 -0800 2013-11-12 15:26:54 -0800 Patch bug-124239-20131112152604.patch text/plain 3615 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGE1NGYzZDFjOTljOGY4 YWUyZmFiMDBhOWQ5OTEyMTQ2OWY1NzFhZS4uNjQzNjdmZjMxYmM2YmFmNGViZjFlYWZhY2E3ZTc4 ZGU0YTZiNDBmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTExLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV0tNdXRhYmxlQXJy YXlSZWYgc2hvdWxkIGJlIGFuIEltbXV0YWJsZUFycmF5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmpl Y3RDb2Rlci5tbToKKyAgICAgICAgKGVuc3VyZU9iamVjdFN0cmVhbSk6CisgICAgICAgICogU2hh cmVkL0FQSS9jL1dLTXV0YWJsZUFycmF5LmNwcDoKKyAgICAgICAgKFdLTXV0YWJsZUFycmF5Q3Jl YXRlKToKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0Lmg6CisKKzIwMTMt MTEtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBS ZW1vdmUgbW9yZSBmdW5jdGlvbmFsaXR5IGZyb20gTXV0YWJsZUFycmF5CiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQyMzUKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCmlu ZGV4IDhhZjhkYzY4OTM1NDgzZDhjMmNiNDBhOTRhNWYzMTUyNjYwNzk4MjQuLmNhZDQxMDFiYjkz MmE5MTdiY2VhZWMzNjllNzAzNzVkMTEyNTI3YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KQEAgLTU5LDcgKzU5 LDcgQEAgc3RhdGljIFBhc3NSZWZQdHI8SW1tdXRhYmxlRGljdGlvbmFyeT4gY3JlYXRlRW5jb2Rl ZE9iamVjdChXS1JlbW90ZU9iamVjdEVuY29kZXIKIAogQGltcGxlbWVudGF0aW9uIFdLUmVtb3Rl T2JqZWN0RW5jb2RlciB7CiAgICAgUmVmUHRyPE11dGFibGVEaWN0aW9uYXJ5PiBfcm9vdERpY3Rp b25hcnk7Ci0gICAgTXV0YWJsZUFycmF5KiBfb2JqZWN0U3RyZWFtOworICAgIEltbXV0YWJsZUFy cmF5KiBfb2JqZWN0U3RyZWFtOwogCiAgICAgTXV0YWJsZURpY3Rpb25hcnkqIF9jdXJyZW50RGlj dGlvbmFyeTsKIH0KQEAgLTk0LDcgKzk0LDcgQEAgc3RhdGljIHZvaWQgZW5zdXJlT2JqZWN0U3Ry ZWFtKFdLUmVtb3RlT2JqZWN0RW5jb2RlciAqZW5jb2RlcikKICAgICBpZiAoZW5jb2Rlci0+X29i amVjdFN0cmVhbSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgUmVmUHRyPE11dGFibGVBcnJheT4g b2JqZWN0U3RyZWFtID0gTXV0YWJsZUFycmF5OjpjcmVhdGUoKTsKKyAgICBSZWZQdHI8SW1tdXRh YmxlQXJyYXk+IG9iamVjdFN0cmVhbSA9IE11dGFibGVBcnJheTo6Y3JlYXRlKCk7CiAgICAgZW5j b2Rlci0+X29iamVjdFN0cmVhbSA9IG9iamVjdFN0cmVhbS5nZXQoKTsKIAogICAgIGVuY29kZXIt Pl9yb290RGljdGlvbmFyeS0+c2V0KG9iamVjdFN0cmVhbUtleSwgb2JqZWN0U3RyZWFtLnJlbGVh c2UoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tNdXRhYmxl QXJyYXkuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLTXV0YWJsZUFycmF5LmNw cAppbmRleCA1MDViNzExMzdlNDM4YmU1NzZkNjc3YWIxNmY4NWRjYWMyYTBhOTQ3Li5mODU0NTFj OTEyYzEwMDkzNDQ4YTJkYjFmMzUwNzQyZGI5NGViZDBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL2MvV0tNdXRhYmxlQXJyYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9BUEkvYy9XS011dGFibGVBcnJheS5jcHAKQEAgLTMzLDcgKzMzLDcgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIAogV0tNdXRhYmxlQXJyYXlSZWYgV0tNdXRhYmxlQXJyYXlDcmVh dGUoKQogewotICAgIHJldHVybiB0b0FQSShNdXRhYmxlQXJyYXk6OmNyZWF0ZSgpLmxlYWtSZWYo KSk7CisgICAgcmV0dXJuIGNvbnN0X2Nhc3Q8V0tNdXRhYmxlQXJyYXlSZWY+KHRvQVBJKEltbXV0 YWJsZUFycmF5OjpjcmVhdGUoKS5sZWFrUmVmKCkpKTsKIH0KIAogYm9vbCBXS0FycmF5SXNNdXRh YmxlKFdLQXJyYXlSZWYgYXJyYXlSZWYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2Mv V0tTaGFyZWRBUElDYXN0LmgKaW5kZXggODBhZWE4OGM3ZTJmMTZlNDgzNmMzNWE5MmMwZWQ2M2Mx N2UxY2E1Yi4uOWY0OTE5Yzc1ZTI4OWI5ZWQ5NTM5NWI0MzU4NWQyODExYzMyZjM3YiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NoYXJlZEFQSUNhc3QuaApAQCAtMTAwLDcg KzEwMCw2IEBAIFdLX0FERF9BUElfTUFQUElORyhXS0RvdWJsZVJlZiwgV2ViRG91YmxlKQogV0tf QUREX0FQSV9NQVBQSU5HKFdLRXJyb3JSZWYsIFdlYkVycm9yKQogV0tfQUREX0FQSV9NQVBQSU5H KFdLR3JhcGhpY3NDb250ZXh0UmVmLCBXZWJHcmFwaGljc0NvbnRleHQpCiBXS19BRERfQVBJX01B UFBJTkcoV0tJbWFnZVJlZiwgV2ViSW1hZ2UpCi1XS19BRERfQVBJX01BUFBJTkcoV0tNdXRhYmxl QXJyYXlSZWYsIE11dGFibGVBcnJheSkKIFdLX0FERF9BUElfTUFQUElORyhXS011dGFibGVEaWN0 aW9uYXJ5UmVmLCBNdXRhYmxlRGljdGlvbmFyeSkKIFdLX0FERF9BUElfTUFQUElORyhXS1BvaW50 UmVmLCBXZWJQb2ludCkKIFdLX0FERF9BUElfTUFQUElORyhXS1JlY3RSZWYsIFdlYlJlY3QpCkBA IC0xMTUsNiArMTE0LDggQEAgV0tfQUREX0FQSV9NQVBQSU5HKFdLVVJMUmVxdWVzdFJlZiwgV2Vi VVJMUmVxdWVzdCkKIFdLX0FERF9BUElfTUFQUElORyhXS1VSTFJlc3BvbnNlUmVmLCBXZWJVUkxS ZXNwb25zZSkKIFdLX0FERF9BUElfTUFQUElORyhXS1VzZXJDb250ZW50VVJMUGF0dGVyblJlZiwg V2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuKQogCit0ZW1wbGF0ZTw+IHN0cnVjdCBBUElUeXBlSW5m bzxXS011dGFibGVBcnJheVJlZj4geyB0eXBlZGVmIEltbXV0YWJsZUFycmF5KiBJbXBsVHlwZTsg fTsKKwogI2lmIFBMQVRGT1JNKE1BQykKIFdLX0FERF9BUElfTUFQUElORyhXS1dlYkFyY2hpdmVS ZWYsIFdlYkFyY2hpdmUpCiBXS19BRERfQVBJX01BUFBJTkcoV0tXZWJBcmNoaXZlUmVzb3VyY2VS ZWYsIFdlYkFyY2hpdmVSZXNvdXJjZSkK