124238 2013-11-12 15:24:22 -0800 Code cleanup: change FrameView::doLayoutWithFrameFlattening() to make it more explicit. 2013-11-13 13:26:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 zalan zalan commit-queue simon.fraser oldest_to_newest 949897 0 zalan 2013-11-12 15:24:22 -0800 SSIA 949907 1 216734 zalan 2013-11-12 15:41:38 -0800 Created attachment 216734 Patch 949910 2 216734 simon.fraser 2013-11-12 15:47:43 -0800 Comment on attachment 216734 Patch The header file should have the "Return true if the layout got re-initiated and this view needs no layout anymore." comment just above the function declaration, perhaps worded in a way that makes more sense with less context. 950054 3 216773 zalan 2013-11-12 23:57:18 -0800 Created attachment 216773 Patch 950327 4 216773 commit-queue 2013-11-13 13:26:45 -0800 Comment on attachment 216773 Patch Clearing flags on attachment: 216773 Committed r159231: <http://trac.webkit.org/changeset/159231> 950328 5 commit-queue 2013-11-13 13:26:47 -0800 All reviewed patches have been landed. Closing bug. 216734 2013-11-12 15:41:38 -0800 2013-11-12 23:57:16 -0800 Patch bug-124238-20131112154138.patch text/plain 1586 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlmYTUwZTg0NGEwNTJj MDBhYjZiZTc1ZTQ3ODNmMTk4ZmUxYjliZC4uMDdhODllNzM4Y2Y1ZmQwM2I5ODM2ZTU5NDIzYTE4 OWY1YTUyZGZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTExLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGNvbW1lbnQgdG8gRnJh bWVWaWV3Ojpkb0xheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmcoKSB0byBjbGVhciB1cCB0aGUgbWVh bmluZyBvZiB0aGUgYm9vbCByZXR1cm4gdmFsdWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6ZG9MYXlvdXRXaXRoRnJhbWVGbGF0dGVuaW5nKToKKwogMjAxMy0x MS0xMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEJ1aWxkIEdTdHJlYW1lciBmaWxlcyBvbiBXaW5kb3dzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCmluZGV4IDgyZjMwMjc1ZTg0ZWM5ZDJmMzkwY2Y3ZDIwM2I5NjhiZDJjZDdhMDEuLjFm MTFhYmFhMTBlODc2NjhjMGVmMjhhYWZjYjQ1OGJlOGI5N2U2YjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKQEAgLTMzNDEsNyArMzM0MSwxMCBAQCBib29sIEZyYW1lVmlldzo6aXNJbkNo aWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkgY29uc3QKIAogYm9vbCBGcmFtZVZpZXc6OmRv TGF5b3V0V2l0aEZyYW1lRmxhdHRlbmluZyhib29sIGFsbG93U3VidHJlZSkKIHsKLSAgICAvLyBU cnkgaW5pdGlhdGluZyBsYXlvdXQgZnJvbSB0aGUgdG9wbW9zdCBwYXJlbnQuCisgICAgLy8gV2hl biB3ZSBzdGFydCBhIGxheW91dCBhdCB0aGUgY2hpbGQgbGV2ZWwgYXMgb3Bwb3NlZCB0byB0aGUg dG9wbW9zdCBmcmFtZSB2aWV3IGFuZCB0aGlzIGNoaWxkCisgICAgLy8gZnJhbWUgcmVxdWlyZXMg ZmxhdHRlbmluZywgd2UgbmVlZCB0byByZS1pbml0aWF0ZSB0aGUgbGF5b3V0IGF0IHRoZSB0b3Bt b3N0IHZpZXcuIExheW91dAorICAgIC8vIHdpbGwgaGl0IHRoaXMgdmlldyBldmVudHVhbGx5Lgor ICAgIC8vIFJldHVybiB0cnVlIGlmIHRoZSBsYXlvdXQgZ290IHJlLWluaXRpYXRlZCBhbmQgdGhp cyB2aWV3IG5lZWRzIG5vIGxheW91dCBhbnltb3JlLgogICAgIEZyYW1lVmlldyogcGFyZW50Vmll dyA9IHBhcmVudEZyYW1lVmlldygpOwogCiAgICAgaWYgKCFwYXJlbnRWaWV3KQo= 216773 2013-11-12 23:57:18 -0800 2013-11-13 13:26:45 -0800 Patch bug-124238-20131112235717.patch text/plain 3569 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlmYTUwZTg0NGEwNTJj MDBhYjZiZTc1ZTQ3ODNmMTk4ZmUxYjliZC4uNzQyMmMzMTgzMzkzZGE4MTE3ZDhkYjgxYzk0MTcz MGMzM2UxZDlmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTExLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBjbGVhbnVwOiBjaGFu Z2UgRnJhbWVWaWV3Ojpkb0xheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmcoKSB0byBtYWtlIGl0IG1v cmUgZXhwbGljaXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjQyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW5hbWUgZG9MYXlvdXRXaXRoRnJhbWVGbGF0dGVuaW5nKCkgYW5kIGNoYW5nZSBpdHMg c2lnbmF0dXJlIHNvIHRoYXQgaXQncyBpbmxpbmUgd2l0aAorICAgICAgICB3aGF0IGl0IGRvZXMu CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2Uv RnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KToKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c3RhcnRMYXlvdXRBdE1haW5GcmFtZVZpZXdJZk5l ZWRlZCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKwogMjAxMy0xMS0xMiAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIEdT dHJlYW1lciBmaWxlcyBvbiBXaW5kb3dzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4 IDgyZjMwMjc1ZTg0ZWM5ZDJmMzkwY2Y3ZDIwM2I5NjhiZDJjZDdhMDEuLjYzMGIyYmI4YTIwZDEw YjE4NjYxZDhjN2RjNTUzZTJhYjU0MjMwODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAK QEAgLTEwNzcsNyArMTA3Nyw5IEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1 YnRyZWUpCiAgICAgYm9vbCBpbkNoaWxkRnJhbWVMYXlvdXRXaXRoRnJhbWVGbGF0dGVuaW5nID0g aXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCk7CiAKICAgICBpZiAoaW5DaGlsZEZy YW1lTGF5b3V0V2l0aEZyYW1lRmxhdHRlbmluZykgewotICAgICAgICBpZiAoZG9MYXlvdXRXaXRo RnJhbWVGbGF0dGVuaW5nKGFsbG93U3VidHJlZSkpCisgICAgICAgIHN0YXJ0TGF5b3V0QXRNYWlu RnJhbWVWaWV3SWZOZWVkZWQoYWxsb3dTdWJ0cmVlKTsKKyAgICAgICAgUmVuZGVyRWxlbWVudCog cm9vdCA9IG1fbGF5b3V0Um9vdCA/IG1fbGF5b3V0Um9vdCA6IGZyYW1lKCkuZG9jdW1lbnQoKS0+ cmVuZGVyVmlldygpOworICAgICAgICBpZiAoIXJvb3QtPm5lZWRzTGF5b3V0KCkpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgfQogCkBAIC0zMzM5LDIxICszMzQxLDIyIEBAIGJvb2wgRnJhbWVW aWV3Ojppc0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSBjb25zdAogICAgIHJldHVy biBmYWxzZTsKIH0KIAotYm9vbCBGcmFtZVZpZXc6OmRvTGF5b3V0V2l0aEZyYW1lRmxhdHRlbmlu Zyhib29sIGFsbG93U3VidHJlZSkKK3ZvaWQgRnJhbWVWaWV3OjpzdGFydExheW91dEF0TWFpbkZy YW1lVmlld0lmTmVlZGVkKGJvb2wgYWxsb3dTdWJ0cmVlKQogewotICAgIC8vIFRyeSBpbml0aWF0 aW5nIGxheW91dCBmcm9tIHRoZSB0b3Btb3N0IHBhcmVudC4KKyAgICAvLyBXaGVuIHdlIHN0YXJ0 IGEgbGF5b3V0IGF0IHRoZSBjaGlsZCBsZXZlbCBhcyBvcHBvc2VkIHRvIHRoZSB0b3Btb3N0IGZy YW1lIHZpZXcgYW5kIHRoaXMgY2hpbGQKKyAgICAvLyBmcmFtZSByZXF1aXJlcyBmbGF0dGVuaW5n LCB3ZSBuZWVkIHRvIHJlLWluaXRpYXRlIHRoZSBsYXlvdXQgYXQgdGhlIHRvcG1vc3Qgdmlldy4g TGF5b3V0CisgICAgLy8gd2lsbCBoaXQgdGhpcyB2aWV3IGV2ZW50dWFsbHkuCiAgICAgRnJhbWVW aWV3KiBwYXJlbnRWaWV3ID0gcGFyZW50RnJhbWVWaWV3KCk7Ci0KICAgICBpZiAoIXBhcmVudFZp ZXcpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gSW4g dGhlIG1pZGRsZSBvZiBwYXJlbnQgbGF5b3V0LCBubyBuZWVkIHRvIHJlc3RhcnQgZnJvbSB0b3Bt b3N0LgogICAgIGlmIChwYXJlbnRWaWV3LT5tX25lc3RlZExheW91dENvdW50KQotICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybjsKIAogICAgIC8vIFBhcmVudCB0cmVlIGlzIGNs ZWFuLiBTdGFydGluZyBsYXlvdXQgZnJvbSBpdCB3b3VsZCBoYXZlIG5vIGVmZmVjdC4KICAgICBp ZiAoIXBhcmVudFZpZXctPm5lZWRzTGF5b3V0KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgcmV0dXJuOwogCiAgICAgd2hpbGUgKHBhcmVudFZpZXctPnBhcmVudEZyYW1lVmlldygp KQogICAgICAgICBwYXJlbnRWaWV3ID0gcGFyZW50Vmlldy0+cGFyZW50RnJhbWVWaWV3KCk7CkBA IC0zMzYyLDggKzMzNjUsNiBAQCBib29sIEZyYW1lVmlldzo6ZG9MYXlvdXRXaXRoRnJhbWVGbGF0 dGVuaW5nKGJvb2wgYWxsb3dTdWJ0cmVlKQogCiAgICAgUmVuZGVyRWxlbWVudCogcm9vdCA9IG1f bGF5b3V0Um9vdCA/IG1fbGF5b3V0Um9vdCA6IGZyYW1lKCkuZG9jdW1lbnQoKS0+cmVuZGVyVmll dygpOwogICAgIEFTU0VSVF9VTlVTRUQocm9vdCwgIXJvb3QtPm5lZWRzTGF5b3V0KCkpOwotCi0g ICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgRnJhbWVWaWV3Ojp1cGRhdGVDb250cm9sVGludHMo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggNTljZWYzODFmMzRlYWNlM2JhNmJhMjdkZjZh Y2IwMDQxYjE3MjRiNC4uNDg1MzEyNGMyNTAwZjE4Mzk2MzJkZTA5M2YxNGU2OTAxOWVkMzZiYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC01MjcsNyArNTI3LDcgQEAgcHJpdmF0ZToKIAog ICAgIEZyYW1lVmlldyogcGFyZW50RnJhbWVWaWV3KCkgY29uc3Q7CiAKLSAgICBib29sIGRvTGF5 b3V0V2l0aEZyYW1lRmxhdHRlbmluZyhib29sIGFsbG93U3VidHJlZSk7CisgICAgdm9pZCBzdGFy dExheW91dEF0TWFpbkZyYW1lVmlld0lmTmVlZGVkKGJvb2wgYWxsb3dTdWJ0cmVlKTsKICAgICBi b29sIGZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoKSBjb25zdDsKICAgICBib29sIGlzRnJhbWVGbGF0 dGVuaW5nVmFsaWRGb3JUaGlzRnJhbWUoKSBjb25zdDsKIAo=