124217 2013-11-12 12:05:50 -0800 Stop using WKArrayCreate internally 2013-11-12 12:14:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 949780 0 andersca 2013-11-12 12:05:50 -0800 Stop using WKArrayCreate internally 949782 1 216701 andersca 2013-11-12 12:06:48 -0800 Created attachment 216701 Patch 949793 2 andersca 2013-11-12 12:14:38 -0800 Committed r159133: <http://trac.webkit.org/changeset/159133> 216701 2013-11-12 12:06:48 -0800 2013-11-12 12:10:19 -0800 Patch bug-124217-20131112120647.patch text/plain 6081 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTUyMmI1YTg0ZTJjMWYy NzBmNGQ1NjRkZmY0YWM2NzI5MTFjNjYzMy4uNGE5YTY0MTNjNjI1NTE4MTBjMzgxYzg2N2VmY2Ni ZGFjMWNkMTE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTExLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU3RvcCB1c2luZyBX S0FycmF5Q3JlYXRlIGludGVybmFsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRHcm91 cC5tbToKKyAgICAgICAgKGNyZWF0ZVdLQXJyYXkpOgorICAgICAgICAoLVtXS0Jyb3dzaW5nQ29u dGV4dEdyb3VwIGFkZFVzZXJTdHlsZVNoZWV0OmJhc2VVUkw6d2hpdGVsaXN0ZWRVUkxQYXR0ZXJu czpibGFja2xpc3RlZFVSTFBhdHRlcm5zOm1haW5GcmFtZU9ubHk6XSk6CisgICAgICAgICgtW1dL QnJvd3NpbmdDb250ZXh0R3JvdXAgYWRkVXNlclNjcmlwdDpiYXNlVVJMOndoaXRlbGlzdGVkVVJM UGF0dGVybnM6YmxhY2tsaXN0ZWRVUkxQYXR0ZXJuczppbmplY3Rpb25UaW1lOm1haW5GcmFtZU9u bHk6XSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRs ZVBhZ2UuY3BwOgorICAgICAgICAoV0tCdW5kbGVQYWdlQ29weUNvbnRleHRNZW51SXRlbXMpOgor CisyMDEzLTExLTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAg ICAgICAgU2ltcGxpZnkgSW1tdXRhYmxlQXJyYXkgY3JlYXRpb24KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDIxMwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dEdyb3VwLm1tIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRHcm91cC5t bQppbmRleCBhMjRiMDE1Yzk0ZTA0ODVmY2M3YjRmOTYyODcyODM0NmMwZGJiMDAyLi5hN2IzMTA0 MThlZDRkMTE0ZmVlYjc4MWY0NTNiZjc0MzhhNDU4NjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dEdyb3VwLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0R3JvdXAubW0K QEAgLTI3LDE1ICsyNywyMCBAQAogI2ltcG9ydCAiV0tCcm93c2luZ0NvbnRleHRHcm91cC5oIgog I2ltcG9ydCAiV0tCcm93c2luZ0NvbnRleHRHcm91cFByaXZhdGUuaCIKIAorI2ltcG9ydCAiSW1t dXRhYmxlQXJyYXkuaCIKICNpbXBvcnQgIldLQXJyYXkuaCIKICNpbXBvcnQgIldLUGFnZUdyb3Vw LmgiCiAjaW1wb3J0ICJXS1ByZWZlcmVuY2VzLmgiCiAjaW1wb3J0ICJXS1JldGFpblB0ci5oIgor I2ltcG9ydCAiV0tTaGFyZWRBUElDYXN0LmgiCiAjaW1wb3J0ICJXS1N0cmluZ0NGLmgiCiAjaW1w b3J0ICJXS1VSTC5oIgogI2ltcG9ydCAiV0tVUkxDRi5oIgorI2ltcG9ydCAiV2ViU3RyaW5nLmgi CiAjaW1wb3J0IDx3dGYvVmVjdG9yLmg+CiAKK3VzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CisKIEBp bnRlcmZhY2UgV0tCcm93c2luZ0NvbnRleHRHcm91cERhdGEgOiBOU09iamVjdCB7CiBAcHVibGlj CiAgICAgV0tSZXRhaW5QdHI8V0tQYWdlR3JvdXBSZWY+IF9wYWdlR3JvdXBSZWY7CkBAIC0xMDEs MjIgKzEwNiwyMiBAQAogICAgIFdLUHJlZmVyZW5jZXNTZXRQbHVnaW5zRW5hYmxlZChXS1BhZ2VH cm91cEdldFByZWZlcmVuY2VzKHNlbGYuX3BhZ2VHcm91cFJlZiksIGFsbG93c1BsdWdJbnMpOwog fQogCi1zdGF0aWMgV0tBcnJheVJlZiBjcmVhdGVXS0FycmF5KE5TQXJyYXkgKmFycmF5KQorc3Rh dGljIFdLUmV0YWluUHRyPFdLQXJyYXlSZWY+IGNyZWF0ZVdLQXJyYXkoTlNBcnJheSAqYXJyYXkp CiB7CiAgICAgTlNVSW50ZWdlciBjb3VudCA9IFthcnJheSBjb3VudF07Ci0gICAgaWYgKGNvdW50 ID09IDApCi0gICAgICAgIHJldHVybiBXS0FycmF5UmVmKCk7CiAKLSAgICBWZWN0b3I8V0tUeXBl UmVmPiBzdHJpbmdWZWN0b3I7Ci0gICAgc3RyaW5nVmVjdG9yLnJlc2VydmVJbml0aWFsQ2FwYWNp dHkoY291bnQpOwotICAgIGZvciAoTlNVSW50ZWdlciBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsK LSAgICAgICAgaWQgZW50cnkgPSBbYXJyYXkgb2JqZWN0QXRJbmRleDppXTsKKyAgICBpZiAoIWNv dW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgIFZlY3RvcjxSZWZQdHI8QVBJT2Jq ZWN0Pj4gc3RyaW5nczsKKyAgICBzdHJpbmdzLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoY291bnQp OworCisgICAgZm9yIChpZCBlbnRyeSBpbiBhcnJheSkgewogICAgICAgICBpZiAoW2VudHJ5IGlz S2luZE9mQ2xhc3M6W05TU3RyaW5nIGNsYXNzXV0pCi0gICAgICAgICAgICBzdHJpbmdWZWN0b3Iu dW5jaGVja2VkQXBwZW5kKFdLU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5nKChDRlN0cmluZ1JlZill bnRyeSkpOwotICAgICAgICAgICAgCisgICAgICAgICAgICBzdHJpbmdzLnVuY2hlY2tlZEFwcGVu ZChhZG9wdFJlZih0b0ltcGwoV0tTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoKENGU3RyaW5nUmVm KWVudHJ5KSkpKTsKICAgICB9CiAKLSAgICByZXR1cm4gV0tBcnJheUNyZWF0ZUFkb3B0aW5nVmFs dWVzKHN0cmluZ1ZlY3Rvci5kYXRhKCksIHN0cmluZ1ZlY3Rvci5zaXplKCkpOworICAgIHJldHVy biB0b0FQSShJbW11dGFibGVBcnJheTo6Y3JlYXRlKHN0ZDo6bW92ZShzdHJpbmdzKSkubGVha1Jl ZigpKTsKIH0KIAogLSh2b2lkKWFkZFVzZXJTdHlsZVNoZWV0OihOU1N0cmluZyAqKXNvdXJjZSBi YXNlVVJMOihOU1VSTCAqKWJhc2VVUkwgd2hpdGVsaXN0ZWRVUkxQYXR0ZXJuczooTlNBcnJheSAq KXdoaXRlbGlzdCBibGFja2xpc3RlZFVSTFBhdHRlcm5zOihOU0FycmF5ICopYmxhY2tsaXN0IG1h aW5GcmFtZU9ubHk6KEJPT0wpbWFpbkZyYW1lT25seQpAQCAtMTI2LDggKzEzMSw4IEBAIHN0YXRp YyBXS0FycmF5UmVmIGNyZWF0ZVdLQXJyYXkoTlNBcnJheSAqYXJyYXkpCiAKICAgICBXS1JldGFp blB0cjxXS1N0cmluZ1JlZj4gd2tTb3VyY2UgPSBhZG9wdFdLKFdLU3RyaW5nQ3JlYXRlV2l0aENG U3RyaW5nKChDRlN0cmluZ1JlZilzb3VyY2UpKTsKICAgICBXS1JldGFpblB0cjxXS1VSTFJlZj4g d2tCYXNlVVJMID0gYWRvcHRXSyhXS1VSTENyZWF0ZVdpdGhDRlVSTCgoQ0ZVUkxSZWYpYmFzZVVS TCkpOwotICAgIFdLUmV0YWluUHRyPFdLQXJyYXlSZWY+IHdrV2hpdGVsaXN0ID0gYWRvcHRXSyhj cmVhdGVXS0FycmF5KHdoaXRlbGlzdCkpOwotICAgIFdLUmV0YWluUHRyPFdLQXJyYXlSZWY+IHdr QmxhY2tsaXN0ID0gYWRvcHRXSyhjcmVhdGVXS0FycmF5KGJsYWNrbGlzdCkpOworICAgIGF1dG8g d2tXaGl0ZWxpc3QgPSBjcmVhdGVXS0FycmF5KHdoaXRlbGlzdCk7CisgICAgYXV0byB3a0JsYWNr bGlzdCA9IGNyZWF0ZVdLQXJyYXkoYmxhY2tsaXN0KTsKICAgICBXS1VzZXJDb250ZW50SW5qZWN0 ZWRGcmFtZXMgaW5qZWN0ZWRGcmFtZXMgPSBtYWluRnJhbWVPbmx5ID8ga1dLSW5qZWN0SW5Ub3BG cmFtZU9ubHkgOiBrV0tJbmplY3RJbkFsbEZyYW1lczsKIAogICAgIFdLUGFnZUdyb3VwQWRkVXNl clN0eWxlU2hlZXQoc2VsZi5fcGFnZUdyb3VwUmVmLCB3a1NvdXJjZS5nZXQoKSwgd2tCYXNlVVJM LmdldCgpLCB3a1doaXRlbGlzdC5nZXQoKSwgd2tCbGFja2xpc3QuZ2V0KCksIGluamVjdGVkRnJh bWVzKTsKQEAgLTE0NSw4ICsxNTAsOCBAQCBzdGF0aWMgV0tBcnJheVJlZiBjcmVhdGVXS0FycmF5 KE5TQXJyYXkgKmFycmF5KQogCiAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHdrU291cmNl ID0gYWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZygoQ0ZTdHJpbmdSZWYpc291cmNl KSk7CiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IHdrQmFzZVVSTCA9IGFkb3B0V0soV0tVUkxD cmVhdGVXaXRoQ0ZVUkwoKENGVVJMUmVmKWJhc2VVUkwpKTsKLSAgICBXS1JldGFpblB0cjxXS0Fy cmF5UmVmPiB3a1doaXRlbGlzdCA9IGFkb3B0V0soY3JlYXRlV0tBcnJheSh3aGl0ZWxpc3QpKTsK LSAgICBXS1JldGFpblB0cjxXS0FycmF5UmVmPiB3a0JsYWNrbGlzdCA9IGFkb3B0V0soY3JlYXRl V0tBcnJheShibGFja2xpc3QpKTsKKyAgICBhdXRvIHdrV2hpdGVsaXN0ID0gY3JlYXRlV0tBcnJh eSh3aGl0ZWxpc3QpOworICAgIGF1dG8gd2tCbGFja2xpc3QgPSBjcmVhdGVXS0FycmF5KGJsYWNr bGlzdCk7CiAgICAgV0tVc2VyQ29udGVudEluamVjdGVkRnJhbWVzIGluamVjdGVkRnJhbWVzID0g bWFpbkZyYW1lT25seSA/IGtXS0luamVjdEluVG9wRnJhbWVPbmx5IDoga1dLSW5qZWN0SW5BbGxG cmFtZXM7CiAKICAgICBXS1BhZ2VHcm91cEFkZFVzZXJTY3JpcHQoc2VsZi5fcGFnZUdyb3VwUmVm LCB3a1NvdXJjZS5nZXQoKSwgd2tCYXNlVVJMLmdldCgpLCB3a1doaXRlbGlzdC5nZXQoKSwgd2tC bGFja2xpc3QuZ2V0KCksIGluamVjdGVkRnJhbWVzLCBpbmplY3Rpb25UaW1lKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L2MvV0tCdW5kbGVQYWdlLmNwcAppbmRleCA4NDc3YWU0NWFiMTk4Y2JkMTk0YmU3NjUzMGUzMDhk MTQ3YjA0MGM3Li43YjY2YmUyYzVmYzYxMDExYTZhYzE0NTQwZjZmMmVmZDkzZjk1ZWQ0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dL QnVuZGxlUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwCkBAIC0xNjksMTYgKzE2OSwxOCBAQCBXS0FycmF5 UmVmIFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0TWVudUl0ZW1zKFdLQnVuZGxlUGFnZVJlZiBwYWdl UmVmKQogewogI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQogICAgIFdlYkNvbnRleHRNZW51KiBj b250ZXh0TWVudSA9IHRvSW1wbChwYWdlUmVmKS0+Y29udGV4dE1lbnUoKTsKLSAgICBjb25zdCBW ZWN0b3I8V2ViQ29udGV4dE1lbnVJdGVtRGF0YT4mIGl0ZW1zID0gY29udGV4dE1lbnUtPml0ZW1z KCk7Ci0gICAgc2l6ZV90IGFycmF5TGVuZ3RoID0gaXRlbXMuc2l6ZSgpOwogCi0gICAgYXV0byB3 a0l0ZW1zID0gc3RkOjptYWtlX3VuaXF1ZTxXS1R5cGVSZWZbXT4oYXJyYXlMZW5ndGgpOwotICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgYXJyYXlMZW5ndGg7ICsraSkKLSAgICAgICAgd2tJdGVt c1tpXSA9IHRvQVBJKFdlYkNvbnRleHRNZW51SXRlbTo6Y3JlYXRlKGl0ZW1zW2ldKS5sZWFrUmVm KCkpOworICAgIGF1dG8gaXRlbXMgPSBjb250ZXh0TWVudS0+aXRlbXMoKTsKKworICAgIFZlY3Rv cjxSZWZQdHI8QVBJT2JqZWN0Pj4gbWVudUl0ZW1zOworICAgIG1lbnVJdGVtcy5yZXNlcnZlSW5p dGlhbENhcGFjaXR5KGl0ZW1zLnNpemUoKSk7CiAKLSAgICByZXR1cm4gV0tBcnJheUNyZWF0ZSh3 a0l0ZW1zLmdldCgpLCBhcnJheUxlbmd0aCk7CisgICAgZm9yIChjb25zdCBhdXRvJiBpdGVtIDog aXRlbXMpCisgICAgICAgIG1lbnVJdGVtcy51bmNoZWNrZWRBcHBlbmQoV2ViQ29udGV4dE1lbnVJ dGVtOjpjcmVhdGUoaXRlbSkpOworCisgICAgcmV0dXJuIHRvQVBJKEltbXV0YWJsZUFycmF5Ojpj cmVhdGUoc3RkOjptb3ZlKG1lbnVJdGVtcykpLmxlYWtSZWYoKSk7CiAjZWxzZQotICAgIHJldHVy biAwOworICAgIHJldHVybiBudWxscHRyOwogI2VuZGlmCiB9CiAK