124207 2013-11-12 08:22:31 -0800 Make the placed floats tree use LayoutUnit instead of int 2013-11-12 17:30:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 949676 0 bjonesbe 2013-11-12 08:22:31 -0800 Floats use LayoutUnits for all dimensions, it doesn't really make sense to be converting to ints for the placed floats tree. 949695 1 216685 bjonesbe 2013-11-12 09:18:15 -0800 Created attachment 216685 Patch 949931 2 216740 bjonesbe 2013-11-12 16:32:27 -0800 Created attachment 216740 New Patch 949936 3 216740 achicu 2013-11-12 16:36:23 -0800 Comment on attachment 216740 New Patch Looks good, r=me. 949940 4 216740 bjonesbe 2013-11-12 16:39:25 -0800 Comment on attachment 216740 New Patch Note that there is a small but non-zero chance that this could cause small precision issues with tests when subpixel layout is enabled. I have run all of the tests locally, and have not seen any issues, so I don't expect there to be any new issues from this change. 949975 5 216740 commit-queue 2013-11-12 17:30:28 -0800 Comment on attachment 216740 New Patch Clearing flags on attachment: 216740 Committed r159166: <http://trac.webkit.org/changeset/159166> 949976 6 commit-queue 2013-11-12 17:30:30 -0800 All reviewed patches have been landed. Closing bug. 216685 2013-11-12 09:18:15 -0800 2013-11-12 16:32:25 -0800 Patch bug-124207-20131112091814.patch text/plain 7935 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVmMDE4ZjdjOGVkM2Yz NTE4NWQxMzA5OGE5ZGFjYTc0OGI4ODllMi4uN2JhNjg1NDJhMDFmMWNkZTk2MTEyMDMyNThiNzM2 NDk3MmM1YWM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEzLTExLTEyICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIE1ha2UgdGhlIHBsYWNl ZCBmbG9hdHMgdHJlZSB1c2UgTGF5b3V0VW5pdCBpbnN0ZWFkIG9mIGludAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGRpbWVuc2lvbnMgb2YgZmxv YXRzIGFyZSBpbiBMYXlvdXRVbml0cywgc28gaXQgZG9lc24ndCBtYWtlIHNlbnNlCisgICAgICAg IHRvIGJlIGNvbnZlcnRpbmcgdG8gaW50cyBmb3IgdXNlIGluIHRoZSBwbGFjZWQgZmxvYXRzIHRy ZWUuCisKKyAgICAgICAgTm90ZSB0aGF0IFJlbmRlckZsb3dUaHJlYWQgYWxzbyBkZWZpbmVkIGEg c3BlY2lhbGl6YXRpb24gb2YKKyAgICAgICAgVmFsdWVUb1N0cmluZzxMYXlvdXRVbml0PiwgYnV0 IHNpbmNlIGEgUmVuZGVyRmxvd1RocmVhZCBpcyBhbHNvIGEKKyAgICAgICAgUmVuZGVyQmxvY2tG bG93LCB3aGljaCBpbmNsdWRlcyBGbG9hdGluZ09iamVjdCwgdGhlIHNwZWNpYWxpemF0aW9uIGlu CisgICAgICAgIFJlbmRlckZsb3dUaHJlYWQgaGFzIGJlZW4gcmVtb3ZlZC4KKworICAgICAgICBB bHNvIGFkZCBtaXNzZWQgImV4cGxpY2l0IiB0byBzaW5nbGUgYXJndW1lbnQgRmxvYXRpbmdPYmpl Y3RzCisgICAgICAgIGNvbnN0cnVjdG9yLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVo YXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpyYW5nZXNJbnRlcnNlY3QpOgorICAgICAgICAoV2ViQ29yZTo6 Q29tcHV0ZUZsb2F0T2Zmc2V0QWRhcHRlcjo6Q29tcHV0ZUZsb2F0T2Zmc2V0QWRhcHRlcik6Cisg ICAgICAgIChXZWJDb3JlOjpDb21wdXRlRmxvYXRPZmZzZXRBZGFwdGVyOjpsb3dWYWx1ZSk6Cisg ICAgICAgIChXZWJDb3JlOjpDb21wdXRlRmxvYXRPZmZzZXRBZGFwdGVyOjpoaWdoVmFsdWUpOgor ICAgICAgICAoV2ViQ29yZTo6RmluZE5leHRGbG9hdExvZ2ljYWxCb3R0b21BZGFwdGVyOjpGaW5k TmV4dEZsb2F0TG9naWNhbEJvdHRvbUFkYXB0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RmluZE5l eHRGbG9hdExvZ2ljYWxCb3R0b21BZGFwdGVyOjpsb3dWYWx1ZSk6CisgICAgICAgIChXZWJDb3Jl OjpGaW5kTmV4dEZsb2F0TG9naWNhbEJvdHRvbUFkYXB0ZXI6OmhpZ2hWYWx1ZSk6CisgICAgICAg ICogcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJGbG93VGhyZWFkLmg6CisKIDIwMTMtMTEtMTEgIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFu ZGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBTZWxlY3Rpb24gZm9jdXNO b2RlIHNldCB0byB0aGUgInJlZ2lvbiIgYmxvY2ssIGluc3RlYWQgb2YgdGhlICJzb3VyY2UiIGJs b2NrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3Rz LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwCmluZGV4 IGUwZjZhYmMyMWU1MDk1MTg2OGNkZjRhYTQyMzExYzg5MjYzNThlOTQuLjkwOTM2NDZiMDJiMzIx Mzk5MTQ5ZWMzNzQ1MWMyMzMzZThiNDY5YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9GbG9hdGluZ09iamVjdHMuY3BwCkBAIC05OSw3ICs5OSw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxG bG9hdGluZ09iamVjdD4gRmxvYXRpbmdPYmplY3Q6OnVuc2FmZUNsb25lKCkgY29uc3QKICAgICBy ZXR1cm4gY2xvbmVPYmplY3Q7CiB9CiAKLWlubGluZSBzdGF0aWMgYm9vbCByYW5nZXNJbnRlcnNl Y3QoaW50IGZsb2F0VG9wLCBpbnQgZmxvYXRCb3R0b20sIGludCBvYmplY3RUb3AsIGludCBvYmpl Y3RCb3R0b20pCitpbmxpbmUgc3RhdGljIGJvb2wgcmFuZ2VzSW50ZXJzZWN0KExheW91dFVuaXQg ZmxvYXRUb3AsIExheW91dFVuaXQgZmxvYXRCb3R0b20sIExheW91dFVuaXQgb2JqZWN0VG9wLCBM YXlvdXRVbml0IG9iamVjdEJvdHRvbSkKIHsKICAgICBpZiAob2JqZWN0VG9wID49IGZsb2F0Qm90 dG9tIHx8IG9iamVjdEJvdHRvbSA8IGZsb2F0VG9wKQogICAgICAgICByZXR1cm4gZmFsc2U7CkBA IC0xMjYsMTUgKzEyNiwxNSBAQCBwdWJsaWM6CiAKICAgICBDb21wdXRlRmxvYXRPZmZzZXRBZGFw dGVyKGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgcmVuZGVyZXIsIExheW91dFVuaXQgbGluZVRvcCwg TGF5b3V0VW5pdCBsaW5lQm90dG9tLCBMYXlvdXRVbml0IG9mZnNldCkKICAgICAgICAgOiBtX3Jl bmRlcmVyKHJlbmRlcmVyKQotICAgICAgICAsIG1fbGluZVRvcChyb3VuZFRvSW50KGxpbmVUb3Ap KQotICAgICAgICAsIG1fbGluZUJvdHRvbShyb3VuZFRvSW50KGxpbmVCb3R0b20pKQorICAgICAg ICAsIG1fbGluZVRvcChsaW5lVG9wKQorICAgICAgICAsIG1fbGluZUJvdHRvbShsaW5lQm90dG9t KQogICAgICAgICAsIG1fb2Zmc2V0KG9mZnNldCkKICAgICAgICAgLCBtX291dGVybW9zdEZsb2F0 KDApCiAgICAgewogICAgIH0KIAotICAgIGludCBsb3dWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1f bGluZVRvcDsgfQotICAgIGludCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2xpbmVCb3R0 b207IH0KKyAgICBMYXlvdXRVbml0IGxvd1ZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV9saW5lVG9w OyB9CisgICAgTGF5b3V0VW5pdCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2xpbmVCb3R0 b207IH0KICAgICB2b2lkIGNvbGxlY3RJZk5lZWRlZChjb25zdCBJbnRlcnZhbFR5cGUmKTsKIAog ICAgIExheW91dFVuaXQgb2Zmc2V0KCkgY29uc3QgeyByZXR1cm4gbV9vZmZzZXQ7IH0KQEAgLTE0 NSw4ICsxNDUsOCBAQCBwcml2YXRlOgogICAgIGJvb2wgdXBkYXRlT2Zmc2V0SWZOZWVkZWQoY29u c3QgRmxvYXRpbmdPYmplY3QqKTsKIAogICAgIGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgbV9yZW5k ZXJlcjsKLSAgICBpbnQgbV9saW5lVG9wOwotICAgIGludCBtX2xpbmVCb3R0b207CisgICAgTGF5 b3V0VW5pdCBtX2xpbmVUb3A7CisgICAgTGF5b3V0VW5pdCBtX2xpbmVCb3R0b207CiAgICAgTGF5 b3V0VW5pdCBtX29mZnNldDsKICAgICBjb25zdCBGbG9hdGluZ09iamVjdCogbV9vdXRlcm1vc3RG bG9hdDsKIH07CkBAIC0xNTcsMTUgKzE1NywxNSBAQCBwdWJsaWM6CiAKICAgICBGaW5kTmV4dEZs b2F0TG9naWNhbEJvdHRvbUFkYXB0ZXIoY29uc3QgUmVuZGVyQmxvY2tGbG93JiByZW5kZXJlciwg TGF5b3V0VW5pdCBiZWxvd0xvZ2ljYWxIZWlnaHQpCiAgICAgICAgIDogbV9yZW5kZXJlcihyZW5k ZXJlcikKLSAgICAgICAgLCBtX2JlbG93TG9naWNhbEhlaWdodChmbG9vclRvSW50KGJlbG93TG9n aWNhbEhlaWdodCkpCi0gICAgICAgICwgbV9hYm92ZUxvZ2ljYWxIZWlnaHQocm91bmRUb0ludChM YXlvdXRVbml0OjptYXgoKSkpCisgICAgICAgICwgbV9iZWxvd0xvZ2ljYWxIZWlnaHQoYmVsb3dM b2dpY2FsSGVpZ2h0KQorICAgICAgICAsIG1fYWJvdmVMb2dpY2FsSGVpZ2h0KExheW91dFVuaXQ6 Om1heCgpKQogICAgICAgICAsIG1fbmV4dExvZ2ljYWxCb3R0b20oTGF5b3V0VW5pdDo6bWF4KCkp CiAgICAgICAgICwgbV9uZXh0U2hhcGVMb2dpY2FsQm90dG9tKExheW91dFVuaXQ6Om1heCgpKQog ICAgIHsKICAgICB9CiAKLSAgICBpbnQgbG93VmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2JlbG93 TG9naWNhbEhlaWdodDsgfQotICAgIGludCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2Fi b3ZlTG9naWNhbEhlaWdodDsgfQorICAgIExheW91dFVuaXQgbG93VmFsdWUoKSBjb25zdCB7IHJl dHVybiBtX2JlbG93TG9naWNhbEhlaWdodDsgfQorICAgIExheW91dFVuaXQgaGlnaFZhbHVlKCkg Y29uc3QgeyByZXR1cm4gbV9hYm92ZUxvZ2ljYWxIZWlnaHQ7IH0KICAgICB2b2lkIGNvbGxlY3RJ Zk5lZWRlZChjb25zdCBJbnRlcnZhbFR5cGUmKTsKIAogICAgIExheW91dFVuaXQgbmV4dExvZ2lj YWxCb3R0b20oKSB7IHJldHVybiBtX25leHRMb2dpY2FsQm90dG9tID09IExheW91dFVuaXQ6Om1h eCgpID8gTGF5b3V0VW5pdCgpIDogbV9uZXh0TG9naWNhbEJvdHRvbTsgfQpAQCAtMTczLDggKzE3 Myw4IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIG1f cmVuZGVyZXI7Ci0gICAgaW50IG1fYmVsb3dMb2dpY2FsSGVpZ2h0OwotICAgIGludCBtX2Fib3Zl TG9naWNhbEhlaWdodDsKKyAgICBMYXlvdXRVbml0IG1fYmVsb3dMb2dpY2FsSGVpZ2h0OworICAg IExheW91dFVuaXQgbV9hYm92ZUxvZ2ljYWxIZWlnaHQ7CiAgICAgTGF5b3V0VW5pdCBtX25leHRM b2dpY2FsQm90dG9tOwogICAgIExheW91dFVuaXQgbV9uZXh0U2hhcGVMb2dpY2FsQm90dG9tOwog fTsKQEAgLTQ3NSwxMSArNDc1LDYgQEAgTGF5b3V0VW5pdCBDb21wdXRlRmxvYXRPZmZzZXRBZGFw dGVyPEZsb2F0VHlwZVZhbHVlPjo6aGVpZ2h0UmVtYWluaW5nKCkgY29uc3QKIAogI2lmbmRlZiBO REVCVUcKIC8vIFRoZXNlIGhlbHBlcnMgYXJlIG9ubHkgdXNlZCBieSB0aGUgUE9ESW50ZXJ2YWxU cmVlIGZvciBkZWJ1Z2dpbmcgcHVycG9zZXMuCi1TdHJpbmcgVmFsdWVUb1N0cmluZzxpbnQ+Ojpz dHJpbmcoY29uc3QgaW50IHZhbHVlKQotewotICAgIHJldHVybiBTdHJpbmc6Om51bWJlcih2YWx1 ZSk7Ci19Ci0KIFN0cmluZyBWYWx1ZVRvU3RyaW5nPEZsb2F0aW5nT2JqZWN0Kj46OnN0cmluZyhj b25zdCBGbG9hdGluZ09iamVjdCogZmxvYXRpbmdPYmplY3QpCiB7CiAgICAgcmV0dXJuIFN0cmlu Zzo6Zm9ybWF0KCIlcCAoJWl4JWkgJWl4JWkpIiwgZmxvYXRpbmdPYmplY3QsIGZsb2F0aW5nT2Jq ZWN0LT5mcmFtZVJlY3QoKS54KCkudG9JbnQoKSwgZmxvYXRpbmdPYmplY3QtPmZyYW1lUmVjdCgp LnkoKS50b0ludCgpLCBmbG9hdGluZ09iamVjdC0+ZnJhbWVSZWN0KCkubWF4WCgpLnRvSW50KCks IGZsb2F0aW5nT2JqZWN0LT5mcmFtZVJlY3QoKS5tYXhZKCkudG9JbnQoKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmgKaW5kZXggNjI4OTQwZmE3YWZmZjc3ZTZi NzJiZDhlM2U5ZjM5ZTQzYjI3ZjA4ZS4uMjBkN2E4OGRiMWVkZGNiYWZjMDhmM2YyYjc4OTg1NmUy MTRhYjkwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2Jq ZWN0cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuaApA QCAtMTEzLDggKzExMyw4IEBAIHN0cnVjdCBGbG9hdGluZ09iamVjdEhhc2hUcmFuc2xhdG9yIHsK IAogdHlwZWRlZiBMaXN0SGFzaFNldDxzdGQ6OnVuaXF1ZV9wdHI8RmxvYXRpbmdPYmplY3Q+LCA0 LCBGbG9hdGluZ09iamVjdEhhc2hGdW5jdGlvbnM+IEZsb2F0aW5nT2JqZWN0U2V0OwogCi10eXBl ZGVmIFBPREludGVydmFsPGludCwgRmxvYXRpbmdPYmplY3QqPiBGbG9hdGluZ09iamVjdEludGVy dmFsOwotdHlwZWRlZiBQT0RJbnRlcnZhbFRyZWU8aW50LCBGbG9hdGluZ09iamVjdCo+IEZsb2F0 aW5nT2JqZWN0VHJlZTsKK3R5cGVkZWYgUE9ESW50ZXJ2YWw8TGF5b3V0VW5pdCwgRmxvYXRpbmdP YmplY3QqPiBGbG9hdGluZ09iamVjdEludGVydmFsOwordHlwZWRlZiBQT0RJbnRlcnZhbFRyZWU8 TGF5b3V0VW5pdCwgRmxvYXRpbmdPYmplY3QqPiBGbG9hdGluZ09iamVjdFRyZWU7CiB0eXBlZGVm IFBPREZyZWVMaXN0QXJlbmE8UE9EUmVkQmxhY2tUcmVlPEZsb2F0aW5nT2JqZWN0SW50ZXJ2YWw+ OjpOb2RlPiBJbnRlcnZhbEFyZW5hOwogCiAvLyBGSVhNRTogVGhpcyBpcyByZWFsbHkgdGhlIHNh bWUgdGhpbmcgYXMgRmxvYXRpbmdPYmplY3RTZXQuCkBAIC0xMjQsNyArMTI0LDcgQEAgdHlwZWRl ZiBIYXNoTWFwPFJlbmRlckJveCosIHN0ZDo6dW5pcXVlX3B0cjxGbG9hdGluZ09iamVjdD4+IFJl bmRlcmVyVG9GbG9hdEluZm8KIGNsYXNzIEZsb2F0aW5nT2JqZWN0cyB7CiAgICAgV1RGX01BS0Vf Tk9OQ09QWUFCTEUoRmxvYXRpbmdPYmplY3RzKTsgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBw dWJsaWM6Ci0gICAgRmxvYXRpbmdPYmplY3RzKGNvbnN0IFJlbmRlckJsb2NrRmxvdyYpOworICAg IGV4cGxpY2l0IEZsb2F0aW5nT2JqZWN0cyhjb25zdCBSZW5kZXJCbG9ja0Zsb3cmKTsKICAgICB+ RmxvYXRpbmdPYmplY3RzKCk7CiAKICAgICB2b2lkIGNsZWFyKCk7CkBAIC0xNjYsOSArMTY2LDEw IEBAIHByaXZhdGU6CiAKICNpZm5kZWYgTkRFQlVHCiAvLyBUaGVzZSBzdHJ1Y3R1cmVzIGFyZSB1 c2VkIGJ5IFBPREludGVydmFsVHJlZSBmb3IgZGVidWdnaW5nIHB1cnBvc2VzLgotdGVtcGxhdGUg PD4gc3RydWN0IFZhbHVlVG9TdHJpbmc8aW50PiB7Ci0gICAgc3RhdGljIFN0cmluZyBzdHJpbmco Y29uc3QgaW50IHZhbHVlKTsKK3RlbXBsYXRlIDw+IHN0cnVjdCBWYWx1ZVRvU3RyaW5nPExheW91 dFVuaXQ+IHsKKyAgICBzdGF0aWMgU3RyaW5nIHN0cmluZyhjb25zdCBMYXlvdXRVbml0IHZhbHVl KSB7IHJldHVybiBTdHJpbmc6Om51bWJlcih2YWx1ZS50b0Zsb2F0KCkpOyB9CiB9OworCiB0ZW1w bGF0ZTw+IHN0cnVjdCBWYWx1ZVRvU3RyaW5nPEZsb2F0aW5nT2JqZWN0Kj4gewogICAgIHN0YXRp YyBTdHJpbmcgc3RyaW5nKGNvbnN0IEZsb2F0aW5nT2JqZWN0Kik7CiB9OwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmgKaW5kZXggMjFiNGZhZTMzNjk1NjJlYmEx OWM1OGM0ZDY1ZTlhN2YwM2ZiMDg2MS4uOWUxOTFkYzZlMDQyOWJlN2U4YWU5ZDVmYTVkODhjZTUz NTcyOGVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dU aHJlYWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5o CkBAIC0zNjksMTIgKzM2OSw4IEBAIHByaXZhdGU6CiAgICAgUmVuZGVyRmxvd1RocmVhZCogbV9w cmV2aW91c1JlbmRlckZsb3dUaHJlYWQ7CiB9OwogCi0vLyBUaGVzZSBzdHJ1Y3R1cmVzIGFyZSB1 c2VkIGJ5IFBPREludGVydmFsVHJlZSBmb3IgZGVidWdnaW5nLgogI2lmbmRlZiBOREVCVUcKLXRl bXBsYXRlIDw+IHN0cnVjdCBWYWx1ZVRvU3RyaW5nPExheW91dFVuaXQ+IHsKLSAgICBzdGF0aWMg U3RyaW5nIHN0cmluZyhjb25zdCBMYXlvdXRVbml0IHZhbHVlKSB7IHJldHVybiBTdHJpbmc6Om51 bWJlcih2YWx1ZS50b0Zsb2F0KCkpOyB9Ci19OwotCisvLyBUaGlzIHN0cnVjdHVyZSBpcyB1c2Vk IGJ5IFBPREludGVydmFsVHJlZSBmb3IgZGVidWdnaW5nLgogdGVtcGxhdGUgPD4gc3RydWN0IFZh bHVlVG9TdHJpbmc8UmVuZGVyUmVnaW9uKj4gewogICAgIHN0YXRpYyBTdHJpbmcgc3RyaW5nKGNv bnN0IFJlbmRlclJlZ2lvbiogdmFsdWUpIHsgcmV0dXJuIFN0cmluZzo6Zm9ybWF0KCIlcCIsIHZh bHVlKTsgfQogfTsK 216740 2013-11-12 16:32:27 -0800 2013-11-12 17:30:28 -0800 New Patch bug-124207-20131112163226.patch text/plain 5799 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNjM2I5MGY0MzFlNmI3 ZmM1NzZmMTk2NjMwZjhkZTMwY2RhYTM5My4uNTRiMzRiMjgzZjg5MWUwZTljMjhiNzc2MGY3Nzg1 YWY2MjY3ZjQ0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEzLTExLTEyICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgogCisgICAgICAgIE1ha2UgdGhlIHBsYWNl ZCBmbG9hdHMgdHJlZSB1c2UgTGF5b3V0VW5pdCBpbnN0ZWFkIG9mIGludAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGRpbWVuc2lvbnMgb2YgZmxv YXRzIGFyZSBpbiBMYXlvdXRVbml0cywgc28gaXQgZG9lc24ndCBtYWtlIHNlbnNlCisgICAgICAg IHRvIGJlIGNvbnZlcnRpbmcgdG8gaW50cyBmb3IgdXNlIGluIHRoZSBwbGFjZWQgZmxvYXRzIHRy ZWUuCisKKyAgICAgICAgQWxzbyBhZGQgbWlzc2VkICJleHBsaWNpdCIgdG8gc2luZ2xlIGFyZ3Vt ZW50IEZsb2F0aW5nT2JqZWN0cworICAgICAgICBjb25zdHJ1Y3Rvci4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmluZy9GbG9h dGluZ09iamVjdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmFuZ2VzSW50ZXJzZWN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkNvbXB1dGVGbG9hdE9mZnNldEFkYXB0ZXI6OkNvbXB1dGVGbG9hdE9m ZnNldEFkYXB0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6Q29tcHV0ZUZsb2F0T2Zmc2V0QWRhcHRl cjo6bG93VmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q29tcHV0ZUZsb2F0T2Zmc2V0QWRhcHRl cjo6aGlnaFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkZpbmROZXh0RmxvYXRMb2dpY2FsQm90 dG9tQWRhcHRlcjo6RmluZE5leHRGbG9hdExvZ2ljYWxCb3R0b21BZGFwdGVyKToKKyAgICAgICAg KFdlYkNvcmU6OkZpbmROZXh0RmxvYXRMb2dpY2FsQm90dG9tQWRhcHRlcjo6bG93VmFsdWUpOgor ICAgICAgICAoV2ViQ29yZTo6RmluZE5leHRGbG9hdExvZ2ljYWxCb3R0b21BZGFwdGVyOjpoaWdo VmFsdWUpOgorICAgICAgICAqIHJlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oOgorCisyMDEzLTExLTEyICBCZW0gSm9uZXMt QmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCiAgICAgICAgIE1vdmUgVmFsdWVUb1N0cmluZyBv dXQgdG8gaXRzIG93biBoZWFkZXIgZmlsZSB0byByZW1vdmUgZHVwbGljYXRpb24KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDIzNwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwCmluZGV4IDYwZTE5MTAyMTM1 MzExZTc1YTM5ODI2NTcyYmQ0OGZlZjkxMWNkNjAuLjEyNTU2YTRhZGUwYjM1NzdjYzg1ZDY2NWY5 ZDY0YzI5ZWZkNjdjYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9h dGluZ09iamVjdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09i amVjdHMuY3BwCkBAIC05OSw3ICs5OSw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxGbG9hdGluZ09iamVj dD4gRmxvYXRpbmdPYmplY3Q6OnVuc2FmZUNsb25lKCkgY29uc3QKICAgICByZXR1cm4gY2xvbmVP YmplY3Q7CiB9CiAKLWlubGluZSBzdGF0aWMgYm9vbCByYW5nZXNJbnRlcnNlY3QoaW50IGZsb2F0 VG9wLCBpbnQgZmxvYXRCb3R0b20sIGludCBvYmplY3RUb3AsIGludCBvYmplY3RCb3R0b20pCitp bmxpbmUgc3RhdGljIGJvb2wgcmFuZ2VzSW50ZXJzZWN0KExheW91dFVuaXQgZmxvYXRUb3AsIExh eW91dFVuaXQgZmxvYXRCb3R0b20sIExheW91dFVuaXQgb2JqZWN0VG9wLCBMYXlvdXRVbml0IG9i amVjdEJvdHRvbSkKIHsKICAgICBpZiAob2JqZWN0VG9wID49IGZsb2F0Qm90dG9tIHx8IG9iamVj dEJvdHRvbSA8IGZsb2F0VG9wKQogICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0xMjYsMTUgKzEy NiwxNSBAQCBwdWJsaWM6CiAKICAgICBDb21wdXRlRmxvYXRPZmZzZXRBZGFwdGVyKGNvbnN0IFJl bmRlckJsb2NrRmxvdyYgcmVuZGVyZXIsIExheW91dFVuaXQgbGluZVRvcCwgTGF5b3V0VW5pdCBs aW5lQm90dG9tLCBMYXlvdXRVbml0IG9mZnNldCkKICAgICAgICAgOiBtX3JlbmRlcmVyKHJlbmRl cmVyKQotICAgICAgICAsIG1fbGluZVRvcChyb3VuZFRvSW50KGxpbmVUb3ApKQotICAgICAgICAs IG1fbGluZUJvdHRvbShyb3VuZFRvSW50KGxpbmVCb3R0b20pKQorICAgICAgICAsIG1fbGluZVRv cChsaW5lVG9wKQorICAgICAgICAsIG1fbGluZUJvdHRvbShsaW5lQm90dG9tKQogICAgICAgICAs IG1fb2Zmc2V0KG9mZnNldCkKICAgICAgICAgLCBtX291dGVybW9zdEZsb2F0KDApCiAgICAgewog ICAgIH0KIAotICAgIGludCBsb3dWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbGluZVRvcDsgfQot ICAgIGludCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2xpbmVCb3R0b207IH0KKyAgICBM YXlvdXRVbml0IGxvd1ZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV9saW5lVG9wOyB9CisgICAgTGF5 b3V0VW5pdCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2xpbmVCb3R0b207IH0KICAgICB2 b2lkIGNvbGxlY3RJZk5lZWRlZChjb25zdCBJbnRlcnZhbFR5cGUmKTsKIAogICAgIExheW91dFVu aXQgb2Zmc2V0KCkgY29uc3QgeyByZXR1cm4gbV9vZmZzZXQ7IH0KQEAgLTE0NSw4ICsxNDUsOCBA QCBwcml2YXRlOgogICAgIGJvb2wgdXBkYXRlT2Zmc2V0SWZOZWVkZWQoY29uc3QgRmxvYXRpbmdP YmplY3QqKTsKIAogICAgIGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgbV9yZW5kZXJlcjsKLSAgICBp bnQgbV9saW5lVG9wOwotICAgIGludCBtX2xpbmVCb3R0b207CisgICAgTGF5b3V0VW5pdCBtX2xp bmVUb3A7CisgICAgTGF5b3V0VW5pdCBtX2xpbmVCb3R0b207CiAgICAgTGF5b3V0VW5pdCBtX29m ZnNldDsKICAgICBjb25zdCBGbG9hdGluZ09iamVjdCogbV9vdXRlcm1vc3RGbG9hdDsKIH07CkBA IC0xNTcsMTUgKzE1NywxNSBAQCBwdWJsaWM6CiAKICAgICBGaW5kTmV4dEZsb2F0TG9naWNhbEJv dHRvbUFkYXB0ZXIoY29uc3QgUmVuZGVyQmxvY2tGbG93JiByZW5kZXJlciwgTGF5b3V0VW5pdCBi ZWxvd0xvZ2ljYWxIZWlnaHQpCiAgICAgICAgIDogbV9yZW5kZXJlcihyZW5kZXJlcikKLSAgICAg ICAgLCBtX2JlbG93TG9naWNhbEhlaWdodChmbG9vclRvSW50KGJlbG93TG9naWNhbEhlaWdodCkp Ci0gICAgICAgICwgbV9hYm92ZUxvZ2ljYWxIZWlnaHQocm91bmRUb0ludChMYXlvdXRVbml0Ojpt YXgoKSkpCisgICAgICAgICwgbV9iZWxvd0xvZ2ljYWxIZWlnaHQoYmVsb3dMb2dpY2FsSGVpZ2h0 KQorICAgICAgICAsIG1fYWJvdmVMb2dpY2FsSGVpZ2h0KExheW91dFVuaXQ6Om1heCgpKQogICAg ICAgICAsIG1fbmV4dExvZ2ljYWxCb3R0b20oTGF5b3V0VW5pdDo6bWF4KCkpCiAgICAgICAgICwg bV9uZXh0U2hhcGVMb2dpY2FsQm90dG9tKExheW91dFVuaXQ6Om1heCgpKQogICAgIHsKICAgICB9 CiAKLSAgICBpbnQgbG93VmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2JlbG93TG9naWNhbEhlaWdo dDsgfQotICAgIGludCBoaWdoVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2Fib3ZlTG9naWNhbEhl aWdodDsgfQorICAgIExheW91dFVuaXQgbG93VmFsdWUoKSBjb25zdCB7IHJldHVybiBtX2JlbG93 TG9naWNhbEhlaWdodDsgfQorICAgIExheW91dFVuaXQgaGlnaFZhbHVlKCkgY29uc3QgeyByZXR1 cm4gbV9hYm92ZUxvZ2ljYWxIZWlnaHQ7IH0KICAgICB2b2lkIGNvbGxlY3RJZk5lZWRlZChjb25z dCBJbnRlcnZhbFR5cGUmKTsKIAogICAgIExheW91dFVuaXQgbmV4dExvZ2ljYWxCb3R0b20oKSB7 IHJldHVybiBtX25leHRMb2dpY2FsQm90dG9tID09IExheW91dFVuaXQ6Om1heCgpID8gTGF5b3V0 VW5pdCgpIDogbV9uZXh0TG9naWNhbEJvdHRvbTsgfQpAQCAtMTczLDggKzE3Myw4IEBAIHB1Ymxp YzoKIAogcHJpdmF0ZToKICAgICBjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIG1fcmVuZGVyZXI7Ci0g ICAgaW50IG1fYmVsb3dMb2dpY2FsSGVpZ2h0OwotICAgIGludCBtX2Fib3ZlTG9naWNhbEhlaWdo dDsKKyAgICBMYXlvdXRVbml0IG1fYmVsb3dMb2dpY2FsSGVpZ2h0OworICAgIExheW91dFVuaXQg bV9hYm92ZUxvZ2ljYWxIZWlnaHQ7CiAgICAgTGF5b3V0VW5pdCBtX25leHRMb2dpY2FsQm90dG9t OwogICAgIExheW91dFVuaXQgbV9uZXh0U2hhcGVMb2dpY2FsQm90dG9tOwogfTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuaCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuaAppbmRleCBkNDUxZGJhYzFlMzM4NjE0 NGMwNDljNDg5NjY0ZWVlODNjNmU5OWFkLi44NTE5MjM3NzkyYWIxNDhiNmY3YjdmMDc5NzNkMjM2 YTQwYzJlN2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdP YmplY3RzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5o CkBAIC0xMTMsOCArMTEzLDggQEAgc3RydWN0IEZsb2F0aW5nT2JqZWN0SGFzaFRyYW5zbGF0b3Ig ewogCiB0eXBlZGVmIExpc3RIYXNoU2V0PHN0ZDo6dW5pcXVlX3B0cjxGbG9hdGluZ09iamVjdD4s IDQsIEZsb2F0aW5nT2JqZWN0SGFzaEZ1bmN0aW9ucz4gRmxvYXRpbmdPYmplY3RTZXQ7CiAKLXR5 cGVkZWYgUE9ESW50ZXJ2YWw8aW50LCBGbG9hdGluZ09iamVjdCo+IEZsb2F0aW5nT2JqZWN0SW50 ZXJ2YWw7Ci10eXBlZGVmIFBPREludGVydmFsVHJlZTxpbnQsIEZsb2F0aW5nT2JqZWN0Kj4gRmxv YXRpbmdPYmplY3RUcmVlOwordHlwZWRlZiBQT0RJbnRlcnZhbDxMYXlvdXRVbml0LCBGbG9hdGlu Z09iamVjdCo+IEZsb2F0aW5nT2JqZWN0SW50ZXJ2YWw7Cit0eXBlZGVmIFBPREludGVydmFsVHJl ZTxMYXlvdXRVbml0LCBGbG9hdGluZ09iamVjdCo+IEZsb2F0aW5nT2JqZWN0VHJlZTsKIHR5cGVk ZWYgUE9ERnJlZUxpc3RBcmVuYTxQT0RSZWRCbGFja1RyZWU8RmxvYXRpbmdPYmplY3RJbnRlcnZh bD46Ok5vZGU+IEludGVydmFsQXJlbmE7CiAKIC8vIEZJWE1FOiBUaGlzIGlzIHJlYWxseSB0aGUg c2FtZSB0aGluZyBhcyBGbG9hdGluZ09iamVjdFNldC4KQEAgLTEyNCw3ICsxMjQsNyBAQCB0eXBl ZGVmIEhhc2hNYXA8UmVuZGVyQm94Kiwgc3RkOjp1bmlxdWVfcHRyPEZsb2F0aW5nT2JqZWN0Pj4g UmVuZGVyZXJUb0Zsb2F0SW5mbwogY2xhc3MgRmxvYXRpbmdPYmplY3RzIHsKICAgICBXVEZfTUFL RV9OT05DT1BZQUJMRShGbG9hdGluZ09iamVjdHMpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsK IHB1YmxpYzoKLSAgICBGbG9hdGluZ09iamVjdHMoY29uc3QgUmVuZGVyQmxvY2tGbG93Jik7Cisg ICAgZXhwbGljaXQgRmxvYXRpbmdPYmplY3RzKGNvbnN0IFJlbmRlckJsb2NrRmxvdyYpOwogICAg IH5GbG9hdGluZ09iamVjdHMoKTsKIAogICAgIHZvaWQgY2xlYXIoKTsK