124205 2013-11-12 07:56:58 -0800 [CSS Regions] Float get sliced if its container has forced break and is less tall than float 2013-11-21 07:41:13 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 124706 1 mibalan stavila commit-queue WebkitBugTracker oldest_to_newest 949674 0 216675 mibalan 2013-11-12 07:56:58 -0800 Created attachment 216675 HTML file highlighting the problem When a float is taller than its container and overflowing it, setting a forced region break on the container will lead to the float being sliced instead of properly fragmented. In the attached file, the lines of the float *must not* be sliced, yet they are. The slicing does not occur if the breaks are unforced (e.g. first region is 30px tall). 952636 1 217449 stavila 2013-11-20 09:52:11 -0800 Created attachment 217449 Patch containing layout test This problem has been fixed by https://bugs.webkit.org/show_bug.cgi?id=118665. After that patch lands, this new test can be landed as well (the tests fail on the current implementation, without the 118665 patch). 953097 2 217449 commit-queue 2013-11-21 07:41:12 -0800 Comment on attachment 217449 Patch containing layout test Clearing flags on attachment: 217449 Committed r159627: <http://trac.webkit.org/changeset/159627> 953098 3 commit-queue 2013-11-21 07:41:13 -0800 All reviewed patches have been landed. Closing bug. 216675 2013-11-12 07:56:58 -0800 2013-11-12 07:56:58 -0800 HTML file highlighting the problem float-slicing-on-forced-break.html text/html 926 mibalan PCFET0NUWVBFIGh0bWw+CjxodG1sPgoJPGhlYWQ+CgkJPHRpdGxlPmZsb2F0IG92ZXJmbG93aW5n IGNvbnRhaW5lciB3aXRoIGZvcmNlZCByZWdpb24gYnJlYWs8L3RpdGxlPgoJCTxzdHlsZT4KCQlh cnRpY2xlIHsKCQkJZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsKCQkJZm9udC1zaXplOiAyMHB4OwoJ CQlsaW5lLWhlaWdodDogMWVtOwoJCQljb2xvcjogZ3JlZW47CgkJfQoJCS5mbG93IHsKCQkJLXdl YmtpdC1mbG93LWludG86IGY7CgkJCWNvbG9yOiBibHVlOwoJCX0KCQkuZmxvYXQgewoJCQlmbG9h dDogbGVmdDsKCQkJY29sb3I6IGdyZWVuOwoJCX0KCQkucmVnaW9uIHsKCQkJLXdlYmtpdC1mbG93 LWZyb206IGY7CgkJCW1hcmdpbjogMjBweDsKCQl9CgkJI2NvbnRhaW5lciB7CgkJCS13ZWJraXQt cmVnaW9uLWJyZWFrLWFmdGVyOiBhbHdheXM7CgkJfQoJCSNzbWFsbCB7CgkJCWZvbnQtc2l6ZTog MTBweDsKCQkJbGluZS1oZWlnaHQ6IDFlbTsKCQl9CgkJPC9zdHlsZT4KCTwvaGVhZD4KCTxib2R5 PgoJCTxwPgoJCQlGbG9hdCBvdmVyZmxvd2luZyBpdHMgY29udGFpbmVyIHRoYXQgaGFzIGEgZm9y Y2VkIGJyZWFrLiBUd28gcmVnaW9ucy4gTm8gbGluZSBzaG91bGQgYmUgc2xpY2VkLgoJCTwvcD4K CgkJPGRpdiBjbGFzcz0icmVnaW9uIj4KCQk8L2Rpdj4KCQk8ZGl2IGNsYXNzPSJyZWdpb24iPgoJ CTwvZGl2PgoKCQk8YXJ0aWNsZSBjbGFzcz0iZmxvdyI+CgkJCTxkaXYgaWQ9ImNvbnRhaW5lciI+ CgkJCQk8ZGl2IGNsYXNzPSJmbG9hdCI+CgkJCQkJRklMTEVSPGJyPgoJCQkJCUZJTExFUjxicj4K CQkJCQlGSUxMRVIKCQkJCTwvZGl2PgoJCQkJRklMTEVSCgkJCQk8ZGl2IGlkPSJzbWFsbCI+VElO WTwvZGl2PgoJCQk8L2Rpdj4KCQkJRklMTEVSPGJyPgoJCQlGSUxMRVIKCQk8L2FydGljbGU+Cgk8 L2JvZHk+CjwvaHRtbD4= 217449 2013-11-20 09:52:11 -0800 2013-11-21 07:41:12 -0800 Patch containing layout test 124205.patch text/plain 3236 stavila ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZTYyODE1Li5lZmFlYTIzYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEx LTIwICBSYWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIFJl Z2lvbnNdIEZsb2F0IGdldCBzbGljZWQgaWYgaXRzIGNvbnRhaW5lciBoYXMgZm9yY2VkIGJyZWFr IGFuZCBpcyBsZXNzIHRhbGwgdGhhbiBmbG9hdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MjA1CisKKyAgICAgICAgQWRkZWQgdGVzdCBmb3IgdGhl IGNhc2Ugd2hlbiBhIGZsb2F0IGlzIG92ZXJmbG93aW5nIGEgcmVnaW9uIGR1ZSB0byBhIGZvcmNl ZCBicmVhay4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZhc3QvcmVnaW9ucy9mbG9hdC1zbGljaW5nLW9uLWZvcmNlZC1icmVhay1leHBlY3RlZC5o dG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvZmxvYXQtc2xpY2luZy1vbi1mb3Jj ZWQtYnJlYWsuaHRtbDogQWRkZWQuCisKIDIwMTMtMTEtMjAgIE1pY2hhxYIgUGFrdcWCYSB2ZWwg UnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEVGTCBn YXJkZW5pbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9mbG9hdC1zbGlj aW5nLW9uLWZvcmNlZC1icmVhay1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdp b25zL2Zsb2F0LXNsaWNpbmctb24tZm9yY2VkLWJyZWFrLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOGZiYjIzMQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9mbG9hdC1zbGljaW5nLW9uLWZvcmNlZC1icmVhay1leHBl Y3RlZC5odG1sCkBAIC0wLDAgKzEsNDkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisJPGhl YWQ+CisJCTx0aXRsZT5mbG9hdCBvdmVyZmxvd2luZyBjb250YWluZXIgd2l0aCBmb3JjZWQgcmVn aW9uIGJyZWFrPC90aXRsZT4KKwkJPHN0eWxlPgorCQlkaXYgeworCQkJZm9udC1mYW1pbHk6IG1v bm9zcGFjZTsKKwkJCWZvbnQtc2l6ZTogMjBweDsKKwkJCWxpbmUtaGVpZ2h0OiAxZW07CisJCX0K KwkJI2NvbnRhaW5lciB7CisJCQljb2xvcjogYmx1ZTsKKwkJfQorCQkuZmxvYXQgeworCQkJZmxv YXQ6IGxlZnQ7CisJCQljb2xvcjogZ3JlZW47CisJCX0KKwkJLnJlZ2lvbiB7CisJCQltYXJnaW46 IDIwcHg7CisJCX0KKwkJI3NtYWxsIHsKKwkJCWZvbnQtc2l6ZTogMTBweDsKKwkJCWxpbmUtaGVp Z2h0OiAxZW07CisJCX0KKwkJPC9zdHlsZT4KKwk8L2hlYWQ+CisJPGJvZHk+CisJCTxwPgorCQkJ RmxvYXQgb3ZlcmZsb3dpbmcgaXRzIGNvbnRhaW5lciB0aGF0IGhhcyBhIGZvcmNlZCBicmVhay4g VHdvIHJlZ2lvbnMuIE5vIGxpbmUgc2hvdWxkIGJlIHNsaWNlZC4KKwkJPC9wPgorCisJCTxkaXYg Y2xhc3M9InJlZ2lvbiI+CisJCQk8ZGl2IGlkPSJjb250YWluZXIiPgorCQkJCTxkaXYgY2xhc3M9 ImZsb2F0Ij4KKwkJCQkJRklMTEVSPGJyPgorCQkJCQlGSUxMRVI8YnI+CisJCQkJCUZJTExFUjxi cj4KKwkJCQkJRklMTEVSCisJCQkJPC9kaXY+CisJCQkJRklMTEVSCisJCQkJPGRpdiBpZD0ic21h bGwiPlRJTlk8L2Rpdj4KKwkJCTwvZGl2PgorCQk8L2Rpdj4KKwkJPGRpdiBjbGFzcz0icmVnaW9u IiBzdHlsZT0iY29sb3I6IGJsdWU7Ij4KKwkJCUZJTExFUjxicj4KKwkJCUZJTExFUgorCQk8L2Rp dj4KKwk8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2Zsb2F0LXNsaWNpbmctb24tZm9yY2VkLWJy ZWFrLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvZmxvYXQtc2xpY2luZy1vbi1mb3Jj ZWQtYnJlYWsuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41NTc3MTk1 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2Zsb2F0LXNsaWNp bmctb24tZm9yY2VkLWJyZWFrLmh0bWwKQEAgLTAsMCArMSw1OCBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKwk8aGVhZD4KKwkJPHRpdGxlPmZsb2F0IG92ZXJmbG93aW5nIGNvbnRhaW5lciB3 aXRoIGZvcmNlZCByZWdpb24gYnJlYWs8L3RpdGxlPgorCQk8c3R5bGU+CisJCWFydGljbGUgewor CQkJZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsKKwkJCWZvbnQtc2l6ZTogMjBweDsKKwkJCWxpbmUt aGVpZ2h0OiAxZW07CisJCQljb2xvcjogZ3JlZW47CisJCX0KKwkJLmZsb3cgeworCQkJLXdlYmtp dC1mbG93LWludG86IGY7CisJCQljb2xvcjogYmx1ZTsKKwkJfQorCQkuZmxvYXQgeworCQkJZmxv YXQ6IGxlZnQ7CisJCQljb2xvcjogZ3JlZW47CisJCX0KKwkJLnJlZ2lvbiB7CisJCQktd2Via2l0 LWZsb3ctZnJvbTogZjsKKwkJCW1hcmdpbjogMjBweDsKKwkJfQorCQkjY29udGFpbmVyIHsKKwkJ CS13ZWJraXQtcmVnaW9uLWJyZWFrLWFmdGVyOiBhbHdheXM7CisJCX0KKwkJI3NtYWxsIHsKKwkJ CWZvbnQtc2l6ZTogMTBweDsKKwkJCWxpbmUtaGVpZ2h0OiAxZW07CisJCX0KKwkJPC9zdHlsZT4K Kwk8L2hlYWQ+CisJPGJvZHk+CisJCTxwPgorCQkJRmxvYXQgb3ZlcmZsb3dpbmcgaXRzIGNvbnRh aW5lciB0aGF0IGhhcyBhIGZvcmNlZCBicmVhay4gVHdvIHJlZ2lvbnMuIE5vIGxpbmUgc2hvdWxk IGJlIHNsaWNlZC4KKwkJPC9wPgorCisJCTxkaXYgY2xhc3M9InJlZ2lvbiI+CisJCTwvZGl2Pgor CQk8ZGl2IGNsYXNzPSJyZWdpb24iPgorCQk8L2Rpdj4KKworCQk8YXJ0aWNsZSBjbGFzcz0iZmxv dyI+CisJCQk8ZGl2IGlkPSJjb250YWluZXIiPgorCQkJCTxkaXYgY2xhc3M9ImZsb2F0Ij4KKwkJ CQkJRklMTEVSPGJyPgorCQkJCQlGSUxMRVI8YnI+CisJCQkJCUZJTExFUjxicj4KKwkJCQkJRklM TEVSCisJCQkJPC9kaXY+CisJCQkJRklMTEVSCisJCQkJPGRpdiBpZD0ic21hbGwiPlRJTlk8L2Rp dj4KKwkJCTwvZGl2PgorCQkJRklMTEVSPGJyPgorCQkJRklMTEVSCisJCTwvYXJ0aWNsZT4KKwk8 L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=