124200 2013-11-12 06:04:23 -0800 Text on simple lines sometimes paints one pixel off 2013-11-12 06:44:32 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 949634 0 koivisto 2013-11-12 06:04:23 -0800 Paint rounding is wrong 949639 1 216659 koivisto 2013-11-12 06:18:04 -0800 Created attachment 216659 patch 949645 2 216659 kling 2013-11-12 06:25:28 -0800 Comment on attachment 216659 patch r=me 949653 3 koivisto 2013-11-12 06:44:32 -0800 https://trac.webkit.org/r159105 216659 2013-11-12 06:18:04 -0800 2013-11-12 06:25:28 -0800 patch simple-line-rounding.patch text/plain 5919 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTEwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEzLTExLTEyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUZXh0IG9uIHNpbXBsZSBsaW5l cyBzb21ldGltZXMgcGFpbnRzIG9uZSBwaXhlbCBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDIwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9saW5lLXJ1bnMtc2ltcGxl LWxpbmVzLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OmFkanVzdFJ1bk9mZnNldHMpOgor ICAgICAgICAKKyAgICAgICAgICAgIERvbid0IHJvdW5kIG9uIHJ1biBjb25zdHJ1Y3Rpb24gdGlt ZS4KKworICAgICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6Y3JlYXRlVGV4dFJ1bnMp OgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2ZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OlJ1blJlc29sdmVyOjpSdW46OnJlY3QpOgor ICAgICAgICAKKyAgICAgICAgICAgIEluc3RlYWQgcm91bmQgd2hlbiBnZW5lcmF0aW5nIHJlY3Rz LgorCisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpSdW5SZXNvbHZlcjo6UnVu OjpiYXNlbGluZSk6CisgICAgICAgIAorICAgICAgICAgICAgUHJvdmlkZSB0aGUgYmFzZWxpbmUg KHVzZWQgYnkgcGFpbnRpbmcpIGFzIHVucm91bmRlZCBGbG9hdFBvaW50LgorCiAyMDEzLTExLTEy ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBKU0MgYmlu ZGluZ3MgZ2VuZXJhdG9yIHNob3VsZCBnZW5lcmF0ZSBkZWxldGFibGUgSlNDIGZ1bmN0aW9ucwpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcAko cmV2aXNpb24gMTU5MTAwKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsMTIgKzI2MCwxMyBAQCBzdGF0aWMgZmxv YXQgY29tcHV0ZUxpbmVMZWZ0KEVUZXh0QWxpZ24gCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0YXRp YyB2b2lkIGFkanVzdFJ1bk9mZnNldHMoVmVjdG9yPFJ1biwgND4mIGxpbmVSdW5zLCBFVGV4dEFs aWduIHRleHRBbGlnbiwgZmxvYXQgbGluZVdpZHRoLCBmbG9hdCBhdmFpbGFibGVXaWR0aCkKK3N0 YXRpYyB2b2lkIGFkanVzdFJ1bk9mZnNldHMoVmVjdG9yPFJ1biwgND4mIGxpbmVSdW5zLCBmbG9h dCBhZGp1c3RtZW50KQogewotICAgIGZsb2F0IGxpbmVMZWZ0ID0gY29tcHV0ZUxpbmVMZWZ0KHRl eHRBbGlnbiwgYXZhaWxhYmxlV2lkdGggLSBsaW5lV2lkdGgpOworICAgIGlmICghYWRqdXN0bWVu dCkKKyAgICAgICAgcmV0dXJuOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsaW5lUnVu cy5zaXplKCk7ICsraSkgewotICAgICAgICBsaW5lUnVuc1tpXS5sZWZ0ID0gZmxvb3IobGluZUxl ZnQgKyBsaW5lUnVuc1tpXS5sZWZ0KTsKLSAgICAgICAgbGluZVJ1bnNbaV0ucmlnaHQgPSBjZWls KGxpbmVMZWZ0ICsgbGluZVJ1bnNbaV0ucmlnaHQpOworICAgICAgICBsaW5lUnVuc1tpXS5sZWZ0 ICs9IGFkanVzdG1lbnQ7CisgICAgICAgIGxpbmVSdW5zW2ldLnJpZ2h0ICs9IGFkanVzdG1lbnQ7 CiAgICAgfQogfQogCkBAIC0zODEsNyArMzgyLDggQEAgdm9pZCBjcmVhdGVUZXh0UnVucyhMYXlv dXQ6OlJ1blZlY3RvciYgcgogCiAgICAgICAgIGxpbmVSdW5zLmxhc3QoKS5pc0VuZE9mTGluZSA9 IHRydWU7CiAKLSAgICAgICAgYWRqdXN0UnVuT2Zmc2V0cyhsaW5lUnVucywgdGV4dEFsaWduLCBs aW5lV2lkdGguY29tbWl0dGVkV2lkdGgoKSwgbGluZVdpZHRoLmF2YWlsYWJsZVdpZHRoKCkpOwor ICAgICAgICBmbG9hdCBsaW5lTGVmdCA9IGNvbXB1dGVMaW5lTGVmdCh0ZXh0QWxpZ24sIGxpbmVX aWR0aC5hdmFpbGFibGVXaWR0aCgpIC0gbGluZVdpZHRoLmNvbW1pdHRlZFdpZHRoKCkpOworICAg ICAgICBhZGp1c3RSdW5PZmZzZXRzKGxpbmVSdW5zLCBsaW5lTGVmdCk7CiAKICAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IGxpbmVSdW5zLnNpemUoKTsgKytpKQogICAgICAgICAgICAg cnVucy5hcHBlbmQobGluZVJ1bnNbaV0pOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1NpbXBsZUxpbmVMYXlvdXRSZXNvbHZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2ZXIuaAkocmV2aXNpb24gMTU5MTAwKQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXRSZXNvbHZlci5oCSh3 b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw3IEBAIHB1YmxpYzoKICAgICAgICAgZXhwbGljaXQg UnVuKGNvbnN0IEl0ZXJhdG9yJik7CiAKICAgICAgICAgTGF5b3V0UmVjdCByZWN0KCkgY29uc3Q7 Ci0gICAgICAgIExheW91dFBvaW50IGJhc2VsaW5lKCkgY29uc3Q7CisgICAgICAgIEZsb2F0UG9p bnQgYmFzZWxpbmUoKSBjb25zdDsKICAgICAgICAgU3RyaW5nIHRleHQoKSBjb25zdDsKIAogICAg ICAgICB1bnNpZ25lZCBsaW5lSW5kZXgoKSBjb25zdDsKQEAgLTEzMCwxOCArMTMwLDE4IEBAIGlu bGluZSBMYXlvdXRSZWN0IFJ1blJlc29sdmVyOjpSdW46OnJlY3QKICAgICBhdXRvJiByZXNvbHZl ciA9IG1faXRlcmF0b3IucmVzb2x2ZXIoKTsKICAgICBhdXRvJiBydW4gPSBtX2l0ZXJhdG9yLnNp bXBsZVJ1bigpOwogCi0gICAgTGF5b3V0UG9pbnQgbGluZVBvc2l0aW9uKHJ1bi5sZWZ0LCByZXNv bHZlci5tX2xpbmVIZWlnaHQgKiBtX2l0ZXJhdG9yLmxpbmVJbmRleCgpICsgcmVzb2x2ZXIubV9i YXNlbGluZSAtIHJlc29sdmVyLm1fYXNjZW50KTsKLSAgICBMYXlvdXRTaXplIGxpbmVTaXplKHJ1 bi5yaWdodCAtIHJ1bi5sZWZ0LCByZXNvbHZlci5tX2FzY2VudCArIHJlc29sdmVyLm1fZGVzY2Vu dCk7CisgICAgTGF5b3V0UG9pbnQgbGluZVBvc2l0aW9uKGZsb29yKHJ1bi5sZWZ0KSwgcmVzb2x2 ZXIubV9saW5lSGVpZ2h0ICogbV9pdGVyYXRvci5saW5lSW5kZXgoKSArIHJlc29sdmVyLm1fYmFz ZWxpbmUgLSByZXNvbHZlci5tX2FzY2VudCk7CisgICAgTGF5b3V0U2l6ZSBsaW5lU2l6ZShjZWls KHJ1bi5yaWdodCkgLSBmbG9vcihydW4ubGVmdCksIHJlc29sdmVyLm1fYXNjZW50ICsgcmVzb2x2 ZXIubV9kZXNjZW50KTsKICAgICByZXR1cm4gTGF5b3V0UmVjdChsaW5lUG9zaXRpb24gKyByZXNv bHZlci5tX2NvbnRlbnRPZmZzZXQsIGxpbmVTaXplKTsKIH0KIAotaW5saW5lIExheW91dFBvaW50 IFJ1blJlc29sdmVyOjpSdW46OmJhc2VsaW5lKCkgY29uc3QKK2lubGluZSBGbG9hdFBvaW50IFJ1 blJlc29sdmVyOjpSdW46OmJhc2VsaW5lKCkgY29uc3QKIHsKICAgICBhdXRvJiByZXNvbHZlciA9 IG1faXRlcmF0b3IucmVzb2x2ZXIoKTsKICAgICBhdXRvJiBydW4gPSBtX2l0ZXJhdG9yLnNpbXBs ZVJ1bigpOwogCiAgICAgZmxvYXQgYmFzZWxpbmVZID0gcmVzb2x2ZXIubV9saW5lSGVpZ2h0ICog bV9pdGVyYXRvci5saW5lSW5kZXgoKSArIHJlc29sdmVyLm1fYmFzZWxpbmU7Ci0gICAgcmV0dXJu IExheW91dFBvaW50KHJ1bi5sZWZ0LCBiYXNlbGluZVkpICsgcmVzb2x2ZXIubV9jb250ZW50T2Zm c2V0OworICAgIHJldHVybiBGbG9hdFBvaW50KHJ1bi5sZWZ0LCBiYXNlbGluZVkpICsgcmVzb2x2 ZXIubV9jb250ZW50T2Zmc2V0OwogfQogCiBpbmxpbmUgU3RyaW5nIFJ1blJlc29sdmVyOjpSdW46 OnRleHQoKSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5MTAyKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTEtMTIgIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFRleHQgb24gc2ltcGxl IGxpbmVzIHNvbWV0aW1lcyBwYWludHMgb25lIHBpeGVsIG9mZgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MjAwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvbGluZS1ydW5zLXJvdW5k aW5nLXNpbXBsZS1saW5lcy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Rl eHQvbGluZS1ydW5zLXJvdW5kaW5nLXNpbXBsZS1saW5lcy5odG1sOiBBZGRlZC4KKwogMjAxMy0x MS0xMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgSlND IGJpbmRpbmdzIGdlbmVyYXRvciBzaG91bGQgZ2VuZXJhdGUgZGVsZXRhYmxlIEpTQyBmdW5jdGlv bnMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9saW5lLXJ1bnMtcm91bmRpbmctc2ltcGxl LWxpbmVzLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L2xpbmUtcnVucy1yb3VuZGluZy1zaW1wbGUtbGluZXMtZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGV4dC9saW5lLXJ1bnMtcm91bmRpbmctc2ltcGxlLWxp bmVzLWV4cGVjdGVkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw5IEBACis8c2NyaXB0 PgoraWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldFNpbXBs ZUxpbmVMYXlvdXRFbmFibGVkKGZhbHNlKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorZGl2IHsgZm9u dC1zaXplOiAxMXB4OyBmb250LWZhbWlseTogJy5MdWNpZGFHcmFuZGVVSSc7IH0KKzwvc3R5bGU+ Cis8ZGl2PkxvcmVtIGlwc3VtIGRvbG9yPC9kaXY+Cis8ZGl2PkxvcmVtIGlwc3VtICBkb2xvcjwv ZGl2PgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2xpbmUtcnVucy1yb3VuZGluZy1zaW1w bGUtbGluZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvbGluZS1y dW5zLXJvdW5kaW5nLXNpbXBsZS1saW5lcy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC90ZXh0L2xpbmUtcnVucy1yb3VuZGluZy1zaW1wbGUtbGluZXMuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKKzxzdHlsZT4KK2RpdiB7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1mYW1pbHk6ICcuTHVjaWRhR3JhbmRlVUknOyB9Cis8L3N0eWxlPgorPGRpdj5Mb3JlbSBp cHN1bSBkb2xvcjwvZGl2PgorPGRpdj5Mb3JlbSBpcHN1bSAgZG9sb3I8L2Rpdj4K