124194 2013-11-12 00:27:17 -0800 Remote Layer Tree: Assertions during layer flushing after replaceSublayer() 2013-11-12 10:53:29 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 949595 0 thorton 2013-11-12 00:27:17 -0800 Two glaring issues with PlatformCALayerRemote::replaceSublayer: 1) It double-removes the old child. 2) It it never sets the superlayer backpointer on the new child. 949596 1 216647 thorton 2013-11-12 00:29:23 -0800 Created attachment 216647 patch 949735 2 thorton 2013-11-12 10:53:29 -0800 http://trac.webkit.org/changeset/159124 216647 2013-11-12 00:29:23 -0800 2013-11-12 06:43:14 -0800 patch assert.diff text/plain 1625 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMWEwZWNlLi4wMWJmMGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMTEtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3RlIExheWVyIFRyZWU6IEFzc2VydGlvbnMgZHVyaW5nIGxheWVyIGZsdXNo aW5nIGFmdGVyIHJlcGxhY2VTdWJsYXllcigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQxOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxh eWVyUmVtb3RlLmNwcDoKKyAgICAgICAgKFBsYXRmb3JtQ0FMYXllclJlbW90ZTo6cmVwbGFjZVN1 YmxheWVyKToKKyAgICAgICAgT25seSByZW1vdmUgdGhlIG9sZCBsYXllciBmcm9tIHRoZSBjaGls ZHJlbiBhcnJheSBvbmNlICh2aWEgcmVtb3ZlRnJvbVN1cGVybGF5ZXIpLgorICAgICAgICBVcGRh dGUgdGhlIHN1cGVybGF5ZXIgYmFja3BvaW50ZXIgb24gdGhlIG5ldyBsYXllci4KKwogMjAxMy0x MS0xMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdGUgTGF5ZXIgVHJlZTogU3BvcmFkaWMgbWVtb3J5IGNvcnJ1cHRpb24gZHVyaW5nIHBhaW50 aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Bs YXRmb3JtQ0FMYXllclJlbW90ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZS5jcHAKaW5kZXggMzJhM2Y1Yi4uODAwNWQwNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9y bUNBTGF5ZXJSZW1vdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcApAQCAtMjMzLDggKzIzMyw4IEBAIHZvaWQg UGxhdGZvcm1DQUxheWVyUmVtb3RlOjpyZXBsYWNlU3VibGF5ZXIoUGxhdGZvcm1DQUxheWVyKiBy ZWZlcmVuY2UsIFBsYXRmb3JtCiAgICAgc2l6ZV90IHJlZmVyZW5jZUluZGV4ID0gbV9jaGlsZHJl bi5maW5kKHJlZmVyZW5jZSk7CiAgICAgaWYgKHJlZmVyZW5jZUluZGV4ICE9IG5vdEZvdW5kKSB7 CiAgICAgICAgIG1fY2hpbGRyZW5bcmVmZXJlbmNlSW5kZXhdLT5yZW1vdmVGcm9tU3VwZXJsYXll cigpOwotICAgICAgICBtX2NoaWxkcmVuLnJlbW92ZShyZWZlcmVuY2VJbmRleCk7CiAgICAgICAg IG1fY2hpbGRyZW4uaW5zZXJ0KHJlZmVyZW5jZUluZGV4LCBsYXllcik7CisgICAgICAgIHRvUGxh dGZvcm1DQUxheWVyUmVtb3RlKGxheWVyKS0+bV9zdXBlcmxheWVyID0gdGhpczsKICAgICB9CiAK ICAgICBtX3Byb3BlcnRpZXMubm90ZVByb3BlcnRpZXNDaGFuZ2VkKFJlbW90ZUxheWVyVHJlZVRy YW5zYWN0aW9uOjpDaGlsZHJlbkNoYW5nZWQpOwo=