124186 2013-11-11 22:26:18 -0800 WTF, JavaScriptCore fails to build with trunk clang: operators new, new[], delete, delete[] cannot be declared inline 2016-08-01 10:42:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.9 REOPENED P2 Normal --- 1 dfarler dbates andersca bburg benjamin buildbot cmarcelo commit-queue dbates ddkilzer ggaren rniwa sam slewis oldest_to_newest 949552 0 dfarler 2013-11-11 22:26:18 -0800 CompileC /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/Objects-normal/x86_64/LLIntOffsetsExtractor.o llint/LLIntOffsetsExtractor.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler cd /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Source/JavaScriptCore /Volumes/Data/BuildSlave/build-asan-webkit/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -O0 -Wno-missing-field-initializers -Wmissing-prototypes -Wnon-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wsign-compare -Wno-shorten-64-to-32 -Wnewline-eof -Wno-c++11-extensions -DHAVE_DTRACE=1 -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -DHAVE_HEADER_DETECTION_H -DJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 -DENABLE_3D_RENDERING -DENABLE_BLOB -DENABLE_CACHE_PARTITIONING -DENABLE_CANVAS_PATH -DENABLE_CHANNEL_MESSAGING -DENABLE_CSS_BOX_DECORATION_BREAK -DENABLE_CSS_COMPOSITING -DENABLE_CSS_EXCLUSIONS -DENABLE_CSS_FILTERS -DENABLE_CSS_REGIONS -DENABLE_CSS_SHADERS -DENABLE_CSS_SHAPES -DENABLE_CSS_STICKY_POSITION -DENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED -DENABLE_CSS3_TEXT_DECORATION -DENABLE_CURSOR_VISIBILITY -DENABLE_DASHBOARD_SUPPORT -DENABLE_DETAILS_ELEMENT -DENABLE_DOM4_EVENTS_CONSTRUCTOR -DENABLE_ENCRYPTED_MEDIA -DENABLE_ENCRYPTED_MEDIA_V2 -DENABLE_FILTERS -DENABLE_FULLSCREEN_API -DENABLE_GEOLOCATION -DENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING -DENABLE_ICONDATABASE -DENABLE_IFRAME_SEAMLESS -DENABLE_INDEXED_DATABASE -DENABLE_INDIE_UI -DENABLE_INPUT_TYPE_COLOR -DENABLE_INPUT_TYPE_COLOR_POPOVER -DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_LEGACY_CSS_VENDOR_PREFIXES -DENABLE_LEGACY_NOTIFICATIONS -DENABLE_LEGACY_VENDOR_PREFIXES -DENABLE_LEGACY_WEB_AUDIO -DENABLE_MATHML -DENABLE_MEDIA_CONTROLS_SCRIPT -DENABLE_METER_ELEMENT -DENABLE_MOUSE_CURSOR_SCALE -DENABLE_NOTIFICATIONS -DENABLE_PAGE_VISIBILITY_API -DENABLE_PDFKIT_PLUGIN -DENABLE_PROGRESS_ELEMENT -DENABLE_PROMISES -DENABLE_PUBLIC_SUFFIX_LIST -DENABLE_REQUEST_ANIMATION_FRAME -DENABLE_REMOTE_INSPECTOR -DENABLE_SHARED_WORKERS -DENABLE_SPEECH_SYNTHESIS -DENABLE_SQL_DATABASE -DENABLE_SUBTLE_CRYPTO -DENABLE_SVG -DENABLE_SVG_FONTS -DENABLE_USERSELECT_ALL -DENABLE_VIDEO -DENABLE_VIDEO_TRACK -DENABLE_WEBGL -DENABLE_WEB_ANIMATIONS -DENABLE_WEB_AUDIO -DENABLE_WEB_SOCKETS -DENABLE_WORKERS -DENABLE_XHR_TIMEOUT -DENABLE_XSLT -isysroot /Volumes/Data/BuildSlave/build-asan-webkit/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.Internal.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.9 -g -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion -I/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/JSCLLIntOffsetsExtractor.hmap -I/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/include -I. -Iicu -I/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include -I/Volumes/Data/BuildSlave/build-asan-webkit/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/DerivedSources/x86_64 -I/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -F/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -MMD -MT dependencies -MF /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/Objects-normal/x86_64/LLIntOffsetsExtractor.d --serialize-diagnostics /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/Objects-normal/x86_64/LLIntOffsetsExtractor.dia -c /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp -o /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JSCLLIntOffsetsExtractor.build/Objects-normal/x86_64/LLIntOffsetsExtractor.o In file included from /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26: In file included from /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Source/JavaScriptCore/config.h:60: /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:266:1: error: replacement function 'operator new' cannot be declared 'inline' WTF_PRIVATE_INLINE void* operator new(size_t size) throw (std::bad_alloc) { return fastMalloc(size); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:267:1: error: replacement function 'operator new' cannot be declared 'inline' WTF_PRIVATE_INLINE void* operator new(size_t size, const std::nothrow_t&) throw() { return fastMalloc(size); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:268:1: error: replacement function 'operator delete' cannot be declared 'inline' WTF_PRIVATE_INLINE void operator delete(void* p) throw() { fastFree(p); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:269:1: error: replacement function 'operator delete' cannot be declared 'inline' WTF_PRIVATE_INLINE void operator delete(void* p, const std::nothrow_t&) throw() { fastFree(p); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:270:1: error: replacement function 'operator new[]' cannot be declared 'inline' WTF_PRIVATE_INLINE void* operator new[](size_t size) throw (std::bad_alloc) { return fastMalloc(size); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:271:1: error: replacement function 'operator new[]' cannot be declared 'inline' WTF_PRIVATE_INLINE void* operator new[](size_t size, const std::nothrow_t&) throw() { return fastMalloc(size); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:272:1: error: replacement function 'operator delete[]' cannot be declared 'inline' WTF_PRIVATE_INLINE void operator delete[](void* p) throw() { fastFree(p); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:273:1: error: replacement function 'operator delete[]' cannot be declared 'inline' WTF_PRIVATE_INLINE void operator delete[](void* p, const std::nothrow_t&) throw() { fastFree(p); } ^ /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/FastMalloc.h:242:47: note: expanded from macro 'WTF_PRIVATE_INLINE' #define WTF_PRIVATE_INLINE __private_extern__ inline __attribute__((always_inline)) ^ 8 errors generated. 949662 1 andersca 2013-11-12 07:13:02 -0800 Yup. What we do is violating the C++ spec :( 949753 2 ggaren 2013-11-12 11:23:25 -0800 Will these overrides still work if we declare them out-of-line? NOTE: In the short term, un-inlining these functions will cause us to crash on launch, due to bugs in other components, which are masked by our current strategy. Stephanie knows the details. 949757 3 andersca 2013-11-12 11:30:03 -0800 (In reply to comment #2) > Will these overrides still work if we declare them out-of-line? If we declare them out of line they will replace the global operators everywhere. > NOTE: In the short term, un-inlining these functions will cause us to crash on launch, due to bugs in other components, which are masked by our current strategy. Stephanie knows the details. I’d love to hear the details. Stephanie? 949861 4 dfarler 2013-11-12 13:51:32 -0800 ddkilzer mentioned that this file isn't building with USE_SYSTEM_MALLOC=1. The reason for that is that this particular target doesn't build with ASAN since it's an intermediate tool for building. I'm going to try building with USE_SYSTEM_MALLOC=1 at least for all targets regardless of building with ASAN and see if I can work around this. 950709 5 dfarler 2013-11-14 09:21:15 -0800 I’ll be able to work around this for now with https://bugs.webkit.org/show_bug.cgi?id=124362 but anything using FastMalloc will run into this problem. 960989 6 dbates 2013-12-18 10:32:43 -0800 I ran into this issue when building WTF with trunk clang as of 12/16/2013. 960991 7 219547 dbates 2013-12-18 10:37:13 -0800 Created attachment 219547 Workaround 960993 8 219547 dbates 2013-12-18 10:38:35 -0800 Comment on attachment 219547 Workaround As a workaround, disable the inline new, delete warnings. Ideally, we should fix our violation of the C++ standard. 960994 9 dbates 2013-12-18 10:40:51 -0800 For completeness, the LLVM warnings were implemented in <http://llvm.org/bugs/show_bug.cgi?id=17591>. 960995 10 219548 dbates 2013-12-18 10:42:45 -0800 Created attachment 219548 Workaround 960996 11 219547 ggaren 2013-12-18 10:44:10 -0800 Comment on attachment 219547 Workaround r=me Do we need a follow-up bug to figure out what we should do instead? Do we know what we should do instead? What are the consequences of continuing to inline new/delete, even though C++ says we can't? 961000 12 dfarler 2013-12-18 10:46:58 -0800 (In reply to comment #11) > (From update of attachment 219547 [details]) > r=me > > Do we need a follow-up bug to figure out what we should do instead? Do we know what we should do instead? > > What are the consequences of continuing to inline new/delete, even though C++ says we can't? I believe it has to do with the number of matching compiled allocation / freeing of memory with optimizations. There is an example in the bugzilla: http://llvm.org/bugs/show_bug.cgi?id=17591 961013 13 dbates 2013-12-18 11:16:35 -0800 (In reply to comment #11) > (From update of attachment 219547 [details]) > r=me > > Do we need a follow-up bug to figure out what we should do instead? Unless you prefer a new bug, I'll keep this bug open after I land the patch so that we can use it to follow up on this issue. Notice that I reference this bug in the FIXME comment in the patch. > Do we know what we should do instead? At this time, I don't have a good solution. From talking with Anders Carlson, one solution is to sprinkle more WTF_MAKE_FAST_ALLOCATED in the code. Alternatively, we can un-inline the operator new, delete functions assuming we resolve the issues you mentioned in your note in comment 2. 961015 14 219548 buildbot 2013-12-18 11:18:04 -0800 Comment on attachment 219548 Workaround Attachment 219548 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/50548030 961023 15 219553 dbates 2013-12-18 11:28:23 -0800 Created attachment 219553 For EWS: Workaround 961413 16 dbates 2013-12-19 09:46:50 -0800 Committed r160838: <http://trac.webkit.org/changeset/160838> 962265 17 dbates 2013-12-21 12:42:13 -0800 Re-opening this bug so that we can follow up with the appropriate fix. Let me know if it's preferred to file a new bug. 980256 18 219548 ossy 2014-02-13 04:15:14 -0800 Comment on attachment 219548 Workaround Cleared Geoffrey Garen's review+ from obsolete attachment 219548 so that this bug does not appear in http://webkit.org/pending-commit. 1216147 19 bburg 2016-08-01 10:42:48 -0700 Is this bug still relevant? If so, please fix the title. 219547 2013-12-18 10:37:13 -0800 2013-12-18 10:44:10 -0800 Workaround bug-124186-20131218103713.patch text/plain 2380 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNhNTQzNTEwMzVjOWYwN2U1YTcxY2M1 ZjhhZDZiNmQ1NGRjMGM3ZGUuLjI1NGU2Mzg1NDdmMjUxNDc3NjU1Mzk4NDk3YzkxMjk2YjlkMWYz ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMTItMTggIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFdURiwgSmF2YVNjcmlwdENvcmUgZmFpbHMgdG8gYnVp bGQgd2l0aCB0cnVuayBjbGFuZzogb3BlcmF0b3JzIG5ldywgbmV3W10sCisgICAgICAgIGRlbGV0 ZSwgZGVsZXRlW10gY2Fubm90IGJlIGRlY2xhcmVkIGlubGluZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTg2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9sbG93aW5nIDxodHRwOi8vbGx2bS5vcmcv dmlld3ZjL2xsdm0tcHJvamVjdD92aWV3PXJldmlzaW9uJnJldmlzaW9uPTE5MzA0ND4KKyAgICAg ICAgKGh0dHA6Ly9sbHZtLm9yZy9idWdzL3Nob3dfYnVnLmNnaT9pZD0xNzU5MT4pLCBDbGFuZyBl bWl0cyB3YXJuaW5ncyB3aGVuCisgICAgICAgIG9wZXJhdG9yIG5ldywgZGVsZXRlIGFyZSBpbmxp bmVkLiBTdWNoIGRlZmluaXRpb25zIGNhbm5vdCBiZSBpbmxpbmUgcGVyCisgICAgICAgIHJlcGxh Y2VtZW50LmZ1bmN0aW9ucyAoMTcuNi40LjYvMykgb2YgdGhlIEMrKyBzdGFuZGFyZC4gRm9yIG5v dywKKyAgICAgICAgZGlzYWJsZSB0aGVzZSB3YXJuaW5ncyBpbnN0ZWFkIG9mIGV4cG9ydGluZyB0 aGVzZSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5oOgorCiAyMDEzLTEy LTE2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBV cHN0cmVhbSBXZWJDb3JlL2h0bWwgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv RmFzdE1hbGxvYy5oIGIvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5oCmluZGV4IGJkMTY5YzU0 Zjk4YzBhZWY4NTkyY2ZjNjA5NjM4Y2Y1MzBkYTJlZWUuLmJkMTE3YWE3YTQxZTY2NjU3OGIwNTBk NTA5NTA1OTEwOTJiOTVlN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2Mu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmgKQEAgLTI2Miw2ICsyNjIsMTEgQEAg dXNpbmcgV1RGOjpmYXN0TWFsbG9jQWxsb3c7CiAjaWYgQ09NUElMRVIoTVNWQykKICNwcmFnbWEg d2FybmluZyhwdXNoKQogI3ByYWdtYSB3YXJuaW5nKGRpc2FibGU6IDQyOTApIC8vIERpc2FibGUg dGhlIEMrKyBleGNlcHRpb24gc3BlY2lmaWNhdGlvbiBpZ25vcmVkIHdhcm5pbmcuCisjZWxpZiBD T01QSUxFUihDTEFORykKKy8vIEZJWE1FOiBUaGUgb3BlcmF0b3IgbmV3LCBkZWxldGUgZGVmaW5p dGlvbnMgY2Fubm90IGJlIGlubGluZSBwZXIgcmVwbGFjZW1lbnQuZnVuY3Rpb25zICgxNy42LjQu Ni8zKSBvZiB0aGUgQysrCisvLyBzdGFuZGFyZCAoc2VlIDxodHRwOi8vbGx2bS5vcmcvYnVncy9z aG93X2J1Zy5jZ2k/aWQ9MTc1OTE+KS4gQXMgYSB3b3JrYXJvdW5kLCBkaXNhYmxlIHdhcm5pbmdz IGZvciBzdWNoIHVzYWdlLgorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEg Y2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2lubGluZS1uZXctZGVsZXRlIgogI2VuZGlmCiBX VEZfUFJJVkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3KHNpemVfdCBzaXplKSB0aHJvdyAo c3RkOjpiYWRfYWxsb2MpIHsgcmV0dXJuIGZhc3RNYWxsb2Moc2l6ZSk7IH0KIFdURl9QUklWQVRF X0lOTElORSB2b2lkKiBvcGVyYXRvciBuZXcoc2l6ZV90IHNpemUsIGNvbnN0IHN0ZDo6bm90aHJv d190JikgdGhyb3coKSB7IHJldHVybiBmYXN0TWFsbG9jKHNpemUpOyB9CkBAIC0yNzMsNiArMjc4 LDggQEAgV1RGX1BSSVZBVEVfSU5MSU5FIHZvaWQgb3BlcmF0b3IgZGVsZXRlW10odm9pZCogcCkg dGhyb3coKSB7IGZhc3RGcmVlKHApOyB9CiBXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCBvcGVyYXRv ciBkZWxldGVbXSh2b2lkKiBwLCBjb25zdCBzdGQ6Om5vdGhyb3dfdCYpIHRocm93KCkgeyBmYXN0 RnJlZShwKTsgfQogI2lmIENPTVBJTEVSKE1TVkMpCiAjcHJhZ21hIHdhcm5pbmcocG9wKQorI2Vs aWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCiAjZW5kaWYK IAogI2VuZGlmIC8vIEVOQUJMRShHTE9CQUxfRkFTVE1BTExPQ19ORVcpCg== 219548 2013-12-18 10:42:45 -0800 2014-02-13 04:15:11 -0800 Workaround bug-124186-20131218104245.patch text/plain 2383 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNhNTQzNTEwMzVjOWYwN2U1YTcxY2M1 ZjhhZDZiNmQ1NGRjMGM3ZGUuLjI1NGU2Mzg1NDdmMjUxNDc3NjU1Mzk4NDk3YzkxMjk2YjlkMWYz ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMTItMTggIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFdURiwgSmF2YVNjcmlwdENvcmUgZmFpbHMgdG8gYnVp bGQgd2l0aCB0cnVuayBjbGFuZzogb3BlcmF0b3JzIG5ldywgbmV3W10sCisgICAgICAgIGRlbGV0 ZSwgZGVsZXRlW10gY2Fubm90IGJlIGRlY2xhcmVkIGlubGluZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTg2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9sbG93aW5nIDxodHRwOi8vbGx2bS5vcmcv dmlld3ZjL2xsdm0tcHJvamVjdD92aWV3PXJldmlzaW9uJnJldmlzaW9uPTE5MzA0ND4KKyAgICAg ICAgKGh0dHA6Ly9sbHZtLm9yZy9idWdzL3Nob3dfYnVnLmNnaT9pZD0xNzU5MT4pLCBDbGFuZyBl bWl0cyB3YXJuaW5ncyB3aGVuCisgICAgICAgIG9wZXJhdG9yIG5ldywgZGVsZXRlIGFyZSBpbmxp bmVkLiBTdWNoIGRlZmluaXRpb25zIGNhbm5vdCBiZSBpbmxpbmUgcGVyCisgICAgICAgIHJlcGxh Y2VtZW50LmZ1bmN0aW9ucyAoMTcuNi40LjYvMykgb2YgdGhlIEMrKyBzdGFuZGFyZC4gRm9yIG5v dywKKyAgICAgICAgZGlzYWJsZSB0aGVzZSB3YXJuaW5ncyBpbnN0ZWFkIG9mIGV4cG9ydGluZyB0 aGVzZSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5oOgorCiAyMDEzLTEy LTE2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBV cHN0cmVhbSBXZWJDb3JlL2h0bWwgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv RmFzdE1hbGxvYy5oIGIvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5oCmluZGV4IGJkMTY5YzU0 Zjk4YzBhZWY4NTkyY2ZjNjA5NjM4Y2Y1MzBkYTJlZWUuLmM3ZGE1MTc4OWM4MWQxN2YzY2IxODM5 Y2M0M2ZjNGMwYWZhYjBlZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2Mu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmgKQEAgLTI2Miw2ICsyNjIsMTEgQEAg dXNpbmcgV1RGOjpmYXN0TWFsbG9jQWxsb3c7CiAjaWYgQ09NUElMRVIoTVNWQykKICNwcmFnbWEg d2FybmluZyhwdXNoKQogI3ByYWdtYSB3YXJuaW5nKGRpc2FibGU6IDQyOTApIC8vIERpc2FibGUg dGhlIEMrKyBleGNlcHRpb24gc3BlY2lmaWNhdGlvbiBpZ25vcmVkIHdhcm5pbmcuCisjZWxpZiBD T01QSUxFUihDTEFORykKKy8vIEZJWE1FOiBUaGUgb3BlcmF0b3IgbmV3LCBkZWxldGUgZGVmaW5p dGlvbnMgY2Fubm90IGJlIGlubGluZSBwZXIgcmVwbGFjZW1lbnQuZnVuY3Rpb25zICgxNy42LjQu Ni8zKSBvZiB0aGUgQysrCisvLyBzdGFuZGFyZC4gQXMgYSB3b3JrYXJvdW5kLCBkaXNhYmxlIHdh cm5pbmdzIGZvciBzdWNoIHVzYWdlLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjQxODY+LgorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFn bWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2lubGluZS1uZXctZGVsZXRlIgogI2VuZGlm CiBXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCogb3BlcmF0b3IgbmV3KHNpemVfdCBzaXplKSB0aHJv dyAoc3RkOjpiYWRfYWxsb2MpIHsgcmV0dXJuIGZhc3RNYWxsb2Moc2l6ZSk7IH0KIFdURl9QUklW QVRFX0lOTElORSB2b2lkKiBvcGVyYXRvciBuZXcoc2l6ZV90IHNpemUsIGNvbnN0IHN0ZDo6bm90 aHJvd190JikgdGhyb3coKSB7IHJldHVybiBmYXN0TWFsbG9jKHNpemUpOyB9CkBAIC0yNzMsNiAr Mjc4LDggQEAgV1RGX1BSSVZBVEVfSU5MSU5FIHZvaWQgb3BlcmF0b3IgZGVsZXRlW10odm9pZCog cCkgdGhyb3coKSB7IGZhc3RGcmVlKHApOyB9CiBXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCBvcGVy YXRvciBkZWxldGVbXSh2b2lkKiBwLCBjb25zdCBzdGQ6Om5vdGhyb3dfdCYpIHRocm93KCkgeyBm YXN0RnJlZShwKTsgfQogI2lmIENPTVBJTEVSKE1TVkMpCiAjcHJhZ21hIHdhcm5pbmcocG9wKQor I2VsaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCiAjZW5k aWYKIAogI2VuZGlmIC8vIEVOQUJMRShHTE9CQUxfRkFTVE1BTExPQ19ORVcpCg== 219553 2013-12-18 11:28:23 -0800 2013-12-18 11:28:23 -0800 For EWS: Workaround Bug124186EWSOnly.patch text/plain 3322 dbates RnJvbSAwOTM5YTk0N2UwNDM4OWI0YzgwYjU4NWEyZWFhOGFhZmJmZDlhZjM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl OiBXZWQsIDE4IERlYyAyMDEzIDExOjI3OjI5IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gV1RGLCBK YXZhU2NyaXB0Q29yZSBmYWlscyB0byBidWlsZCB3aXRoIHRydW5rIGNsYW5nOgogb3BlcmF0b3Jz IG5ldywgbmV3W10sIGRlbGV0ZSwgZGVsZXRlW10gY2Fubm90IGJlIGRlY2xhcmVkIGlubGluZQog aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE4NiA8cmRhcjovL3By b2JsZW0vMTU2NDQwMzk+CgpSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbiBhbmQgQW5kZXJzIENh cmxzc29uLgoKRm9sbG93aW5nIDxodHRwOi8vbGx2bS5vcmcvdmlld3ZjL2xsdm0tcHJvamVjdD92 aWV3PXJldmlzaW9uJnJldmlzaW9uPTE5MzA0ND4KKGh0dHA6Ly9sbHZtLm9yZy9idWdzL3Nob3df YnVnLmNnaT9pZD0xNzU5MT4pLCBDbGFuZyBlbWl0cyB3YXJuaW5ncyB3aGVuCm9wZXJhdG9yIG5l dywgZGVsZXRlIGFyZSBpbmxpbmVkLiBTdWNoIGRlZmluaXRpb25zIGNhbm5vdCBiZSBpbmxpbmUg cGVyCnJlcGxhY2VtZW50LmZ1bmN0aW9ucyAoMTcuNi40LjYvMykgb2YgdGhlIEMrKyBzdGFuZGFy ZC4gRm9yIG5vdywKZGlzYWJsZSB0aGVzZSB3YXJuaW5ncyBpbnN0ZWFkIG9mIGV4cG9ydGluZyB0 aGVzZSBmdW5jdGlvbnMuCgoqIHd0Zi9GYXN0TWFsbG9jLmg6Ci0tLQogU291cmNlL1dURi9DaGFu Z2VMb2cgICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XVEYvd3RmL0Zhc3RN YWxsb2MuaCB8ICA5ICsrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxv ZwppbmRleCAzYTU0MzUxLi5mNWI4OWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEyLTE4 ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBXVEYsIEphdmFT Y3JpcHRDb3JlIGZhaWxzIHRvIGJ1aWxkIHdpdGggdHJ1bmsgY2xhbmc6IG9wZXJhdG9ycyBuZXcs IG5ld1tdLAorICAgICAgICBkZWxldGUsIGRlbGV0ZVtdIGNhbm5vdCBiZSBkZWNsYXJlZCBpbmxp bmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE4 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU2NDQwMzk+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgR2VvZmZyZXkgR2FyZW4gYW5kIEFuZGVycyBDYXJsc3Nvbi4KKworICAgICAgICBGb2xsb3dp bmcgPGh0dHA6Ly9sbHZtLm9yZy92aWV3dmMvbGx2bS1wcm9qZWN0P3ZpZXc9cmV2aXNpb24mcmV2 aXNpb249MTkzMDQ0PgorICAgICAgICAoaHR0cDovL2xsdm0ub3JnL2J1Z3Mvc2hvd19idWcuY2dp P2lkPTE3NTkxPiksIENsYW5nIGVtaXRzIHdhcm5pbmdzIHdoZW4KKyAgICAgICAgb3BlcmF0b3Ig bmV3LCBkZWxldGUgYXJlIGlubGluZWQuIFN1Y2ggZGVmaW5pdGlvbnMgY2Fubm90IGJlIGlubGlu ZSBwZXIKKyAgICAgICAgcmVwbGFjZW1lbnQuZnVuY3Rpb25zICgxNy42LjQuNi8zKSBvZiB0aGUg QysrIHN0YW5kYXJkLiBGb3Igbm93LAorICAgICAgICBkaXNhYmxlIHRoZXNlIHdhcm5pbmdzIGlu c3RlYWQgb2YgZXhwb3J0aW5nIHRoZXNlIGZ1bmN0aW9ucy4KKworICAgICAgICAqIHd0Zi9GYXN0 TWFsbG9jLmg6CisKIDIwMTMtMTItMTYgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIFVwc3RyZWFtIFdlYkNvcmUvaHRtbCBjaGFuZ2VzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmggYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFs bG9jLmgKaW5kZXggYmQxNjljNS4uNDRiZjhkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv RmFzdE1hbGxvYy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuaApAQCAtMjYyLDYg KzI2MiwxMyBAQCB1c2luZyBXVEY6OmZhc3RNYWxsb2NBbGxvdzsKICNpZiBDT01QSUxFUihNU1ZD KQogI3ByYWdtYSB3YXJuaW5nKHB1c2gpCiAjcHJhZ21hIHdhcm5pbmcoZGlzYWJsZTogNDI5MCkg Ly8gRGlzYWJsZSB0aGUgQysrIGV4Y2VwdGlvbiBzcGVjaWZpY2F0aW9uIGlnbm9yZWQgd2Fybmlu Zy4KKyNlbGlmIENPTVBJTEVSKENMQU5HKSAmJiBkZWZpbmVkKF9faGFzX3dhcm5pbmcpCisvLyBG SVhNRTogVGhlIG9wZXJhdG9yIG5ldywgZGVsZXRlIGRlZmluaXRpb25zIGNhbm5vdCBiZSBpbmxp bmUgcGVyIHJlcGxhY2VtZW50LmZ1bmN0aW9ucyAoMTcuNi40LjYvMykgb2YgdGhlIEMrKworLy8g c3RhbmRhcmQuIEFzIGEgd29ya2Fyb3VuZCwgZGlzYWJsZSB3YXJuaW5ncyBmb3Igc3VjaCB1c2Fn ZS4gU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTg2Pi4K KyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjaWYgX19oYXNfd2FybmluZygiLVdpbmxp bmUtbmV3LWRlbGV0ZSIpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdpbmxp bmUtbmV3LWRlbGV0ZSIKKyNlbmRpZgogI2VuZGlmCiBXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCog b3BlcmF0b3IgbmV3KHNpemVfdCBzaXplKSB0aHJvdyAoc3RkOjpiYWRfYWxsb2MpIHsgcmV0dXJu IGZhc3RNYWxsb2Moc2l6ZSk7IH0KIFdURl9QUklWQVRFX0lOTElORSB2b2lkKiBvcGVyYXRvciBu ZXcoc2l6ZV90IHNpemUsIGNvbnN0IHN0ZDo6bm90aHJvd190JikgdGhyb3coKSB7IHJldHVybiBm YXN0TWFsbG9jKHNpemUpOyB9CkBAIC0yNzMsNiArMjgwLDggQEAgV1RGX1BSSVZBVEVfSU5MSU5F IHZvaWQgb3BlcmF0b3IgZGVsZXRlW10odm9pZCogcCkgdGhyb3coKSB7IGZhc3RGcmVlKHApOyB9 CiBXVEZfUFJJVkFURV9JTkxJTkUgdm9pZCBvcGVyYXRvciBkZWxldGVbXSh2b2lkKiBwLCBjb25z dCBzdGQ6Om5vdGhyb3dfdCYpIHRocm93KCkgeyBmYXN0RnJlZShwKTsgfQogI2lmIENPTVBJTEVS KE1TVkMpCiAjcHJhZ21hIHdhcm5pbmcocG9wKQorI2VsaWYgQ09NUElMRVIoQ0xBTkcpICYmIGRl ZmluZWQoX19oYXNfd2FybmluZykKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKICNlbmRp ZgogCiAjZW5kaWYgLy8gRU5BQkxFKEdMT0JBTF9GQVNUTUFMTE9DX05FVykKLS0gCjEuOC4zLjQg KEFwcGxlIEdpdC00NykKCg==