124179 2013-11-11 19:49:28 -0800 Web Inspector: Remove some unused generated code 2013-11-11 20:37:54 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 949522 0 joepeck 2013-11-11 19:49:28 -0800 • InspectorBackendDispatcher::getCommandName is not used. • InspectorFrontend::Foo classes never modify their InspectorFrontendChannel, so the getter/setter and null checks are unnecessary. Make m_inspectorFrontendChannel protected to avoid unused warning. This base class will go away. This is just some prep for generating separate InspectorBackendDispatchers / InspectorFrontendDispatchers per domain. Start by removing some of the dead code not being converted / carried over. 949523 1 webkit-bug-importer 2013-11-11 19:49:52 -0800 <rdar://problem/15444748> 949524 2 216629 joepeck 2013-11-11 19:51:18 -0800 Created attachment 216629 [PATCH] Proposed Fix 949532 3 216629 commit-queue 2013-11-11 20:37:52 -0800 Comment on attachment 216629 [PATCH] Proposed Fix Clearing flags on attachment: 216629 Committed r159093: <http://trac.webkit.org/changeset/159093> 949533 4 commit-queue 2013-11-11 20:37:54 -0800 All reviewed patches have been landed. Closing bug. 216629 2013-11-11 19:51:18 -0800 2013-11-11 20:37:52 -0800 [PATCH] Proposed Fix rmgen.patch text/plain 3404 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYjNmMGJmLi4xYmQ5NGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTMtMTEtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc29tZSB1bnVzZWQgZ2VuZXJhdGVkIGNvZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE3OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVj dG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3JTdHJpbmdzLnB5OgorCisyMDEzLTExLTExICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogU3BsaXQgSW5zcGVjdG9yLmpzb24gaW50byBpbmRpdmlkdWFsIGRvbWFpbiBqc29uIGZpbGVz CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQwOTgK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3JTdHJpbmdzLnB5IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJ bnNwZWN0b3JTdHJpbmdzLnB5CmluZGV4IDI5NWZkNmIuLmVkOGVlYzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yU3RyaW5ncy5weQor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3RvclN0cmlu Z3MucHkKQEAgLTMzLDkgKzMzLDggQEAgZnJvbnRlbmRfZG9tYWluX2NsYXNzID0gKAogIiIiICAg IGNsYXNzICRkb21haW5DbGFzc05hbWUgewogICAgIHB1YmxpYzoKICAgICAgICAgJGRvbWFpbkNs YXNzTmFtZShJbnNwZWN0b3JGcm9udGVuZENoYW5uZWwqIGluc3BlY3RvckZyb250ZW5kQ2hhbm5l bCkgOiBtX2luc3BlY3RvckZyb250ZW5kQ2hhbm5lbChpbnNwZWN0b3JGcm9udGVuZENoYW5uZWwp IHsgfQotJHtmcm9udGVuZERvbWFpbk1ldGhvZERlY2xhcmF0aW9uc30gICAgICAgIHZvaWQgc2V0 SW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKEluc3BlY3RvckZyb250ZW5kQ2hhbm5lbCogaW5zcGVj dG9yRnJvbnRlbmRDaGFubmVsKSB7IG1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsID0gaW5zcGVj dG9yRnJvbnRlbmRDaGFubmVsOyB9Ci0gICAgICAgIEluc3BlY3RvckZyb250ZW5kQ2hhbm5lbCog Z2V0SW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKCkgeyByZXR1cm4gbV9pbnNwZWN0b3JGcm9udGVu ZENoYW5uZWw7IH0KLSAgICBwcml2YXRlOgorJHtmcm9udGVuZERvbWFpbk1ldGhvZERlY2xhcmF0 aW9uc30KKyAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIEluc3BlY3RvckZyb250ZW5kQ2hhbm5lbCog bV9pbnNwZWN0b3JGcm9udGVuZENoYW5uZWw7CiAgICAgfTsKIApAQCAtNjcsOCArNjYsOCBAQCBm cm9udGVuZF9tZXRob2QgPSAoIiIidm9pZCBJbnNwZWN0b3JGcm9udGVuZDo6JGRvbWFpbk5hbWU6 OiRldmVudE5hbWUoJHBhcmFtZXRlcgogewogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGpz b25NZXNzYWdlID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUoKTsKICAgICBqc29uTWVzc2FnZS0+ c2V0U3RyaW5nKCJtZXRob2QiLCAiJGRvbWFpbk5hbWUuJGV2ZW50TmFtZSIpOwotJGNvZGUgICAg aWYgKG1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKQotICAgICAgICBtX2luc3BlY3RvckZyb250 ZW5kQ2hhbm5lbC0+c2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGpzb25NZXNzYWdlLT50b0pTT05TdHJp bmcoKSk7CiskY29kZQorICAgIG1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsLT5zZW5kTWVzc2Fn ZVRvRnJvbnRlbmQoanNvbk1lc3NhZ2UtPnRvSlNPTlN0cmluZygpKTsKIH0KICIiIikKIApAQCAt MTgyLDcgKzE4MSw2IEBAICR2aXJ0dWFsU2V0dGVycwogICAgIHZvaWQgcmVwb3J0UHJvdG9jb2xF cnJvcihjb25zdCBsb25nKiBjb25zdCBjYWxsSWQsIENvbW1vbkVycm9yQ29kZSwgY29uc3QgU3Ry aW5nJiBlcnJvck1lc3NhZ2UpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCByZXBvcnRQcm90b2Nv bEVycm9yKGNvbnN0IGxvbmcqIGNvbnN0IGNhbGxJZCwgQ29tbW9uRXJyb3JDb2RlLCBjb25zdCBT dHJpbmcmIGVycm9yTWVzc2FnZSwgUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gZGF0YSkgY29u c3QgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaChjb25zdCBTdHJpbmcmIG1lc3NhZ2Up ID0gMDsKLSAgICBzdGF0aWMgYm9vbCBnZXRDb21tYW5kTmFtZShjb25zdCBTdHJpbmcmIG1lc3Nh Z2UsIFN0cmluZyogcmVzdWx0KTsKIAogICAgIGVudW0gTWV0aG9kTmFtZXMgewogJG1ldGhvZE5h bWVzRW51bUNvbnRlbnQKQEAgLTQ2MCwyMiArNDU4LDYgQEAgUGFzc1JlZlB0cjxJbnNwZWN0b3JB cnJheT4gSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXJJbXBsOjpnZXRBcnJheShJbnNwZWN0b3JP YmoKICAgICByZXR1cm4gZ2V0UHJvcGVydHlWYWx1ZUltcGw8UGFzc1JlZlB0cjxJbnNwZWN0b3JB cnJheT4sIFJlZlB0cjxJbnNwZWN0b3JBcnJheT4sIEluc3BlY3RvckFycmF5Kj4ob2JqZWN0LCBu YW1lLCB2YWx1ZUZvdW5kLCBwcm90b2NvbEVycm9ycywgMCwgQXNNZXRob2RCcmlkZ2VzOjphc0Fy cmF5LCAiQXJyYXkiKTsKIH0KIAotYm9vbCBJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlcjo6Z2V0 Q29tbWFuZE5hbWUoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBTdHJpbmcqIHJlc3VsdCkKLXsKLSAg ICBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+IHZhbHVlID0gSW5zcGVjdG9yVmFsdWU6OnBhcnNlSlNP TihtZXNzYWdlKTsKLSAgICBpZiAoIXZhbHVlKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg ICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBvYmplY3QgPSB2YWx1ZS0+YXNPYmplY3QoKTsKLSAg ICBpZiAoIW9iamVjdCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKCFvYmplY3Qt PmdldFN0cmluZygibWV0aG9kIiwgcmVzdWx0KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0g ICAgcmV0dXJuIHRydWU7Ci19Ci0KIEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyOjpDYWxsYmFj a0Jhc2U6OkNhbGxiYWNrQmFzZShQYXNzUmVmUHRyPEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVy SW1wbD4gYmFja2VuZEltcGwsIGludCBpZCkKICAgICA6IG1fYmFja2VuZEltcGwoYmFja2VuZElt cGwpLCBtX2lkKGlkKSwgbV9hbHJlYWR5U2VudChmYWxzZSkge30KIAo=