124174 2013-11-11 17:02:00 -0800 Remove unused Qt cruft 2014-02-06 07:57:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124182 124187 1 andersca andersca commit-queue gyuyoung.kim ossy thorton oldest_to_newest 949495 0 andersca 2013-11-11 17:02:00 -0800 Remove unused Qt cruft 949501 1 216625 andersca 2013-11-11 17:10:27 -0800 Created attachment 216625 Patch 949503 2 andersca 2013-11-11 17:15:32 -0800 Committed r159088: <http://trac.webkit.org/changeset/159088> 949540 3 ossy 2013-11-11 22:01:24 -0800 (In reply to comment #2) > Committed r159088: <http://trac.webkit.org/changeset/159088> It seems it isn't Qt and isn't cruft, because it broke the EFL build: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp: In member function 'virtual void WebKit::WebView::processDidCrash()': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:354:46: error: 'class WebKit::WebPageProxy' has no member named 'urlAtProcessExit' 949541 4 ossy 2013-11-11 22:07:47 -0800 Do you think if we can revert this change or should EFL drop the code display a warning which page the WebProcess crashed on? 949547 5 gyuyoung.kim 2013-11-11 22:19:17 -0800 (In reply to comment #4) > Do you think if we can revert this change or should EFL drop > the code display a warning which page the WebProcess crashed on? Ryuan file a Bug 124182 to drop to report a url which page came to crash. But, it seems to me that it is more helpful to report crashed url. Anders, could you let me know why urlAtProcessExit() is cruft ? Because GTK port has a build break as well. 949555 6 commit-queue 2013-11-11 22:35:31 -0800 Re-opened since this is blocked by bug 124187 949588 7 ossy 2013-11-12 00:12:10 -0800 Leave it open until we get the answer if removing this code was only a mistake or intentional. 216625 2013-11-11 17:10:27 -0800 2013-11-12 00:08:56 -0800 Patch bug-124174-20131111171026.patch text/plain 2967 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDEzMzFkOWQwMmI4NTY4 ZTE4NzkyYzNmMjJlMjlkMWI3N2Q5OThhMi4uY2JmM2RjYWRmODg5YWRlYzU2Y2QyZDNkM2I5ZmQ4 ZTg4OWE5YzY5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTExLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBRdCBjcnVmdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI0MTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjpXZWJQYWdlUHJveHkpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnJl c2V0U3RhdGVBZnRlclByb2Nlc3NFeGl0ZWQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdl UHJveHkuaDoKKworMjAxMy0xMS0xMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTg5MjcpOiBjdXJseS1icmFjZXMtZXNjYXBp bmcuaHRtbCBpcyBicm9rZW4gb24gTWFjIFdlYktpdDIKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE2NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGJjMWE5ODFlNjgyNTk3OTg5NTY3MjkyZTFiODExMWQ4 NTBjNTY3ZWUuLmU2MDA4NTA4YWRkZjJlYTZhNzgyNWU2MGM0ZGZlYzg2NDA5M2UyNzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0yMzgsNyArMjM4LDYg QEAgV2ViUGFnZVByb3h5OjpXZWJQYWdlUHJveHkoUGFnZUNsaWVudCogcGFnZUNsaWVudCwgUGFz c1JlZlB0cjxXZWJQcm9jZXNzUHJveHk+IHAKICAgICAsIG1fZXN0aW1hdGVkUHJvZ3Jlc3MoMCkK ICAgICAsIG1fdmlld1N0YXRlKFZpZXdTdGF0ZTo6Tm9GbGFncykKICAgICAsIG1fYmFja0Zvcndh cmRMaXN0KFdlYkJhY2tGb3J3YXJkTGlzdDo6Y3JlYXRlKHRoaXMpKQotICAgICwgbV9sb2FkU3Rh dGVBdFByb2Nlc3NFeGl0KEZyYW1lTG9hZFN0YXRlOjpMb2FkU3RhdGVGaW5pc2hlZCkKICAgICAs IG1fdGVtcG9yYXJpbHlDbG9zZWRDb21wb3NpdGlvbihmYWxzZSkKICAgICAsIG1fdGV4dFpvb21G YWN0b3IoMSkKICAgICAsIG1fcGFnZVpvb21GYWN0b3IoMSkKQEAgLTM3ODYsMTEgKzM3ODUsNiBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6cmVzZXRTdGF0ZUFmdGVyUHJvY2Vzc0V4aXRlZCgpCiAgICAg bV9pc1BhZ2VTdXNwZW5kZWQgPSBmYWxzZTsKICAgICBtX3dhaXRpbmdGb3JEaWRVcGRhdGVWaWV3 U3RhdGUgPSBmYWxzZTsKIAotICAgIGlmIChtX21haW5GcmFtZSkgewotICAgICAgICBtX3VybEF0 UHJvY2Vzc0V4aXQgPSBtX21haW5GcmFtZS0+dXJsKCk7Ci0gICAgICAgIG1fbG9hZFN0YXRlQXRQ cm9jZXNzRXhpdCA9IG1fbWFpbkZyYW1lLT5sb2FkU3RhdGUoKTsKLSAgICB9Ci0KICAgICByZXNl dFN0YXRlKCk7CiAKICAgICBtX3BhZ2VDbGllbnQtPmNsZWFyQWxsRWRpdENvbW1hbmRzKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmggYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggN2FmMTQ3MjQwOTQyNjgz MGU2MDJlZTQ5MzQ3MzQ4NmE1ZWNhZTc4YS4uNGI1OGZiZjI3MDgxYmVkMjI1MTkyOGRkMjJkZDJi OTczNzRjNmFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApAQCAt NjA5LDkgKzYwOSw2IEBAIHB1YmxpYzoKIAogICAgIFBhc3NSZWZQdHI8SW1tdXRhYmxlQXJyYXk+ IHJlbGF0ZWRQYWdlcygpIGNvbnN0OwogCi0gICAgY29uc3QgU3RyaW5nJiB1cmxBdFByb2Nlc3NF eGl0KCkgY29uc3QgeyByZXR1cm4gbV91cmxBdFByb2Nlc3NFeGl0OyB9Ci0gICAgRnJhbWVMb2Fk U3RhdGU6OkxvYWRTdGF0ZSBsb2FkU3RhdGVBdFByb2Nlc3NFeGl0KCkgY29uc3QgeyByZXR1cm4g bV9sb2FkU3RhdGVBdFByb2Nlc3NFeGl0OyB9Ci0KICNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQog ICAgIFdlYkNvcmU6OkRyYWdTZXNzaW9uIGRyYWdTZXNzaW9uKCkgY29uc3QgeyByZXR1cm4gbV9j dXJyZW50RHJhZ1Nlc3Npb247IH0KICAgICB2b2lkIHJlc2V0RHJhZ09wZXJhdGlvbigpIHsgbV9j dXJyZW50RHJhZ1Nlc3Npb24gPSBXZWJDb3JlOjpEcmFnU2Vzc2lvbigpOyB9CkBAIC0xMDg5LDkg KzEwODYsNiBAQCBwcml2YXRlOgogCiAgICAgU3RyaW5nIG1fdG9vbFRpcDsKIAotICAgIFN0cmlu ZyBtX3VybEF0UHJvY2Vzc0V4aXQ7Ci0gICAgRnJhbWVMb2FkU3RhdGU6OkxvYWRTdGF0ZSBtX2xv YWRTdGF0ZUF0UHJvY2Vzc0V4aXQ7Ci0KICAgICBFZGl0b3JTdGF0ZSBtX2VkaXRvclN0YXRlOwog ICAgIGJvb2wgbV90ZW1wb3JhcmlseUNsb3NlZENvbXBvc2l0aW9uOyAvLyBFZGl0b3Igc3RhdGUg Y2hhbmdlZCBmcm9tIGhhc0NvbXBvc2l0aW9uIHRvICFoYXNDb21wb3NpdGlvbiwgYnV0IHRoYXQg d2FzIG9ubHkgd2l0aCBzaG91bGRJZ25vcmVDb21wb3NpdGlvblNlbGVjdGlvbkNoYW5nZSB5ZXQu CiAK