124164 2013-11-11 13:17:44 -0800 REGRESSION (r158927): curly-braces-escaping.html is broken on Mac WebKit2 2013-11-11 17:06:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED MakingBotsRed, Regression P2 Normal --- 1 ap andersca andersca oldest_to_newest 949428 0 ap 2013-11-11 13:17:44 -0800 -PASS req.responseText is '/uri/resources/echo-uri.php?q={}' +FAIL req.responseText should be /uri/resources/echo-uri.php?q={}. Was /uri/resources/echo-uri.php?q=%7B%7D. This is pretty bad - check svn log if interested in the rationale for the test. Please also see bugs related to <rdar://problem/12965959> in Radar. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Furi%2Fcurly-braces-escaping.html 949433 1 ap 2013-11-11 13:26:48 -0800 The same change broke http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html, I think. 949485 2 216621 andersca 2013-11-11 16:32:25 -0800 Created attachment 216621 Patch 949499 3 andersca 2013-11-11 17:06:48 -0800 Committed r159084: <http://trac.webkit.org/changeset/159084> 216621 2013-11-11 16:32:25 -0800 2013-11-11 16:35:41 -0800 Patch bug-124164-20131111163224.patch text/plain 5717 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDE2ZmY3MzE3MDhkNTkw YWY4ZDgyYmM1NGJiYmI2OTllMDc0YjA1Ny4uZjZjZDFhMzAxMzhmOWYyOTYwOWFlYjNhMjkwZDZm M2UyZWFkMGYzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTExLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTiAo cjE1ODkyNyk6IGN1cmx5LWJyYWNlcy1lc2NhcGluZy5odG1sIGlzIGJyb2tlbiBvbiBNYWMgV2Vi S2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 MTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFj ayBvdXQgdGhlIGNoYW5nZSB0byB1c2UgTlNTZWN1cmVDb2RpbmcgZm9yIGVuY29kaW5nL2RlY29k aW5nIE5TVVJMUmVxdWVzdCBhbmQKKyAgICAgICAgTlNVUkxSZXNwb25zZSBvYmplY3RzOyB0dXJu cyBvdXQgdGhlIE5TVVJMIGVuY29kaW5nL2RlY29kaW5nIGRvZXNuJ3QgcHJlc2VydmUgdGhlIHJh dyBVUkwgYnl0ZXMuCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVy c01hYy5tbToKKyAgICAgICAgKENvcmVJUEM6OmVuY29kZVBsYXRmb3JtRGF0YSk6CisgICAgICAg IChDb3JlSVBDOjpkZWNvZGVQbGF0Zm9ybURhdGEpOgorCisyMDEzLTExLTExICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgRnJhbWVMb2FkU3Rh dGUgb2JqZWN0IGFuZCBiZWdpbiBtb3ZpbmcgbG9hZGluZyByZWxhdGVkIG1lbWJlcnMgZnJvbSBX ZWJGcmFtZVByb3h5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjQxNjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9XZWJD b3JlQXJndW1lbnRDb2RlcnNNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1dlYkNv cmVBcmd1bWVudENvZGVyc01hYy5tbQppbmRleCBiYTRlODc5NjhhOThiN2FhNjg3OWE5ZGQ4MTc5 MWNkYmJkYmVjOTVkLi41NjJiNWIxMzRmM2NmNWU2NDkzNWRmOTZmZGVjYjczMDVlMDNmY2NlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVy c01hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENv ZGVyc01hYy5tbQpAQCAtMzksMzMgKzM5LDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAog bmFtZXNwYWNlIENvcmVJUEMgewogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSAxMDkwCi1zdGF0aWMgdm9pZCBhcmNoaXZlQW5kRW5jb2RlT2JqZWN0KEFyZ3VtZW50RW5j b2RlciYgZW5jb2RlciwgaWQgb2JqZWN0LCBOU1N0cmluZyAqa2V5KQotewotICAgIFJldGFpblB0 cjxOU011dGFibGVEYXRhPiBkYXRhID0gYWRvcHROUyhbW05TTXV0YWJsZURhdGEgYWxsb2NdIGlu aXRdKTsKLSAgICBSZXRhaW5QdHI8TlNLZXllZEFyY2hpdmVyPiBhcmNoaXZlciA9IGFkb3B0TlMo W1tOU0tleWVkQXJjaGl2ZXIgYWxsb2NdIGluaXRGb3JXcml0aW5nV2l0aE11dGFibGVEYXRhOmRh dGEuZ2V0KCldKTsKLQotICAgIFthcmNoaXZlciBzZXRSZXF1aXJlc1NlY3VyZUNvZGluZzpZRVNd OwotICAgIFthcmNoaXZlci5nZXQoKSBlbmNvZGVPYmplY3Q6b2JqZWN0IGZvcktleTprZXldOwot ICAgIFthcmNoaXZlciBmaW5pc2hFbmNvZGluZ107Ci0gICAgZW5jb2RlciA8PCBDb3JlSVBDOjpE YXRhUmVmZXJlbmNlKHN0YXRpY19jYXN0PGNvbnN0IHVpbnQ4X3QqPihbZGF0YSBieXRlc10pLCBb ZGF0YSBsZW5ndGhdKTsKLX0KLQotdGVtcGxhdGU8dHlwZW5hbWUgVD4KLXN0YXRpYyBib29sIGRl Y29kZUFuZFVuYXJjaGl2ZU9iamVjdChBcmd1bWVudERlY29kZXImIGRlY29kZXIsIE5TU3RyaW5n ICprZXksIFJldGFpblB0cjxUPiYgcmVzdWx0KQotewotICAgIENvcmVJUEM6OkRhdGFSZWZlcmVu Y2UgZGF0YVJlZmVyZW5jZTsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGRhdGFSZWZlcmVuY2Up KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBSZXRhaW5QdHI8TlNEYXRhPiBkYXRhID0g YWRvcHROUyhbW05TRGF0YSBhbGxvY10gaW5pdFdpdGhCeXRlc05vQ29weTpjb25zdF9jYXN0PHVp bnQ4X3QqPihkYXRhUmVmZXJlbmNlLmRhdGEoKSkgbGVuZ3RoOmRhdGFSZWZlcmVuY2Uuc2l6ZSgp IGZyZWVXaGVuRG9uZTpOT10pOwotICAgIFJldGFpblB0cjxOU0tleWVkVW5hcmNoaXZlcj4gdW5h cmNoaXZlciA9IGFkb3B0TlMoW1tOU0tleWVkVW5hcmNoaXZlciBhbGxvY10gaW5pdEZvclJlYWRp bmdXaXRoRGF0YTpkYXRhLmdldCgpXSk7Ci0gICAgW3VuYXJjaGl2ZXIgc2V0UmVxdWlyZXNTZWN1 cmVDb2Rpbmc6WUVTXTsKLSAgICByZXN1bHQgPSBbdW5hcmNoaXZlciBkZWNvZGVPYmplY3RPZkNs YXNzOltUIGNsYXNzXSBmb3JLZXk6a2V5XTsKLSAgICByZXR1cm4gdHJ1ZTsKLX0KLSNlbmRpZgot CiB2b2lkIEFyZ3VtZW50Q29kZXI8UmVzb3VyY2VSZXF1ZXN0Pjo6ZW5jb2RlUGxhdGZvcm1EYXRh KEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJj ZVJlcXVlc3QpCiB7CiAgICAgUmV0YWluUHRyPE5TVVJMUmVxdWVzdD4gcmVxdWVzdFRvU2VyaWFs aXplID0gcmVzb3VyY2VSZXF1ZXN0Lm5zVVJMUmVxdWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5KTsK QEAgLTg0LDEyICs1Nyw4IEBAIHZvaWQgQXJndW1lbnRDb2RlcjxSZXNvdXJjZVJlcXVlc3Q+Ojpl bmNvZGVQbGF0Zm9ybURhdGEoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyCiAgICAgICAgIFsoTlNN dXRhYmxlVVJMUmVxdWVzdCAqKXJlcXVlc3RUb1NlcmlhbGl6ZSBzZXRIVFRQQm9keVN0cmVhbTpu aWxdOwogICAgIH0KIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5 MAotICAgIGFyY2hpdmVBbmRFbmNvZGVPYmplY3QoZW5jb2RlciwgcmVxdWVzdFRvU2VyaWFsaXpl LmdldCgpLCBAInJlcXVlc3QiKTsKLSNlbHNlCiAgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJl Zj4gZGljdGlvbmFyeSA9IGFkb3B0Q0YoV0tOU1VSTFJlcXVlc3RDcmVhdGVTZXJpYWxpemFibGVS ZXByZXNlbnRhdGlvbihyZXF1ZXN0VG9TZXJpYWxpemUuZ2V0KCksIENvcmVJUEM6OnRva2VuTnVs bFR5cGVSZWYoKSkpOwogICAgIENvcmVJUEM6OmVuY29kZShlbmNvZGVyLCBkaWN0aW9uYXJ5Lmdl dCgpKTsKLSNlbmRpZgogCiAgICAgLy8gVGhlIGZhbGxiYWNrIGFycmF5IGlzIHBhcnQgb2YgTlNV UkxSZXF1ZXN0LCBidXQgaXQgaXMgbm90IGVuY29kZWQgYnkgV0tOU1VSTFJlcXVlc3RDcmVhdGVT ZXJpYWxpemFibGVSZXByZXNlbnRhdGlvbi4KICAgICBlbmNvZGVyIDw8IHJlc291cmNlUmVxdWVz dC5yZXNwb25zZUNvbnRlbnREaXNwb3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheSgpOwpAQCAt MTA2LDExICs3NSw2IEBAIGJvb2wgQXJndW1lbnRDb2RlcjxSZXNvdXJjZVJlcXVlc3Q+OjpkZWNv ZGVQbGF0Zm9ybURhdGEoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVyCiAgICAgICAgIHJldHVybiB0 cnVlOwogICAgIH0KIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5 MAotICAgIFJldGFpblB0cjxOU1VSTFJlcXVlc3Q+IG5zVVJMUmVxdWVzdDsKLSAgICBpZiAoIWRl Y29kZUFuZFVuYXJjaGl2ZU9iamVjdChkZWNvZGVyLCBAInJlcXVlc3QiLCBuc1VSTFJlcXVlc3Qp KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0jZWxzZQogICAgIFJldGFpblB0cjxDRkRpY3Rpb25h cnlSZWY+IGRpY3Rpb25hcnk7CiAgICAgaWYgKCFDb3JlSVBDOjpkZWNvZGUoZGVjb2RlciwgZGlj dGlvbmFyeSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTExOCw3ICs4Miw2IEBAIGJvb2wg QXJndW1lbnRDb2RlcjxSZXNvdXJjZVJlcXVlc3Q+OjpkZWNvZGVQbGF0Zm9ybURhdGEoQXJndW1l bnREZWNvZGVyJiBkZWNvZGVyCiAgICAgUmV0YWluUHRyPE5TVVJMUmVxdWVzdD4gbnNVUkxSZXF1 ZXN0ID0gV0tOU1VSTFJlcXVlc3RGcm9tU2VyaWFsaXphYmxlUmVwcmVzZW50YXRpb24oZGljdGlv bmFyeS5nZXQoKSwgQ29yZUlQQzo6dG9rZW5OdWxsVHlwZVJlZigpKTsKICAgICBpZiAoIW5zVVJM UmVxdWVzdCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotI2VuZGlmCiAKICAgICByZXNvdXJjZVJl cXVlc3QgPSBSZXNvdXJjZVJlcXVlc3QobnNVUkxSZXF1ZXN0LmdldCgpKTsKICAgICAKQEAgLTE0 MywxMiArMTA2LDggQEAgdm9pZCBBcmd1bWVudENvZGVyPFJlc291cmNlUmVzcG9uc2U+OjplbmNv ZGVQbGF0Zm9ybURhdGEoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGUKICAgICBpZiAoIXJlc3BvbnNl SXNQcmVzZW50KQogICAgICAgICByZXR1cm47CiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwOTAKLSAgICBhcmNoaXZlQW5kRW5jb2RlT2JqZWN0KGVuY29kZXIsIHJl c291cmNlUmVzcG9uc2UubnNVUkxSZXNwb25zZSgpLCBAInJlc3BvbnNlIik7Ci0jZWxzZQogICAg IFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IGRpY3Rpb25hcnkgPSBhZG9wdENGKFdLTlNVUkxS ZXNwb25zZUNyZWF0ZVNlcmlhbGl6YWJsZVJlcHJlc2VudGF0aW9uKHJlc291cmNlUmVzcG9uc2Uu bnNVUkxSZXNwb25zZSgpLCBDb3JlSVBDOjp0b2tlbk51bGxUeXBlUmVmKCkpKTsKICAgICBDb3Jl SVBDOjplbmNvZGUoZW5jb2RlciwgZGljdGlvbmFyeS5nZXQoKSk7Ci0jZW5kaWYKIH0KIAogYm9v bCBBcmd1bWVudENvZGVyPFJlc291cmNlUmVzcG9uc2U+OjpkZWNvZGVQbGF0Zm9ybURhdGEoQXJn dW1lbnREZWNvZGVyJiBkZWNvZGVyLCBSZXNvdXJjZVJlc3BvbnNlJiByZXNvdXJjZVJlc3BvbnNl KQpAQCAtMTYyLDE3ICsxMjEsMTEgQEAgYm9vbCBBcmd1bWVudENvZGVyPFJlc291cmNlUmVzcG9u c2U+OjpkZWNvZGVQbGF0Zm9ybURhdGEoQXJndW1lbnREZWNvZGVyJiBkZWNvZGUKICAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgfQogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSAxMDkwCi0gICAgUmV0YWluUHRyPE5TVVJMUmVzcG9uc2U+IG5zVVJMUmVzcG9uc2U7Ci0g ICAgaWYgKCFkZWNvZGVBbmRVbmFyY2hpdmVPYmplY3QoZGVjb2RlciwgQCJyZXNwb25zZSIsIG5z VVJMUmVzcG9uc2UpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0jZWxzZQogICAgIFJldGFpblB0 cjxDRkRpY3Rpb25hcnlSZWY+IGRpY3Rpb25hcnk7CiAgICAgaWYgKCFDb3JlSVBDOjpkZWNvZGUo ZGVjb2RlciwgZGljdGlvbmFyeSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIFJldGFp blB0cjxOU1VSTFJlc3BvbnNlPiBuc1VSTFJlc3BvbnNlID0gV0tOU1VSTFJlc3BvbnNlRnJvbVNl cmlhbGl6YWJsZVJlcHJlc2VudGF0aW9uKGRpY3Rpb25hcnkuZ2V0KCksIENvcmVJUEM6OnRva2Vu TnVsbFR5cGVSZWYoKSk7Ci0jZW5kaWYKIAogICAgIGlmICghbnNVUkxSZXNwb25zZSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwo=