124152 2013-11-11 09:21:42 -0800 Fix undefined reference issues in JavaScriptCore build. 2013-11-12 09:36:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kilvadyb webkit-unassigned commit-queue fpizlo fu gergely ggaren gtk-ews jbriance msaboff oliver palfia xan.lopez oldest_to_newest 949322 0 kilvadyb 2013-11-11 09:21:42 -0800 These errors come up when building GTK port of jsc with gcc 4.7.2. Linking CXX executable ../../../bin/jsc ../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)': SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::inherits(JSC::ClassInfo const*) const' ../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)': SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::classInfo() const' 949326 1 216580 kilvadyb 2013-11-11 09:30:23 -0800 Created attachment 216580 proposed patch. 949343 2 216580 gtk-ews 2013-11-11 09:47:44 -0800 Comment on attachment 216580 proposed patch. Attachment 216580 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22938190 949461 3 216580 zan 2013-11-11 14:55:15 -0800 Comment on attachment 216580 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=216580&action=review > Source/JavaScriptCore/runtime/SymbolTable.cpp:33 > +#include "JSCellInlines.h" > +#include "JSDestructibleObject.h" Additionally include the SlotVisitorInlines.h header to get rid of the new undefined reference that was exposed by the GTK EWS. I think after that the patch will be good to go into the tree. 949602 4 216649 kilvadyb 2013-11-12 01:06:17 -0800 Created attachment 216649 fixed patch. SlotVisitorInlines.h added, thanks to Zan Dobersek. Rebased on 159100. 949706 5 216649 commit-queue 2013-11-12 09:36:00 -0800 Comment on attachment 216649 fixed patch. Clearing flags on attachment: 216649 Committed r159116: <http://trac.webkit.org/changeset/159116> 949707 6 commit-queue 2013-11-12 09:36:03 -0800 All reviewed patches have been landed. Closing bug. 216580 2013-11-11 09:30:23 -0800 2013-11-12 01:06:17 -0800 proposed patch. includes.diff text/plain 1107 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRiZjc2MzIuLmE5NDliMTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTExICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgRml4IHVuZGVmaW5lZCByZWZl cmVuY2UgaXNzdWVzIGluIEphdmFTY3JpcHRDb3JlIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5jbHVkZXMgYWRkZWQuCisKKyAgICAgICAg KiBydW50aW1lL1N5bWJvbFRhYmxlLmNwcDoKKwogMjAxMy0xMS0wOSAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCBGVEwgR2V0QnlJZC9QdXRCeUlkIElD J3Mgb3ZlciB0byB1c2luZyBBbnlSZWdDQwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvU3ltYm9sVGFibGUuY3BwCmluZGV4IGE2ZTdhNjguLmYwZDE3OGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5jcHAKQEAgLTI5LDYgKzI5LDkgQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJTeW1ib2xUYWJsZS5oIgogCisjaW5jbHVk ZSAiSlNDZWxsSW5saW5lcy5oIgorI2luY2x1ZGUgIkpTRGVzdHJ1Y3RpYmxlT2JqZWN0LmgiCisK IG5hbWVzcGFjZSBKU0MgewogCiBjb25zdCBDbGFzc0luZm8gU2hhcmVkU3ltYm9sVGFibGU6OnNf aW5mbyA9IHsgIlNoYXJlZFN5bWJvbFRhYmxlIiwgMCwgMCwgMCwgQ1JFQVRFX01FVEhPRF9UQUJM RShTaGFyZWRTeW1ib2xUYWJsZSkgfTsK 216649 2013-11-12 01:06:17 -0800 2013-11-12 09:36:00 -0800 fixed patch. includes.diff text/plain 1197 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDkzYzg1NTQuLmU4ZjAzYzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTEyICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgRml4IHVuZGVmaW5lZCByZWZl cmVuY2UgaXNzdWVzIGluIEphdmFTY3JpcHRDb3JlIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWlzc2luZyBpbmNsdWRlcyBhZGRlZC4KKwor ICAgICAgICAqIHJ1bnRpbWUvU3ltYm9sVGFibGUuY3BwOgorCiAyMDEzLTExLTEyICBKdWxpZW4g QnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgogCiAgICAgICAgIEludmFsaWRJbmRleCBz aG91bGRuJ3QgYmUgcHJpdmF0ZSBpbiBHUFJJbmZvIGFuZCBGUFJJbmZvIGZvciBzaDQsIG1pcHMg YW5kIGFybTY0IGFyY2hpdGVjdHVyZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TeW1ib2xUYWJsZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TeW1ib2xUYWJsZS5jcHAKaW5kZXggYTZlN2E2OC4uY2I5YjBiZiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmNwcApAQCAtMjksNiArMjksMTAgQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJTeW1ib2xUYWJsZS5oIgogCisjaW5jbHVk ZSAiSlNDZWxsSW5saW5lcy5oIgorI2luY2x1ZGUgIkpTRGVzdHJ1Y3RpYmxlT2JqZWN0LmgiCisj aW5jbHVkZSAiU2xvdFZpc2l0b3JJbmxpbmVzLmgiCisKIG5hbWVzcGFjZSBKU0MgewogCiBjb25z dCBDbGFzc0luZm8gU2hhcmVkU3ltYm9sVGFibGU6OnNfaW5mbyA9IHsgIlNoYXJlZFN5bWJvbFRh YmxlIiwgMCwgMCwgMCwgQ1JFQVRFX01FVEhPRF9UQUJMRShTaGFyZWRTeW1ib2xUYWJsZSkgfTsK