124149 2013-11-11 08:26:08 -0800 Build fail on CPU(ARM_TRADITIONAL) after r159039 2013-11-11 10:12:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned commit-queue ggaren ossy oldest_to_newest 949301 0 rgabor 2013-11-11 08:26:08 -0800 Build fail on CPU(ARM_TRADITIONAL) after r159039 949302 1 216575 rgabor 2013-11-11 08:29:23 -0800 Created attachment 216575 proposed fix 949311 2 216575 ggaren 2013-11-11 08:56:46 -0800 Comment on attachment 216575 proposed fix It looks like this change will cut back the ARMv7Assembler from max register r15 to max register r13, since ARMv7Assembler::lastRegister() returns r13. Is that the right thing to do? Your ChangeLog doesn't explain why you did it, or why it's right. Regardless of whether it's right, it's bad for a build fix patch on one platform to include a behavior change on another platform. They should be two separate patches. 949316 3 rgabor 2013-11-11 09:11:24 -0800 That's the ARMAssembler not the ARMv7Assembler and it has no effect on it. I just put these functions to the right place form MacroAssemblerARM to ARMAssembler as the other Assemblers work. I don't see how this patch effects on the ARMv7Assembler. (In reply to comment #2) > (From update of attachment 216575 [details]) > It looks like this change will cut back the ARMv7Assembler from max register r15 to max register r13, since ARMv7Assembler::lastRegister() returns r13. > > Is that the right thing to do? Your ChangeLog doesn't explain why you did it, or why it's right. > > Regardless of whether it's right, it's bad for a build fix patch on one platform to include a behavior change on another platform. They should be two separate patches. 949319 4 ossy 2013-11-11 09:14:38 -0800 (In reply to comment #3) > That's the ARMAssembler not the ARMv7Assembler and it has no effect on it. I just put these functions to the right place form MacroAssemblerARM to ARMAssembler as the other Assemblers work. I don't see how this patch effects on the ARMv7Assembler. CPU(ARM) in FPRInfo.h is true on ARM_TRADITIONAL and ARM_THUMB2 too. 949341 5 ggaren 2013-11-11 09:41:09 -0800 > That's the ARMAssembler not the ARMv7Assembler and it has no effect on it. I see. I thought, incorrectly, that MacroAssemblerARM was used by all ARM platforms. 949342 6 216575 ggaren 2013-11-11 09:41:20 -0800 Comment on attachment 216575 proposed fix r=me 949345 7 216575 commit-queue 2013-11-11 09:54:12 -0800 Comment on attachment 216575 proposed fix Rejecting attachment 216575 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216575, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/22599400 949348 8 216575 ossy 2013-11-11 09:58:39 -0800 Comment on attachment 216575 proposed fix Let's try CQ again, the SVN server is sick today. 949356 9 216575 commit-queue 2013-11-11 10:12:41 -0800 Comment on attachment 216575 proposed fix Clearing flags on attachment: 216575 Committed r159055: <http://trac.webkit.org/changeset/159055> 949357 10 commit-queue 2013-11-11 10:12:44 -0800 All reviewed patches have been landed. Closing bug. 216575 2013-11-11 08:29:23 -0800 2013-11-11 10:12:41 -0800 proposed fix arm_buildfix.patch text/plain 2755 rgabor SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5MDQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTExLTExICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAg ICAgICBGaXggQ1BVKEFSTV9UUkFESVRJT05BTCkgYnVpbGQgYWZ0ZXIgcjE1OTAzOS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE0OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0FS TUFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OmZpcnN0UmVnaXN0ZXIp OgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6Omxhc3RSZWdpc3Rlcik6CisgICAgICAgIChK U0M6OkFSTUFzc2VtYmxlcjo6Zmlyc3RGUFJlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6QVJNQXNz ZW1ibGVyOjpsYXN0RlBSZWdpc3Rlcik6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNLmg6CisgICAgICAgICogaml0L0ZQUkluZm8uaDoKKwogMjAxMy0xMS0wOSAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCBGVEwgR2V0QnlJZC9Q dXRCeUlkIElDJ3Mgb3ZlciB0byB1c2luZyBBbnlSZWdDQwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCShyZXZpc2lvbiAxNTkwNDkpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNTMsNiArMTUzLDEyIEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIEFS TUJ1ZmZlciYgYnVmZmVyKCkgeyByZXR1cm4gbV9idWZmZXI7IH0KIAorICAgICAgICBzdGF0aWMg UmVnaXN0ZXJJRCBmaXJzdFJlZ2lzdGVyKCkgeyByZXR1cm4gQVJNUmVnaXN0ZXJzOjpyMDsgfQor ICAgICAgICBzdGF0aWMgUmVnaXN0ZXJJRCBsYXN0UmVnaXN0ZXIoKSB7IHJldHVybiBBUk1SZWdp c3RlcnM6OnIxNTsgfQorCisgICAgICAgIHN0YXRpYyBGUFJlZ2lzdGVySUQgZmlyc3RGUFJlZ2lz dGVyKCkgeyByZXR1cm4gQVJNUmVnaXN0ZXJzOjpkMDsgfQorICAgICAgICBzdGF0aWMgRlBSZWdp c3RlcklEIGxhc3RGUFJlZ2lzdGVyKCkgeyByZXR1cm4gQVJNUmVnaXN0ZXJzOjpkMzE7IH0KKwog ICAgICAgICAvLyBBUk0gY29uZGl0aW9uYWwgY29uc3RhbnRzCiAgICAgICAgIHR5cGVkZWYgZW51 bSB7CiAgICAgICAgICAgICBFUSA9IDB4MDAwMDAwMDAsIC8vIFplcm8gLyBFcXVhbC4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmgJKHJldmlzaW9uIDE1OTA0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2luZyBjb3B5KQpAQCAtNDIsMTIgKzQyLDYgQEAg Y2xhc3MgTWFjcm9Bc3NlbWJsZXJBUk0gOiBwdWJsaWMgQWJzdHJhYwogcHVibGljOgogICAgIHR5 cGVkZWYgQVJNUmVnaXN0ZXJzOjpGUFJlZ2lzdGVySUQgRlBSZWdpc3RlcklEOwogCi0gICAgc3Rh dGljIFJlZ2lzdGVySUQgZmlyc3RSZWdpc3RlcigpIHsgcmV0dXJuIEFSTVJlZ2lzdGVyczo6cjA7 IH0KLSAgICBzdGF0aWMgUmVnaXN0ZXJJRCBsYXN0UmVnaXN0ZXIoKSB7IHJldHVybiBBUk1SZWdp c3RlcnM6OnIxNTsgfQotCi0gICAgc3RhdGljIEZQUmVnaXN0ZXJJRCBmaXJzdEZQUmVnaXN0ZXIo KSB7IHJldHVybiBBUk1SZWdpc3RlcnM6OmQwOyB9Ci0gICAgc3RhdGljIEZQUmVnaXN0ZXJJRCBs YXN0RlBSZWdpc3RlcigpIHsgcmV0dXJuIEFSTVJlZ2lzdGVyczo6ZDMxOyB9Ci0KICAgICBlbnVt IFJlbGF0aW9uYWxDb25kaXRpb24gewogICAgICAgICBFcXVhbCA9IEFSTUFzc2VtYmxlcjo6RVEs CiAgICAgICAgIE5vdEVxdWFsID0gQVJNQXNzZW1ibGVyOjpORSwKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvRlBSSW5mby5oCShyZXZpc2lvbiAxNTkwNDkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0ZQUkluZm8uaAkod29ya2luZyBjb3B5KQpAQCAtMTY4LDYgKzE2OCw4IEBAIHB1 YmxpYzoKICAgICAgICAgfTsKICAgICAgICAgcmV0dXJuIG5hbWVGb3JSZWdpc3RlcltyZWddOwog ICAgIH0KKworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBJbnZhbGlkSW5kZXggPSAweGZmZmZm ZmZmOwogfTsKIAogI2VuZGlmCg==