124148 2013-11-11 08:07:44 -0800 REGRESSION(r158976): Web Inspector: unable to start docked or dock 2013-11-11 17:53:34 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 gustavo gustavo achicu commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 949295 0 gustavo 2013-11-11 08:07:44 -0800 With the change in r158976, the canAttach method takes into account the level of inspector that is being started, to avoid starting an inspector instance that is inspecting an inspector on the same window. The first level of inspectors is 1, but canAttach checks for m_level > 0, so we are never able to attach. 949296 1 webkit-bug-importer 2013-11-11 08:08:05 -0800 <rdar://problem/15437083> 949297 2 216572 gustavo 2013-11-11 08:10:08 -0800 Created attachment 216572 Patch 949353 3 achicu 2013-11-11 10:03:30 -0800 *** Bug 124155 has been marked as a duplicate of this bug. *** 949354 4 achicu 2013-11-11 10:05:13 -0800 Sorry about that. Having the level set to 1 was a last minute change that I've done when the debug build asserted in the HashMap. 949513 5 216572 commit-queue 2013-11-11 17:53:32 -0800 Comment on attachment 216572 Patch Clearing flags on attachment: 216572 Committed r159090: <http://trac.webkit.org/changeset/159090> 949514 6 commit-queue 2013-11-11 17:53:34 -0800 All reviewed patches have been landed. Closing bug. 216572 2013-11-11 08:10:08 -0800 2013-11-11 17:53:31 -0800 Patch bug-124148-20131111141005.patch text/plain 1499 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjFmMDVlZjgzZmQ3NWJi NDczYmVjYmYxZWRkZTBjMzE1YjFmMTFhMC4uM2VkZDA2YzkwMTMwYzg5ODY3MjE0MGJjYjNmNTdm MmU5NDI4ODEyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTExICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjE1ODk3Nik6IFdlYiBJbnNwZWN0b3I6IHVuYWJsZSB0byBzdGFydCBkb2NrZWQgb3IgZG9jawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MTQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQ cm94eTo6Y2FuQXR0YWNoKTogY2hlY2sgZm9yIGEgbGV2ZWwgdGhhdCBpcyBncmVhdGVyIHRoYW4g MSByYXRoZXIgdGhhbiAwCisgICAgICAgIHRvIGRlbnkgYXR0YWNobWVudCwgc2luY2UgMSBpcyB0 aGUgZmlyc3QgbGV2ZWwgb2YgaW5zcGVjdG9ycy4KKwogMjAxMy0xMS0wOSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBjcmVhdGVDRlVSTEZyb21CdWZmZXIg d2hlbiBjb252ZXJ0aW5nIGEgU3RyaW5nIHRvIGEgQ0ZVUkwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCmluZGV4IGQ1NzYyMGIxYzgwZGVhZTMxZGIw MzM3NmNmMmYwODQ2N2MxNWM2M2MuLjNhZWZiNjIwMjFlM2VjYjFkMzc5YWUwNjJkYjY5YjY2MGNj Njc1Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5 LmNwcApAQCAtNTQ5LDcgKzU0OSw3IEBAIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OmNhbkF0dGFj aCgpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8gRG9uJ3QgYWxsb3cgYXR0YWNoaW5n IHRvIGFub3RoZXIgaW5zcGVjdG9yIC0tIHR3byBpbnNwZWN0b3JzIGluIG9uZSB3aW5kb3cgaXMg dG9vIG11Y2ghCi0gICAgaWYgKG1fbGV2ZWwgPiAwKQorICAgIGlmIChtX2xldmVsID4gMSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgLy8gRG9uJ3QgYWxsb3cgdGhlIGF0dGFjaCBpZiB0 aGUgd2luZG93IHdvdWxkIGJlIHRvbyBzbWFsbCB0byBhY2NvbW1vZGF0ZSB0aGUgbWluaW11bSBp bnNwZWN0b3IgaGVpZ2h0Lgo=