124147 2013-11-11 07:23:45 -0800 Report error when #else is used in message receiver generator's input. 2013-12-05 14:19:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121877 1 gbalogh.u-szeged webkit-unassigned ap bfulgham commit-queue darin ossy oldest_to_newest 949290 0 gbalogh.u-szeged 2013-11-11 07:23:45 -0800 Report error when #else is used in message receiver generator's input, because it is ignored by the generator script. 949299 1 216573 gbalogh.u-szeged 2013-11-11 08:13:03 -0800 Created attachment 216573 patch 951038 2 ossy 2013-11-15 05:34:34 -0800 I don't think if we will need #else in the message files, but warning the user is better than simple ignoring the #else. The patch looks good to me, but we need a WK2 owner review. 951076 3 216573 ap 2013-11-15 08:28:35 -0800 Comment on attachment 216573 patch View in context: https://bugs.webkit.org/attachment.cgi?id=216573&action=review > Source/WebKit2/ChangeLog:8 > + * Scripts/webkit2/parser.py: Can this be tested with a webkitpy regression test? 954680 4 217986 gbalogh.u-szeged 2013-11-28 01:52:18 -0800 Created attachment 217986 patch the style check is crash on Source/WebKit2/Scripts/webkit2/messages_unittest.py even it is well formated (my part anyway) and working 954930 5 ossy 2013-11-29 03:13:23 -0800 LGTM with the new unittest. WK2 owners? 955179 6 217986 ap 2013-12-01 13:50:07 -0800 Comment on attachment 217986 patch View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review This change is good, please feel free to review and land as appropriate. > Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130 > + with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"): Where does this ".*" come from? How is it helpful? > Source/WebKit2/Scripts/webkit2/parser.py:68 > + raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed) Shouldn't it be "... is not supported in .in files" (no "the", and singular)? 955256 7 gbalogh.u-szeged 2013-12-01 22:10:27 -0800 (In reply to comment #6) > (From update of attachment 217986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review > > This change is good, please feel free to review and land as appropriate. > > > Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130 > > + with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"): > > Where does this ".*" come from? How is it helpful? I use to follow the practise, that I give as much information as possible in an error message. Maybe it is irrelevant in the case of 'else', but I think if somebody make a mistake (for example 'else if' instead of 'elif') it will be nice to show the whole line, to help identify and correct it. > > > Source/WebKit2/Scripts/webkit2/parser.py:68 > > + raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed) > > Shouldn't it be "... is not supported in .in files" (no "the", and singular)? 955841 8 gbalogh.u-szeged 2013-12-03 03:12:22 -0800 (In reply to comment #6) > (From update of attachment 217986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review > > This change is good, please feel free to review and land as appropriate. Could you please set r+ and c+ for it as a WebKit2 owner? > > > Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130 > > + with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"): > > Where does this ".*" come from? How is it helpful? > > > Source/WebKit2/Scripts/webkit2/parser.py:68 > > + raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed) > > Shouldn't it be "... is not supported in .in files" (no "the", and singular)? 955901 9 ap 2013-12-03 08:37:46 -0800 > Could you please set r+ and c+ for it as a WebKit2 owner? You don't need an owner for that, any reviewer can do final review and set r+ with approval from an owner. Are you planning to address the comments though? 956313 10 218390 gbalogh.u-szeged 2013-12-04 01:43:34 -0800 Created attachment 218390 patch fix > Are you planning to address the comments though? Yes. are -> is The answer for the other one see above. 956365 11 218390 ossy 2013-12-04 05:30:31 -0800 Comment on attachment 218390 patch fix View in context: https://bugs.webkit.org/attachment.cgi?id=218390&action=review > Source/WebKit2/Scripts/webkit2/parser.py:68 > + raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed) are -> is here too 956771 12 218488 gbalogh.u-szeged 2013-12-04 21:56:30 -0800 Created attachment 218488 patch 956787 13 218488 commit-queue 2013-12-04 23:38:38 -0800 Comment on attachment 218488 patch Clearing flags on attachment: 218488 Committed r160161: <http://trac.webkit.org/changeset/160161> 956788 14 commit-queue 2013-12-04 23:38:40 -0800 All reviewed patches have been landed. Closing bug. 956971 15 bfulgham 2013-12-05 11:18:02 -0800 This change breaks the Windows build: Running the tests ... [4/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_elif erred: Traceback (most recent call last): File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1135, in test_error_at_elif with self.assertRaisesRegexp(Exception, r"ERROR: '#elif.*' is not supported in the \*\.in files"): AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp' [5/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_else erred: Traceback (most recent call last): File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1131, in test_error_at_else with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' is not supported in the \*\.in files"): AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp' 957042 16 ossy 2013-12-05 14:15:59 -0800 (In reply to comment #15) > This change breaks the Windows build: > > Running the tests ... > [4/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_elif erred: > Traceback (most recent call last): > File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1135, in test_error_at_elif > with self.assertRaisesRegexp(Exception, r"ERROR: '#elif.*' is not supported in the \*\.in files"): > AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp' > > [5/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_else erred: > Traceback (most recent call last): > File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1131, in test_error_at_else > with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' is not supported in the \*\.in files"): > AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp' Thanks for noticing this failure. But I think it isn't a serious problem, because not the build is broken, only two webkitpy unittest fail. And they fail because the Windows bots have older than 2.7 python. (which was released ~3.5 years before) Additionally it was a WebKit2 patch and there is no WebKit2 on Windows long time ago. I think we can fix this problem in 3 different way: - install newer python to Windows buildbots - disable this WebKit2 unittest, because there is no WebKit2 on Windows - use similar workaround to Tools/Scripts/webkitpy/common/webkitunittest.py 957044 17 ossy 2013-12-05 14:19:12 -0800 new bug report to disable wk2-webkitpy unittests on Windows: https://bugs.webkit.org/show_bug.cgi?id=125318 216573 2013-11-11 08:13:03 -0800 2013-11-28 01:52:18 -0800 patch f2355-2368.diff text/plain 1548 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiZGIxMGYxLi5lMDY0NDljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMTEtMTEgIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJlcG9ydCBlcnJvciB3aGVuICNlbHNlIGlzIHVzZWQgaW4gbWVzc2FnZSByZWNl aXZlciBnZW5lcmF0b3IncyBpbnB1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weToKKyAgICAgICAgKHBh cnNlKToKKwogMjAxMy0xMC0xOCAgR2VyZ28gQmFsb2doICA8Z2VyeXh5ekBpbmYudS1zemVnZWQu aHU+CiAKICAgICAgICAgZ2VuZXJhdGUtbWVzc2FnZS1yZWNlaXZlci5weSBjYW4ndCBoYW5kbGUg bmVzdGVkICNpZnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9w YXJzZXIucHkgYi9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvcGFyc2VyLnB5CmluZGV4 IDU4Y2JlNWMuLjVhZTJlMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Vi a2l0Mi9wYXJzZXIucHkKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL3BhcnNl ci5weQpAQCAtNTksMTAgKzU5LDE0IEBAIGRlZiBwYXJzZShmaWxlKToKICAgICAgICAgICAgIGRl c3RpbmF0aW9uID0gbWF0Y2guZ3JvdXAoJ2Rlc3RpbmF0aW9uJykKICAgICAgICAgICAgIGNvbnRp bnVlCiAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgnIycpOgorICAgICAgICAgICAgdHJpbW1l ZCA9IGxpbmUucnN0cmlwKCkKICAgICAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgnI2lmICcp OgotICAgICAgICAgICAgICAgIGNvbmRpdGlvbnMuYXBwZW5kKGxpbmUucnN0cmlwKClbNDpdKQor ICAgICAgICAgICAgICAgIGNvbmRpdGlvbnMuYXBwZW5kKHRyaW1tZWRbNDpdKQogICAgICAgICAg ICAgZWxpZiBsaW5lLnN0YXJ0c3dpdGgoJyNlbmRpZicpIGFuZCBjb25kaXRpb25zOgogICAgICAg ICAgICAgICAgIGNvbmRpdGlvbnMucG9wKCkKKyAgICAgICAgICAgIGVsaWYgbGluZS5zdGFydHN3 aXRoKCcjZWxzZScpIG9yIGxpbmUuc3RhcnRzd2l0aCgnI2VsaWYnKToKKyAgICAgICAgICAgICAg ICBwcmludCgnRVJST1I6ICVzIGFyZSBub3Qgc3VwcG9ydGVkIGluIHRoZSAqLmluIGZpbGVzJyAl IHRyaW1tZWRbMTpdKQorICAgICAgICAgICAgICAgIGV4aXQoMSkKICAgICAgICAgICAgIGNvbnRp bnVlCiAgICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKHInKFtBLVphLXpfMC05XSspXCgoLio/KVwp KD86KD86XHMrLT5ccyspXCgoLio/KVwpKT8oPzpccysoLiopKT8nLCBsaW5lKQogICAgICAgICBp ZiBtYXRjaDoK 217986 2013-11-28 01:52:18 -0800 2013-12-04 01:43:34 -0800 patch f2368.utest.diff text/plain 2766 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiMDkyNDBlLi5kNzMwOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTEtMjggIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJlcG9ydCBlcnJvciB3aGVuICNlbHNlIGlzIHVzZWQgaW4gbWVzc2FnZSByZWNl aXZlciBnZW5lcmF0b3IncyBpbnB1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoVW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QpOgorICAgICAgICAo VW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QudGVzdF9lcnJvcl9hdF9lbHNlKToK KyAgICAgICAgKFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0LnRlc3RfZXJyb3Jf YXRfZWxpZik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weToKKyAgICAgICAg KHBhcnNlKToKKwogMjAxMy0xMS0yMSAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtFRkxdW1dLMl0gRml4IGJ1aWxkIGFmdGVyIHIxNTk2 NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191 bml0dGVzdC5weSBiL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0 dGVzdC5weQppbmRleCBhMGRkNDgwLi41ZWM2ZmI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKKysrIGIvU291cmNlL1dlYktp dDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5CkBAIC0xMTI1LDUgKzExMjUs MTUgQEAgY2xhc3MgUmVjZWl2ZXJJbXBsZW1lbnRhdGlvblRlc3QoR2VuZXJhdGVkRmlsZUNvbnRl bnRzVGVzdCk6CiAgICAgICAgIHNlbGYuYXNzZXJ0R2VuZXJhdGVkRmlsZUNvbnRlbnRzRXF1YWwo ZmlsZV9jb250ZW50cywgX2V4cGVjdGVkX3JlY2VpdmVyX2ltcGxlbWVudGF0aW9uKQogCiAKK2Ns YXNzIFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKKyAgICBkZWYgdGVzdF9lcnJvcl9hdF9lbHNlKHNlbGYpOgorICAgICAgICB3aXRoIHNlbGYu YXNzZXJ0UmFpc2VzUmVnZXhwKEV4Y2VwdGlvbiwgciJFUlJPUjogJyNlbHNlLionIGFyZSBub3Qg c3VwcG9ydGVkIGluIHRoZSBcKlwuaW4gZmlsZXMiKToKKyAgICAgICAgICAgIG1lc3NhZ2VzLmdl bmVyYXRlX21lc3NhZ2VfaGFuZGxlcihTdHJpbmdJTygiYXNkXG4jZWxzZSBibGFcbmZvbyIpKQor CisgICAgZGVmIHRlc3RfZXJyb3JfYXRfZWxpZihzZWxmKToKKyAgICAgICAgd2l0aCBzZWxmLmFz c2VydFJhaXNlc1JlZ2V4cChFeGNlcHRpb24sIHIiRVJST1I6ICcjZWxpZi4qJyBhcmUgbm90IHN1 cHBvcnRlZCBpbiB0aGUgXCpcLmluIGZpbGVzIik6CisgICAgICAgICAgICBtZXNzYWdlcy5nZW5l cmF0ZV9tZXNzYWdlX2hhbmRsZXIoU3RyaW5nSU8oImFzZFxuI2VsaWYgYmxhXG5mb28iKSkKKwor CiBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgIHVuaXR0ZXN0Lm1haW4oKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weSBiL1NvdXJjZS9X ZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9wYXJzZXIucHkKaW5kZXggNThjYmU1Yy4uZTQxZDRkZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvcGFyc2VyLnB5CkBAIC01OSwxMCArNTks MTMgQEAgZGVmIHBhcnNlKGZpbGUpOgogICAgICAgICAgICAgZGVzdGluYXRpb24gPSBtYXRjaC5n cm91cCgnZGVzdGluYXRpb24nKQogICAgICAgICAgICAgY29udGludWUKICAgICAgICAgaWYgbGlu ZS5zdGFydHN3aXRoKCcjJyk6CisgICAgICAgICAgICB0cmltbWVkID0gbGluZS5yc3RyaXAoKQog ICAgICAgICAgICAgaWYgbGluZS5zdGFydHN3aXRoKCcjaWYgJyk6Ci0gICAgICAgICAgICAgICAg Y29uZGl0aW9ucy5hcHBlbmQobGluZS5yc3RyaXAoKVs0Ol0pCisgICAgICAgICAgICAgICAgY29u ZGl0aW9ucy5hcHBlbmQodHJpbW1lZFs0Ol0pCiAgICAgICAgICAgICBlbGlmIGxpbmUuc3RhcnRz d2l0aCgnI2VuZGlmJykgYW5kIGNvbmRpdGlvbnM6CiAgICAgICAgICAgICAgICAgY29uZGl0aW9u cy5wb3AoKQorICAgICAgICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dpdGgoJyNlbHNlJykgb3IgbGlu ZS5zdGFydHN3aXRoKCcjZWxpZicpOgorICAgICAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigi RVJST1I6ICclcycgYXJlIG5vdCBzdXBwb3J0ZWQgaW4gdGhlICouaW4gZmlsZXMiICUgdHJpbW1l ZCkKICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKHInKFtB LVphLXpfMC05XSspXCgoLio/KVwpKD86KD86XHMrLT5ccyspXCgoLio/KVwpKT8oPzpccysoLiop KT8nLCBsaW5lKQogICAgICAgICBpZiBtYXRjaDoK 218390 2013-12-04 01:43:34 -0800 2013-12-04 21:56:30 -0800 patch fix 217986.fix.patch text/plain 2764 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiMDkyNDBlLi5kNzMwOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTEtMjggIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJlcG9ydCBlcnJvciB3aGVuICNlbHNlIGlzIHVzZWQgaW4gbWVzc2FnZSByZWNl aXZlciBnZW5lcmF0b3IncyBpbnB1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoVW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QpOgorICAgICAgICAo VW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QudGVzdF9lcnJvcl9hdF9lbHNlKToK KyAgICAgICAgKFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0LnRlc3RfZXJyb3Jf YXRfZWxpZik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weToKKyAgICAgICAg KHBhcnNlKToKKwogMjAxMy0xMS0yMSAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtFRkxdW1dLMl0gRml4IGJ1aWxkIGFmdGVyIHIxNTk2 NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191 bml0dGVzdC5weSBiL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0 dGVzdC5weQppbmRleCBhMGRkNDgwLi41ZWM2ZmI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKKysrIGIvU291cmNlL1dlYktp dDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5CkBAIC0xMTI1LDUgKzExMjUs MTUgQEAgY2xhc3MgUmVjZWl2ZXJJbXBsZW1lbnRhdGlvblRlc3QoR2VuZXJhdGVkRmlsZUNvbnRl bnRzVGVzdCk6CiAgICAgICAgIHNlbGYuYXNzZXJ0R2VuZXJhdGVkRmlsZUNvbnRlbnRzRXF1YWwo ZmlsZV9jb250ZW50cywgX2V4cGVjdGVkX3JlY2VpdmVyX2ltcGxlbWVudGF0aW9uKQogCiAKK2Ns YXNzIFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKKyAgICBkZWYgdGVzdF9lcnJvcl9hdF9lbHNlKHNlbGYpOgorICAgICAgICB3aXRoIHNlbGYu YXNzZXJ0UmFpc2VzUmVnZXhwKEV4Y2VwdGlvbiwgciJFUlJPUjogJyNlbHNlLionIGlzIG5vdCBz dXBwb3J0ZWQgaW4gdGhlIFwqXC5pbiBmaWxlcyIpOgorICAgICAgICAgICAgbWVzc2FnZXMuZ2Vu ZXJhdGVfbWVzc2FnZV9oYW5kbGVyKFN0cmluZ0lPKCJhc2RcbiNlbHNlIGJsYVxuZm9vIikpCisK KyAgICBkZWYgdGVzdF9lcnJvcl9hdF9lbGlmKHNlbGYpOgorICAgICAgICB3aXRoIHNlbGYuYXNz ZXJ0UmFpc2VzUmVnZXhwKEV4Y2VwdGlvbiwgciJFUlJPUjogJyNlbGlmLionIGlzIG5vdCBzdXBw b3J0ZWQgaW4gdGhlIFwqXC5pbiBmaWxlcyIpOgorICAgICAgICAgICAgbWVzc2FnZXMuZ2VuZXJh dGVfbWVzc2FnZV9oYW5kbGVyKFN0cmluZ0lPKCJhc2RcbiNlbGlmIGJsYVxuZm9vIikpCisKKwog aWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9wYXJzZXIucHkgYi9Tb3VyY2UvV2Vi S2l0Mi9TY3JpcHRzL3dlYmtpdDIvcGFyc2VyLnB5CmluZGV4IDU4Y2JlNWMuLmU0MWQ0ZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9wYXJzZXIucHkKKysrIGIv U291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weQpAQCAtNTksMTAgKzU5LDEz IEBAIGRlZiBwYXJzZShmaWxlKToKICAgICAgICAgICAgIGRlc3RpbmF0aW9uID0gbWF0Y2guZ3Jv dXAoJ2Rlc3RpbmF0aW9uJykKICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgIGlmIGxpbmUu c3RhcnRzd2l0aCgnIycpOgorICAgICAgICAgICAgdHJpbW1lZCA9IGxpbmUucnN0cmlwKCkKICAg ICAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgnI2lmICcpOgotICAgICAgICAgICAgICAgIGNv bmRpdGlvbnMuYXBwZW5kKGxpbmUucnN0cmlwKClbNDpdKQorICAgICAgICAgICAgICAgIGNvbmRp dGlvbnMuYXBwZW5kKHRyaW1tZWRbNDpdKQogICAgICAgICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dp dGgoJyNlbmRpZicpIGFuZCBjb25kaXRpb25zOgogICAgICAgICAgICAgICAgIGNvbmRpdGlvbnMu cG9wKCkKKyAgICAgICAgICAgIGVsaWYgbGluZS5zdGFydHN3aXRoKCcjZWxzZScpIG9yIGxpbmUu c3RhcnRzd2l0aCgnI2VsaWYnKToKKyAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIkVS Uk9SOiAnJXMnIGFyZSBub3Qgc3VwcG9ydGVkIGluIHRoZSAqLmluIGZpbGVzIiAlIHRyaW1tZWQp CiAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICBtYXRjaCA9IHJlLnNlYXJjaChyJyhbQS1a YS16XzAtOV0rKVwoKC4qPylcKSg/Oig/OlxzKy0+XHMrKVwoKC4qPylcKSk/KD86XHMrKC4qKSk/ JywgbGluZSkKICAgICAgICAgaWYgbWF0Y2g6Cg== 218488 2013-12-04 21:56:30 -0800 2013-12-04 23:38:38 -0800 patch attachment.cgi.txt text/plain 2763 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiMDkyNDBlLi5kNzMwOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTEtMjggIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJlcG9ydCBlcnJvciB3aGVuICNlbHNlIGlzIHVzZWQgaW4gbWVzc2FnZSByZWNl aXZlciBnZW5lcmF0b3IncyBpbnB1dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoVW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QpOgorICAgICAgICAo VW5zdXBwb3J0ZWRQcmVjb21waWxlckRpcmVjdGl2ZVRlc3QudGVzdF9lcnJvcl9hdF9lbHNlKToK KyAgICAgICAgKFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0LnRlc3RfZXJyb3Jf YXRfZWxpZik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weToKKyAgICAgICAg KHBhcnNlKToKKwogMjAxMy0xMS0yMSAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtFRkxdW1dLMl0gRml4IGJ1aWxkIGFmdGVyIHIxNTk2 NTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191 bml0dGVzdC5weSBiL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0 dGVzdC5weQppbmRleCBhMGRkNDgwLi41ZWM2ZmI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKKysrIGIvU291cmNlL1dlYktp dDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5CkBAIC0xMTI1LDUgKzExMjUs MTUgQEAgY2xhc3MgUmVjZWl2ZXJJbXBsZW1lbnRhdGlvblRlc3QoR2VuZXJhdGVkRmlsZUNvbnRl bnRzVGVzdCk6CiAgICAgICAgIHNlbGYuYXNzZXJ0R2VuZXJhdGVkRmlsZUNvbnRlbnRzRXF1YWwo ZmlsZV9jb250ZW50cywgX2V4cGVjdGVkX3JlY2VpdmVyX2ltcGxlbWVudGF0aW9uKQogCiAKK2Ns YXNzIFVuc3VwcG9ydGVkUHJlY29tcGlsZXJEaXJlY3RpdmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKKyAgICBkZWYgdGVzdF9lcnJvcl9hdF9lbHNlKHNlbGYpOgorICAgICAgICB3aXRoIHNlbGYu YXNzZXJ0UmFpc2VzUmVnZXhwKEV4Y2VwdGlvbiwgciJFUlJPUjogJyNlbHNlLionIGlzIG5vdCBz dXBwb3J0ZWQgaW4gdGhlIFwqXC5pbiBmaWxlcyIpOgorICAgICAgICAgICAgbWVzc2FnZXMuZ2Vu ZXJhdGVfbWVzc2FnZV9oYW5kbGVyKFN0cmluZ0lPKCJhc2RcbiNlbHNlIGJsYVxuZm9vIikpCisK KyAgICBkZWYgdGVzdF9lcnJvcl9hdF9lbGlmKHNlbGYpOgorICAgICAgICB3aXRoIHNlbGYuYXNz ZXJ0UmFpc2VzUmVnZXhwKEV4Y2VwdGlvbiwgciJFUlJPUjogJyNlbGlmLionIGlzIG5vdCBzdXBw b3J0ZWQgaW4gdGhlIFwqXC5pbiBmaWxlcyIpOgorICAgICAgICAgICAgbWVzc2FnZXMuZ2VuZXJh dGVfbWVzc2FnZV9oYW5kbGVyKFN0cmluZ0lPKCJhc2RcbiNlbGlmIGJsYVxuZm9vIikpCisKKwog aWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9wYXJzZXIucHkgYi9Tb3VyY2UvV2Vi S2l0Mi9TY3JpcHRzL3dlYmtpdDIvcGFyc2VyLnB5CmluZGV4IDU4Y2JlNWMuLmU0MWQ0ZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9wYXJzZXIucHkKKysrIGIv U291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL3BhcnNlci5weQpAQCAtNTksMTAgKzU5LDEz IEBAIGRlZiBwYXJzZShmaWxlKToKICAgICAgICAgICAgIGRlc3RpbmF0aW9uID0gbWF0Y2guZ3Jv dXAoJ2Rlc3RpbmF0aW9uJykKICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgIGlmIGxpbmUu c3RhcnRzd2l0aCgnIycpOgorICAgICAgICAgICAgdHJpbW1lZCA9IGxpbmUucnN0cmlwKCkKICAg ICAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgnI2lmICcpOgotICAgICAgICAgICAgICAgIGNv bmRpdGlvbnMuYXBwZW5kKGxpbmUucnN0cmlwKClbNDpdKQorICAgICAgICAgICAgICAgIGNvbmRp dGlvbnMuYXBwZW5kKHRyaW1tZWRbNDpdKQogICAgICAgICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dp dGgoJyNlbmRpZicpIGFuZCBjb25kaXRpb25zOgogICAgICAgICAgICAgICAgIGNvbmRpdGlvbnMu cG9wKCkKKyAgICAgICAgICAgIGVsaWYgbGluZS5zdGFydHN3aXRoKCcjZWxzZScpIG9yIGxpbmUu c3RhcnRzd2l0aCgnI2VsaWYnKToKKyAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIkVS Uk9SOiAnJXMnIGlzIG5vdCBzdXBwb3J0ZWQgaW4gdGhlICouaW4gZmlsZXMiICUgdHJpbW1lZCkK ICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKHInKFtBLVph LXpfMC05XSspXCgoLio/KVwpKD86KD86XHMrLT5ccyspXCgoLio/KVwpKT8oPzpccysoLiopKT8n LCBsaW5lKQogICAgICAgICBpZiBtYXRjaDoK