124145 2013-11-11 06:31:29 -0800 REGRESSION (r158774): Iteration over element children is broken 2013-11-17 13:36:17 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 yannick.poirier webkit-unassigned ap commit-queue esprehn+autocc gyuyoung.kim kling koivisto rniwa oldest_to_newest 949274 0 yannick.poirier 2013-11-11 06:31:29 -0800 The following test fails with the error line 14:41 : TypeError: null is not an object (evaluating 'frame.children[i].firstChild.innerHTML = "test"') The DOM tree seems to be corrupted after an innerHTML. <html> <head></head> <body> <div id="frame"> <div><div></div></div> <div><div></div></div> <div><div></div></div> <div><div></div></div> <div><div></div></div> </div> <script type="text/javascript"> frame = document.getElementById("frame"); for (var i = 0; i < frame.children.length; i++) frame.children[i].firstChild.innerHTML = "test"; </script> </body> </html> 949338 1 ap 2013-11-11 09:35:43 -0800 <rdar://problem/15437790> 951433 2 217151 koivisto 2013-11-17 12:51:16 -0800 Created attachment 217151 patch 951434 3 217151 andersca 2013-11-17 12:53:30 -0800 Comment on attachment 217151 patch View in context: https://bugs.webkit.org/attachment.cgi?id=217151&action=review > Source/WebCore/ChangeLog:12 > + Reducation by yannick.poirier@inverto.tv. Reduction? 951435 4 koivisto 2013-11-17 13:35:26 -0800 https://trac.webkit.org/r159389 951436 5 koivisto 2013-11-17 13:36:17 -0800 Thanks for the bug report and good reduction Yannick! 217151 2013-11-17 12:51:16 -0800 2013-11-17 12:53:30 -0800 patch htmlcollection-children-only-backwards.patch text/plain 4575 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTM4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTExLTE3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTU4Nzc0 KTogSXRlcmF0aW9uIG92ZXIgZWxlbWVudCBjaGlsZHJlbiBpcyBicm9rZW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE0NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTXV0YXRpb24gZHVy aW5nIHRyYXZlcnNhbCBpbnZhbGlkYXRlcyB0aGUgcG9zaXRpb24gY2FjaGUgYW5kIGFmdGVyIG1p ZC1wb2ludCB3ZSBzdGFydAorICAgICAgICB0cmF2ZXJzaW5nIGJhY2t3YXJkcyBhcyBpdCB0aGUg c2hvcnRlc3QgcGF0aC4gSG93ZXZlciBiYWNrd2FyZCB0cmF2ZXJzYWwgb2YgY2hpbGRyZW4tb25s eQorICAgICAgICBIVE1MQ29sbGVjdGlvbiB3YXMgYnVnZ3kgYW5kIHdvdWxkIHN0aWxsIGVuZCB1 cCBnb2luZyB0byBkZXNjZW5kYW50cy4KKyAgICAgICAgCisgICAgICAgIFJlZHVjYXRpb24gYnkg eWFubmljay5wb2lyaWVyQGludmVydG8udHYuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vaHRt bGNvbGxlY3Rpb24tY2hpbGRyZW4tbXV0YXRpb24uaHRtbAorCisgICAgICAgICogaHRtbC9IVE1M Q29sbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29sbGVjdGlvbjo6Y29sbGVj dGlvblRyYXZlcnNlQmFja3dhcmQpOgorICAgICAgICAKKyAgICAgICAgICAgIFRyYXZlcnNlIGRp cmVjdCBjaGlsZHJlbiBvbmx5IHdoZW4gbV9zaG91bGRPbmx5SW5jbHVkZURpcmVjdENoaWxkcmVu IGJpdCBpcyBzZXQuCisKIDIwMTMtMTEtMTcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgTW92ZSBMaW5lTGF5b3V0U3RhdGUuaCBpbnRvIHJlbmRlcmluZy9s aW5lCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmNwcAkocmV2aXNpb24g MTU5MzY5KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM1NCw2ICszNTQsMTEgQEAgRWxlbWVudCogSFRNTENvbGxlY3Rpb246OmNv bGxlY3Rpb25UcmF2ZQogICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBvcHRpbWl6ZWQgc2lt aWxhcmx5IHRvIHRoZSBmb3J3YXJkIGNhc2UuCiAgICAgYXV0byYgcm9vdCA9IHJvb3ROb2RlKCk7 CiAgICAgRWxlbWVudCogZWxlbWVudCA9ICZjdXJyZW50OworICAgIGlmIChtX3Nob3VsZE9ubHlJ bmNsdWRlRGlyZWN0Q2hpbGRyZW4pIHsKKyAgICAgICAgZm9yICg7IGNvdW50ICYmIGVsZW1lbnQg OyAtLWNvdW50KQorICAgICAgICAgICAgZWxlbWVudCA9IGl0ZXJhdGVGb3JQcmV2aW91c0VsZW1l bnQoRWxlbWVudFRyYXZlcnNhbDo6cHJldmlvdXNTaWJsaW5nKGVsZW1lbnQpKTsKKyAgICAgICAg cmV0dXJuIGVsZW1lbnQ7CisgICAgfQogICAgIGZvciAoOyBjb3VudCAmJiBlbGVtZW50IDsgLS1j b3VudCkKICAgICAgICAgZWxlbWVudCA9IGl0ZXJhdGVGb3JQcmV2aW91c0VsZW1lbnQoRWxlbWVu dFRyYXZlcnNhbDo6cHJldmlvdXMoZWxlbWVudCwgJnJvb3QpKTsKICAgICByZXR1cm4gZWxlbWVu dDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTM4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTExLTE3ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTU4Nzc0KTogSXRl cmF0aW9uIG92ZXIgZWxlbWVudCBjaGlsZHJlbiBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDE0NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24t Y2hpbGRyZW4tbXV0YXRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Rv bS9odG1sY29sbGVjdGlvbi1jaGlsZHJlbi1tdXRhdGlvbi5odG1sOiBBZGRlZC4KKwogMjAxMy0x MS0xNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxl IGxpbmUgcGF0aCBkb2VzIG5vdCByZXNwZWN0IHZpc2liaWxpdHk6aGlkZGVuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1jaGlsZHJlbi1tdXRhdGlvbi1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24t Y2hpbGRyZW4tbXV0YXRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24tY2hpbGRyZW4tbXV0YXRpb24tZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTUgQEAKK1Rlc3QgdHJhdmVyc2luZyBjaGlsZHJl biB1c2luZyBIVE1MQ29sbGVjdGlvbiB3aGlsZSBtdXRhdGluZyBET00KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2hpbGQuZmlyc3RDaGlsZC5pbm5lclRleHQgaXMgImNo aWxkIDAiCitQQVNTIGNoaWxkLmZpcnN0Q2hpbGQuaW5uZXJUZXh0IGlzICJjaGlsZCAxIgorUEFT UyBjaGlsZC5maXJzdENoaWxkLmlubmVyVGV4dCBpcyAiY2hpbGQgMiIKK1BBU1MgY2hpbGQuZmly c3RDaGlsZC5pbm5lclRleHQgaXMgImNoaWxkIDMiCitQQVNTIGNoaWxkLmZpcnN0Q2hpbGQuaW5u ZXJUZXh0IGlzICJjaGlsZCA0IgorUEFTUyBjaGlsZCBpcyBudWxsCitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vaHRtbGNvbGxlY3Rpb24tY2hpbGRyZW4tbXV0YXRpb24uaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1jaGlsZHJlbi1tdXRhdGlvbi5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24t Y2hpbGRyZW4tbXV0YXRpb24uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM1IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPGRpdiBpZD0idGVzdCIgc3R5bGU9ImRpc3BsYXk6bm9uZSI+Cis8ZGl2 PjxzcGFuPjwvc3Bhbj48L2Rpdj4KKzxkaXY+PHNwYW4+PC9zcGFuPjwvZGl2PgorPGRpdj48c3Bh bj48L3NwYW4+PC9kaXY+Cis8ZGl2PjxzcGFuPjwvc3Bhbj48L2Rpdj4KKzxkaXY+PHNwYW4+PC9z cGFuPjwvZGl2PgorPC9kaXY+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGVzdCB0cmF2ZXJz aW5nIGNoaWxkcmVuIHVzaW5nIEhUTUxDb2xsZWN0aW9uIHdoaWxlIG11dGF0aW5nIERPTSIpOwor Cit0cnkgewordmFyIHRlc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpOworZm9y ICh2YXIgaSA9IDA7IGkgPCB0ZXN0LmNoaWxkcmVuLmxlbmd0aDsgaSsrKQorICAgIHRlc3QuY2hp bGRyZW5baV0uZmlyc3RDaGlsZC5pbm5lckhUTUwgPSAiY2hpbGQgIiArIGk7Cit9IGNhdGNoKGUp IHt9CisKK3ZhciBjaGlsZCA9IHRlc3QuZmlyc3RFbGVtZW50Q2hpbGQ7Citmb3IgKHZhciBpID0g MDsgaSA8IDU7IGkrKykgeworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiY2hpbGQuZmlyc3RD aGlsZC5pbm5lclRleHQiLCAiY2hpbGQgIiArIGkpOworICAgIGNoaWxkID0gY2hpbGQubmV4dEVs ZW1lbnRTaWJsaW5nOworfQorc2hvdWxkQmVOdWxsKCJjaGlsZCIpOworCis8L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4K