124144 2013-11-11 06:00:34 -0800 [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py 2013-11-13 03:14:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d.nomiyama webkit-unassigned commit-queue glenn gustavo thorton oldest_to_newest 949268 0 d.nomiyama 2013-11-11 06:00:34 -0800 The list of GTK builders in Tools/Scripts/webkitpy/port/builders.py does not match the actual names in http://build.webkit.org/builders. 949269 1 216561 d.nomiyama 2013-11-11 06:05:08 -0800 Created attachment 216561 Patch 949270 2 216561 mario 2013-11-11 06:09:11 -0800 Comment on attachment 216561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216561&action=review > Tools/Scripts/webkitpy/port/builders.py:71 > "GTK Linux 64-bit Debug": {"port_name": "gtk", "is_debug": True}, This one's name is now "GTK Linux 64-bit Debug WK1". What about updating it too? 949276 3 d.nomiyama 2013-11-11 06:33:36 -0800 (In reply to comment #2) > (From update of attachment 216561 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216561&action=review > > Tools/Scripts/webkitpy/port/builders.py:71 > > "GTK Linux 64-bit Debug": {"port_name": "gtk", "is_debug": True}, > This one's name is now "GTK Linux 64-bit Debug WK1". What about updating it too? Sure, I'll update the patch. 949277 4 216564 d.nomiyama 2013-11-11 06:44:15 -0800 Created attachment 216564 Patch 949282 5 216564 mario 2013-11-11 06:49:49 -0800 Comment on attachment 216564 Patch Looks good to me, but I'd rather have someone more familiar with the python magic taking a look to it, in case we might be missing something. 949487 6 216564 gustavo 2013-11-11 16:41:01 -0800 Comment on attachment 216564 Patch LGTM! 949605 7 d.nomiyama 2013-11-12 01:29:50 -0800 (In reply to comment #6) > (From update of attachment 216564 [details]) > LGTM! Great! Thanks Gustavo. 949607 8 216564 commit-queue 2013-11-12 01:56:35 -0800 Comment on attachment 216564 Patch Rejecting attachment 216564 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216564, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit d2d6baf..9b6223e master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 159100 = d2d6baf839adc8e58564459b2aacd6c6d5b0e753 r159101 = 9b6223e3c25de7f39b567bb175b3e3ec4ad85e03 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/22539597 949659 9 216564 mario 2013-11-12 06:55:27 -0800 Comment on attachment 216564 Patch Let's give this another try now that SVN auth seems to be working fine again 949666 10 216564 commit-queue 2013-11-12 07:21:05 -0800 Comment on attachment 216564 Patch Clearing flags on attachment: 216564 Committed r159109: <http://trac.webkit.org/changeset/159109> 949667 11 commit-queue 2013-11-12 07:21:08 -0800 All reviewed patches have been landed. Closing bug. 949758 12 thorton 2013-11-12 11:31:18 -0800 I think this broke a webkitpy test: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/13504/steps/webkitpy-test/logs/stdio Looking into it. 949765 13 thorton 2013-11-12 11:38:32 -0800 (In reply to comment #12) > I think this broke a webkitpy test: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/13504/steps/webkitpy-test/logs/stdio > > Looking into it. Theoretically fixed in http://trac.webkit.org/changeset/159130. Do you guys not have any WK2 testers anymore? 950095 14 gustavo 2013-11-13 03:14:31 -0800 Thanks Tim, sorry for the trouble! Our 64 bits release bot is also a tester and it runs the wk2 tests. I think it may be a good idea to split the tests to help see build failures more easily, since our bot ends up being red most of the time because of layout tests being added that we don't pass or the like. 216561 2013-11-11 06:05:08 -0800 2013-11-11 06:44:09 -0800 Patch bug-124144-20131111140541.patch text/plain 1717 d.nomiyama U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU0YTYxMWI4MzM0NzQzOWRlMzEzNTZhZmZmMzA5MTc3 NTZjZjMzZi4uMTYxNjhjODQ0NWNmYmNmZTEyMjI2ZDcyMmI0NWMxMzU5ZjA0NWE4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTExLTExICBEZW5pcyBOb21peWFtYSAgPGQubm9taXlhbWFAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0dUS10gVXBkYXRlIEdUSyBidWlsZGVycyBpbiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvYnVpbGRlcnMucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZWQgdGhlIGxpc3Qgb2YgR1RLIGJ1aWxkZXJzIGluIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVycy5weQorICAgICAgICBhY2NvcmRpbmcgdG8g aHR0cDovL2J1aWxkLndlYmtpdC5vcmcvYnVpbGRlcnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3BvcnQvYnVpbGRlcnMucHk6CisKIDIwMTMtMTEtMDggIE1hdHRoZXcgSGFuc29uICA8 bWF0dGhld19oYW5zb25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZGVkIG15 c2VsZiBhcyBhIGNvbnRyaWJ1dG9yLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2J1aWxkZXJzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2J1aWxkZXJz LnB5CmluZGV4IDM3OTg3ZjQyYzBjOTZlNmU2Yzk1ODRhOThiODY0OTYyMGNlNzVkYjYuLjMyYjE2 ZTljNTQ5Njk1OTIwZGQzNTM4NzJiZTlkNWFiZDFmNTYyZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVycy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYnVpbGRlcnMucHkKQEAgLTY5LDggKzY5LDggQEAgX2V4YWN0X21hdGNoZXMgPSB7 CiAKICAgICAiR1RLIExpbnV4IDMyLWJpdCBSZWxlYXNlIjogeyJwb3J0X25hbWUiOiAiZ3RrIiwg ImlzX2RlYnVnIjogRmFsc2V9LAogICAgICJHVEsgTGludXggNjQtYml0IERlYnVnIjogeyJwb3J0 X25hbWUiOiAiZ3RrIiwgImlzX2RlYnVnIjogVHJ1ZX0sCi0gICAgIkdUSyBMaW51eCA2NC1iaXQg UmVsZWFzZSI6IHsicG9ydF9uYW1lIjogImd0ayIsICJpc19kZWJ1ZyI6IEZhbHNlfSwKLSAgICAi R1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIFdLMiAoVGVzdHMpIjogeyJwb3J0X25hbWUiOiAiZ3Rr LXdrMiIsICJpc19kZWJ1ZyI6IEZhbHNlfSwKKyAgICAiR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNl IjogeyJwb3J0X25hbWUiOiAiZ3RrLXdrMiIsICJpc19kZWJ1ZyI6IEZhbHNlfSwKKyAgICAiR1RL IExpbnV4IDY0LWJpdCBSZWxlYXNlIFdLMSAoVGVzdHMpIjogeyJwb3J0X25hbWUiOiAiZ3RrIiwg ImlzX2RlYnVnIjogRmFsc2V9LAogCiAgICAgIkVGTCBMaW51eCA2NC1iaXQgUmVsZWFzZSI6IHsi cG9ydF9uYW1lIjogImVmbCIsICJpc19kZWJ1ZyI6IEZhbHNlfSwKICAgICAiRUZMIExpbnV4IDY0 LWJpdCBSZWxlYXNlIFdLMiI6IHsicG9ydF9uYW1lIjogImVmbC13azIiLCAiaXNfZGVidWciOiBG YWxzZX0sCg== 216564 2013-11-11 06:44:15 -0800 2013-11-12 07:21:05 -0800 Patch bug-124144-20131111144447.patch text/plain 1908 d.nomiyama U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU0YTYxMWI4MzM0NzQzOWRlMzEzNTZhZmZmMzA5MTc3 NTZjZjMzZi4uMTYxNjhjODQ0NWNmYmNmZTEyMjI2ZDcyMmI0NWMxMzU5ZjA0NWE4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTExLTExICBEZW5pcyBOb21peWFtYSAgPGQubm9taXlhbWFAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0dUS10gVXBkYXRlIEdUSyBidWlsZGVycyBpbiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvYnVpbGRlcnMucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNDE0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZWQgdGhlIGxpc3Qgb2YgR1RLIGJ1aWxkZXJzIGluIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVycy5weQorICAgICAgICBhY2NvcmRpbmcgdG8g aHR0cDovL2J1aWxkLndlYmtpdC5vcmcvYnVpbGRlcnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3BvcnQvYnVpbGRlcnMucHk6CisKIDIwMTMtMTEtMDggIE1hdHRoZXcgSGFuc29uICA8 bWF0dGhld19oYW5zb25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZGVkIG15 c2VsZiBhcyBhIGNvbnRyaWJ1dG9yLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2J1aWxkZXJzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2J1aWxkZXJz LnB5CmluZGV4IDM3OTg3ZjQyYzBjOTZlNmU2Yzk1ODRhOThiODY0OTYyMGNlNzVkYjYuLjhlNzA1 OWE5NWVlNzYwOWNmMTc5MzJhMGMyNjlkOWY5M2E4MTk5MzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9idWlsZGVycy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYnVpbGRlcnMucHkKQEAgLTY4LDkgKzY4LDkgQEAgX2V4YWN0X21hdGNoZXMgPSB7 CiAgICAgIkFwcGxlIFdpbiA3IFJlbGVhc2UgKFRlc3RzKSI6IHsicG9ydF9uYW1lIjogIndpbi03 c3AwIiwgImlzX2RlYnVnIjogRmFsc2UsICJyZWJhc2VsaW5lX292ZXJyaWRlX2RpciI6ICJ3aW4i fSwKIAogICAgICJHVEsgTGludXggMzItYml0IFJlbGVhc2UiOiB7InBvcnRfbmFtZSI6ICJndGsi LCAiaXNfZGVidWciOiBGYWxzZX0sCi0gICAgIkdUSyBMaW51eCA2NC1iaXQgRGVidWciOiB7InBv cnRfbmFtZSI6ICJndGsiLCAiaXNfZGVidWciOiBUcnVlfSwKLSAgICAiR1RLIExpbnV4IDY0LWJp dCBSZWxlYXNlIjogeyJwb3J0X25hbWUiOiAiZ3RrIiwgImlzX2RlYnVnIjogRmFsc2V9LAotICAg ICJHVEsgTGludXggNjQtYml0IFJlbGVhc2UgV0syIChUZXN0cykiOiB7InBvcnRfbmFtZSI6ICJn dGstd2syIiwgImlzX2RlYnVnIjogRmFsc2V9LAorICAgICJHVEsgTGludXggNjQtYml0IERlYnVn IFdLMSI6IHsicG9ydF9uYW1lIjogImd0ayIsICJpc19kZWJ1ZyI6IFRydWV9LAorICAgICJHVEsg TGludXggNjQtYml0IFJlbGVhc2UiOiB7InBvcnRfbmFtZSI6ICJndGstd2syIiwgImlzX2RlYnVn IjogRmFsc2V9LAorICAgICJHVEsgTGludXggNjQtYml0IFJlbGVhc2UgV0sxIChUZXN0cykiOiB7 InBvcnRfbmFtZSI6ICJndGsiLCAiaXNfZGVidWciOiBGYWxzZX0sCiAKICAgICAiRUZMIExpbnV4 IDY0LWJpdCBSZWxlYXNlIjogeyJwb3J0X25hbWUiOiAiZWZsIiwgImlzX2RlYnVnIjogRmFsc2V9 LAogICAgICJFRkwgTGludXggNjQtYml0IFJlbGVhc2UgV0syIjogeyJwb3J0X25hbWUiOiAiZWZs LXdrMiIsICJpc19kZWJ1ZyI6IEZhbHNlfSwK