124140 2013-11-11 01:39:59 -0800 Do not shut down ImageDiff server after every diff during the tests. 2013-11-11 09:31:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned commit-queue glenn ossy oldest_to_newest 949241 0 tgergely.u-szeged 2013-11-11 01:39:59 -0800 There is a FIXME in image_diff.py: There is no need to shut down the ImageDiff server after every diff. 949244 1 216552 tgergely.u-szeged 2013-11-11 01:47:16 -0800 Created attachment 216552 Do not shut down ImageDiff server after every diff during the tests. 949261 2 216552 commit-queue 2013-11-11 03:42:59 -0800 Comment on attachment 216552 Do not shut down ImageDiff server after every diff during the tests. Rejecting attachment 216552 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216552, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/22938116 949262 3 ossy 2013-11-11 03:49:09 -0800 It seems svn.webkit.org has some issue, I tried and wasn't able to land it manually. I sent a mail to wms and bdash about the problem. 949327 4 216552 commit-queue 2013-11-11 09:31:13 -0800 Comment on attachment 216552 Do not shut down ImageDiff server after every diff during the tests. Clearing flags on attachment: 216552 Committed r159051: <http://trac.webkit.org/changeset/159051> 949328 5 commit-queue 2013-11-11 09:31:15 -0800 All reviewed patches have been landed. Closing bug. 216552 2013-11-11 01:47:16 -0800 2013-11-11 09:31:13 -0800 Do not shut down ImageDiff server after every diff during the tests. imagediff_server.patch text/plain 1324 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZTRh NjExLi4zODU0MmRjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTEtMTEgIFRhbWFzIEdlcmdlbHkgIDxnZXJ0 b21AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIERvIG5vdCBzaHV0IGRvd24gSW1hZ2VEaWZm IHNlcnZlciBhZnRlciBldmVyeSBkaWZmIGR1cmluZyB0aGUgdGVzdHMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQxNDAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3YXMgYSBGSVhNRTogVGhl cmUgaXMgbm8gbmVlZCB0byBzaHV0IGRvd24gdGhlIEltYWdlRGlmZgorICAgICAgICBzZXJ2ZXIg YWZ0ZXIgZXZlcnkgZGlmZi4gU2h1dGRvd24gaXMgcmVtb3ZlZCBmcm9tIHRoYXQgcG9pbnQuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW1hZ2VfZGlmZi5weToKKyAgICAgICAg KEltYWdlRGlmZmVyLl9yZWFkKToKKwogMjAxMy0xMS0wOCAgTWF0dGhldyBIYW5zb24gIDxtYXR0 aGV3X2hhbnNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkZWQgbXlzZWxm IGFzIGEgY29udHJpYnV0b3IuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvaW1hZ2VfZGlmZi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pbWFnZV9kaWZm LnB5CmluZGV4IDRmMWIwNTkuLmZhZTg5YzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9pbWFnZV9kaWZmLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9pbWFnZV9kaWZmLnB5CkBAIC0xMDAsOSArMTAwLDYgQEAgY2xhc3MgSW1hZ2VEaWZmZXIob2Jq ZWN0KToKICAgICAgICAgaWYgc2VsZi5fcHJvY2Vzcy5oYXNfY3Jhc2hlZCgpOgogICAgICAgICAg ICAgZXJyX3N0ciArPSAiSW1hZ2VEaWZmIGNyYXNoZWRcbiIKIAotICAgICAgICAjIEZJWE1FOiBU aGVyZSBpcyBubyBuZWVkIHRvIHNodXQgZG93biB0aGUgSW1hZ2VEaWZmIHNlcnZlciBhZnRlciBl dmVyeSBkaWZmLgotICAgICAgICBzZWxmLl9wcm9jZXNzLnN0b3AoKQotCiAgICAgICAgIGRpZmZf cGVyY2VudCA9IDAKICAgICAgICAgaWYgb3V0cHV0IGFuZCBvdXRwdXQuc3RhcnRzd2l0aCgnZGlm ZicpOgogICAgICAgICAgICAgbSA9IHJlLm1hdGNoKCdkaWZmOiAoLispJSAocGFzc2VkfGZhaWxl ZCknLCBvdXRwdXQpCg==