124133 2013-11-10 21:08:46 -0800 Clean up static_cast<Element*> usage 2013-11-11 20:37:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue esprehn+autocc kangil.han oldest_to_newest 949208 0 gyuyoung.kim 2013-11-10 21:08:46 -0800 We need to use toFoo cast function instead of static_cast<>. Though there is toElement() functions, static_cast<Element*> is still being used. 949209 1 216544 gyuyoung.kim 2013-11-10 21:10:26 -0800 Created attachment 216544 Patch 949529 2 216544 commit-queue 2013-11-11 20:37:27 -0800 Comment on attachment 216544 Patch Clearing flags on attachment: 216544 Committed r159092: <http://trac.webkit.org/changeset/159092> 949530 3 commit-queue 2013-11-11 20:37:30 -0800 All reviewed patches have been landed. Closing bug. 216544 2013-11-10 21:10:26 -0800 2013-11-11 20:37:27 -0800 Patch bug-124133-20131111141025.patch text/plain 3778 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU3NGMxYmEzYjZjMjI1 Mzk0N2I1NTM1MGQ4MDU1ZDkyNWVhMGRiMC4uZWU4ZWRlYThiYTY1NzEzOGQ0Zjc1MGY1MDAwZDMw ODA2Yzg3NTVlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTExLTEwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAg c3RhdGljX2Nhc3Q8RWxlbWVudCo+IHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQxMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRvIHVzZSB0b0ZvbyBjYXN0IGZ1bmN0aW9uIGlu c3RlYWQgb2Ygc3RhdGljX2Nhc3Q8Pi4gVGhvdWdoIHRoZXJlIGlzIHRvRWxlbWVudCgpLAorICAg ICAgICBzdGF0aWNfY2FzdDxFbGVtZW50Kj4gaXMgc3RpbGwgYmVpbmcgdXNlZC4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBiaW5kaW5n cy9nb2JqZWN0L1dlYktpdERPTVByaXZhdGUuY3BwOgorICAgICAgICAoV2ViS2l0Ojp3cmFwKToK KyAgICAgICAgKiBkb20vRWxlbWVudFRyYXZlcnNhbC5oOgorICAgICAgICAoV2ViQ29yZTo6Ojps YXN0V2l0aGluVGVtcGxhdGUpOgorICAgICAgICAoV2ViQ29yZTo6OjpuZXh0VGVtcGxhdGUpOgor ICAgICAgICAoV2ViQ29yZTo6OjpwcmV2aW91c1RlbXBsYXRlKToKKwogMjAxMy0xMS0xMCAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgY2hpbGRTaG91bGRDcmVh dGVSZW5kZXJlcigpIHRha2UgYSBOb2RlIHJlZmVyZW5jZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01Qcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NUHJpdmF0ZS5jcHAKaW5kZXggMDhlZmQ2ZTBm OWVhZDY3ZTcxYzhjZjUwMTQwMGNiMGE2NTIxNDQ1ZS4uODZkMGFhZTRmZjdkZWFlZjg5ZTk0ZmQy YjVkM2M0M2M2MGFiNGZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01Qcml2YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n b2JqZWN0L1dlYktpdERPTVByaXZhdGUuY3BwCkBAIC03OCw3ICs3OCw3IEBAIFdlYktpdERPTU5v ZGUqIHdyYXAoTm9kZSogbm9kZSkKICAgICBjYXNlIE5vZGU6OkVMRU1FTlRfTk9ERToKICAgICAg ICAgaWYgKG5vZGUtPmlzSFRNTEVsZW1lbnQoKSkKICAgICAgICAgICAgIHJldHVybiBXRUJLSVRf RE9NX05PREUod3JhcCh0b0hUTUxFbGVtZW50KG5vZGUpKSk7Ci0gICAgICAgIHJldHVybiBXRUJL SVRfRE9NX05PREUod3JhcEVsZW1lbnQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpKSk7Cisg ICAgICAgIHJldHVybiBXRUJLSVRfRE9NX05PREUod3JhcEVsZW1lbnQodG9FbGVtZW50KG5vZGUp KSk7CiAgICAgY2FzZSBOb2RlOjpBVFRSSUJVVEVfTk9ERToKICAgICAgICAgcmV0dXJuIFdFQktJ VF9ET01fTk9ERSh3cmFwQXR0cihzdGF0aWNfY2FzdDxBdHRyKj4obm9kZSkpKTsKICAgICBjYXNl IE5vZGU6OlRFWFRfTk9ERToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 VHJhdmVyc2FsLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFRyYXZlcnNhbC5oCmluZGV4 IDFlMzZhOWQ4ZTZmNGUxOWY3M2MyNjU4ODIwZmQ2MmQ1YjkxMGM3MzYuLjAzYTdjOThmMWMzMjI5 ZjI5NmU5ZDIxZWIyOWIwMjllYzBiODNkM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50VHJhdmVyc2FsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRUcmF2 ZXJzYWwuaApAQCAtMTA5LDcgKzEwOSw3IEBAIGlubGluZSBFbGVtZW50KiBUcmF2ZXJzYWw8RWxl bWVudD46Omxhc3RXaXRoaW5UZW1wbGF0ZShDdXJyZW50VHlwZSogY3VycmVudCkKICAgICBOb2Rl KiBub2RlID0gTm9kZVRyYXZlcnNhbDo6bGFzdChjdXJyZW50KTsKICAgICB3aGlsZSAobm9kZSAm JiAhbm9kZS0+aXNFbGVtZW50Tm9kZSgpKQogICAgICAgICBub2RlID0gTm9kZVRyYXZlcnNhbDo6 cHJldmlvdXMobm9kZSwgY3VycmVudCk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnQq Pihub2RlKTsKKyAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwogfQogCiB0ZW1wbGF0ZSA8PgpA QCAtMTE5LDcgKzExOSw3IEBAIGlubGluZSBFbGVtZW50KiBUcmF2ZXJzYWw8RWxlbWVudD46Om5l eHRUZW1wbGF0ZShDdXJyZW50VHlwZSogY3VycmVudCkKICAgICBOb2RlKiBub2RlID0gTm9kZVRy YXZlcnNhbDo6bmV4dChjdXJyZW50KTsKICAgICB3aGlsZSAobm9kZSAmJiAhbm9kZS0+aXNFbGVt ZW50Tm9kZSgpKQogICAgICAgICBub2RlID0gTm9kZVRyYXZlcnNhbDo6bmV4dFNraXBwaW5nQ2hp bGRyZW4obm9kZSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnQqPihub2RlKTsKKyAg ICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwogfQogCiB0ZW1wbGF0ZSA8PgpAQCAtMTI5LDcgKzEy OSw3IEBAIGlubGluZSBFbGVtZW50KiBUcmF2ZXJzYWw8RWxlbWVudD46Om5leHRUZW1wbGF0ZShD dXJyZW50VHlwZSogY3VycmVudCwgY29uc3QgTm9kCiAgICAgTm9kZSogbm9kZSA9IE5vZGVUcmF2 ZXJzYWw6Om5leHQoY3VycmVudCwgc3RheVdpdGhpbik7CiAgICAgd2hpbGUgKG5vZGUgJiYgIW5v ZGUtPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgbm9kZSA9IE5vZGVUcmF2ZXJzYWw6Om5leHRT a2lwcGluZ0NoaWxkcmVuKG5vZGUsIHN0YXlXaXRoaW4pOwotICAgIHJldHVybiBzdGF0aWNfY2Fz dDxFbGVtZW50Kj4obm9kZSk7CisgICAgcmV0dXJuIHRvRWxlbWVudChub2RlKTsKIH0KIAogdGVt cGxhdGUgPD4KQEAgLTEzOSw3ICsxMzksNyBAQCBpbmxpbmUgRWxlbWVudCogVHJhdmVyc2FsPEVs ZW1lbnQ+OjpwcmV2aW91c1RlbXBsYXRlKEN1cnJlbnRUeXBlKiBjdXJyZW50KQogICAgIE5vZGUq IG5vZGUgPSBOb2RlVHJhdmVyc2FsOjpwcmV2aW91cyhjdXJyZW50KTsKICAgICB3aGlsZSAobm9k ZSAmJiAhbm9kZS0+aXNFbGVtZW50Tm9kZSgpKQogICAgICAgICBub2RlID0gTm9kZVRyYXZlcnNh bDo6cHJldmlvdXMobm9kZSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnQqPihub2Rl KTsKKyAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwogfQogCiB0ZW1wbGF0ZSA8PgpAQCAtMTQ5 LDcgKzE0OSw3IEBAIGlubGluZSBFbGVtZW50KiBUcmF2ZXJzYWw8RWxlbWVudD46OnByZXZpb3Vz VGVtcGxhdGUoQ3VycmVudFR5cGUqIGN1cnJlbnQsIGNvbnN0CiAgICAgTm9kZSogbm9kZSA9IE5v ZGVUcmF2ZXJzYWw6OnByZXZpb3VzKGN1cnJlbnQsIHN0YXlXaXRoaW4pOwogICAgIHdoaWxlIChu b2RlICYmICFub2RlLT5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgIG5vZGUgPSBOb2RlVHJhdmVy c2FsOjpwcmV2aW91cyhub2RlLCBzdGF5V2l0aGluKTsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 RWxlbWVudCo+KG5vZGUpOworICAgIHJldHVybiB0b0VsZW1lbnQobm9kZSk7CiB9CiAKIC8vIEdl bmVyaWMgdmVyc2lvbnMuCg==