124131 2013-11-10 19:05:59 -0800 [EFL] Build break on Ubuntu 13.10 2013-11-10 20:56:44 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi benjamin cmarcelo commit-queue lucas.de.marchi oldest_to_newest 949197 0 ryuan.choi 2013-11-10 19:05:59 -0800 I got below errors on ubuntu 13.10. In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/gtest.h:57:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h:24, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:20: /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h: In function ‘const char* testing::internal::SkipComma(const char*)’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:650:28: error: ‘isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h’ was not declared in this scope while (isspace(*(++comma))) {} ^ /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:650:28: note: suggested alternative: In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebCore/config.h:80:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:19: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/DisallowCType.h:75:17: note: ‘std::isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h’ #define isspace isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h ^ make[2]: *** [Source/WebKit/CMakeFiles/ewkTestUtils.dir/efl/tests/UnitTestUtils/EWKTestEnvironment.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... 949198 1 216542 ryuan.choi 2013-11-10 19:24:44 -0800 Created attachment 216542 Patch 949202 2 216542 gyuyoung.kim 2013-11-10 20:26:16 -0800 Comment on attachment 216542 Patch Looks OK, But, isn't this better ? !(OS(DARWIN) && PLATFORM(GTK) && PLATFORM(EFL)) 949203 3 ryuan.choi 2013-11-10 20:29:00 -0800 (In reply to comment #2) > (From update of attachment 216542 [details]) > Looks OK, But, isn't this better ? > !(OS(DARWIN) && PLATFORM(GTK) && PLATFORM(EFL)) No, We are not based on OS(DARWIN). :) 949204 4 216542 gyuyoung.kim 2013-11-10 20:30:43 -0800 Comment on attachment 216542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216542&action=review > Source/WTF/wtf/DisallowCType.h:44 > +#if !(OS(DARWIN) && PLATFORM(GTK)) && !OS(QNX) && !PLATFORM(EFL) && !defined(_LIBCPP_VERSION) Ah, you're right. I mistook this condition. Go ahead ! 949206 5 216542 commit-queue 2013-11-10 20:56:41 -0800 Comment on attachment 216542 Patch Clearing flags on attachment: 216542 Committed r159037: <http://trac.webkit.org/changeset/159037> 949207 6 commit-queue 2013-11-10 20:56:44 -0800 All reviewed patches have been landed. Closing bug. 216542 2013-11-10 19:24:44 -0800 2013-11-10 20:56:41 -0800 Patch bug-124131-20131111122447.patch text/plain 1280 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDlhM2VlZGE0ODNlNjU5ZjZiMGU4MWY2 MDNhMDU0ZGYyYjRjNTI5NGMuLjNlNWJlOTg0YmEzM2ViY2ExYjk0NWFlNGI4NDhiN2I2M2Q0NThj NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTEtMTAgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEJ1aWxkIGJyZWFrIG9uIFVidW50dSAx My4xMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 MTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHVy bmVkIERpc2FsbG93Q1R5cGUgbWFjcm9zIG9mZiBvbiBFRkwgcG9ydCBiZWNhdXNlIGd0ZXN0LWlu dGVybmFsLmggdXNlcyBpc3NwYWNlKCkuCisKKyAgICAgICAgKiB3dGYvRGlzYWxsb3dDVHlwZS5o OiBBZGRlZCAhUExBVEZPUk0oRUZMKSBndWFyZC4KKwogMjAxMy0xMS0wOSAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIFJ1bkxvb3AgZnJvbSBX ZWJDb3JlIHRvIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRGlzYWxsb3dDVHlwZS5o IGIvU291cmNlL1dURi93dGYvRGlzYWxsb3dDVHlwZS5oCmluZGV4IDg5ZmMxNzBiMTQ4MDk1NjA0 MjZmYzQ0MjE1MWIxMjMxOGJkZThjZTQuLmQ2NjUzMGRhZTllMzA2NWZlODc4NTk4MDVjOGVjOTMz YTQ5NGE5NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Rpc2FsbG93Q1R5cGUuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi9EaXNhbGxvd0NUeXBlLmgKQEAgLTQxLDcgKzQxLDcgQEAKIC8vIG9y IDxnbGliL2dpMThuLWxpYi5oPiwgd2hpY2ggaW4gdHVybiBpbmNsdWRlIDx4bG9jYWxlL19jdHlw ZS5oPiB3aGljaCB1c2VzCiAvLyBpc2FjaWkoKS4gCiAjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+ Ci0jaWYgIShPUyhEQVJXSU4pICYmIFBMQVRGT1JNKEdUSykpICYmICFPUyhRTlgpICYmICFkZWZp bmVkKF9MSUJDUFBfVkVSU0lPTikKKyNpZiAhKE9TKERBUldJTikgJiYgUExBVEZPUk0oR1RLKSkg JiYgIU9TKFFOWCkgJiYgIVBMQVRGT1JNKEVGTCkgJiYgIWRlZmluZWQoX0xJQkNQUF9WRVJTSU9O KQogCiAjaW5jbHVkZSA8Y3R5cGUuaD4KIAo=