124108 2013-11-09 19:37:57 -0800 Use child iterator to find operators in RenderMathMLRow::layout(). 2013-11-26 16:24:01 -0800 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling bfulgham buildbot commit-queue dbarton eflews.bot esprehn+autocc fred.wang glenn gtk-ews gyuyoung.kim kling kondapallykalyan mrobinson rego+ews rniwa xan.lopez oldest_to_newest 949072 0 kling 2013-11-09 19:37:57 -0800 Use child iterator to find operators in RenderMathMLRow::layout(). 949073 1 216505 kling 2013-11-09 19:38:40 -0800 Created attachment 216505 Patch 949074 2 216505 eflews.bot 2013-11-09 19:43:06 -0800 Comment on attachment 216505 Patch Attachment 216505 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22368949 949075 3 216505 eflews.bot 2013-11-09 19:43:30 -0800 Comment on attachment 216505 Patch Attachment 216505 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22728916 949076 4 216506 kling 2013-11-09 19:44:57 -0800 Created attachment 216506 Patch 949077 5 216506 mrobinson 2013-11-09 19:47:55 -0800 Comment on attachment 216506 Patch All hail, childrenOfType! 949078 6 216506 eflews.bot 2013-11-09 19:49:55 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22768912 949079 7 216506 eflews.bot 2013-11-09 19:50:01 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22368952 949080 8 216506 gtk-ews 2013-11-09 19:54:34 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22598971 949085 9 216506 buildbot 2013-11-09 20:13:49 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22638976 949088 10 216506 buildbot 2013-11-09 20:30:21 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/21249024 949091 11 216506 buildbot 2013-11-09 20:41:25 -0800 Comment on attachment 216506 Patch Attachment 216506 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22868081 954368 12 bfulgham 2013-11-26 15:52:45 -0800 Committed r159794: <http://trac.webkit.org/changeset/159794> 954369 13 kling 2013-11-26 15:54:58 -0800 (In reply to comment #12) > Committed r159794: <http://trac.webkit.org/changeset/159794> Oh whoops. I forgot about this one. Thanks for landing it :) 954377 14 bfulgham 2013-11-26 16:24:01 -0800 (In reply to comment #13) > (In reply to comment #12) > > Committed r159794: <http://trac.webkit.org/changeset/159794> > > Oh whoops. I forgot about this one. Thanks for landing it :) Just cleaning up my MathML bug list! I fixed the minor build error with the patch. Build looks good at the moment, with no failures or new problems. 216505 2013-11-09 19:38:40 -0800 2013-11-09 19:44:57 -0800 Patch bug-124108.diff text/plain 1771 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDRlOThmLi4zYWZlYWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMTEtMDkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFVzZSBjaGlsZCBpdGVyYXRvciB0byBmaW5kIG9wZXJhdG9ycyBpbiBSZW5kZXJNYXRoTUxS b3c6OmxheW91dCgpLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI0MTA4PgorCisg ICAgICAgIFJlcGxhY2UgbWFudWFsIGNoaWxkcmVuIHdhbGsgd2l0aCBjaGlsZHJlbk9mVHlwZTxS ZW5kZXJNYXRoTUxCbG9jaz4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKIDIwMTMtMTEtMDkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBFbmNvZGUgZm9ybSBkYXRhIHVzaW5nIHRoZSBLZXllZEVuY29kZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcAppbmRl eCAxNzVmOWUzLi5mZTIzNDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv bWF0aG1sL1JlbmRlck1hdGhNTFJvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L21hdGhtbC9SZW5kZXJNYXRoTUxSb3cuY3BwCkBAIC03MCwxMiArNzAsMTEgQEAgdm9pZCBSZW5k ZXJNYXRoTUxSb3c6OmxheW91dCgpCiAgICAgICAgIHN0cmV0Y2hMb2dpY2FsSGVpZ2h0ID0gc3R5 bGUoKS5mb250U2l6ZSgpOwogICAgIAogICAgIC8vIFNldCB0aGUgc2l6ZXMgb2YgKHBvc3NpYmx5 IGVtYmVsbGlzaGVkKSBzdHJldGNoeSBvcGVyYXRvciBjaGlsZHJlbi4KLSAgICBmb3IgKFJlbmRl ck9iamVjdCogY2hpbGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0 U2libGluZygpKSB7Ci0gICAgICAgIGlmIChjaGlsZC0+aXNSZW5kZXJNYXRoTUxCbG9jaygpKSB7 Ci0gICAgICAgICAgICBpZiAoUmVuZGVyTWF0aE1MT3BlcmF0b3IqIHJlbmRlck1vID0gdG9SZW5k ZXJNYXRoTUxCbG9jayhjaGlsZCktPnVuZW1iZWxsaXNoZWRPcGVyYXRvcigpKSB7Ci0gICAgICAg ICAgICAgICAgaWYgKHJlbmRlck1vLT5zdHJldGNoSGVpZ2h0KCkgIT0gc3RyZXRjaExvZ2ljYWxI ZWlnaHQpCi0gICAgICAgICAgICAgICAgICAgIHJlbmRlck1vLT5zdHJldGNoVG9IZWlnaHQoc3Ry ZXRjaExvZ2ljYWxIZWlnaHQpOwotICAgICAgICAgICAgfQorICAgIGF1dG8gY2hpbGRyZW4gPSBj aGlsZHJlbk9mVHlwZTxSZW5kZXJNYXRoTUxCbG9jaz4oKnRoaXMpOworICAgIGZvciAoYXV0byBj aGlsZCA9IGNoaWxkcmVuLmJlZ2luKCksIGVuZCA9IGNoaWxkcmVuLmVuZCgpOyBjaGlsZCAhPSBl bmQ7ICsrY2hpbGQpIHsKKyAgICAgICAgaWYgKGF1dG8gcmVuZGVyTW8gPSBjaGlsZC0+dW5lbWJl bGxpc2hlZE9wZXJhdG9yKCkpIHsKKyAgICAgICAgICAgIGlmIChyZW5kZXJNby0+c3RyZXRjaEhl aWdodCgpICE9IHN0cmV0Y2hMb2dpY2FsSGVpZ2h0KQorICAgICAgICAgICAgICAgIHJlbmRlck1v LT5zdHJldGNoVG9IZWlnaHQoc3RyZXRjaExvZ2ljYWxIZWlnaHQpOwogICAgICAgICB9CiAgICAg fQogCg== 216506 2013-11-09 19:44:57 -0800 2013-11-09 20:41:25 -0800 Patch bug-124108.diff text/plain 1934 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDRlOThmLi4zYWZlYWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMTEtMDkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFVzZSBjaGlsZCBpdGVyYXRvciB0byBmaW5kIG9wZXJhdG9ycyBpbiBSZW5kZXJNYXRoTUxS b3c6OmxheW91dCgpLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI0MTA4PgorCisg ICAgICAgIFJlcGxhY2UgbWFudWFsIGNoaWxkcmVuIHdhbGsgd2l0aCBjaGlsZHJlbk9mVHlwZTxS ZW5kZXJNYXRoTUxCbG9jaz4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKIDIwMTMtMTEtMDkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBFbmNvZGUgZm9ybSBkYXRhIHVzaW5nIHRoZSBLZXllZEVuY29kZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcAppbmRl eCAxNzVmOWUzLi40Nzc0MGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv bWF0aG1sL1JlbmRlck1hdGhNTFJvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L21hdGhtbC9SZW5kZXJNYXRoTUxSb3cuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAi UmVuZGVyTWF0aE1MUm93LmgiCiAKICNpbmNsdWRlICJNYXRoTUxOYW1lcy5oIgorI2luY2x1ZGUg IlJlbmRlckl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAiUmVuZGVyTWF0aE1MT3BlcmF0b3IuaCIKIAog bmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNzAsMTIgKzcxLDExIEBAIHZvaWQgUmVuZGVyTWF0aE1M Um93OjpsYXlvdXQoKQogICAgICAgICBzdHJldGNoTG9naWNhbEhlaWdodCA9IHN0eWxlKCkuZm9u dFNpemUoKTsKICAgICAKICAgICAvLyBTZXQgdGhlIHNpemVzIG9mIChwb3NzaWJseSBlbWJlbGxp c2hlZCkgc3RyZXRjaHkgb3BlcmF0b3IgY2hpbGRyZW4uCi0gICAgZm9yIChSZW5kZXJPYmplY3Qq IGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmco KSkgewotICAgICAgICBpZiAoY2hpbGQtPmlzUmVuZGVyTWF0aE1MQmxvY2soKSkgewotICAgICAg ICAgICAgaWYgKFJlbmRlck1hdGhNTE9wZXJhdG9yKiByZW5kZXJNbyA9IHRvUmVuZGVyTWF0aE1M QmxvY2soY2hpbGQpLT51bmVtYmVsbGlzaGVkT3BlcmF0b3IoKSkgewotICAgICAgICAgICAgICAg IGlmIChyZW5kZXJNby0+c3RyZXRjaEhlaWdodCgpICE9IHN0cmV0Y2hMb2dpY2FsSGVpZ2h0KQot ICAgICAgICAgICAgICAgICAgICByZW5kZXJNby0+c3RyZXRjaFRvSGVpZ2h0KHN0cmV0Y2hMb2dp Y2FsSGVpZ2h0KTsKLSAgICAgICAgICAgIH0KKyAgICBhdXRvIGNoaWxkcmVuID0gY2hpbGRyZW5P ZlR5cGU8UmVuZGVyTWF0aE1MQmxvY2s+KCp0aGlzKTsKKyAgICBmb3IgKGF1dG8gY2hpbGQgPSBj aGlsZHJlbi5iZWdpbigpLCBlbmQgPSBjaGlsZHJlbi5lbmQoKTsgY2hpbGQgIT0gZW5kOyArK2No aWxkKSB7CisgICAgICAgIGlmIChhdXRvIHJlbmRlck1vID0gY2hpbGQtPnVuZW1iZWxsaXNoZWRP cGVyYXRvcigpKSB7CisgICAgICAgICAgICBpZiAocmVuZGVyTW8tPnN0cmV0Y2hIZWlnaHQoKSAh PSBzdHJldGNoTG9naWNhbEhlaWdodCkKKyAgICAgICAgICAgICAgICByZW5kZXJNby0+c3RyZXRj aFRvSGVpZ2h0KHN0cmV0Y2hMb2dpY2FsSGVpZ2h0KTsKICAgICAgICAgfQogICAgIH0KIAo=