124084 2013-11-08 16:40:07 -0800 getCueAsHTML() on an empty cue should return a document fragment 2013-11-08 17:12:21 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue esprehn+autocc glenn gyuyoung.kim jer.noble oldest_to_newest 948927 0 eric.carlson 2013-11-08 16:40:07 -0800 A cue with no text should return a valid document fragment 948934 1 216463 eric.carlson 2013-11-08 16:47:26 -0800 Created attachment 216463 Proposed patch 948938 2 216463 darin 2013-11-08 16:56:37 -0800 Comment on attachment 216463 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review > Source/WebCore/html/track/WebVTTParser.cpp:356 > + if (!text.length()) { Normally we’d use isEmpty here instead. 948945 3 eric.carlson 2013-11-08 17:11:48 -0800 (In reply to comment #2) > (From update of attachment 216463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review > > > Source/WebCore/html/track/WebVTTParser.cpp:356 > > + if (!text.length()) { > > Normally we’d use isEmpty here instead. Good point, fixed. 948947 4 eric.carlson 2013-11-08 17:12:14 -0800 Committed r158979: https://trac.webkit.org/r158979 216463 2013-11-08 16:47:26 -0800 2013-11-08 17:12:21 -0800 Proposed patch patch_1.txt text/plain 4446 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODk3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGdldEN1ZUFzSFRNTCgp IG9uIGFuIGVtcHR5IGN1ZSBzaG91bGQgcmV0dXJuIGEgZG9jdW1lbnQgZnJhZ21lbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDA4NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL3Ry YWNrL3RyYWNrLWN1ZS1lbXB0eS1jdWUtdGV4dC5odG1sCisKKyAgICAgICAgKiBodG1sL3RyYWNr L1dlYlZUVFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJWVFRQYXJzZXI6OmNyZWF0 ZURvY3VtZW50RnJhZ21lbnRGcm9tQ3VlVGV4dCk6IERvbid0IHJldHVybiBlYXJseSB3aGVuIHRo ZQorICAgICAgICAgICAgcGFzc2VkIGFuIGVtcHR5IHN0cmluZy4KKwogMjAxMy0xMS0wOCAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFRlYWNoIENhbnZhc09ic2VydmVy IGFib3V0IHJlZmVyZW5jZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svV2ViVlRU UGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1dlYlZU VFBhcnNlci5jcHAJKHJldmlzaW9uIDE1ODkzMCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJh Y2svV2ViVlRUUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ4LDEzICszNDgsMTYgQEAg UGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBXZWJWVFRQYXJzZQogICAgIC8vIDQuOC4xMC4x My40IFdlYlZUVCBjdWUgdGV4dCBwYXJzaW5nIHJ1bGVzIGFuZAogICAgIC8vIDQuOC4xMC4xMy41 IFdlYlZUVCBjdWUgdGV4dCBET00gY29uc3RydWN0aW9uIHJ1bGVzLgogCi0gICAgaWYgKCF0ZXh0 Lmxlbmd0aCgpKQotICAgICAgICByZXR1cm4gMDsKLQogICAgIEFTU0VSVChtX3NjcmlwdEV4ZWN1 dGlvbkNvbnRleHQtPmlzRG9jdW1lbnQoKSk7CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gdG9E b2N1bWVudChtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOwogICAgIAogICAgIFJlZlB0cjxEb2N1 bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IERvY3VtZW50RnJhZ21lbnQ6OmNyZWF0ZSgqZG9jdW1l bnQpOworCisgICAgaWYgKCF0ZXh0Lmxlbmd0aCgpKSB7CisgICAgICAgIGZyYWdtZW50LT5wYXJz ZXJBcHBlbmRDaGlsZChUZXh0OjpjcmVhdGUoKmRvY3VtZW50LCBlbXB0eVN0cmluZygpKSk7Cisg ICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAgfQorCiAgICAgbV9jdXJyZW50 Tm9kZSA9IGZyYWdtZW50OwogICAgIG1fdG9rZW5pemVyLT5yZXNldCgpOwogICAgIG1fdG9rZW4u Y2xlYXIoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODk3NykKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTExLTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGdldEN1ZUFzSFRNTCgp IG9uIGFuIGVtcHR5IGN1ZSBzaG91bGQgcmV0dXJuIGEgZG9jdW1lbnQgZnJhZ21lbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDA4NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdHJhY2sv dHJhY2stY3VlLWVtcHR5LWN1ZS10ZXh0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog bWVkaWEvdHJhY2svdHJhY2stY3VlLWVtcHR5LWN1ZS10ZXh0Lmh0bWw6IEFkZGVkLgorCiAyMDEz LTExLTA4ICBBbGV4YW5kcnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBJdCBzaG91bGQgYmUgcG9zc2libGUgdG8gZGVidWcgdGhlIEluc3Bl Y3RvciBjb2RlCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtZW1wdHkt Y3VlLXRleHQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3Ry YWNrL3RyYWNrLWN1ZS1lbXB0eS1jdWUtdGV4dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtZW1wdHktY3VlLXRleHQtZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMgQEAKK2dldEN1ZUFzSFRNTCgpIG9u IGFuIGVtcHR5IGN1ZSBzaG91bGQgcmV0dXJuIGEgdmFsaWQgZG9jdW1lbnQgZnJhZ21lbnQuCisK KworKiogVGhlIGdldEN1ZUFzSFRNTCgpIG1ldGhvZCBzaG91bGQgcmV0dXJuIGEgZG9jdW1lbnQg ZnJhZ21lbnQgKioKK0VYUEVDVEVEIChmcmFnbWVudCAhPSAnbnVsbCcpIE9LCisKKyoqIFRoZSBk b2N1bWVudCBmcmFnbWVudCBzaG91bGQgaGF2ZSBvbmUgY2hpbGQsIGFuIGVtcHR5IFRleHQgbm9k ZSAqKgorRVhQRUNURUQgKGZyYWdtZW50LmNoaWxkTm9kZXMubGVuZ3RoID09ICcxJykgT0sKK0VY UEVDVEVEIChmcmFnbWVudC5jaGlsZE5vZGVzWzBdLmxlbmd0aCA9PSAnMCcpIE9LCitFWFBFQ1RF RCAoZnJhZ21lbnQuY2hpbGROb2Rlc1swXS5jb25zdHJ1Y3Rvci5uYW1lID09ICd1bmRlZmluZWQn KSBPSworCitFTkQgT0YgVEVTVAorCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFj ay1jdWUtZW1wdHktY3VlLXRleHQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRp YS90cmFjay90cmFjay1jdWUtZW1wdHktY3VlLXRleHQuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1lbXB0eS1jdWUtdGV4dC5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMzIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAg PGhlYWQ+CisgICAgICAgIDxzY3JpcHQgc3JjPS4uL21lZGlhLWZpbGUuanM+PC9zY3JpcHQ+Cisg ICAgICAgIDxzY3JpcHQgc3JjPS4uL3ZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgICAgIDxz Y3JpcHQ+CisgICAgICAgIHZhciBmcmFnbWVudDsKKyAgICAgICAgZnVuY3Rpb24gc3RhcnRUZXN0 KCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFyIGVtcHR5Q3VlID0gbmV3IFRleHRUcmFja0N1 ZSgwLCAwLCAiIik7CisgICAgICAgICAgICBmcmFnbWVudCA9IGVtcHR5Q3VlLmdldEN1ZUFzSFRN TCgpOworCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIioqIFRoZSBnZXRDdWVBc0hUTUwoKSBt ZXRob2Qgc2hvdWxkIHJldHVybiBhIGRvY3VtZW50IGZyYWdtZW50ICoqIik7CisgICAgICAgICAg ICB0ZXN0RXhwZWN0ZWQoImZyYWdtZW50IiwgbnVsbCwgIiE9Iik7CisKKyAgICAgICAgICAgIGNv bnNvbGVXcml0ZSgiPGJyPioqIFRoZSBkb2N1bWVudCBmcmFnbWVudCBzaG91bGQgaGF2ZSBvbmUg Y2hpbGQsIGFuIGVtcHR5IFRleHQgbm9kZSAqKiIpOworICAgICAgICAgICAgdGVzdEV4cGVjdGVk KCJmcmFnbWVudC5jaGlsZE5vZGVzLmxlbmd0aCIsIDEpOworICAgICAgICAgICAgdGVzdEV4cGVj dGVkKCJmcmFnbWVudC5jaGlsZE5vZGVzWzBdLmxlbmd0aCIsIDApOworICAgICAgICAgICAgdGVz dEV4cGVjdGVkKCJmcmFnbWVudC5jaGlsZE5vZGVzWzBdLmNvbnN0cnVjdG9yLm5hbWUiLCBUZXh0 Lm5hbWUpOworCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOworCisgICAgICAgICAgICBl bmRUZXN0KCk7CisgICAgICAgICAgfQorICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisK KyAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0VGVzdCgpIj4KKyAgICAgICAgPHA+Z2V0Q3VlQXNIVE1M KCkgb24gYW4gZW1wdHkgY3VlIHNob3VsZCByZXR1cm4gYSB2YWxpZCBkb2N1bWVudCBmcmFnbWVu dC48L3A+CisgICAgICAgIDx2aWRlbyBjb250cm9scyAvPgorICAgIDwvYm9keT4KKzwvaHRtbD4K