124075 2013-11-08 15:13:01 -0800 REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars 2013-11-08 15:51:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue simon.fraser thorton oldest_to_newest 948868 0 simon.fraser 2013-11-08 15:13:01 -0800 REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars 948873 1 216450 simon.fraser 2013-11-08 15:16:03 -0800 Created attachment 216450 Patch 948874 2 simon.fraser 2013-11-08 15:16:27 -0800 <rdar://problem/15417068> 948880 3 216450 simon.fraser 2013-11-08 15:31:09 -0800 Comment on attachment 216450 Patch This is wrong. We don't need to avoid the double toggle if scrollbars are overlay. 948891 4 216450 simon.fraser 2013-11-08 15:43:52 -0800 Comment on attachment 216450 Patch On second thoughts, let's stick with this. We don't really know that the scrollbars are overlay until we try to make one. 948897 5 216450 commit-queue 2013-11-08 15:51:56 -0800 Comment on attachment 216450 Patch Clearing flags on attachment: 216450 Committed r158968: <http://trac.webkit.org/changeset/158968> 948898 6 commit-queue 2013-11-08 15:51:58 -0800 All reviewed patches have been landed. Closing bug. 216450 2013-11-08 15:16:03 -0800 2013-11-08 15:51:56 -0800 Patch bug-124075-20131108151602.patch text/plain 3081 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZmNjE1MmMxM2IwZjcx YzdmMWU1NjVjOGE3MzVmYWRlNjc4NTIzMi4uNzA5NzhiYzBhY2EzYzVmOGU0MDUyMzI2NzA2YTk2 ZWNkNDNjZjgwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEzLTExLTA4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04g KHIxNTU2NjApOiBTb21lIEV0aGVycGFkIHBhZ2VzIG5vdCBzY3JvbGxhYmxlIHdpdGggb3Zlcmxh eSBzY3JvbGxiYXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjQwNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIEluIHIxNTU2NjAgSSByZW1vdmVkIHNvbWUgc2Nyb2xsYmFyLXJlbGF0ZWQg bGF5b3V0cyB3aGVuIHNjcm9sbGJhcnMKKyAgICAgICAgYXJlIGluIG92ZXJsYXkgbW9kZS4KKyAg ICAgICAgCisgICAgICAgIEhvd2V2ZXIsIFNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9sbGJhcnMoKSBo YXMgYSBjYXNlIHdoZXJlIHdlIHN0aWxsIG5lZWQKKyAgICAgICAgdG8gZG8gbXVsdGlwbGUgcGFz ZXMsIHJlbGF0ZWQgdG8gaXRzICJOZXZlciBldmVyIHRyeSB0byBib3RoIGdhaW4vbG9zZSBhCisg ICAgICAgIHNjcm9sbGJhciBpbiB0aGUgc2FtZSBwYXNzIiBjb21tZW50LiBXaGVuIHdlIGF2b2lk IG1ha2luZyBhIG5ldyBzY3JvbGxiYXIKKyAgICAgICAgYmVjYXVzZSB0aGUgb3RoZXIgd2FzIHJl bW92ZWQsIHdlIG5lZWQgdG8gZG8gYW5vdGhlciBwYXNzIHRvIGJyaW5nIHRoZQorICAgICAgICBj b3JyZWN0IHNjcm9sbGJhciBiYWNrLgorCisgICAgICAgIENhbid0IHRlc3Qgb3ZlcmxheSBzY3Jv bGxiYXJzIGluIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKToKKworMjAxMy0x MS0wOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBM ZWZ0IHNpZGViYXIgb24gY3ViaWMtYmV6aWVyLmNvbSBmbGlja2VycwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMTI4CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXggM2YyYjY3OGU3MDU4ZThjNGUxYjBiODBmM2QxOGI5 YjdlY2VhMWIxZi4uYmJhZTNkZTg4ZjNiZGUzZjYwNTliZTQ1YmFjMTE4MTI3YjQ4YzdmOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTU1OSwxMCArNTU5LDE2IEBA IHZvaWQgU2Nyb2xsVmlldzo6dXBkYXRlU2Nyb2xsYmFycyhjb25zdCBJbnRTaXplJiBkZXNpcmVk T2Zmc2V0KQogCiAgICAgICAgIC8vIElmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwg YWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgogICAgICAgICAv LyB0cnkgdG8gYm90aCBnYWluL2xvc2UgYSBzY3JvbGxiYXIgaW4gdGhlIHNhbWUgcGFzcy4KLSAg ICAgICAgaWYgKCFuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyICYmIGhhc0hvcml6b250YWxTY3Jv bGxiYXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNPbikKKyAgICAgICAgYm9vbCBuZWVk QW5vdGhlclBhc3MgPSBmYWxzZTsKKyAgICAgICAgaWYgKCFuZXdIYXNIb3Jpem9udGFsU2Nyb2xs YmFyICYmIGhhc0hvcml6b250YWxTY3JvbGxiYXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdh eXNPbikgewogICAgICAgICAgICAgbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgPSBmYWxzZTsKLSAg ICAgICAgaWYgKCFuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhciAmJiBoYXNWZXJ0aWNhbFNjcm9sbGJh ciAmJiBoU2Nyb2xsICE9IFNjcm9sbGJhckFsd2F5c09uKQorICAgICAgICAgICAgbmVlZEFub3Ro ZXJQYXNzID0gdHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgIGlmICghbmV3SGFzVmVydGljYWxT Y3JvbGxiYXIgJiYgaGFzVmVydGljYWxTY3JvbGxiYXIgJiYgaFNjcm9sbCAhPSBTY3JvbGxiYXJB bHdheXNPbikgewogICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGZhbHNl OworICAgICAgICAgICAgbmVlZEFub3RoZXJQYXNzID0gdHJ1ZTsKKyAgICAgICAgfQogCiAgICAg ICAgIGlmIChoYXNIb3Jpem9udGFsU2Nyb2xsYmFyICE9IG5ld0hhc0hvcml6b250YWxTY3JvbGxi YXIgJiYgKGhhc0hvcml6b250YWxTY3JvbGxiYXIgfHwgIWF2b2lkU2Nyb2xsYmFyQ3JlYXRpb24o KSkpIHsKICAgICAgICAgICAgIGlmIChzY3JvbGxPcmlnaW4oKS55KCkgJiYgIW5ld0hhc0hvcml6 b250YWxTY3JvbGxiYXIpCkBAIC01OTAsNyArNTk2LDcgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRh dGVTY3JvbGxiYXJzKGNvbnN0IEludFNpemUmIGRlc2lyZWRPZmZzZXQpCiAgICAgICAgICAgICB9 CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoc2VuZENvbnRlbnRSZXNpemVkTm90aWZpY2F0aW9u ICYmIG1fdXBkYXRlU2Nyb2xsYmFyc1Bhc3MgPCBjTWF4VXBkYXRlU2Nyb2xsYmFyc1Bhc3MpIHsK KyAgICAgICAgaWYgKChzZW5kQ29udGVudFJlc2l6ZWROb3RpZmljYXRpb24gfHwgbmVlZEFub3Ro ZXJQYXNzKSAmJiBtX3VwZGF0ZVNjcm9sbGJhcnNQYXNzIDwgY01heFVwZGF0ZVNjcm9sbGJhcnNQ YXNzKSB7CiAgICAgICAgICAgICBtX3VwZGF0ZVNjcm9sbGJhcnNQYXNzKys7CiAgICAgICAgICAg ICBjb250ZW50c1Jlc2l6ZWQoKTsKICAgICAgICAgICAgIHZpc2libGVDb250ZW50c1Jlc2l6ZWQo KTsK