124048 2013-11-08 09:08:19 -0800 Cleanup the EFL --minimal build from unused parameters 2013-11-10 16:11:11 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mtiborinf webkit-unassigned cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 948681 0 mtiborinf 2013-11-08 09:08:19 -0800 There are some unused parameter, so they should be added to UNUSED_PARAM(); 948690 1 216403 mtiborinf 2013-11-08 09:27:32 -0800 Created attachment 216403 patch patch for unused parameters 948699 2 216404 mtiborinf 2013-11-08 09:48:26 -0800 Created attachment 216404 patch v2 The changes are same as in version 1, but changed the title to bugzilla link title 949186 3 216404 commit-queue 2013-11-10 16:11:09 -0800 Comment on attachment 216404 patch v2 Clearing flags on attachment: 216404 Committed r159033: <http://trac.webkit.org/changeset/159033> 949187 4 commit-queue 2013-11-10 16:11:11 -0800 All reviewed patches have been landed. Closing bug. 216403 2013-11-08 09:27:32 -0800 2013-11-08 09:48:26 -0800 patch efl.patch text/plain 2837 mtiborinf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwMTM1MzcyLi45ZmExN2E2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMTEtMDggIFRpYm9yIE1lc3phcm9zICA8bXRpYm9yQGluZi51 LXN6ZWdlZC5odT4KKworICAgICAgICBUaGVyZSB3ZXJlIHNvbWUgdW51c2VkIHBhcmFtZXRlciwg c28gdGhleSB3ZXJlIGFkZGVkIHRvIFVOVVNFRF9QQVJBTSgpOworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjpjcmVhdGVXaW5k b3cpOgorICAgICAgICAqIGV3ay9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRp bmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldCk6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoK KyAgICAgICAgKGV3a192aWV3X3Zpc2liaWxpdHlfc3RhdGVfc2V0KToKKyAgICAgICAgKGV3a192 aWV3X3Zpc2liaWxpdHlfc3RhdGVfZ2V0KToKKwogMjAxMy0xMS0wNSAgWGFiaWVyIFJvZHJpZ3Vl eiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFJl bW92ZSBOQVRJVkVfRlVMTFNDUkVFTl9WSURFTyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwIGIvU291cmNlL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAppbmRleCAwYmI3MmQy Li4yNDBhYzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0Nocm9tZUNsaWVudEVmbC5jcHAKQEAgLTE1NSw2ICsxNTUsOCBAQCBQYWdlKiBDaHJvbWVDbGll bnRFZmw6OmNyZWF0ZVdpbmRvdyhGcmFtZSogZnJhbWUsIGNvbnN0IEZyYW1lTG9hZFJlcXVlc3Qm LCBjb25zdAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBpZiAoZnJhbWUtPmRvY3Vt ZW50KCkgJiYgZnJhbWUtPmRvY3VtZW50KCktPndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVu dCgpKQogICAgICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+d2Via2l0Q2FuY2VsRnVsbFNjcmVlbigp OworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJhbWUpOwogI2VuZGlmCiAKICAgICBFdmFzX09i amVjdCogbmV3VmlldyA9IGV3a192aWV3X3dpbmRvd19jcmVhdGUobV92aWV3LCBFSU5BX1RSVUUs ICZmZWF0dXJlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRp bmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IDRj ZDQwMmYuLjNjM2Y2NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0 dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBA IC0xNDMsNiArMTQzLDggQEAgdm9pZCBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfc2V0 KGNvbnN0IGNoYXIqIHBhdGgpCiAjaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKICAgICBXZWJDb3Jl OjpEYXRhYmFzZU1hbmFnZXI6Om1hbmFnZXIoKS5zZXREYXRhYmFzZURpcmVjdG9yeVBhdGgoV1RG OjpTdHJpbmc6OmZyb21VVEY4KHBhdGgpKTsKICAgICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2Uo JnNfd2ViRGF0YWJhc2VQYXRoLCBwYXRoKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHBhdGgp OwogI2VuZGlmCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDYyMWY2NDMu LmJlMmJjNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtNDI1NSw2ICs0MjU1 LDkgQEAgRWluYV9Cb29sIGV3a192aWV3X3Zpc2liaWxpdHlfc3RhdGVfc2V0KEV2YXNfT2JqZWN0 KiBld2tWaWV3LCBFd2tfUGFnZV9WaXNpYmlsaXQKICAgICByZXR1cm4gdHJ1ZTsKICNlbHNlCiAg ICAgREJHKCJQQUdFX1ZJU0lCSUxJVFlfQVBJIGlzIGRpc2FibGVkLiIpOworICAgIFVOVVNFRF9Q QVJBTShld2tWaWV3KTsKKyAgICBVTlVTRURfUEFSQU0ocGFnZVZpc2liaWxpdHlTdGF0ZSk7Cisg ICAgVU5VU0VEX1BBUkFNKGluaXRpYWxTdGF0ZSk7CiAgICAgcmV0dXJuIGZhbHNlOwogI2VuZGlm CiB9CkBAIC00MjY4LDYgKzQyNzEsNyBAQCBFd2tfUGFnZV9WaXNpYmlsaXR5X1N0YXRlIGV3a192 aWV3X3Zpc2liaWxpdHlfc3RhdGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaQogICAgIHJl dHVybiBzdGF0aWNfY2FzdDxFd2tfUGFnZV9WaXNpYmlsaXR5X1N0YXRlPihwcml2LT5wYWdlLT52 aXNpYmlsaXR5U3RhdGUoKSk7CiAjZWxzZQogICAgIERCRygiUEFHRV9WSVNJQklMSVRZX0FQSSBp cyBkaXNhYmxlZC4iKTsKKyAgICBVTlVTRURfUEFSQU0oZXdrVmlldyk7CiAgICAgcmV0dXJuIEVX S19QQUdFX1ZJU0lCSUxJVFlfU1RBVEVfVklTSUJMRTsKICNlbmRpZgogfQo= 216404 2013-11-08 09:48:26 -0800 2013-11-10 16:11:09 -0800 patch v2 efl.patch text/plain 2820 mtiborinf ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwMTM1MzcyLi45ZmExN2E2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMTEtMDggIFRpYm9yIE1lc3phcm9zICA8bXRpYm9yQGluZi51 LXN6ZWdlZC5odT4KKworICAgICAgICBDbGVhbnVwIHRoZSBFRkwgLS1taW5pbWFsIGJ1aWxkIGZy b20gdW51c2VkIHBhcmFtZXRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNDA0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6Y3JlYXRlV2luZG93KToKKyAgICAgICAgKiBl d2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2Vf cGF0aF9zZXQpOgorICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmll d192aXNpYmlsaXR5X3N0YXRlX3NldCk6CisgICAgICAgIChld2tfdmlld192aXNpYmlsaXR5X3N0 YXRlX2dldCk6CisKIDIwMTMtMTEtMDUgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFy aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBSZW1vdmUgTkFUSVZFX0ZVTExT Q1JFRU5fVklERU8gc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKaW5kZXggMGJiNzJkMi4uMjQwYWMwMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwu Y3BwCkBAIC0xNTUsNiArMTU1LDggQEAgUGFnZSogQ2hyb21lQ2xpZW50RWZsOjpjcmVhdGVXaW5k b3coRnJhbWUqIGZyYW1lLCBjb25zdCBGcmFtZUxvYWRSZXF1ZXN0JiwgY29uc3QKICNpZiBFTkFC TEUoRlVMTFNDUkVFTl9BUEkpCiAgICAgaWYgKGZyYW1lLT5kb2N1bWVudCgpICYmIGZyYW1lLT5k b2N1bWVudCgpLT53ZWJraXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSkKICAgICAgICAgZnJh bWUtPmRvY3VtZW50KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyNlbHNlCisgICAgVU5V U0VEX1BBUkFNKGZyYW1lKTsKICNlbmRpZgogCiAgICAgRXZhc19PYmplY3QqIG5ld1ZpZXcgPSBl d2tfdmlld193aW5kb3dfY3JlYXRlKG1fdmlldywgRUlOQV9UUlVFLCAmZmVhdHVyZXMpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAppbmRleCA0Y2Q0MDJmLi4zYzNmNjc1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtMTQzLDYgKzE0Myw4IEBA IHZvaWQgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldChjb25zdCBjaGFyKiBwYXRo KQogI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCiAgICAgV2ViQ29yZTo6RGF0YWJhc2VNYW5hZ2Vy OjptYW5hZ2VyKCkuc2V0RGF0YWJhc2VEaXJlY3RvcnlQYXRoKFdURjo6U3RyaW5nOjpmcm9tVVRG OChwYXRoKSk7CiAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZzX3dlYkRhdGFiYXNlUGF0 aCwgcGF0aCk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShwYXRoKTsKICNlbmRpZgogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA2MjFmNjQzLi5iZTJiYzRmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTQyNTUsNiArNDI1NSw5IEBAIEVpbmFfQm9vbCBl d2tfdmlld192aXNpYmlsaXR5X3N0YXRlX3NldChFdmFzX09iamVjdCogZXdrVmlldywgRXdrX1Bh Z2VfVmlzaWJpbGl0CiAgICAgcmV0dXJuIHRydWU7CiAjZWxzZQogICAgIERCRygiUEFHRV9WSVNJ QklMSVRZX0FQSSBpcyBkaXNhYmxlZC4iKTsKKyAgICBVTlVTRURfUEFSQU0oZXdrVmlldyk7Cisg ICAgVU5VU0VEX1BBUkFNKHBhZ2VWaXNpYmlsaXR5U3RhdGUpOworICAgIFVOVVNFRF9QQVJBTShp bml0aWFsU3RhdGUpOwogICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogfQpAQCAtNDI2OCw2ICs0 MjcxLDcgQEAgRXdrX1BhZ2VfVmlzaWJpbGl0eV9TdGF0ZSBld2tfdmlld192aXNpYmlsaXR5X3N0 YXRlX2dldChjb25zdCBFdmFzX09iamVjdCogZXdrVmkKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 RXdrX1BhZ2VfVmlzaWJpbGl0eV9TdGF0ZT4ocHJpdi0+cGFnZS0+dmlzaWJpbGl0eVN0YXRlKCkp OwogI2Vsc2UKICAgICBEQkcoIlBBR0VfVklTSUJJTElUWV9BUEkgaXMgZGlzYWJsZWQuIik7Cisg ICAgVU5VU0VEX1BBUkFNKGV3a1ZpZXcpOwogICAgIHJldHVybiBFV0tfUEFHRV9WSVNJQklMSVRZ X1NUQVRFX1ZJU0lCTEU7CiAjZW5kaWYKIH0K