124046 2013-11-08 08:04:37 -0800 [WebGL] Removing unnecessary pointer checks 2014-01-10 10:19:00 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 p.szymanski3 webkit-unassigned bfulgham commit-queue dino esprehn+autocc gyuyoung.kim kondapallykalyan roger_fong webkit-bug-importer oldest_to_newest 948664 0 p.szymanski3 2013-11-08 08:04:37 -0800 When an array pointer is check with 0 it is not necessary to check it again 948665 1 216399 p.szymanski3 2013-11-08 08:09:26 -0800 Created attachment 216399 glbuffer 952341 2 216399 bfulgham 2013-11-19 17:39:37 -0800 Comment on attachment 216399 glbuffer View in context: https://bugs.webkit.org/attachment.cgi?id=216399&action=review True! Thanks for catching this. Can you revise the ChangeLog slightly per my comments? > Source/WebCore/ChangeLog:8 > + Pointer to array member can be check only once. It is not need The log message is a little incorrect. I think it should read: "The array argument does not need to checked for NULL more than once." 966418 3 216399 bfulgham 2014-01-10 10:12:22 -0800 Comment on attachment 216399 glbuffer r=me. I'll correct the change log while landing. 966420 4 webkit-bug-importer 2014-01-10 10:16:13 -0800 <rdar://problem/15793235> 966421 5 bfulgham 2014-01-10 10:19:00 -0800 Committed r161649: <http://trac.webkit.org/changeset/161649> 216399 2013-11-08 08:09:26 -0800 2014-01-10 10:12:22 -0800 glbuffer glbuffer.patch text/plain 1745 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNDI3NTNlLi5hMjk5M2RiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMTEtMDggIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtXZWJHTF0gUmVtb3ZpbmcgdW5uZWNlc3NhcnkgcG9pbnRlciBj aGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDA0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBv aW50ZXIgdG8gYXJyYXkgbWVtYmVyIGNhbiBiZSBjaGVjayBvbmx5IG9uY2UuIEl0IGlzIG5vdCBu ZWVkCisgICAgICAgIHRvIGNoZWNrIGl0IGFnYWluIGluIGZ1bmN0aW9uIHBhcmFtZXRlcnMuCisg ICAgICAgIFdlYktpdCBmdW5jdGlvbmFsaXR5IGlzIG5vdCBjaGFuZ2VkLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyBvbmVzLgorCisgICAgICAgICogaHRtbC9j YW52YXMvV2ViR0xCdWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xCdWZmZXI6OmFz c29jaWF0ZUJ1ZmZlckRhdGEpOgorCiAyMDEzLTExLTA4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBUZW1wbGF0ZWQgTENoYXIvVUNoYXIgcGF0aHMgZm9yIHNp bXBsZSBsaW5lIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xCdWZmZXIu Y3BwCmluZGV4IGI1ZDI1MGYuLjM0MjFlOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTEJ1ZmZlci5jcHAKQEAgLTEwMCwxNCArMTAwLDE0IEBAIGJvb2wgV2ViR0xCdWZmZXI6 OmFzc29jaWF0ZUJ1ZmZlckRhdGEoQXJyYXlCdWZmZXIqIGFycmF5KQogewogICAgIGlmICghYXJy YXkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gYXNzb2NpYXRlQnVmZmVyRGF0 YUltcGwoYXJyYXkgPyBhcnJheS0+ZGF0YSgpIDogMCwgYXJyYXkgPyBhcnJheS0+Ynl0ZUxlbmd0 aCgpIDogMCk7CisgICAgcmV0dXJuIGFzc29jaWF0ZUJ1ZmZlckRhdGFJbXBsKGFycmF5LT5kYXRh KCksIGFycmF5LT5ieXRlTGVuZ3RoKCkpOwogfQogCiBib29sIFdlYkdMQnVmZmVyOjphc3NvY2lh dGVCdWZmZXJEYXRhKEFycmF5QnVmZmVyVmlldyogYXJyYXkpCiB7CiAgICAgaWYgKCFhcnJheSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIHJldHVybiBhc3NvY2lhdGVCdWZmZXJEYXRhSW1w bChhcnJheSA/IGFycmF5LT5iYXNlQWRkcmVzcygpIDogMCwgYXJyYXkgPyBhcnJheS0+Ynl0ZUxl bmd0aCgpIDogMCk7CisgICAgcmV0dXJuIGFzc29jaWF0ZUJ1ZmZlckRhdGFJbXBsKGFycmF5LT5i YXNlQWRkcmVzcygpLCBhcnJheS0+Ynl0ZUxlbmd0aCgpKTsKIH0KIAogYm9vbCBXZWJHTEJ1ZmZl cjo6YXNzb2NpYXRlQnVmZmVyU3ViRGF0YUltcGwoR0MzRGludHB0ciBvZmZzZXQsIGNvbnN0IHZv aWQqIGRhdGEsIEdDM0RzaXplaXB0ciBieXRlTGVuZ3RoKQo=