124015 2013-11-07 14:49:04 -0800 Web Inspector: CSS Regions: Use a Map object to store the ContentFlows 2013-11-07 15:32:50 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 achicu achicu commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 948429 0 achicu 2013-11-07 14:49:04 -0800 Convert the existing Object based code to Map instead. 948430 1 webkit-bug-importer 2013-11-07 14:49:20 -0800 <rdar://problem/15418574> 948432 2 216335 achicu 2013-11-07 15:01:10 -0800 Created attachment 216335 Patch V1 948433 3 216335 joepeck 2013-11-07 15:06:45 -0800 Comment on attachment 216335 Patch V1 r=me 948444 4 216335 commit-queue 2013-11-07 15:32:49 -0800 Comment on attachment 216335 Patch V1 Clearing flags on attachment: 216335 Committed r158881: <http://trac.webkit.org/changeset/158881> 948445 5 commit-queue 2013-11-07 15:32:50 -0800 All reviewed patches have been landed. Closing bug. 216335 2013-11-07 15:01:10 -0800 2013-11-07 15:32:48 -0800 Patch V1 bug124015.v1.patch text/plain 4762 achicu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhjZDcyNjkuLjI1Mzk2ZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTExLTA3ICBBbGV4YW5kcnUgQ2hp Y3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBDU1Mg UmVnaW9uczogVXNlIGEgTWFwIG9iamVjdCB0byBzdG9yZSB0aGUgQ29udGVudEZsb3dzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQwMTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRoZSBP YmplY3QgaGFzaG1hcCB0byBhIE1hcCBiYXNlZCBoYXNobWFwIHdoZW4gc3RvcmluZyB0aGUgZmxv d3MgaW4gRE9NVHJlZU1hbmFnZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0RPTVRyZWVN YW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5wcm90b3R5cGUuZ2V0TmFtZWRGbG93Q29s bGVjdGlvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIucHJvdG90eXBl Lm5hbWVkRmxvd1JlbW92ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2Vy LnByb3RvdHlwZS5fc2VuZE5hbWVkRmxvd1VwZGF0ZUV2ZW50cyk6CisKKzIwMTMtMTEtMDcgIEFs ZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENTUyBSZWdpb25zOiBSZW1vdmluZyBhIGNvbnRlbnQgbm9kZSBvZiBhIENvbnRlbnRG bG93IGZyb20gdGhlIERPTSB3aWxsIHNlbmQgYSAwIG5vZGVJZAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTc3CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RPTVRyZWVNYW5hZ2VyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRE9NVHJlZU1hbmFnZXIuanMKaW5kZXggZDUw YjgxMy4uOTVjMDY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvRE9NVHJlZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvRE9NVHJlZU1hbmFnZXIuanMKQEAgLTM5LDcgKzM5LDcgQEAgV2ViSW5zcGVjdG9y LkRPTVRyZWVNYW5hZ2VyID0gZnVuY3Rpb24oKSB7CiAgICAgdGhpcy5faWRUb0RPTU5vZGUgPSB7 fTsKICAgICB0aGlzLl9kb2N1bWVudCA9IG51bGw7CiAgICAgdGhpcy5fYXR0cmlidXRlTG9hZE5v ZGVJZHMgPSB7fTsKLSAgICB0aGlzLl9mbG93cyA9IHt9OworICAgIHRoaXMuX2Zsb3dzID0gbmV3 IE1hcDsKICAgICB0aGlzLl9jb250ZW50Tm9kZXNUb0Zsb3dzTWFwID0gbmV3IE1hcDsKIH0KIApA QCAtNTcyLDEyICs1NzIsMTIgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZmxvd3MubGVuZ3RoOyArK2kp IHsKICAgICAgICAgICAgICAgICB2YXIgZmxvd1BheWxvYWQgPSBmbG93c1tpXTsKICAgICAgICAg ICAgICAgICB2YXIgZmxvd0tleSA9IFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5fZmxvd1Bh eWxvYWRIYXNoS2V5KGZsb3dQYXlsb2FkKTsKLSAgICAgICAgICAgICAgICB2YXIgY29udGVudEZs b3cgPSB0aGlzLl9mbG93c1tmbG93S2V5XTsKKyAgICAgICAgICAgICAgICB2YXIgY29udGVudEZs b3cgPSB0aGlzLl9mbG93cy5nZXQoZmxvd0tleSk7CiAgICAgICAgICAgICAgICAgaWYgKGNvbnRl bnRGbG93KQogICAgICAgICAgICAgICAgICAgICB0aGlzLl91cGRhdGVDb250ZW50Rmxvd0Zyb21Q YXlsb2FkKGNvbnRlbnRGbG93LCBmbG93UGF5bG9hZCk7CiAgICAgICAgICAgICAgICAgZWxzZSB7 CiAgICAgICAgICAgICAgICAgICAgIGNvbnRlbnRGbG93ID0gdGhpcy5fY3JlYXRlQ29udGVudEZs b3dGcm9tUGF5bG9hZChmbG93UGF5bG9hZCk7Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMuX2Zs b3dzW2Zsb3dLZXldID0gY29udGVudEZsb3c7CisgICAgICAgICAgICAgICAgICAgIHRoaXMuX2Zs b3dzLnNldChmbG93S2V5LCBjb250ZW50Rmxvdyk7CiAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgICAgIGNvbnRlbnRGbG93cy5wdXNoKGNvbnRlbnRGbG93KTsKICAgICAgICAgICAgIH0K QEAgLTU4OSwyNiArNTg5LDI2IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5wcm90b3R5 cGUgPSB7CiAgICAgbmFtZWRGbG93Q3JlYXRlZDogZnVuY3Rpb24oZmxvd1BheWxvYWQpCiAgICAg ewogICAgICAgICB2YXIgZmxvd0tleSA9IFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5fZmxv d1BheWxvYWRIYXNoS2V5KGZsb3dQYXlsb2FkKTsKLSAgICAgICAgY29uc29sZS5hc3NlcnQoIXRo aXMuX2Zsb3dzLmhhc093blByb3BlcnR5KGZsb3dLZXkpKTsKKyAgICAgICAgY29uc29sZS5hc3Nl cnQoIXRoaXMuX2Zsb3dzLmhhcyhmbG93S2V5KSk7CiAgICAgICAgIHZhciBjb250ZW50RmxvdyA9 IHRoaXMuX2NyZWF0ZUNvbnRlbnRGbG93RnJvbVBheWxvYWQoZmxvd1BheWxvYWQpOwotICAgICAg ICB0aGlzLl9mbG93c1tmbG93S2V5XSA9IGNvbnRlbnRGbG93OworICAgICAgICB0aGlzLl9mbG93 cy5zZXQoZmxvd0tleSwgY29udGVudEZsb3cpOwogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRU b0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIuRXZlbnQuQ29udGVudEZsb3dX YXNBZGRlZCwge2Zsb3c6IGNvbnRlbnRGbG93fSk7CiAgICAgfSwKIAogICAgIG5hbWVkRmxvd1Jl bW92ZWQ6IGZ1bmN0aW9uKGRvY3VtZW50Tm9kZUlkZW50aWZpZXIsIGZsb3dOYW1lKQogICAgIHsK ICAgICAgICAgdmFyIGZsb3dLZXkgPSBXZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIuX2Zsb3dQ YXlsb2FkSGFzaEtleSh7ZG9jdW1lbnROb2RlSWQ6IGRvY3VtZW50Tm9kZUlkZW50aWZpZXIsIG5h bWU6IGZsb3dOYW1lfSk7Ci0gICAgICAgIHZhciBjb250ZW50RmxvdyA9IHRoaXMuX2Zsb3dzW2Zs b3dLZXldOworICAgICAgICB2YXIgY29udGVudEZsb3cgPSB0aGlzLl9mbG93cy5nZXQoZmxvd0tl eSk7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGNvbnRlbnRGbG93KTsKLSAgICAgICAgZGVsZXRl IHRoaXMuX2Zsb3dzW2Zsb3dLZXldOworICAgICAgICB0aGlzLl9mbG93cy5kZWxldGUoZmxvd0tl eSk7CiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5E T01UcmVlTWFuYWdlci5FdmVudC5Db250ZW50Rmxvd1dhc1JlbW92ZWQsIHtmbG93OiBjb250ZW50 Rmxvd30pOwogICAgIH0sCiAKICAgICBfc2VuZE5hbWVkRmxvd1VwZGF0ZUV2ZW50czogZnVuY3Rp b24oZmxvd1BheWxvYWQpCiAgICAgewogICAgICAgICB2YXIgZmxvd0tleSA9IFdlYkluc3BlY3Rv ci5ET01UcmVlTWFuYWdlci5fZmxvd1BheWxvYWRIYXNoS2V5KGZsb3dQYXlsb2FkKTsKLSAgICAg ICAgY29uc29sZS5hc3NlcnQodGhpcy5fZmxvd3MuaGFzT3duUHJvcGVydHkoZmxvd0tleSkpOwot ICAgICAgICB0aGlzLl91cGRhdGVDb250ZW50Rmxvd0Zyb21QYXlsb2FkKHRoaXMuX2Zsb3dzW2Zs b3dLZXldLCBmbG93UGF5bG9hZCk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuX2Zsb3dz LmhhcyhmbG93S2V5KSk7CisgICAgICAgIHRoaXMuX3VwZGF0ZUNvbnRlbnRGbG93RnJvbVBheWxv YWQodGhpcy5fZmxvd3MuZ2V0KGZsb3dLZXkpLCBmbG93UGF5bG9hZCk7CiAgICAgfSwKIAogICAg IHJlZ2lvbkxheW91dFVwZGF0ZWQ6IGZ1bmN0aW9uKGZsb3dQYXlsb2FkKQpAQCAtNjI0LDEwICs2 MjQsMTAgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICBy ZWdpc3RlcmVkTmFtZWRGbG93Q29udGVudEVsZW1lbnQ6IGZ1bmN0aW9uKGRvY3VtZW50Tm9kZUlk ZW50aWZpZXIsIGZsb3dOYW1lLCBjb250ZW50Tm9kZUlkLCBuZXh0Q29udGVudEVsZW1lbnROb2Rl SWQpCiAgICAgewogICAgICAgICB2YXIgZmxvd0tleSA9IFdlYkluc3BlY3Rvci5ET01UcmVlTWFu YWdlci5fZmxvd1BheWxvYWRIYXNoS2V5KHtkb2N1bWVudE5vZGVJZDogZG9jdW1lbnROb2RlSWRl bnRpZmllciwgbmFtZTogZmxvd05hbWV9KTsKLSAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5f Zmxvd3MuaGFzT3duUHJvcGVydHkoZmxvd0tleSkpOworICAgICAgICBjb25zb2xlLmFzc2VydCh0 aGlzLl9mbG93cy5oYXMoZmxvd0tleSkpOwogICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5f Y29udGVudE5vZGVzVG9GbG93c01hcC5oYXMoY29udGVudE5vZGVJZCkpOwogCi0gICAgICAgIHZh ciBmbG93ID0gdGhpcy5fZmxvd3NbZmxvd0tleV07CisgICAgICAgIHZhciBmbG93ID0gdGhpcy5f Zmxvd3MuZ2V0KGZsb3dLZXkpOwogICAgICAgICB2YXIgY29udGVudE5vZGUgPSB0aGlzLm5vZGVG b3JJZChjb250ZW50Tm9kZUlkKTsKIAogICAgICAgICB0aGlzLl9jb250ZW50Tm9kZXNUb0Zsb3dz TWFwLnNldChjb250ZW50Tm9kZS5pZCwgZmxvdyk7Cg==