124014 2013-11-07 14:27:42 -0800 Remove a PLATFORM(IOS) from WebKit Private Header 2013-11-07 15:44:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck aestes commit-queue joepeck timothy oldest_to_newest 948425 0 joepeck 2013-11-07 14:27:42 -0800 We should not have PLATFORM(IOS) in exposed headers. 948426 1 joepeck 2013-11-07 14:28:04 -0800 <rdar://problem/15416587> 948427 2 216334 joepeck 2013-11-07 14:29:36 -0800 Created attachment 216334 [PATCH] Proposed Fix 948454 3 216334 commit-queue 2013-11-07 15:44:22 -0800 Comment on attachment 216334 [PATCH] Proposed Fix Clearing flags on attachment: 216334 Committed r158884: <http://trac.webkit.org/changeset/158884> 948455 4 commit-queue 2013-11-07 15:44:23 -0800 All reviewed patches have been landed. Closing bug. 216334 2013-11-07 14:29:36 -0800 2013-11-07 15:44:22 -0800 [PATCH] Proposed Fix proposed-fix.patch text/plain 6110 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwppbmRleCBkN2I4MjY1Li5hNTk2MzI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9pb3MvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTMtMTEtMDcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYSBQTEFURk9STShJT1MpIGZyb20gV2ViS2l0IFBy aXZhdGUgSGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjQwMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYktpdC5pT1MuZXhwOgorCiAyMDEzLTEwLTI5ICBBbmR5IEVzdGVzICA8YWVzdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBVcHN0cmVhbSBTb3VyY2UvV2ViS2l0L2lvcy8K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvaW9zL1dlYktpdC5pT1MuZXhwIGIvU291cmNlL1dl YktpdC9pb3MvV2ViS2l0LmlPUy5leHAKaW5kZXggOTkyNzBjNi4uOTJkNTFhOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9pb3MvV2ViS2l0LmlPUy5leHAKKysrIGIvU291cmNlL1dlYktpdC9p b3MvV2ViS2l0LmlPUy5leHAKQEAgLTM2LDggKzM2LDYgQEAgX1dlYlZpZXdQcm9ncmVzc0JhY2tn cm91bmRDb2xvcktleQogX1dlYlZpZXdQcm9ncmVzc0VzdGltYXRlZFByb2dyZXNzS2V5CiAKICMg Rm9yIFdlYkluc3BlY3RvciBub3RpZmljYXRpb25zCi1fV2ViSW5zcGVjdG9yRGlkU3RhcnRTZWFy Y2hpbmdGb3JOb2RlCi1fV2ViSW5zcGVjdG9yRGlkU3RvcFNlYXJjaGluZ0Zvck5vZGUKIF9fV2Vi Vmlld1JlbW90ZUluc3BlY3Rvckhhc1Nlc3Npb25DaGFuZ2VkTm90aWZpY2F0aW9uCiAKICMgV2Vi S2l0MSBpbnRlcm5hbCB0eXBlcyBleHBvc2VkIGZvciBXZWJLaXQyLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmlu ZGV4IDEzZmU3NGMuLmNhZGMyMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAor MjAxMy0xMS0wNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSBhIFBMQVRGT1JNKElPUykgZnJvbSBXZWJLaXQgUHJpdmF0ZSBIZWFkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDAxNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhlIHBy ZXZpb3VzbHkgaU9TIG9ubHkgV2ViSW5zcGVjdG9yRGlkU3RhcnRTZWFyY2hpbmdGb3JOb2RlCisg ICAgICAgIGFuZCBXZWJJbnNwZWN0b3JEaWRTdG9wU2VhcmNoaW5nRm9yTm9kZSBub3RpZmljYXRp b25zIG5vbiBpT1Mgc3BlY2lmaWMuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJbnNw ZWN0b3JDbGllbnQuaDoKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGll bnQubW06CisgICAgICAgIChXZWJJbnNwZWN0b3JDbGllbnQ6OmRpZFNldFNlYXJjaGluZ0Zvck5v ZGUpOgorICAgICAgICAqIFdlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3IuaDoKKyAgICAgICAgKiBX ZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9yLm1tOgorICAgICAgICAqIFdlYktpdC5leHA6CisKIDIw MTMtMTEtMDcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENvc21l dGljOiByZW5hbWUgeHh4SWQgdG8geHh4SUQgZm9yIFNjcmlwdElkLCBTb3VyY2VJZCwgYW5kIEJy ZWFrcG9pbnRJZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5oIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQv V2ViSW5zcGVjdG9yQ2xpZW50LmgKaW5kZXggNDRhOGIyYy4uNTUxYWY3ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgKKysr IGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgK QEAgLTczLDYgKzczLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBoaWdobGlnaHQoKSBP VkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgaGlkZUhpZ2hsaWdodCgpIE9WRVJSSURFOwogCisg ICAgdmlydHVhbCB2b2lkIGRpZFNldFNlYXJjaGluZ0Zvck5vZGUoYm9vbCkgT1ZFUlJJREU7CisK ICAgICB2aXJ0dWFsIGJvb2wgc2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGNvbnN0IFN0cmluZyYpIE9W RVJSSURFOwogCiAgICAgYm9vbCBpbnNwZWN0b3JTdGFydHNBdHRhY2hlZCgpOwpAQCAtOTcsMTAg Kzk5LDYgQEAgcHVibGljOgogICAgIGJvb2wgY2FuQmVSZW1vdGVseUluc3BlY3RlZCgpIGNvbnN0 OwogCiAgICAgV2ViVmlldyAqaW5zcGVjdGVkV2ViVmlldygpOwotCi0jaWYgUExBVEZPUk0oSU9T KQotICAgIHZpcnR1YWwgdm9pZCBkaWRTZXRTZWFyY2hpbmdGb3JOb2RlKGJvb2wpIE9WRVJSSURF IEZJTkFMOwotI2VuZGlmCiAjZW5kaWYKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJjZS9X ZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQppbmRleCBkMjA0 YWVhLi5lNDM4YzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1 cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCkBAIC0xOTcsNiArMTk3LDE4IEBAIHZvaWQgV2Vi SW5zcGVjdG9yQ2xpZW50OjpoaWRlSGlnaGxpZ2h0KCkKICAgICBbbV9oaWdobGlnaHRlci5nZXQo KSBoaWRlSGlnaGxpZ2h0XTsKIH0KIAordm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OmRpZFNldFNl YXJjaGluZ0Zvck5vZGUoYm9vbCBlbmFibGVkKQoreworICAgIFdlYkluc3BlY3RvciAqaW5zcGVj dG9yID0gW21fd2ViVmlldyBpbnNwZWN0b3JdOworCisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgp KTsKKworICAgIGlmIChlbmFibGVkKQorICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRl ZmF1bHRDZW50ZXJdIHBvc3ROb3RpZmljYXRpb25OYW1lOldlYkluc3BlY3RvckRpZFN0YXJ0U2Vh cmNoaW5nRm9yTm9kZSBvYmplY3Q6aW5zcGVjdG9yXTsKKyAgICBlbHNlCisgICAgICAgIFtbTlNO b3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcG9zdE5vdGlmaWNhdGlvbk5hbWU6V2Vi SW5zcGVjdG9yRGlkU3RvcFNlYXJjaGluZ0Zvck5vZGUgb2JqZWN0Omluc3BlY3Rvcl07Cit9CisK IHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpyZWxlYXNlRnJvbnRlbmQoKQogewogICAgIG1fZnJv bnRlbmRDbGllbnQgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViSW5zcGVj dG9yL1dlYkluc3BlY3Rvci5oIGIvU291cmNlL1dlYktpdC9tYWMvV2ViSW5zcGVjdG9yL1dlYklu c3BlY3Rvci5oCmluZGV4IGU5ZTIzMmUuLmZiMzI3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvbWFjL1dlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0L21h Yy9XZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9yLmgKQEAgLTI4LDEwICsyOCw4IEBACiAKICNpbXBv cnQgPEZvdW5kYXRpb24vTlNPYmplY3QuaD4KIAotI2lmIFBMQVRGT1JNKElPUykKIGV4dGVybiBO U1N0cmluZyAqV2ViSW5zcGVjdG9yRGlkU3RhcnRTZWFyY2hpbmdGb3JOb2RlOwogZXh0ZXJuIE5T U3RyaW5nICpXZWJJbnNwZWN0b3JEaWRTdG9wU2VhcmNoaW5nRm9yTm9kZTsKLSNlbmRpZgogCiBA Y2xhc3MgV2ViVmlldzsKIEBjbGFzcyBXZWJJbnNwZWN0b3JGcm9udGVuZDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3IubW0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9XZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9yLm1tCmluZGV4IDc5M2Y3NDEuLmUz MWJhOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkluc3BlY3Rvci9XZWJJbnNw ZWN0b3IubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViSW5zcGVjdG9yL1dlYkluc3BlY3Rv ci5tbQpAQCAtNiwxMyArNiwxMyBAQAogICogYXJlIG1ldDoKICAqCiAgKiAxLiAgUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAq ICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIuIAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KICAqIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5 IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAogICogICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKLSAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQg d2l0aCB0aGUgZGlzdHJpYnV0aW9uLiAKKyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhl ciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgogICogMy4gIE5laXRo ZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFt ZXMgb2YKICAqICAgICBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3Ig cHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCi0gKiAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhv dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyAqICAgICBmcm9tIHRoaXMg c29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCiAgKgog ICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9S UyAiQVMgSVMiIEFORCBBTlkKICAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNM VURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKQEAgLTM5LDEwICszOSw4IEBA CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCi0jaWYgUExBVEZPUk0oSU9TKQogTlNTdHJp bmcgKldlYkluc3BlY3RvckRpZFN0YXJ0U2VhcmNoaW5nRm9yTm9kZSA9IEAiV2ViSW5zcGVjdG9y RGlkU3RhcnRTZWFyY2hpbmdGb3JOb2RlIjsKIE5TU3RyaW5nICpXZWJJbnNwZWN0b3JEaWRTdG9w U2VhcmNoaW5nRm9yTm9kZSA9IEAiV2ViSW5zcGVjdG9yRGlkU3RvcFNlYXJjaGluZ0Zvck5vZGUi OwotI2VuZGlmCiAKIEBpbXBsZW1lbnRhdGlvbiBXZWJJbnNwZWN0b3IKIC0gKGlkKWluaXRXaXRo V2ViVmlldzooV2ViVmlldyAqKXdlYlZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFj L1dlYktpdC5leHAgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJLaXQuZXhwCmluZGV4IGRlOTE4ZjQu LmYzZmQyZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYktpdC5leHAKKysrIGIv U291cmNlL1dlYktpdC9tYWMvV2ViS2l0LmV4cApAQCAtOTUsNiArOTUsOCBAQCBfV2ViSWNvbk1l ZGl1bVNpemUKIF9XZWJJY29uTm90aWZpY2F0aW9uVXNlckluZm9VUkxLZXkKIF9XZWJJY29uU21h bGxTaXplCiBfV2ViSW5pdEZvckNhcmJvbgorX1dlYkluc3BlY3RvckRpZFN0YXJ0U2VhcmNoaW5n Rm9yTm9kZQorX1dlYkluc3BlY3RvckRpZFN0b3BTZWFyY2hpbmdGb3JOb2RlCiBfV2ViSW5zdGFs bE1lbW9yeVByZXNzdXJlSGFuZGxlcgogX1dlYktpdEVycm9yRG9tYWluCiBfV2ViS2l0RXJyb3JN SU1FVHlwZUtleQo=