124006 2013-11-07 11:27:55 -0800 returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s 2013-11-07 11:31:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 948357 0 msaboff 2013-11-07 11:27:55 -0800 returnFromJavaScript() in jit/ThunkGenerators.cpp which is responsible for restoring register state after a call to JavaScript code inadvertently has push() instead of pop() for the ARM_THUMB2 case. This is a copy/paste error from change set r158751: <http://trac.webkit.org/changeset/158751>. 948358 1 216321 msaboff 2013-11-07 11:30:40 -0800 Created attachment 216321 Patch for landing This patch has already been reviewed. 948359 2 msaboff 2013-11-07 11:31:26 -0800 Committed r158858: <http://trac.webkit.org/changeset/158858> 216321 2013-11-07 11:30:40 -0800 2013-11-07 11:30:40 -0800 Patch for landing 124006.patch text/plain 1847 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4ODU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTExLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIHJldHVybkZyb21KYXZhU2NyaXB0KCkgZm9yIEFSTV9USFVNQjIgdXNlcyBwdXNoKClzIHdo aWNoIHNob3VsZCBiZSBwb3AoKXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNDAwNgorCisgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IE1hcmsgSGFo bmVuYmVyZy4KKworICAgICAgICBDaGFuZ2VkIHRoZSBwdXNoKCkgY2FsbHMgdG8gcG9wKCkuCisK KyAgICAgICAgKiBqaXQvVGh1bmtHZW5lcmF0b3JzLmNwcDoKKyAgICAgICAgKEpTQzo6cmV0dXJu RnJvbUphdmFTY3JpcHQpOgorCiAyMDEzLTExLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZA YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBtb3Zpbmcgb2YgRVNQIHRvIEVD WCBpbiBjYWxsVG9KYXZhU2NyaXB0IGZvciBDT01QSUxFUihNU1ZDKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAkocmV2aXNpb24gMTU4ODU3 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTYsMTUgKzExNiwxNSBAQCBzdGF0aWMgdm9pZCByZXR1cm5Gcm9tSmF2 YVNjcmlwdChDQ2FsbEhlCiAjICAgZGVmaW5lIEVYVFJBX1NUQUNLX1NJWkUgICAgICAgICAgICAg IDI4CiAKICAgICBqaXQuYWRkUHRyKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKEVYVFJBX1NU QUNLX1NJWkUpLCBBUk1SZWdpc3RlcnM6OnNwKTsKLSAgICBqaXQucHVzaChBUk1SZWdpc3RlcnM6 OnIxMSk7Ci0gICAgaml0LnB1c2goQVJNUmVnaXN0ZXJzOjpyMTApOwotICAgIGppdC5wdXNoKEFS TVJlZ2lzdGVyczo6cjkpOwotICAgIGppdC5wdXNoKEFSTVJlZ2lzdGVyczo6cjgpOwotICAgIGpp dC5wdXNoKEFSTVJlZ2lzdGVyczo6cjcpOwotICAgIGppdC5wdXNoKEFSTVJlZ2lzdGVyczo6cjYp OwotICAgIGppdC5wdXNoKEFSTVJlZ2lzdGVyczo6cjUpOwotICAgIGppdC5wdXNoKEFSTVJlZ2lz dGVyczo6cjQpOwotICAgIGppdC5wdXNoKEFSTVJlZ2lzdGVyczo6bHIpOworICAgIGppdC5wb3Ao QVJNUmVnaXN0ZXJzOjpyMTEpOworICAgIGppdC5wb3AoQVJNUmVnaXN0ZXJzOjpyMTApOworICAg IGppdC5wb3AoQVJNUmVnaXN0ZXJzOjpyOSk7CisgICAgaml0LnBvcChBUk1SZWdpc3RlcnM6OnI4 KTsKKyAgICBqaXQucG9wKEFSTVJlZ2lzdGVyczo6cjcpOworICAgIGppdC5wb3AoQVJNUmVnaXN0 ZXJzOjpyNik7CisgICAgaml0LnBvcChBUk1SZWdpc3RlcnM6OnI1KTsKKyAgICBqaXQucG9wKEFS TVJlZ2lzdGVyczo6cjQpOworICAgIGppdC5wb3AoQVJNUmVnaXN0ZXJzOjpscik7CiAjZWxpZiBD UFUoQVJNNjQpCiAgICAgaml0LnBvcChBUk02NFJlZ2lzdGVyczo6eDI4KTsKICAgICBqaXQucG9w KEFSTTY0UmVnaXN0ZXJzOjp4MjcpOwo=