124001 2013-11-07 10:46:34 -0800 Web Inspector: switching sidebars does not persist a main resource / frame selection 2013-11-07 15:24:38 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 948334 0 timothy 2013-11-07 10:46:34 -0800 There are some representedObject issues preventing this from working. 948335 1 webkit-bug-importer 2013-11-07 10:46:59 -0800 <rdar://problem/15415825> 948337 2 216313 timothy 2013-11-07 10:49:46 -0800 Created attachment 216313 Patch 948431 3 216313 joepeck 2013-11-07 14:58:02 -0800 Comment on attachment 216313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216313&action=review r=me > Source/WebInspectorUI/ChangeLog:6 > + as you switch between frames and main reources. Also fix some null checks that are Typo: "reources" => "resources" 948440 4 216313 commit-queue 2013-11-07 15:24:37 -0800 Comment on attachment 216313 Patch Clearing flags on attachment: 216313 Committed r158879: <http://trac.webkit.org/changeset/158879> 948441 5 commit-queue 2013-11-07 15:24:38 -0800 All reviewed patches have been landed. Closing bug. 216313 2013-11-07 10:49:46 -0800 2013-11-07 15:24:36 -0800 Patch bug-124001-20131107104946.patch text/plain 6203 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj NWZjNDc3NTA0Y2E1ODA1YzJmNjA2N2UwYmQ4ZjFlOTQ2YTg3MzJhLi42YmRiMzgyN2NkMTk3Mjcz MWNhNDRmZDliNjlmYzU5OWZhZjE1MDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxMy0xMS0wNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgRml4IHVwIHNvbWUgc2lkZWJhciBzd2l0Y2hpbmcgZGV0YWlscyB0byBt YWtlIHNlbGVjdGlvbnMgcGVyc2lzdCBiZXR0ZXIuCisKKyAgICAgICAgVHJhbnNsYXRlIHJlcHJl c2VudGVkIG9iamVjdHMgYmV0d2VlbiBzaWRlYmFycyBzbyB0aGUgc2FtZSBpdGVtIGNhbiBiZSBy ZXNlbGVjdGVkCisgICAgICAgIGFzIHlvdSBzd2l0Y2ggYmV0d2VlbiBmcmFtZXMgYW5kIG1haW4g cmVvdXJjZXMuIEFsc28gZml4IHNvbWUgbnVsbCBjaGVja3MgdGhhdCBhcmUKKyAgICAgICAgbmVl ZGVkIG9uIHNlbGVjdGVkU2lkZWJhclBhbmVsLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQwMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWdnZXJTaWRlYmFyUGFu ZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90 eXBlLnRyZWVFbGVtZW50Rm9yUmVwcmVzZW50ZWRPYmplY3QpOiBBZGRlZC4gVHJhbnNsYXRlIGEg RnJhbWUKKyAgICAgICAgcmVwcmVzZW50ZWRPYmplY3QgaW50byBhIG1haW4gcmVzb3VyY2UgcmVw cmVzZW50ZWRPYmplY3QuCisgICAgICAgICogVXNlckludGVyZmFjZS9NYWluLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLl9yZXZlYWxBbmRTZWxlY3RSZXByZXNlbnRlZE9iamVjdEluTmF2aWdh dGlvblNpZGViYXIpOiBOdWxsIGNoZWNrIHNlbGVjdGVkU2lkZWJhclBhbmVsLgorICAgICAgICAo V2ViSW5zcGVjdG9yLl91cGRhdGVOYXZpZ2F0aW9uU2lkZWJhckZvckN1cnJlbnRDb250ZW50Vmll dyk6IEZpeCBhIGxvZ2ljIGVycm9yIHRvIG1hdGNoIG90aGVyIGNvZGUuCisgICAgICAgIGFsbG93 ZWROYXZpZ2F0aW9uU2lkZWJhclBhbmVscy5sZW5ndGggbmVlZHMgdG8gaGF2ZSBhIGxlbmd0aCBi ZWZvcmUgdXNpbmcgY29udGFpbnMuCisgICAgICAgIChXZWJJbnNwZWN0b3IuX2NvbnRlbnRCcm93 c2VyQ3VycmVudENvbnRlbnRWaWV3RGlkQ2hhbmdlKTogTnVsbCBjaGVjayBzZWxlY3RlZFNpZGVi YXJQYW5lbC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZS50 cmVlRWxlbWVudEZvclJlcHJlc2VudGVkT2JqZWN0KTogVHJhbnNsYXRlIGEgbWFpbiByZXNvdXJj ZQorICAgICAgICByZXByZXNlbnRlZE9iamVjdCBpbnRvIGEgRnJhbWUgcmVwcmVzZW50ZWRPYmpl Y3QuCisKIDIwMTMtMTEtMDYgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgog CiAgICAgICAgIFByb3Blcmx5IG51bGwgY2hlY2sgcG9zaXRpb25Ub1JldmVhbCBpbiBSZXNvdXJj ZVNpZGViYXJQYW5lbC5wcm90b3R5cGUuc2hvd1NvdXJjZUNvZGUuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyU2lkZWJhclBhbmVs LmpzCmluZGV4IDU0ZDE2MmYzOGMwNTNlOGEyNzhjMWNmNDA1YWE2NzgwYzExOTBjNDQuLjQ0Mjg0 NGM4Y2Y5NjhkYzBmYWM2MDUyNzkyODNlMTMxM2I5OGFkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnZ2VyU2lkZWJhclBhbmVs LmpzCkBAIC0xMjMsNiArMTIzLDE3IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGViYXJQYW5l bC5FeGNlcHRpb25JY29uU3R5bGVDbGFzc05hbWUgPSAiYnJlYWtwb2ludC1leGNlCiBXZWJJbnNw ZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlID0gewogICAgIGNvbnN0cnVjdG9y OiBXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwsCiAKKyAgICAvLyBQdWJsaWMKKwor ICAgIHRyZWVFbGVtZW50Rm9yUmVwcmVzZW50ZWRPYmplY3Q6IGZ1bmN0aW9uKHJlcHJlc2VudGVk T2JqZWN0KQorICAgIHsKKyAgICAgICAgLy8gVGhlIG1haW4gcmVzb3VyY2UgaXMgdXNlZCBhcyB0 aGUgcmVwcmVzZW50ZWRPYmplY3QgaW5zdGVhZCBvZiBGcmFtZSBpbiBvdXIgdHJlZS4KKyAgICAg ICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkZyYW1lKQor ICAgICAgICAgICAgcmVwcmVzZW50ZWRPYmplY3QgPSByZXByZXNlbnRlZE9iamVjdC5tYWluUmVz b3VyY2U7CisKKyAgICAgICAgcmV0dXJuIHRoaXMuY29udGVudFRyZWVPdXRsaW5lLmdldENhY2hl ZFRyZWVFbGVtZW50KHJlcHJlc2VudGVkT2JqZWN0KTsKKyAgICB9LAorCiAgICAgLy8gUHJpdmF0 ZQogCiAgICAgX2RlYnVnZ2VyUGF1c2VSZXN1bWVCdXR0b25DbGlja2VkOiBmdW5jdGlvbihldmVu dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4u anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpzCmluZGV4IDg5 ZmIyNzNiNGM5ZGVmNWE4MGY4YjhmMmI2ZWE1OGVlZTFkOGVhZjYuLmU1ZTY2Njk0ODYzZTQyYzY3 ZDVmMjIzMzQxOGI0YmVlY2JkOGVkZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTWFpbi5qcwpAQCAtODgyLDYgKzg4Miw4IEBAIFdlYkluc3BlY3Rvci5fcmV2ZWFs QW5kU2VsZWN0UmVwcmVzZW50ZWRPYmplY3RJbk5hdmlnYXRpb25TaWRlYmFyID0gZnVuY3Rpb24o cmVwCiAgICAgICAgIHJldHVybjsKIAogICAgIHZhciBzZWxlY3RlZFNpZGViYXJQYW5lbCA9IHRo aXMubmF2aWdhdGlvblNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWw7CisgICAgaWYgKCFzZWxl Y3RlZFNpZGViYXJQYW5lbCkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gSWYgdGhlIHRyZWUg b3V0bGluZSBpcyBwcm9jZXNzaW5nIGEgc2VsZWN0aW9uIGN1cnJlbnRseSB0aGVuIHdlIGNhbiBh c3N1bWUgdGhlIHNlbGVjdGlvbiBkb2VzIG5vdAogICAgIC8vIG5lZWQgdG8gYmUgY2hhbmdlZC4g VGhpcyBpcyBuZWVkZWQgdG8gYWxsb3cgYnJlYWtwb2ludHMgdHJlZSBlbGVtZW50cyB0byBiZSBz ZWxlY3RlZCB3aXRob3V0IGp1bXBpbmcKQEAgLTkxMiw3ICs5MTQsNyBAQCBXZWJJbnNwZWN0b3Iu X3VwZGF0ZU5hdmlnYXRpb25TaWRlYmFyRm9yQ3VycmVudENvbnRlbnRWaWV3ID0gZnVuY3Rpb24o KQogICAgIC8vIEVuc3VyZSB0aGUgbmF2aWdhdGlvbiBzaWRlYmFyIHBhbmVsIGlzIGFsbG93ZWQg YnkgdGhlIGN1cnJlbnQgY29udGVudCB2aWV3LCBpZiBub3QgYXNrIHRoZSBzaWRlYmFyIHBhbmVs CiAgICAgLy8gdG8gc2hvdyB0aGUgY29udGVudCB2aWV3IGZvciB0aGUgY3VycmVudCBzZWxlY3Rp b24uCiAgICAgdmFyIGFsbG93ZWROYXZpZ2F0aW9uU2lkZWJhclBhbmVscyA9IGN1cnJlbnRDb250 ZW50Vmlldy5hbGxvd2VkTmF2aWdhdGlvblNpZGViYXJQYW5lbHM7Ci0gICAgaWYgKCFhbGxvd2Vk TmF2aWdhdGlvblNpZGViYXJQYW5lbHMuY29udGFpbnMoc2VsZWN0ZWRTaWRlYmFyUGFuZWwuaWRl bnRpZmllcikpIHsKKyAgICBpZiAoYWxsb3dlZE5hdmlnYXRpb25TaWRlYmFyUGFuZWxzLmxlbmd0 aCAmJiAhYWxsb3dlZE5hdmlnYXRpb25TaWRlYmFyUGFuZWxzLmNvbnRhaW5zKHNlbGVjdGVkU2lk ZWJhclBhbmVsLmlkZW50aWZpZXIpKSB7CiAgICAgICAgIHNlbGVjdGVkU2lkZWJhclBhbmVsLnNo b3dDb250ZW50Vmlld0ZvckN1cnJlbnRTZWxlY3Rpb24oKTsKIAogICAgICAgICAvLyBGZXRjaCB0 aGUgY3VycmVudCBjb250ZW50IHZpZXcgYWdhaW4sIHNpbmNlIGl0IGxpa2VseSBjaGFuZ2VkLgpA QCAtMTA0NCw5ICsxMDQ2LDEzIEBAIFdlYkluc3BlY3Rvci5fY29udGVudEJyb3dzZXJDdXJyZW50 Q29udGVudFZpZXdEaWRDaGFuZ2UgPSBmdW5jdGlvbihldmVudCkKICAgICBpZiAoIWN1cnJlbnRD b250ZW50VmlldykKICAgICAgICAgcmV0dXJuOwogCisgICAgdmFyIHNlbGVjdGVkU2lkZWJhclBh bmVsID0gdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5zZWxlY3RlZFNpZGViYXJQYW5lbDsKKyAgICBp ZiAoIXNlbGVjdGVkU2lkZWJhclBhbmVsKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBFbnN1 cmUgdGhlIG5hdmlnYXRpb24gc2lkZWJhciBwYW5lbCBpcyBhbGxvd2VkIGJ5IHRoZSBjdXJyZW50 IGNvbnRlbnQgdmlldywgaWYgbm90IGNoYW5nZSB0aGUgbmF2aWdhdGlvbiBzaWRlYmFyIHBhbmVs CiAgICAgLy8gdG8gdGhlIGxhc3QgbmF2aWdhdGlvbiBzaWRlYmFyIHBhbmVsIHVzZWQgd2l0aCB0 aGUgY29udGVudCB2aWV3IG9yIHRoZSBmaXJzdCBvbmUgYWxsb3dlZC4KLSAgICB2YXIgc2VsZWN0 ZWRTaWRlYmFyUGFuZWxJZGVudGlmaWVyID0gdGhpcy5uYXZpZ2F0aW9uU2lkZWJhci5zZWxlY3Rl ZFNpZGViYXJQYW5lbC5pZGVudGlmaWVyOworICAgIHZhciBzZWxlY3RlZFNpZGViYXJQYW5lbElk ZW50aWZpZXIgPSBzZWxlY3RlZFNpZGViYXJQYW5lbC5pZGVudGlmaWVyOwogCiAgICAgdmFyIGFs bG93ZWROYXZpZ2F0aW9uU2lkZWJhclBhbmVscyA9IGN1cnJlbnRDb250ZW50Vmlldy5hbGxvd2Vk TmF2aWdhdGlvblNpZGViYXJQYW5lbHM7CiAgICAgaWYgKGFsbG93ZWROYXZpZ2F0aW9uU2lkZWJh clBhbmVscy5sZW5ndGggJiYgIWFsbG93ZWROYXZpZ2F0aW9uU2lkZWJhclBhbmVscy5jb250YWlu cyhzZWxlY3RlZFNpZGViYXJQYW5lbElkZW50aWZpZXIpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9SZXNvdXJjZVNpZGViYXJQYW5lbC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpz CmluZGV4IGIzMDk1Mjc3OTY4MjExOTUwNzc2OTY1NjI5YmM2ZWRjZTZiMzNhZWMuLjgzYWVmNDUy YzlmNDg1YTE5MzFmNzFiNzk5NjcxYWJkODMzODAxYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpz CkBAIC0yMTAsNiArMjEwLDEwIEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQYW5lbC5w cm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICAvLyBBIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBp cyBuZWVkZWQgZm9yIHRoaXMgc2luY2UgdGhlIGZyYW1lcyBhcmUgcG9wdWxhdGVkIGxhemlseS4K IAorICAgICAgICAvLyBUaGUgRnJhbWUgaXMgdXNlZCBhcyB0aGUgcmVwcmVzZW50ZWRPYmplY3Qg aW5zdGVhZCBvZiB0aGUgbWFpbiByZXNvdXJjZSBpbiBvdXIgdHJlZS4KKyAgICAgICAgaWYgKHJl cHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJlc291cmNlICYmIHJlcHJl c2VudGVkT2JqZWN0LnBhcmVudEZyYW1lLm1haW5SZXNvdXJjZSA9PT0gcmVwcmVzZW50ZWRPYmpl Y3QpCisgICAgICAgICAgICByZXByZXNlbnRlZE9iamVjdCA9IHJlcHJlc2VudGVkT2JqZWN0LnBh cmVudEZyYW1lOworCiAgICAgICAgIGZ1bmN0aW9uIGlzQW5jZXN0b3IoYW5jZXN0b3IsIHJlc291 cmNlT3JGcmFtZSkKICAgICAgICAgewogICAgICAgICAgICAgLy8gU291cmNlTWFwUmVzb3VyY2Vz IGFyZSBkZXNjZW5kYW50cyBvZiBhbm90aGVyIFNvdXJjZUNvZGUgb2JqZWN0Lgo=