123998 2013-11-07 10:07:05 -0800 Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC) 2013-11-07 11:21:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 948320 0 msaboff 2013-11-07 10:07:05 -0800 In trac.webkit.org/changeset/37406, we added __fastcall support to CTI runtime calls. It was there that we copied ESP to ECX in ctiTrampoline as the first argument to the called function. ctiTrampoline is now callToJavaScript thunk. Upon entry to a function, we trash ECX, when we use it to save the returnPC. All arguments to called JavaScript are in the argument slots of the call frame. I'm not sure when we no longer needed , but it can be removed now. 948325 1 216312 msaboff 2013-11-07 10:16:54 -0800 Created attachment 216312 Patch 948327 2 216312 mark.lam 2013-11-07 10:24:22 -0800 Comment on attachment 216312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216312&action=review r=me with comment fixed. > Source/JavaScriptCore/ChangeLog:9 > + funciton is no longer needed. "funciton" ==> "function" 948351 3 msaboff 2013-11-07 11:21:31 -0800 Committed r158857: <http://trac.webkit.org/changeset/158857> 216312 2013-11-07 10:16:54 -0800 2013-11-07 10:24:22 -0800 Patch 123998.patch text/plain 1427 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4ODU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB1bm5lZWRlZCBtb3Zpbmcgb2YgRVNQIHRvIEVDWCBpbiBjYWxsVG9KYXZhU2Ny aXB0IGZvciBDT01QSUxFUihNU1ZDKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIzOTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGVhZCBjb2RlIHJlbW92YWwuICBQYXNzaW5nIGVzcCBhcyB0aGUgZmly c3QgIkMiIGFyZ3VtZW50IHRvIGEgSmF2YVNjcmlwdAorICAgICAgICBmdW5jaXRvbiBpcyBubyBs b25nZXIgbmVlZGVkLgorCisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisgICAg ICAgIChKU0M6OmNhbGxUb0phdmFTY3JpcHQpOgorCiAyMDEzLTExLTA3ICBKdWxpZW4gQnJpYW5j ZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBmb3IgYXJjaGl0 ZWN0dXJlcyB3aXRoIDQgYXJndW1lbnQgcmVnaXN0ZXJzIChicm9rZW4gc2luY2UgcjE1ODgyMCku CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3Bw CShyZXZpc2lvbiAxNTg4NTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2Vu ZXJhdG9ycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwNiw5ICsyMDYsNiBAQCBNYWNyb0Fzc2Vt YmxlckNvZGVSZWYgY2FsbFRvSmF2YVNjcmlwdChWCiAgICAgaml0LnB1c2goWDg2UmVnaXN0ZXJz OjplYngpOwogCiAgICAgaml0LnN1YlB0cihDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMihFWFRS QV9TVEFDS19TSVpFKSwgWDg2UmVnaXN0ZXJzOjplc3ApOwotI2lmIENPTVBJTEVSKE1TVkMpCi0g ICAgaml0Lm1vdmUoWDg2UmVnaXN0ZXJzOjplc3AsIFg4NlJlZ2lzdGVyczo6ZWN4KTsKLSNlbmRp ZgogCiAgICAgaml0LmxvYWQzMihDQ2FsbEhlbHBlcnM6OkFkZHJlc3MoWDg2UmVnaXN0ZXJzOjpl c3AsIEVYVFJBX1NUQUNLX1NJWkUgKyAyNCksIEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyKTsK IAo=