123975 2013-11-07 01:25:40 -0800 Crash when submitting form in a document with null encoding 2013-11-07 13:37:52 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 rniwa rniwa ap beidson benjamin commit-queue darin jonlee mitz webkit-bug-importer oldest_to_newest 948136 0 rniwa 2013-11-07 01:25:40 -0800 Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f The CString object which is passed to normalizeLineEndingsToCRLF() can be a null string. It is created in FormDataList::appendString(), and it produces a null CString if FormDataList::m_encoding is a null encoding. 948137 1 rniwa 2013-11-07 01:28:44 -0800 The crash reproduces on Safari & nightly builds of WebKit. 948138 2 webkit-bug-importer 2013-11-07 01:29:49 -0800 <rdar://problem/15412395> 948140 3 216275 rniwa 2013-11-07 01:30:38 -0800 Created attachment 216275 Fixes the bug 948303 4 216275 ap 2013-11-07 09:34:19 -0800 Comment on attachment 216275 Fixes the bug lol 948392 5 rniwa 2013-11-07 13:12:02 -0800 (In reply to comment #4) > (From update of attachment 216275 [details]) > lol That's what I said too! 948404 6 216275 commit-queue 2013-11-07 13:37:50 -0800 Comment on attachment 216275 Fixes the bug Clearing flags on attachment: 216275 Committed r158868: <http://trac.webkit.org/changeset/158868> 948405 7 commit-queue 2013-11-07 13:37:52 -0800 All reviewed patches have been landed. Closing bug. 216275 2013-11-07 01:30:38 -0800 2013-11-07 13:37:50 -0800 Fixes the bug bug-123975-20131107013038.patch text/plain 3842 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODgyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTExLTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIHdoZW4gc3VibWl0dGlu ZyBmb3JtIGluIGEgZG9jdW1lbnQgd2l0aCBudWxsIGVuY29kaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5NzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRwczovL2Nocm9taXVtLmdv b2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy9iYmEwMWE3ZmZmMDllMzA1M2FkYTk2YWJh YmFjMmE2ZTQyNjFmZTVmCisgICAgICAgIAorICAgICAgICBUaGUgQ1N0cmluZyBvYmplY3Qgd2hp Y2ggaXMgcGFzc2VkIHRvIG5vcm1hbGl6ZUxpbmVFbmRpbmdzVG9DUkxGKCkgY2FuIGJlCisgICAg ICAgIGEgbnVsbCBzdHJpbmcuIEl0IGlzIGNyZWF0ZWQgaW4gRm9ybURhdGFMaXN0OjphcHBlbmRT dHJpbmcoKSwgYW5kIGl0CisgICAgICAgIHByb2R1Y2VzIGEgbnVsbCBDU3RyaW5nIGlmIEZvcm1E YXRhTGlzdDo6bV9lbmNvZGluZyBpcyBhIG51bGwgZW5jb2RpbmcuCisKKyAgICAgICAgVGVzdDog ZmFzdC9mb3Jtcy9mb3JtLXN1Ym1pdC1pbi1pbWFnZS1kb2N1bWVudC5odG1sCisKKyAgICAgICAg KiBwbGF0Zm9ybS90ZXh0L0xpbmVFbmRpbmcuY3BwOgorICAgICAgICAoaW50ZXJuYWxOb3JtYWxp emVMaW5lRW5kaW5nc1RvQ1JMRik6CisKIDIwMTMtMTAtMjUgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01TRV0gQWRkIE1lZGlhU291cmNlIGV4dGVuc2lvbnMg dG8gQXVkaW9UcmFjaywgVmlkZW9UcmFjaywgYW5kIFRleHRUcmFjay4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTGluZUVuZGluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9MaW5lRW5kaW5nLmNwcAkocmV2aXNpb24gMTU4ODI3KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9MaW5lRW5kaW5nLmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTYsNiArOTYsOCBAQCBwcml2YXRlOgogCiB2b2lkIGludGVybmFsTm9ybWFsaXpl TGluZUVuZGluZ3NUb0NSTEYoY29uc3QgQ1N0cmluZyYgZnJvbSwgT3V0cHV0QnVmZmVyJiBidWZm ZXIpCiB7CisgICAgaWYgKCFmcm9tLmxlbmd0aCgpKQorICAgICAgICByZXR1cm47CiAgICAgLy8g Q29tcHV0ZSB0aGUgbmV3IGxlbmd0aC4KICAgICBzaXplX3QgbmV3TGVuID0gMDsKICAgICBjb25z dCBjaGFyKiBwID0gZnJvbS5kYXRhKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTg4MjgpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx My0xMS0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBDcmFz aCB3aGVuIHN1Ym1pdHRpbmcgZm9ybSBpbiBhIGRvY3VtZW50IHdpdGggbnVsbCBlbmNvZGluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzOTc1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zv cm1zL2Zvcm0tc3VibWl0LWluLWltYWdlLWRvY3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9mb3Jtcy9mb3JtLXN1Ym1pdC1pbi1pbWFnZS1kb2N1bWVudC5odG1sOiBB ZGRlZC4KKwogMjAxMy0xMS0wNiAgVmFuaSBIZWdkZSAgPHZhbmkuaGVnZGVAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgQXBwbGllZCBiYWNrZ3JvdW5kIGNvbG9yIGlzIG5vdCByZXRhaW5lZCBhZnRl ciB0eXBpbmcgYSBjaGFyYWN0ZXJzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Zvcm0t c3VibWl0LWluLWltYWdlLWRvY3VtZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2Zvcm0tc3VibWl0LWluLWltYWdlLWRvY3VtZW50LWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvZm9ybS1zdWJtaXQt aW4taW1hZ2UtZG9jdW1lbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTAgQEAKK1Rlc3QgaWYgQmxpbmsgZG9lcyBub3QgY3Jhc2ggYnkgZm9ybSBzdWJtaXNzaW9uIGlu IGEgZG9jdW1lbnQgd2l0aCBudWxsIGVuY29kaW5nLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworUEFTUyBpZiBub3QgY3Jhc2hlZAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvZm9y bS1zdWJtaXQtaW4taW1hZ2UtZG9jdW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2Zvcm0tc3VibWl0LWluLWltYWdlLWRvY3VtZW50Lmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Zvcm0tc3VibWl0LWluLWltYWdlLWRvY3Vt ZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWw+ Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9sb2dvLmdpZiI+PC9pZnJhbWU+Cis8c2Ny aXB0PgorZGVzY3JpcHRpb24oJ1Rlc3QgaWYgQmxpbmsgZG9lcyBub3QgY3Jhc2ggYnkgZm9ybSBz dWJtaXNzaW9uIGluIGEgZG9jdW1lbnQgd2l0aCBudWxsIGVuY29kaW5nLicpOworanNUZXN0SXNB c3luYyA9IHRydWU7CisKK2Z1bmN0aW9uIGZpbmlzaCgpIHsKKyAgICB0ZXN0UGFzc2VkKCdpZiBu b3QgY3Jhc2hlZCcpOworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCit3aW5kb3cub25sb2FkID0g ZnVuY3Rpb24oKSB7CisgICAgdmFyIGRvYyA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2lmcmFt ZScpLmNvbnRlbnREb2N1bWVudDsKKyAgICB2YXIgZm9ybSA9IGRvYy5jcmVhdGVFbGVtZW50KCdm b3JtJyk7CisgICAgZm9ybS5hY3Rpb24gPSAnamF2YXNjcmlwdDpwYXJlbnQuZmluaXNoKCknOwor ICAgIGZvcm0uaW5uZXJIVE1MID0gJzxpbnB1dCB0eXBlPSJoaWRkZW4iIG5hbWU9ImhpZGRlbiI+ JzsKKyAgICBkb2MuYm9keS5hcHBlbmRDaGlsZChmb3JtKTsKKyAgICBmb3JtLnN1Ym1pdCgpOwor fTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5Pgo=