123973 2013-11-07 01:03:09 -0800 nextBoundary and previousBoundary are very slow when there is a password field 2013-11-22 18:01:56 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa ap commit-queue darin enrica kling koivisto mrobinson selinachang oldest_to_newest 948122 0 rniwa 2013-11-07 01:03:09 -0800 Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator may iterate past node boundaries. Before this patch, the transformation was done looking at the starting node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused the iterator to continue iterating and transforming until the extent of the document. 948125 1 216273 rniwa 2013-11-07 01:05:04 -0800 Created attachment 216273 Fixes the bug 948261 2 mrobinson 2013-11-07 08:03:22 -0800 I had considered posting this patch a few weeks ago, but couldn't figure out how to reproduce the bug in WebKit. I think the fix is valid regardless. 948283 3 ap 2013-11-07 09:09:11 -0800 Does this address bug 79815 by any chance? 948333 4 mrobinson 2013-11-07 10:46:20 -0800 (In reply to comment #3) > Does this address bug 79815 by any chance? That is the test case I was using to test this patch, but I found that even without the patch, the test case shows no sluggish behavior. Can one of you verify that the test case still shows the issue on Mac? 948339 5 ap 2013-11-07 10:58:38 -0800 There was an observable delay when deleting the last character in password field, using Safari 7 and its included WebKit. I didn't try a nightly. 948362 6 mrobinson 2013-11-07 11:37:26 -0800 (In reply to comment #5) > There was an observable delay when deleting the last character in password field, using Safari 7 and its included WebKit. I didn't try a nightly. If this patch fixes that, I say go for it. There may be something peculiar about the GTK+ port that means it doesn't affect us. 953044 7 216273 commit-queue 2013-11-21 05:44:15 -0800 Comment on attachment 216273 Fixes the bug Clearing flags on attachment: 216273 Committed r159619: <http://trac.webkit.org/changeset/159619> 953045 8 commit-queue 2013-11-21 05:44:18 -0800 All reviewed patches have been landed. Closing bug. 953151 9 ap 2013-11-21 10:08:47 -0800 The editing/deleting/password-delete-performance.html test is timing out on bots. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fdeleting%2Fpassword-delete-performance.html 953584 10 ap 2013-11-22 09:32:32 -0800 *** Bug 79815 has been marked as a duplicate of this bug. *** 953587 11 ap 2013-11-22 09:36:55 -0800 Ryosuke, could you please fix the test? Tracked as bug 124781 now. 953757 12 rniwa 2013-11-22 18:01:56 -0800 (In reply to comment #11) > Ryosuke, could you please fix the test? Tracked as bug 124781 now. We should just remove the test. 216273 2013-11-07 01:05:04 -0800 2013-11-21 05:44:15 -0800 Fixes the bug bug-123973-20131107010504.patch text/plain 6583 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEzLTExLTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIG5leHRCb3VuZGFyeSBhbmQgcHJl dmlvdXNCb3VuZGFyeSBhcmUgdmVyeSBzbG93IHdoZW4gdGhlcmUgaXMgYSBwYXNzd29yZCBmaWVs ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzOTcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2Ug aHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9taXVtL2JsaW5rLysvNTczNjZl ZWM1ZTNlZGVhNTQwNjJkNGU3NGMwZTA0N2Y4NjgxZGJhZAorCisgICAgICAgIFdoZW4gaXRlcmF0 aW5nIHRocm91Z2ggRE9NIG5vZGVzIG5leHRCb3VuZGFyeSBhbmQgcHJldmlvdXNCb3VuZGFyeSBj b252ZXJ0IHRoZSBjb250ZW50cyBvZiBub2RlcyB1c2luZworICAgICAgICB0ZXh0IHNlY3VyaXR5 IHRvIGEgc2VxdWVuY2Ugb2YgJ3gnIGNoYXJhY3RlcnMuIFRoZSBTaW1wbGlmaWVkQmFja3dhcmRz VGV4dEl0ZXJhdG9yIGFuZCBUZXh0SXRlcmF0b3IKKyAgICAgICAgbWF5IGl0ZXJhdGUgcGFzdCBu b2RlIGJvdW5kYXJpZXMuIEJlZm9yZSB0aGlzIHBhdGNoLCB0aGUgdHJhbnNmb3JtYXRpb24gd2Fz IGRvbmUgbG9va2luZyBhdCB0aGUgc3RhcnRpbmcKKyAgICAgICAgbm9kZSByYXRoZXIgdGhhbiB0 aGUgY3VycmVudCBub2RlLiBJbiBzb21lIHNpdHVhdGlvbnMsIHRoaXMgcmVwbGFjZWQgYWxsIGJv dW5kYXJpZXMgd2l0aCAneCcgYW5kIGNhdXNlZAorICAgICAgICB0aGUgdGV4dCBpdGVyYXRvciB0 byBjb250aW51ZSBpdGVyYXRpbmcgYW5kIHRyYW5zZm9ybWluZyB1bnRpbCB0aGUgZXh0ZW50IG9m IHRoZSBkb2N1bWVudC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2RlbGV0aW5nL3Bhc3N3b3Jk LWRlbGV0ZS1wZXJmb3JtYW5jZS5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRJdGVyYXRv ci5oOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxpZmllZEJhY2t3YXJkc1RleHRJdGVyYXRvcjo6 bm9kZSk6CisgICAgICAgICogZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6cHJldmlvdXNCb3VuZGFyeSk6CisgICAgICAgIChXZWJDb3JlOjpuZXh0Qm91bmRhcnkp OgorCiAyMDEzLTEwLTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNU0VdIEFkZCBNZWRpYVNvdXJjZSBleHRlbnNpb25zIHRvIEF1ZGlvVHJhY2ssIFZpZGVv VHJhY2ssIGFuZCBUZXh0VHJhY2suCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJ dGVyYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJh dG9yLmgJKHJldmlzaW9uIDE1ODgyNykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0 ZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTIwNyw3ICsyMDcsOCBAQCBwdWJsaWM6CiAgICAg CiAgICAgYm9vbCBhdEVuZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Bvc2l0aW9uTm9kZSB8fCBtX3No b3VsZFN0b3A7IH0KICAgICB2b2lkIGFkdmFuY2UoKTsKLSAgICAKKworICAgIE5vZGUqIG5vZGUo KSBjb25zdCB7IHJldHVybiBtX25vZGU7IH0KICAgICBpbnQgbGVuZ3RoKCkgY29uc3QgeyByZXR1 cm4gbV90ZXh0TGVuZ3RoOyB9CiAgICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMoKSBjb25zdCB7 IHJldHVybiBtX3RleHRDaGFyYWN0ZXJzOyB9CiAgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL1Zpc2libGVVbml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRp dGluZy9WaXNpYmxlVW5pdHMuY3BwCShyZXZpc2lvbiAxNTg4MjcpCisrKyBTb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4Nyw5ICs0ODcs OSBAQCBzdGF0aWMgVmlzaWJsZVBvc2l0aW9uIHByZXZpb3VzQm91bmRhcnkoCiAKICAgICBTaW1w bGlmaWVkQmFja3dhcmRzVGV4dEl0ZXJhdG9yIGl0KHNlYXJjaFJhbmdlLmdldCgpKTsKICAgICB1 bnNpZ25lZCBuZXh0ID0gMDsKLSAgICBib29sIGluVGV4dFNlY3VyaXR5TW9kZSA9IHN0YXJ0LmRl cHJlY2F0ZWROb2RlKCkgJiYgc3RhcnQuZGVwcmVjYXRlZE5vZGUoKS0+cmVuZGVyZXIoKSAmJiBz dGFydC5kZXByZWNhdGVkTm9kZSgpLT5yZW5kZXJlcigpLT5zdHlsZSgpLnRleHRTZWN1cml0eSgp ICE9IFRTTk9ORTsKICAgICBib29sIG5lZWRNb3JlQ29udGV4dCA9IGZhbHNlOwogICAgIHdoaWxl ICghaXQuYXRFbmQoKSkgeworICAgICAgICBib29sIGluVGV4dFNlY3VyaXR5TW9kZSA9IGl0Lm5v ZGUoKSAmJiBpdC5ub2RlKCktPnJlbmRlcmVyKCkgJiYgaXQubm9kZSgpLT5yZW5kZXJlcigpLT5z dHlsZSgpLnRleHRTZWN1cml0eSgpICE9IFRTTk9ORTsKICAgICAgICAgLy8gaXRlcmF0ZSB0byBn ZXQgY2h1bmtzIHVudGlsIHRoZSBzZWFyY2hGdW5jdGlvbiByZXR1cm5zIGEgbm9uLXplcm8gdmFs dWUuCiAgICAgICAgIGlmICghaW5UZXh0U2VjdXJpdHlNb2RlKSAKICAgICAgICAgICAgIHN0cmlu Zy5pbnNlcnQoMCwgaXQuY2hhcmFjdGVycygpLCBpdC5sZW5ndGgoKSk7CkBAIC01NjAsOSArNTYw LDkgQEAgc3RhdGljIFZpc2libGVQb3NpdGlvbiBuZXh0Qm91bmRhcnkoY29ucwogICAgIHNlYXJj aFJhbmdlLT5zZXRTdGFydChzdGFydC5kZXByZWNhdGVkTm9kZSgpLCBzdGFydC5kZXByZWNhdGVk RWRpdGluZ09mZnNldCgpLCBJR05PUkVfRVhDRVBUSU9OKTsKICAgICBUZXh0SXRlcmF0b3IgaXQo c2VhcmNoUmFuZ2UuZ2V0KCksIFRleHRJdGVyYXRvckVtaXRzQ2hhcmFjdGVyc0JldHdlZW5BbGxW aXNpYmxlUG9zaXRpb25zKTsKICAgICB1bnNpZ25lZCBuZXh0ID0gMDsKLSAgICBib29sIGluVGV4 dFNlY3VyaXR5TW9kZSA9IHN0YXJ0LmRlcHJlY2F0ZWROb2RlKCkgJiYgc3RhcnQuZGVwcmVjYXRl ZE5vZGUoKS0+cmVuZGVyZXIoKSAmJiBzdGFydC5kZXByZWNhdGVkTm9kZSgpLT5yZW5kZXJlcigp LT5zdHlsZSgpLnRleHRTZWN1cml0eSgpICE9IFRTTk9ORTsKICAgICBib29sIG5lZWRNb3JlQ29u dGV4dCA9IGZhbHNlOwogICAgIHdoaWxlICghaXQuYXRFbmQoKSkgeworICAgICAgICBib29sIGlu VGV4dFNlY3VyaXR5TW9kZSA9IGl0Lm5vZGUoKSAmJiBpdC5ub2RlKCktPnJlbmRlcmVyKCkgJiYg aXQubm9kZSgpLT5yZW5kZXJlcigpLT5zdHlsZSgpLnRleHRTZWN1cml0eSgpICE9IFRTTk9ORTsK ICAgICAgICAgLy8gS2VlcCBhc2tpbmcgdGhlIGl0ZXJhdG9yIGZvciBjaHVua3MgdW50aWwgdGhl IHNlYXJjaCBmdW5jdGlvbgogICAgICAgICAvLyByZXR1cm5zIGFuIGVuZCB2YWx1ZSBub3QgZXF1 YWwgdG8gdGhlIGxlbmd0aCBvZiB0aGUgc3RyaW5nIHBhc3NlZCB0byBpdC4KICAgICAgICAgaWYg KCFpblRleHRTZWN1cml0eU1vZGUpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTg4MjcpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0x MS0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBuZXh0Qm91 bmRhcnkgYW5kIHByZXZpb3VzQm91bmRhcnkgYXJlIHZlcnkgc2xvdyB3aGVuIHRoZXJlIGlzIGEg cGFzc3dvcmQgZmllbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMzk3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZWRpdGluZy9kZWxldGluZy9wYXNzd29yZC1kZWxldGUtcGVyZm9ybWFuY2UtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2RlbGV0aW5nL3Bhc3N3b3JkLWRl bGV0ZS1wZXJmb3JtYW5jZS5odG1sOiBBZGRlZC4KKwogMjAxMy0xMS0wNiAgVmFuaSBIZWdkZSAg PHZhbmkuaGVnZGVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgQXBwbGllZCBiYWNrZ3JvdW5kIGNv bG9yIGlzIG5vdCByZXRhaW5lZCBhZnRlciB0eXBpbmcgYSBjaGFyYWN0ZXJzCkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL3Bhc3N3b3JkLWRlbGV0ZS1wZXJmb3JtYW5jZS1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9wYXNz d29yZC1kZWxldGUtcGVyZm9ybWFuY2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9wYXNzd29yZC1kZWxldGUtcGVyZm9ybWFuY2UtZXhw ZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0IGVuc3Vy ZXMgdGhhdCBkZWxldGluZyBjaGFyYWN0ZXJzIGZyb20gYSBwYXNzd29yZCBmaWVsZCB0aGF0IGZv bGxvd3MgbGFyZ2UgY29udGVudCBibG9ja3MgaXMgbm90IHNsb3cuIFRvIHJ1biB0aGUgdGVzdCBt YW51YWxseSwgZGVsZXRlIHRoZSBjaGFyYWN0ZXIgZnJvbSB0aGUgcGFzc3dvcmQgZmllbGQuIFRo ZSB1c2VyIGFnZW50IHNob3VsZCBub3QgZnJlZXplLgorCisKSW5kZXg6IExheW91dFRlc3RzL2Vk aXRpbmcvZGVsZXRpbmcvcGFzc3dvcmQtZGVsZXRlLXBlcmZvcm1hbmNlLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9wYXNzd29yZC1kZWxldGUtcGVyZm9y bWFuY2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcv cGFzc3dvcmQtZGVsZXRlLXBlcmZvcm1hbmNlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwzMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHAg aWQ9ImRlc2NyaXB0aW9uIj5UaGlzIHRlc3QgZW5zdXJlcyB0aGF0IGRlbGV0aW5nIGNoYXJhY3Rl cnMgZnJvbSBhIHBhc3N3b3JkIGZpZWxkIHRoYXQgZm9sbG93cyBsYXJnZSBjb250ZW50IGJsb2Nr cyBpcyBub3Qgc2xvdy4KKyAgICAgICAgVG8gcnVuIHRoZSB0ZXN0IG1hbnVhbGx5LCBkZWxldGUg dGhlIGNoYXJhY3RlciBmcm9tIHRoZSBwYXNzd29yZCBmaWVsZC4gVGhlIHVzZXIgYWdlbnQgc2hv dWxkIG5vdCBmcmVlemUuPC9wPgorCisgICAgICAgIDxkaXYgaWQ9ImNvbnRlbnQiIHN0eWxlPSJo ZWlnaHQ6MHB4OyBvdmVyZmxvdzpoaWRkZW47Ij4gPC9kaXY+CisgICAgICAgIDxpbnB1dCBpZD0i ZmllbGQiIHR5cGU9InBhc3N3b3JkIiB2YWx1ZT0iQSI+CisKKyAgICAgICAgPHNjcmlwdCBzcmM9 Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFz VGV4dCgpOworCisgICAgICAgICAgICB2YXIgbmV3Q29udGVudCA9ICc8cD5Mb3JlbSBpcHN1bSBk b2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dWVyIGFkaXBpc2NpbmcgZWxpdC48L3A+JzsKKyAgICAg ICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTU7IGkrKykgeworICAgICAgICAgICAgICAgIG5l d0NvbnRlbnQgKz0gbmV3Q29udGVudDsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgdmFy IGNvbnRlbnREaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGVudCcpOworICAgICAg ICAgICAgY29udGVudERpdi5pbm5lckhUTUwgPSBuZXdDb250ZW50OworCisgICAgICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZmllbGQiKS5mb2N1cygpOworICAgICAgICAgICAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoIkRlbGV0ZSIpOworCisgICAgICAgICAgICAvLyBXZSBjbGVhciB0 aGUgY29udGVudCBkaXYgdG8gYXZvaWQgaGF2aW5nIGl0cyBjb250ZW50IGFwcGVhciBpbiB0aGUg dGVzdCBoYXJuZXNzIG91dHB1dC4KKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICAgICAgICAgICAgICBjb250ZW50RGl2LmlubmVySFRNTCA9ICIiOworICAgICAgICA8L3Nj cmlwdD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==