123971 2013-11-07 00:46:54 -0800 Jhbuild build bug workaround 2013-11-08 01:41:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 p.szymanski3 webkit-unassigned commit-queue rniwa oldest_to_newest 948113 0 p.szymanski3 2013-11-07 00:46:54 -0800 Jhbuild build uses Makefile.plain lcated in po directory (WebKitBuild/Dependencies/Source/jhbuild/po). This makefile file uses grep -v '^\#' LINGUAS Output from this grep is: ca cs de el en_GB (...) If someone has set grep env variable GREP_OPTIONS=-n (or other that changes grep output) then this output will be: 2:ca 3:cs 4:de 5:el 6:en_GB (...) The line is added by grep. After that jhbuild will not build because this grep output is different than expected. If you will try to build jhbuild (make install) with this grep option output will be: make[1]: Entering directory `WebKit/WebKitBuild/Dependencies/Source/jhbuild/po' Makefile.plain:10: *** target pattern contains no `%'. Stop. make[1]: Leaving directory `WebKit/WebKitBuild/Dependencies/Source/jhbuild/po' make: *** [install] Error 2 This patch is a WebKit workaround to this jhbuild issue. It doesn't changes anything else with WebKit build. 948114 1 216270 p.szymanski3 2013-11-07 00:49:10 -0800 Created attachment 216270 jhbuild fix 948120 2 216270 rniwa 2013-11-07 01:00:35 -0800 Comment on attachment 216270 jhbuild fix rs=me. 948571 3 p.szymanski3 2013-11-08 01:15:49 -0800 (In reply to comment #2) > (From update of attachment 216270 [details]) > rs=me. Thank you for review. cq? 948574 4 216270 commit-queue 2013-11-08 01:41:44 -0800 Comment on attachment 216270 jhbuild fix Clearing flags on attachment: 216270 Committed r158912: <http://trac.webkit.org/changeset/158912> 948575 5 commit-queue 2013-11-08 01:41:46 -0800 All reviewed patches have been landed. Closing bug. 216270 2013-11-07 00:49:10 -0800 2013-11-08 01:41:44 -0800 jhbuild fix jhbuild.patch text/plain 1681 p.szymanski3 ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1OGNh MzQwLi42ZGI1MjE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMTEtMDcgIFByemVteXNsYXcgU3p5bWFuc2tp ICA8cC5zenltYW5za2kzQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtKSEJVSUxEXSBKaGJ1aWxk IE1ha2VmaWxlIGJ1aWxkIGJ1ZyB3b3JrYXJvdW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBKaGJ1aWxkIHJlcG9zaXRvcnkgaXMgY2xvbmVk IChmb3IgaW5zdGFuY2Ugd2hlbiB5b3UgdXNlCisgICAgICAgIFRvb2xzL1NjcmlwdHMvdXBkYXRl LXdlYmtpdGVmbC1saWJzKSBpdCBpcyBidWlsdCBmcm9tIHNvdXJjZXMuCisgICAgICAgIElmIHlv dSBoYXZlIEdSRVBfT1BUSU9OUyBncmVwIGVudiB2YXJpYWJsZSBzZXQgKGZvciBpbnN0YW5jZQor ICAgICAgICBHUkVQX09QVElPTlM9LW4pIHRoZW4gaXQgaXMgamhidWlsZCBidWlsZCBlcnJvci4g TWFrZWZpbGUucGxhaW4KKyAgICAgICAgdXNlcyBzaGVsbCBncmVwLiBGb3Igc3BlY2lmaWMgR1JF UF9PUFRJT05TIGdyZXAgb3V0cHV0IHdpbGwgYmUKKyAgICAgICAgZGlmZmVyZW50IHRoYW4gZXhw ZWN0ZWQgb25lIGJ5IEpoYnVpbGQgYW5kIHRoZXJlIGlzIGFuIGVycm9yCisgICAgICAgIHdpdGgg SmhidWlsZCBidWlsZC4gSmhidWlsZCB3aWxsIG5vdCBiZSBidWlsdCBhbmQgdGhlbiBXZWJLaXQK KyAgICAgICAgc291cmNlIGFsc28gd2lsbCBub3QgYmUgYnVpbHQuIFRoaXMgcGF0Y2ggaXMgYSB3 b3JrYXJvdW5kIHRvIHRoaXMKKyAgICAgICAgaXNzdWUuIEl0IGRpc2FibGVzIEdSRVBfT1BUSU9O UyBmb3IgSmhidWlsZCBidWlsZCB0aW1lLgorCisgICAgICAgICogamhidWlsZC9qaGJ1aWxkLXdy YXBwZXI6CisgICAgICAgIChpbnN0YWxsX2poYnVpbGQpOgorCiAyMDEzLTExLTA2ICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgd2Via2l0cHkg dW5pdCB0ZXN0IGZpeDsgdXBkYXRlIGJhc2VsaW5lcyBhZnRlciByMTU4NzY1CmRpZmYgLS1naXQg YS9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBlciBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC13 cmFwcGVyCmluZGV4IDM2MDk0MmYuLmEyOWI2MGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL2poYnVpbGQv amhidWlsZC13cmFwcGVyCisrKyBiL1Rvb2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyCkBAIC03 NSw2ICs3NSw4IEBAIGRlZiBjbG9uZV9qaGJ1aWxkKCk6CiAKIAogZGVmIGluc3RhbGxfamhidWls ZCgpOgorICAgIGlmICJHUkVQX09QVElPTlMiIGluIG9zLmVudmlyb246CisgICAgICAgIGRlbCBv cy5lbnZpcm9uWydHUkVQX09QVElPTlMnXQogICAgIHByb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVu KFsnYmFzaCcsICcuL2F1dG9nZW4uc2gnLCAnLS1wcmVmaXg9JXMnICUgaW5zdGFsbGF0aW9uX3By ZWZpeF0sIGN3ZD1qaGJ1aWxkX3NvdXJjZV9wYXRoKQogICAgIHByb2Nlc3Mud2FpdCgpCiAgICAg aWYgcHJvY2Vzcy5yZXR1cm5jb2RlICE9IDA6Cg==