123962 2013-11-06 23:44:15 -0800 DOMTokenList::add can add duplicated values if arguments had duplicated values 2013-11-07 15:14:30 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, WebExposed P2 Normal --- 1 rniwa rniwa ap arv commit-queue darin esprehn+autocc gyuyoung.kim kling sam oldest_to_newest 948093 0 rniwa 2013-11-06 23:44:15 -0800 DOMTokenList::add(const Vector<String>& tokens, ExceptionCode& ec) ensures that newly added tokens are unique existing the existing tokens but don't ensure that newly added tokens are themselves unique. e.g. element.classList.add('a b a') results in element.className being 'a b a' instead of 'a b'. 948094 1 rniwa 2013-11-06 23:44:36 -0800 Merge https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305 948095 2 216264 rniwa 2013-11-06 23:47:35 -0800 Created attachment 216264 Fixes the bug 948434 3 216264 commit-queue 2013-11-07 15:14:27 -0800 Comment on attachment 216264 Fixes the bug Clearing flags on attachment: 216264 Committed r158877: <http://trac.webkit.org/changeset/158877> 948435 4 commit-queue 2013-11-07 15:14:30 -0800 All reviewed patches have been landed. Closing bug. 216264 2013-11-06 23:47:35 -0800 2013-11-07 15:14:27 -0800 Fixes the bug bug-123962-20131106234734.patch text/plain 4348 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODgyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTA2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERPTVRva2VuTGlzdDo6YWRkIGNh biBhZGQgZHVwbGljYXRlZCB2YWx1ZXMgaWYgYXJndW1lbnRzIGhhZCBkdXBsaWNhdGVkIHZhbHVl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzOTYy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2Ug aHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9taXVtL2JsaW5rLysvYmQzODIy YWQ0YWUzZmM1ZDhmODlmNDMzYTdiZjA0ZjY5NzMzNDMwNQorCisgICAgICAgIEluIGNhc2Ugd2Ug ZG8gZWxlbWVudC5jbGFzc0xpc3QuYWRkKCdhJywgJ2EnKSB3ZSBuZWVkIHRvIGVuc3VyZSB0aGF0 IHdlIGRvIG5vdCBhZGQgdGhlIHNhbWUgdG9rZW4gdHdpY2UuCisgICAgICAgIFNlZSBodHRwOi8v ZG9tLnNwZWMud2hhdHdnLm9yZy8jZG9tLWRvbXRva2VubGlzdC1hZGQKKworICAgICAgICAqIGh0 bWwvRE9NVG9rZW5MaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRva2VuTGlzdDo6YWRk KTogTWFrZSBzdXJlIGZpbHRlcmVkIHRva2VucyBhcmUgdW5pcXVlIGFtb25nIHRoZW1zZWx2ZXMu CisKIDIwMTMtMTAtMjUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAg ICAgW01TRV0gQWRkIE1lZGlhU291cmNlIGV4dGVuc2lvbnMgdG8gQXVkaW9UcmFjaywgVmlkZW9U cmFjaywgYW5kIFRleHRUcmFjay4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVG9rZW5M aXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0RPTVRva2VuTGlzdC5j cHAJKHJldmlzaW9uIDE1ODgxMykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVG9rZW5MaXN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzksNyArNzksNyBAQCB2b2lkIERPTVRva2VuTGlzdDo6 YWRkKGNvbnN0IFZlY3RvcjxTdHJpCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB0b2tlbnMu c2l6ZSgpOyArK2kpIHsKICAgICAgICAgaWYgKCF2YWxpZGF0ZVRva2VuKHRva2Vuc1tpXSwgZWMp KQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBpZiAoIWNvbnRhaW5zSW50ZXJuYWwodG9r ZW5zW2ldKSkKKyAgICAgICAgaWYgKCFjb250YWluc0ludGVybmFsKHRva2Vuc1tpXSkgJiYgIWZp bHRlcmVkVG9rZW5zLmNvbnRhaW5zKHRva2Vuc1tpXSkpCiAgICAgICAgICAgICBmaWx0ZXJlZFRv a2Vucy5hcHBlbmQodG9rZW5zW2ldKTsKICAgICB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODgy NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTExLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIERPTVRva2VuTGlzdDo6YWRkIGNhbiBhZGQgZHVwbGljYXRlZCB2YWx1ZXMgaWYgYXJndW1l bnRzIGhhZCBkdXBsaWNhdGVkIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzOTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MRWxlbWVudC9jbGFzcy1saXN0LWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MRWxlbWVudC9jbGFzcy1saXN0LXF1aXJr cy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vSFRNTEVsZW1lbnQvc2NyaXB0LXRl c3RzL2NsYXNzLWxpc3QuanM6CisKIDIwMTMtMTEtMDYgIFZhbmkgSGVnZGUgIDx2YW5pLmhlZ2Rl QHNhbXN1bmcuY29tPgogCiAgICAgICAgIEFwcGxpZWQgYmFja2dyb3VuZCBjb2xvciBpcyBub3Qg cmV0YWluZWQgYWZ0ZXIgdHlwaW5nIGEgY2hhcmFjdGVycwpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTEVsZW1lbnQvY2xhc3MtbGlzdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEVsZW1lbnQvY2xhc3MtbGlzdC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDE1ODgxMykKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxFbGVtZW50L2Ns YXNzLWxpc3QtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC04OSw3ICs4OSw3IEBAIFZh cmlhZGljIGNhbGxzCiBQQVNTIGVsZW1lbnQuY2xhc3NOYW1lIGlzICJhIGIiCiBQQVNTIGVsZW1l bnQuY2xhc3NOYW1lIGlzICJhIGIgYyIKIFBBU1MgZWxlbWVudC5jbGFzc05hbWUgaXMgImEgYiBj IG51bGwgZCB1bmRlZmluZWQgMCBmYWxzZSIKLVBBU1MgZWxlbWVudC5jbGFzc05hbWUgaXMgImEg YiBhIgorUEFTUyBlbGVtZW50LmNsYXNzTmFtZSBpcyAiYSBiIgogUEFTUyBlbGVtZW50LmNsYXNz TGlzdC5hZGQoJ2EnLCAnYicsICcnKSB0aHJldyBleHBlY3RlZCBET01FeGNlcHRpb24gd2l0aCBj b2RlIDEyCiBQQVNTIGVsZW1lbnQuY2xhc3NOYW1lIGlzICIiCiBQQVNTIGVsZW1lbnQuY2xhc3NM aXN0LmFkZCgnYScsICdiJywgJ2MgZCcpIHRocmV3IGV4cGVjdGVkIERPTUV4Y2VwdGlvbiB3aXRo IGNvZGUgNQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEVsZW1lbnQvY2xhc3MtbGlz dC1xdWlya3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxFbGVtZW50L2NsYXNzLWxpc3QtcXVpcmtzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTU4 ODEzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEVsZW1lbnQvY2xhc3MtbGlzdC1xdWly a3MtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC04OSw3ICs4OSw3IEBAIFZhcmlhZGlj IGNhbGxzCiBQQVNTIGVsZW1lbnQuY2xhc3NOYW1lIGlzICJhIGIiCiBQQVNTIGVsZW1lbnQuY2xh c3NOYW1lIGlzICJhIGIgYyIKIFBBU1MgZWxlbWVudC5jbGFzc05hbWUgaXMgImEgYiBjIG51bGwg ZCB1bmRlZmluZWQgMCBmYWxzZSIKLVBBU1MgZWxlbWVudC5jbGFzc05hbWUgaXMgImEgYiBhIgor UEFTUyBlbGVtZW50LmNsYXNzTmFtZSBpcyAiYSBiIgogUEFTUyBlbGVtZW50LmNsYXNzTGlzdC5h ZGQoJ2EnLCAnYicsICcnKSB0aHJldyBleHBlY3RlZCBET01FeGNlcHRpb24gd2l0aCBjb2RlIDEy CiBQQVNTIGVsZW1lbnQuY2xhc3NOYW1lIGlzICIiCiBQQVNTIGVsZW1lbnQuY2xhc3NMaXN0LmFk ZCgnYScsICdiJywgJ2MgZCcpIHRocmV3IGV4cGVjdGVkIERPTUV4Y2VwdGlvbiB3aXRoIGNvZGUg NQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEVsZW1lbnQvc2NyaXB0LXRlc3RzL2Ns YXNzLWxpc3QuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEVsZW1l bnQvc2NyaXB0LXRlc3RzL2NsYXNzLWxpc3QuanMJKHJldmlzaW9uIDE1ODgxMykKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxFbGVtZW50L3NjcmlwdC10ZXN0cy9jbGFzcy1saXN0LmpzCSh3 b3JraW5nIGNvcHkpCkBAIC0yOTksNyArMjk5LDcgQEAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdl bGVtZW50LmNsYXNzTmFtZQogCiBjcmVhdGVFbGVtZW50KCcnKTsKIGVsZW1lbnQuY2xhc3NMaXN0 LmFkZCgnYScsICdiJywgJ2EnKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygnZWxlbWVudC5jbGFz c05hbWUnLCAnYSBiIGEnKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygnZWxlbWVudC5jbGFzc05h bWUnLCAnYSBiJyk7CiAKIGNyZWF0ZUVsZW1lbnQoJycpOwogc2hvdWxkVGhyb3dET01FeGNlcHRp b24oZnVuY3Rpb24oKSB7Cg==