123941 2013-11-06 17:09:46 -0800 kTraceBufferLen is unused in default builds 2013-12-03 11:39:30 -0800 1 1 1 Unclassified WebKit ANGLE 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue dbates kondapallykalyan roger_fong thorton oldest_to_newest 947996 0 dino 2013-11-06 17:09:46 -0800 In debug.cpp, kTraceBufferLen is not used unless TRACE_ENABLED is true. This causes newer versions of clang to throw a warning. For now, add -Wno-error=unused-variable to the build flags. <rdar://problem/14739718> 947998 1 dino 2013-11-06 17:11:59 -0800 Real radar is <rdar://problem/15409804> 948004 2 216246 dino 2013-11-06 17:13:57 -0800 Created attachment 216246 Patch 948009 3 216249 dino 2013-11-06 17:27:06 -0800 Created attachment 216249 Patch 948011 4 216249 thorton 2013-11-06 17:28:04 -0800 Comment on attachment 216249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216249&action=review Much better. > Source/ThirdParty/ANGLE/src/compiler/debug.cpp:46 > +#if defined(__clang__) > +#pragma clang diagnostic pop > +#endif This should wrap just the constant. 948017 5 dino 2013-11-06 17:40:01 -0800 Committed r158807: <http://trac.webkit.org/changeset/158807> 948022 6 thorton 2013-11-06 17:58:27 -0800 Probably should have used "GCC diagnostic push" and no #if defined(__clang__) 956018 7 dbates 2013-12-03 11:39:30 -0800 This change was inadvertently reverted in <http://trac.webkit.org/changeset/159533> (bug #124615). I committed a revised fix for this issue in <https://bugs.webkit.org/show_bug.cgi?id=125164>, which was accepted by the ANGLE project: <https://code.google.com/p/angleproject/issues/detail?id=534>. 216246 2013-11-06 17:13:57 -0800 2013-11-06 17:27:05 -0800 Patch bug-123941-20131106171357.patch text/plain 2028 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4ODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDdjODQzMjc5MTkxZjFiNjUwMzQwNDk1ZDgzYTliNjhhNDk4NzhhMS4uMWY5NjNhNDk5ZTI3 MGYzMTI5MDA1ZWZkMDE4Mzc4OTcxMmI1NTYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBrVHJhY2VCdWZmZXJMZW4gaXMgdW51c2VkIGluIGRlZmF1bHQgYnVp bGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5 NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1NDA5ODA0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGtUcmFjZUJ1ZmZlckxlbiBpcyBub3QgdXNl ZCBpbiBkZWJ1Zy5jcHAgaWYgVFJBQ0VfRU5BQkxFRCBpcworICAgICAgICBub3QgZGVmaW5lZC4g VGhpcyBjYXVzZXMgYSB3YXJuaW5nIGluIG5ld2VyIGJ1aWxkcyBvZiBjbGFuZy4KKyAgICAgICAg Rm9yIG5vdywgc2tpcCB3YXJuaW5ncyBvbiB1bnVzZWQgdmFyaWFibGVzIHVudGlsIHdlCisgICAg ICAgIHVwZGF0ZSBmcm9tIEFOR0xFLgorCisgICAgICAgICogQU5HTEUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajogQWRkIC1Xbm8tZXJyb3I9dW51c2VkLXZhcmlhYmxlLgorCiAyMDEzLTEwLTI0 ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJlZmVyZW5j ZXMgdG8gT1MgWCAxMC43IGZyb20gWGNvZGUgY29uZmlndXJhdGlvbiBzZXR0aW5ncy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2ogYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9BTkdMRS54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qCmluZGV4IDJjN2E0MDg5ZmUzNThkZTdhOGE0YmM3MGZiMzNjYWZhN2Q5MTgyMDEuLjk4 MzVmNDA2NmE0YWQwNDhkNTkxMTU5MWQzZGVhNzk5NGYzOTUyODggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5HTEUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpA QCAtNzc4LDYgKzc3OCw3IEBACiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJh c2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gNUQ3QzU5QzUxMjA4QzY4QjAwMUM4NzNFIC8qIEFO R0xFLnhjY29uZmlnICovOwogCQkJYnVpbGRTZXR0aW5ncyA9IHsKKwkJCQlXQVJOSU5HX0NGTEFH UyA9ICItV25vLWVycm9yPXVudXNlZC12YXJpYWJsZSI7CiAJCQl9OwogCQkJbmFtZSA9IFByb2R1 Y3Rpb247CiAJCX07CkBAIC04MDAsNiArODAxLDcgQEAKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1 cmF0aW9uOwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSA1RDdDNTlDNTEyMDhDNjhC MDAxQzg3M0UgLyogQU5HTEUueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0geworCQkJ CVdBUk5JTkdfQ0ZMQUdTID0gIi1Xbm8tZXJyb3I9dW51c2VkLXZhcmlhYmxlIjsKIAkJCX07CiAJ CQluYW1lID0gRGVidWc7CiAJCX07CkBAIC04MDcsNiArODA5LDcgQEAKIAkJCWlzYSA9IFhDQnVp bGRDb25maWd1cmF0aW9uOwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSA1RDdDNTlD NTEyMDhDNjhCMDAxQzg3M0UgLyogQU5HTEUueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRpbmdz ID0geworCQkJCVdBUk5JTkdfQ0ZMQUdTID0gIi1Xbm8tZXJyb3I9dW51c2VkLXZhcmlhYmxlIjsK IAkJCX07CiAJCQluYW1lID0gUmVsZWFzZTsKIAkJfTsK 216249 2013-11-06 17:27:06 -0800 2013-11-06 17:28:04 -0800 Patch bug-123941-20131106172706.patch text/plain 1772 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4ODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDdjODQzMjc5MTkxZjFiNjUwMzQwNDk1ZDgzYTliNjhhNDk4NzhhMS4uYTM1YjdkZjRjNTNi ZTQ1YTE3NmEwNDFkMjBjZTVjNGNkYjMyOTVlOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBrVHJhY2VCdWZmZXJMZW4gaXMgdW51c2VkIGluIGRlZmF1bHQgYnVp bGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5 NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1NDA5ODA0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGtUcmFjZUJ1ZmZlckxlbiBpcyBub3QgdXNl ZCBpbiBkZWJ1Zy5jcHAgaWYgVFJBQ0VfRU5BQkxFRCBpcworICAgICAgICBub3QgZGVmaW5lZC4g VGhpcyBjYXVzZXMgYSB3YXJuaW5nIGluIG5ld2VyIGJ1aWxkcyBvZiBjbGFuZy4KKyAgICAgICAg Rm9yIG5vdywgc2tpcCB3YXJuaW5ncyBvbiB1bnVzZWQgdmFyaWFibGVzIHVudGlsIHdlCisgICAg ICAgIHVwZGF0ZSBmcm9tIEFOR0xFLgorCisgICAgICAgICogc3JjL2NvbXBpbGVyL2RlYnVnLmNw cDogQWRkIHVudXNlZC12YXJpYWJsZSBpZ25vcmUgcHJhZ21hLgorCiAyMDEzLTEwLTI0ICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJlZmVyZW5jZXMgdG8g T1MgWCAxMC43IGZyb20gWGNvZGUgY29uZmlndXJhdGlvbiBzZXR0aW5ncy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9kZWJ1Zy5jcHAgYi9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZGVidWcuY3BwCmluZGV4IDUzNzc4YmQzZWI3 NWQxODIwMGRhM2RlNmNlNDRlZTBlZjkyYzdmZTkuLjMxMjZmNDE3N2JlYWY2YzBlNTk4MjgwNGEy NWJiYmQyMGRlNjkxM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9j b21waWxlci9kZWJ1Zy5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBp bGVyL2RlYnVnLmNwcApAQCAtMTQsOCArMTQsMTQgQEAKICNpbmNsdWRlICJjb21waWxlci9Jbml0 aWFsaXplUGFyc2VDb250ZXh0LmgiCiAjaW5jbHVkZSAiY29tcGlsZXIvUGFyc2VIZWxwZXIuaCIK IAorI2lmIGRlZmluZWQoX19jbGFuZ19fKQorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gK KyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVd1bnVzZWQtdmFyaWFibGUiCisjZW5k aWYKKwogc3RhdGljIGNvbnN0IGludCBrVHJhY2VCdWZmZXJMZW4gPSAxMDI0OwogCisKICNpZmRl ZiBUUkFDRV9FTkFCTEVECiBleHRlcm4gIkMiIHsKIHZvaWQgVHJhY2UoY29uc3QgY2hhciAqZm9y bWF0LCAuLi4pIHsKQEAgLTM1LDMgKzQxLDYgQEAgdm9pZCBUcmFjZShjb25zdCBjaGFyICpmb3Jt YXQsIC4uLikgewogfSAgLy8gZXh0ZXJuICJDIgogI2VuZGlmICAvLyBUUkFDRV9FTkFCTEVECiAK KyNpZiBkZWZpbmVkKF9fY2xhbmdfXykKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyNl bmRpZgo=