123930 2013-11-06 14:47:46 -0800 Move allowed classes handling to decodeObject 2013-11-06 15:02:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 947931 0 andersca 2013-11-06 14:47:46 -0800 Move allowed classes handling to decodeObject 947932 1 216227 andersca 2013-11-06 14:51:46 -0800 Created attachment 216227 Patch 947933 2 216227 kling 2013-11-06 14:56:22 -0800 Comment on attachment 216227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216227&action=review r=me > Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:453 > + if (!allowedClasses) > + allowedClasses = decoder->_allowedClasses; Not a fan of overwriting arguments like this. I like your IRC version better. 947938 3 andersca 2013-11-06 15:02:44 -0800 Committed r158797: <http://trac.webkit.org/changeset/158797> 216227 2013-11-06 14:51:46 -0800 2013-11-06 14:56:22 -0800 Patch bug-123930-20131106145146.patch text/plain 3663 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzk3OWU0MzAxZWZmOGM0 NjM3ZjAwZGU5YzlmZjZhOTI2OGI4Y2YwZi4uYjc5ZDZlYmJhODFhMmI5Zjk1NTgwODg1ZWM4YjZk MGY0MmNlNzhkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEzLTExLTA2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBhbGxvd2Vk IGNsYXNzZXMgaGFuZGxpbmcgdG8gZGVjb2RlT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmpl Y3RDb2Rlci5tbToKKyAgICAgICAgKGRlY29kZU9iamVjdEZyb21PYmplY3RTdHJlYW0pOgorICAg ICAgICBQYXNzIGFsbG93ZWQgY2xhc3NlcyB0aHJvdWdoIHRvIGRlY29kZU9iamVjdC4KKworICAg ICAgICAoZGVjb2RlT2JqZWN0KToKKyAgICAgICAgVXBkYXRlIHRvIHRha2UgYW4gTlNTZXQgb2Yg YWxsb3dlZCBjbGFzc2VzLiBJZiB0aGUgc2V0IGlzIG5pbCwgdXNlIHRoZSBjdXJyZW50IHNldC4K KworICAgICAgICAoLVtXS1JlbW90ZU9iamVjdERlY29kZXIgZGVjb2RlT2JqZWN0T2ZDbGFzc2Vz OmZvcktleTpdKToKKyAgICAgICAgUGFzcyBjbGFzc2VzIHRvIGRlY29kZU9iamVjdC4KKworMjAx My0xMS0wNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAg IEltcGxlbWVudCBtb3JlIGRlY29kaW5nIG1ldGhvZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzkyMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0gYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KaW5kZXggZGFiNzU0 ZmEwMDhhMWM1OGIwMzBmMzY3MWFmNjk2OGI4ZDE0ZTEzOC4uNTVjMDY2MWNlMDJmMDEyYjA5OTcz YzdkNjVmNjhkZGU3NDgzNWQxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQ SS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQpAQCAtMjk0LDcgKzI5NCw3IEBAIHN0 YXRpYyBOU1N0cmluZyAqZXNjYXBlS2V5KE5TU3RyaW5nICprZXkpCiAgICAgcmV0dXJuIFtzZWxm IGRlY29kZU9iamVjdE9mQ2xhc3NlczpuaWwgZm9yS2V5OmtleV07CiB9CiAKLXN0YXRpYyBpZCBk ZWNvZGVPYmplY3QoV0tSZW1vdGVPYmplY3REZWNvZGVyICpkZWNvZGVyLCBjb25zdCBJbW11dGFi bGVEaWN0aW9uYXJ5Kik7CitzdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVtb3RlT2JqZWN0RGVj b2RlciAqLCBjb25zdCBJbW11dGFibGVEaWN0aW9uYXJ5KiwgTlNTZXQgKmFsbG93ZWRDbGFzc2Vz KTsKIAogc3RhdGljIGlkIGRlY29kZU9iamVjdEZyb21PYmplY3RTdHJlYW0oV0tSZW1vdGVPYmpl Y3REZWNvZGVyICpkZWNvZGVyLCBOU1NldCAqYWxsb3dlZENsYXNzZXMpCiB7CkBAIC0zMDQsMTEg KzMwNCw5IEBAIHN0YXRpYyBpZCBkZWNvZGVPYmplY3RGcm9tT2JqZWN0U3RyZWFtKFdLUmVtb3Rl T2JqZWN0RGVjb2RlciAqZGVjb2RlciwgTlNTZXQgKmFsCiAgICAgaWYgKGRlY29kZXItPl9vYmpl Y3RTdHJlYW1Qb3NpdGlvbiA9PSBkZWNvZGVyLT5fb2JqZWN0U3RyZWFtLT5zaXplKCkpCiAgICAg ICAgIHJldHVybiBuaWw7CiAKLSAgICBUZW1wb3JhcnlDaGFuZ2U8TlNTZXQgKj4gYWxsb3dlZENs YXNzZXNDaGFuZ2UoZGVjb2Rlci0+X2FsbG93ZWRDbGFzc2VzLCBhbGxvd2VkQ2xhc3Nlcyk7Ci0K ICAgICBjb25zdCBJbW11dGFibGVEaWN0aW9uYXJ5KiBkaWN0aW9uYXJ5ID0gZGVjb2Rlci0+X29i amVjdFN0cmVhbS0+YXQ8SW1tdXRhYmxlRGljdGlvbmFyeT4oZGVjb2Rlci0+X29iamVjdFN0cmVh bVBvc2l0aW9uKyspOwogCi0gICAgcmV0dXJuIGRlY29kZU9iamVjdChkZWNvZGVyLCBkaWN0aW9u YXJ5KTsKKyAgICByZXR1cm4gZGVjb2RlT2JqZWN0KGRlY29kZXIsIGRpY3Rpb25hcnksIGFsbG93 ZWRDbGFzc2VzKTsKIH0KIAogc3RhdGljIHZvaWQgY2hlY2tJZkNsYXNzSXNBbGxvd2VkKFdLUmVt b3RlT2JqZWN0RGVjb2RlciAqZGVjb2RlciwgQ2xhc3Mgb2JqZWN0Q2xhc3MpCkBAIC00NDMsMTMg KzQ0MSwxOSBAQCBzdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVtb3RlT2JqZWN0RGVjb2RlciAq ZGVjb2RlcikKICAgICByZXR1cm4gW3Jlc3VsdC5sZWFrUmVmKCkgYXV0b3JlbGVhc2VdOwogfQog Ci1zdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVtb3RlT2JqZWN0RGVjb2RlciAqZGVjb2Rlciwg Y29uc3QgSW1tdXRhYmxlRGljdGlvbmFyeSogZGljdGlvbmFyeSkKK3N0YXRpYyBpZCBkZWNvZGVP YmplY3QoV0tSZW1vdGVPYmplY3REZWNvZGVyICpkZWNvZGVyLCBjb25zdCBJbW11dGFibGVEaWN0 aW9uYXJ5KiBkaWN0aW9uYXJ5LCBOU1NldCAqYWxsb3dlZENsYXNzZXMpCiB7CiAgICAgaWYgKCFk aWN0aW9uYXJ5KQogICAgICAgICByZXR1cm4gbmlsOwogCiAgICAgVGVtcG9yYXJ5Q2hhbmdlPGNv bnN0IEltbXV0YWJsZURpY3Rpb25hcnkqPiBkaWN0aW9uYXJ5Q2hhbmdlKGRlY29kZXItPl9jdXJy ZW50RGljdGlvbmFyeSwgZGljdGlvbmFyeSk7CiAKKyAgICAvLyBJZiBubyBhbGxvd2VkIGNsYXNz ZXMgd2VyZSBsaXN0ZWQsIGp1c3QgdXNlIHRoZSBjdXJyZW50bHkgYWxsb3dlZCBjbGFzc2VzLgor ICAgIGlmICghYWxsb3dlZENsYXNzZXMpCisgICAgICAgIGFsbG93ZWRDbGFzc2VzID0gZGVjb2Rl ci0+X2FsbG93ZWRDbGFzc2VzOworCisgICAgVGVtcG9yYXJ5Q2hhbmdlPE5TU2V0ICo+IGFsbG93 ZWRDbGFzc2VzQ2hhbmdlKGRlY29kZXItPl9hbGxvd2VkQ2xhc3NlcywgYWxsb3dlZENsYXNzZXMp OworCiAgICAgcmV0dXJuIGRlY29kZU9iamVjdChkZWNvZGVyKTsKIH0KIApAQCAtNDg2LDkgKzQ5 MCw3IEBAIHN0YXRpYyBpZCBkZWNvZGVPYmplY3QoV0tSZW1vdGVPYmplY3REZWNvZGVyICpkZWNv ZGVyLCBjb25zdCBJbW11dGFibGVEaWN0aW9uYXJ5CiAKIC0gKGlkKWRlY29kZU9iamVjdE9mQ2xh c3NlczooTlNTZXQgKiljbGFzc2VzIGZvcktleTooTlNTdHJpbmcgKilrZXkKIHsKLSAgICBUZW1w b3JhcnlDaGFuZ2U8TlNTZXQgKj4gYWxsb3dlZENsYXNzZXNDaGFuZ2UoX2FsbG93ZWRDbGFzc2Vz LCBjbGFzc2VzKTsKLQotICAgIHJldHVybiBkZWNvZGVPYmplY3Qoc2VsZiwgX2N1cnJlbnREaWN0 aW9uYXJ5LT5nZXQ8SW1tdXRhYmxlRGljdGlvbmFyeT4oZXNjYXBlS2V5KGtleSkpKTsKKyAgICBy ZXR1cm4gZGVjb2RlT2JqZWN0KHNlbGYsIF9jdXJyZW50RGljdGlvbmFyeS0+Z2V0PEltbXV0YWJs ZURpY3Rpb25hcnk+KGVzY2FwZUtleShrZXkpKSwgY2xhc3Nlcyk7CiB9CiAKIC0gKE5TU2V0ICop YWxsb3dlZENsYXNzZXMK