123921 2013-11-06 13:36:55 -0800 Web Inspector: ResourceSidebarPanel.prototype.showSourceCode throws an exception when positionToReveal is null 2013-11-06 19:47:47 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 947884 0 timothy 2013-11-06 13:36:55 -0800 The cookie object rise to access positionToReveal when it is allowed to be null. 947887 1 webkit-bug-importer 2013-11-06 13:37:20 -0800 <rdar://problem/15407290> 947889 2 216216 timothy 2013-11-06 13:38:07 -0800 Created attachment 216216 Patch 947930 3 216216 joepeck 2013-11-06 14:45:26 -0800 Comment on attachment 216216 Patch r=me 947944 4 216216 commit-queue 2013-11-06 15:09:21 -0800 Comment on attachment 216216 Patch Rejecting attachment 216216 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216216, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: es to CodeGeneratorInspectorStrings.py should rebuild inspector generated files The copy of the patch that failed is found in: /Volumes/Data/EWS/Webkit/.git/rebase-apply/patch When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 123. Full output: http://webkit-queues.appspot.com/results/22758015 948043 5 216216 commit-queue 2013-11-06 19:47:45 -0800 Comment on attachment 216216 Patch Clearing flags on attachment: 216216 Committed r158816: <http://trac.webkit.org/changeset/158816> 948045 6 commit-queue 2013-11-06 19:47:47 -0800 All reviewed patches have been landed. Closing bug. 216216 2013-11-06 13:38:07 -0800 2013-11-06 19:47:45 -0800 Patch 123921.patch text/plain 1563 timothy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYxNjVjZmMuLjA5Mzc1NzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTA2ICBUaW1vdGh5IEhhdGNo ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9wZXJseSBudWxsIGNoZWNrIHBv c2l0aW9uVG9SZXZlYWwgaW4gUmVzb3VyY2VTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3dTb3Vy Y2VDb2RlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjM5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3dTb3VyY2VDb2RlKToK KwogMjAxMy0xMC0yNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAg ICAgICAgSW1wbGVtZW50IFRpbWVsaW5lUmVjb3JkaW5nIGFuZCBwZXItY2FsbC1zaXRlIHRpbWVs aW5lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Jl c291cmNlU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanMKaW5kZXggYzQyZTdlMS4uYjMwOTUyNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUmVzb3VyY2VTaWRlYmFy UGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUmVzb3Vy Y2VTaWRlYmFyUGFuZWwuanMKQEAgLTE1MSw3ICsxNTEsNyBAQCBXZWJJbnNwZWN0b3IuUmVzb3Vy Y2VTaWRlYmFyUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgcmVwcmVzZW50ZWRPYmpl Y3QgPSByZXByZXNlbnRlZE9iamVjdC5wYXJlbnRGcmFtZTsKIAogICAgICAgICB2YXIgbmV3Q29u dGVudFZpZXcgPSBXZWJJbnNwZWN0b3IuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdGb3JSZXBy ZXNlbnRlZE9iamVjdChyZXByZXNlbnRlZE9iamVjdCk7Ci0gICAgICAgIHZhciBjb29raWUgPSB7 bGluZU51bWJlcjogcG9zaXRpb25Ub1JldmVhbC5saW5lTnVtYmVyLCBjb2x1bW5OdW1iZXI6IHBv c2l0aW9uVG9SZXZlYWwuY29sdW1uTnVtYmVyfTsKKyAgICAgICAgdmFyIGNvb2tpZSA9IHBvc2l0 aW9uVG9SZXZlYWwgPyB7bGluZU51bWJlcjogcG9zaXRpb25Ub1JldmVhbC5saW5lTnVtYmVyLCBj b2x1bW5OdW1iZXI6IHBvc2l0aW9uVG9SZXZlYWwuY29sdW1uTnVtYmVyfSA6IHt9OwogCiAgICAg ICAgIFdlYkluc3BlY3Rvci5jb250ZW50QnJvd3Nlci5zaG93Q29udGVudFZpZXcobmV3Q29udGVu dFZpZXcsIGNvb2tpZSk7CiAgICAgfSwK