123911 2013-11-06 12:03:00 -0800 DFG CheckArray(NonArray) should prove that the child isn't an array 2013-11-06 13:43:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough eflews.bot ggaren gyuyoung.kim mark.lam mhahnenberg msaboff oliver rniwa sam oldest_to_newest 947823 0 fpizlo 2013-11-06 12:03:00 -0800 Patch forthcoming. 947824 1 fpizlo 2013-11-06 12:03:20 -0800 <rdar://problem/15202803> 947827 2 216201 fpizlo 2013-11-06 12:06:47 -0800 Created attachment 216201 the patch 947833 3 216201 eflews.bot 2013-11-06 12:11:34 -0800 Comment on attachment 216201 the patch Attachment 216201 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22428006 947834 4 216201 mhahnenberg 2013-11-06 12:13:33 -0800 Comment on attachment 216201 the patch r=me with fixed ports. 947842 5 fpizlo 2013-11-06 12:30:42 -0800 Landed in http://trac.webkit.org/changeset/158773 947893 6 rniwa 2013-11-06 13:43:10 -0800 Looks like the test added by this patch has been failing: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=js%2Fdfg-check-array-non-array.html e.g. http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r158781%20(554)/results.html --- /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/js/dfg-check-array-non-array-expected.txt +++ /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/js/dfg-check-array-non-array-actual.txt @@ -1,10 +1,10 @@ +CONSOLE MESSAGE: line 24: ReferenceError: Can't find variable: neverInlineFunction Tests that CheckArray(NonArray) actually proves that the input isn't an array. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS baz(["blah"], true) is "blahblah" -PASS successfullyParsed is true +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE 216201 2013-11-06 12:06:47 -0800 2013-11-06 12:13:32 -0800 the patch blah.patch text/plain 5828 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NzY1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENoZWNrQXJyYXkoTm9uQXJyYXkpIHNob3VsZCBwcm92ZSB0aGF0IHRoZSByZXN1bHQgaXNu J3QgYW4gYXJyYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMzkxMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTUyMDI4MDM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRp dmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpqdW1wU2xvd0Zv clVud2FudGVkQXJyYXlNb2RlKToKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3Bw OgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjppc0FycmF5VHlwZSk6CisKIDIw MTMtMTEtMDYgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAg ICAgICBKU0V4cG9ydCBkb2Vzbid0IHN1cHBvcnQgY29uc3RydWN0b3JzCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24g MTU4NjA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTY3MSwxMCArNjcxLDE4IEBAIEpJVENvbXBpbGVyOjpKdW1w IFNwZWN1bGF0aXZlSklUOjpqdW1wU2wKICAgICAgICAgcmV0dXJuIG1faml0LmJyYW5jaDMyKAog ICAgICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6Ok5vdEVxdWFsLCB0ZW1wR1BSLCBUcnVzdGVkSW1t MzIoSXNBcnJheSB8IHNoYXBlKSk7CiAgICAgICAgIAotICAgIGRlZmF1bHQ6CisgICAgY2FzZSBB cnJheTo6Tm9uQXJyYXk6CisgICAgY2FzZSBBcnJheTo6T3JpZ2luYWxOb25BcnJheToKKyAgICAg ICAgbV9qaXQuYW5kMzIoVHJ1c3RlZEltbTMyKElzQXJyYXkgfCBJbmRleGluZ1NoYXBlTWFzayks IHRlbXBHUFIpOworICAgICAgICByZXR1cm4gbV9qaXQuYnJhbmNoMzIoCisgICAgICAgICAgICBN YWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIHRlbXBHUFIsIFRydXN0ZWRJbW0zMihzaGFwZSkpOwor ICAgICAgICAKKyAgICBjYXNlIEFycmF5OjpQb3NzaWJseUFycmF5OgogICAgICAgICBtX2ppdC5h bmQzMihUcnVzdGVkSW1tMzIoSW5kZXhpbmdTaGFwZU1hc2spLCB0ZW1wR1BSKTsKICAgICAgICAg cmV0dXJuIG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpOb3RFcXVhbCwgdGVtcEdQUiwg VHJ1c3RlZEltbTMyKHNoYXBlKSk7CiAgICAgfQorICAgIAorICAgIFJFTEVBU0VfQVNTRVJUX05P VF9SRUFDSEVEKCk7CiB9CiAKIEpJVENvbXBpbGVyOjpKdW1wTGlzdCBTcGVjdWxhdGl2ZUpJVDo6 anVtcFNsb3dGb3JVbndhbnRlZEFycmF5TW9kZShHUFJSZWcgdGVtcEdQUiwgQXJyYXlNb2RlIGFy cmF5TW9kZSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJE RkdUb0xMVk0uY3BwCShyZXZpc2lvbiAxNTg2MDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAyMCwxMSArMzAy MCwxOSBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICBtX291dC5iaXRBbmQoaW5kZXhp bmdUeXBlLCBtX291dC5jb25zdEludDgoSXNBcnJheSB8IEluZGV4aW5nU2hhcGVNYXNrKSksCiAg ICAgICAgICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50OChJc0FycmF5IHwgYXJyYXlNb2RlLnNo YXBlTWFzaygpKSk7CiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICBkZWZhdWx0OgorICAg ICAgICAgICAgY2FzZSBBcnJheTo6Tm9uQXJyYXk6CisgICAgICAgICAgICBjYXNlIEFycmF5OjpP cmlnaW5hbE5vbkFycmF5OgorICAgICAgICAgICAgICAgIHJldHVybiBtX291dC5lcXVhbCgKKyAg ICAgICAgICAgICAgICAgICAgbV9vdXQuYml0QW5kKGluZGV4aW5nVHlwZSwgbV9vdXQuY29uc3RJ bnQ4KElzQXJyYXkgfCBJbmRleGluZ1NoYXBlTWFzaykpLAorICAgICAgICAgICAgICAgICAgICBt X291dC5jb25zdEludDgoYXJyYXlNb2RlLnNoYXBlTWFzaygpKSk7CisgICAgICAgICAgICAgICAg CisgICAgICAgICAgICBjYXNlIEFycmF5OjpQb3NzaWJseUFycmF5OgogICAgICAgICAgICAgICAg IHJldHVybiBtX291dC5lcXVhbCgKICAgICAgICAgICAgICAgICAgICAgbV9vdXQuYml0QW5kKGlu ZGV4aW5nVHlwZSwgbV9vdXQuY29uc3RJbnQ4KEluZGV4aW5nU2hhcGVNYXNrKSksCiAgICAgICAg ICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50OChhcnJheU1vZGUuc2hhcGVNYXNrKCkpKTsKICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9U X1JFQUNIRUQoKTsKICAgICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgIGRlZmF1bHQ6Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTg3NjUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0xMS0wNiAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgorCisgICAgICAgIERGRyBDaGVja0FycmF5KE5vbkFycmF5KSBzaG91bGQg cHJvdmUgdGhhdCB0aGUgcmVzdWx0IGlzbid0IGFuIGFycmF5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM5MTEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzE1MjAyODAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICoganMvZGZnLWNoZWNrLWFycmF5LW5vbi1hcnJheS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGpzL2RmZy1jaGVjay1hcnJheS1ub24tYXJyYXkuaHRtbDogQWRkZWQuCisg ICAgICAgICoganMvc2NyaXB0LXRlc3RzL2RmZy1jaGVjay1hcnJheS1ub24tYXJyYXkuanM6IEFk ZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKGJhcik6CisgICAgICAgIChiYXopOgorCiAy MDEzLTExLTA2ICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KIAogICAgICAg ICBBZGQgImlkIiBhdHRyaWJ1dGUgdG8gVGV4dFRyYWNrCkluZGV4OiBMYXlvdXRUZXN0cy9qcy9k ZmctY2hlY2stYXJyYXktbm9uLWFycmF5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9qcy9kZmctY2hlY2stYXJyYXktbm9uLWFycmF5LWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2pzL2RmZy1jaGVjay1hcnJheS1ub24tYXJyYXktZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3RzIHRoYXQgQ2hlY2tB cnJheShOb25BcnJheSkgYWN0dWFsbHkgcHJvdmVzIHRoYXQgdGhlIGlucHV0IGlzbid0IGFuIGFy cmF5LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBiYXooWyJibGFoIl0s IHRydWUpIGlzICJibGFoYmxhaCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9qcy9kZmctY2hlY2stYXJyYXktbm9u LWFycmF5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvZGZnLWNoZWNrLWFycmF5 LW5vbi1hcnJheS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvZGZnLWNoZWNr LWFycmF5LW5vbi1hcnJheS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKKzwh RE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhl YWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9kZmctY2hlY2stYXJy YXktbm9uLWFycmF5LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRl c3RzL2pzL3NjcmlwdC10ZXN0cy9kZmctY2hlY2stYXJyYXktbm9uLWFycmF5LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9kZmctY2hlY2stYXJyYXktbm9uLWFy cmF5LmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RmZy1j aGVjay1hcnJheS1ub24tYXJyYXkuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzNyBAQAor ZGVzY3JpcHRpb24oCisiVGVzdHMgdGhhdCBDaGVja0FycmF5KE5vbkFycmF5KSBhY3R1YWxseSBw cm92ZXMgdGhhdCB0aGUgaW5wdXQgaXNuJ3QgYW4gYXJyYXkuIgorKTsKKworZnVuY3Rpb24gZm9v KGEsIGkpIHsKKyAgICByZXR1cm4gYVtpXTsKK30KKworZnVuY3Rpb24gYmFyKG8sIHAsIHEpIHsK KyAgICBpZiAocSkKKyAgICAgICAgbyA9IDQyOworICAgIGlmIChwKQorICAgICAgICByZXR1cm4g b1swXTsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiA0MjsKK30KKworZnVuY3Rpb24gYmF6KG8s IHApIHsKKyAgICB2YXIgcmVzdWx0ID0gZm9vKG8sIDApOworICAgIHJlc3VsdCArPSBiYXIobywg cCwgZmFsc2UpOworICAgIHJldHVybiByZXN1bHQ7Cit9CisKK25ldmVySW5saW5lRnVuY3Rpb24o YmF6KTsKKworLy8gR2V0IGJhcidzIHByb2ZpbGluZyB0byBjbGFpbSB0aGF0IGl0IHNlZW1zIGEg cGFydGljdWxhciBvcmlnaW5hbCBhcnJheS4KK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwOyArK2kp CisgICAgYmFyKFsiZml6eiJdLCB0cnVlLCBmYWxzZSk7CisKK3doaWxlICghZGZnQ29tcGlsZWQo e2Y6YmF6fSkpIHsKKyAgICB2YXIgbyA9IHt9OworICAgIG9bMF0gPSAiYnV6eiI7CisgICAgYmF6 KG8sIGZhbHNlKTsKK30KKworc2hvdWxkQmUoImJheihbXCJibGFoXCJdLCB0cnVlKSIsICJcImJs YWhibGFoXCIiKTsKKwo=