123900 2013-11-06 10:02:15 -0800 [GTK] Pass the library namespace to gtkdoc-mkdb 2013-11-08 00:10:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson oldest_to_newest 947757 0 cgarcia 2013-11-06 10:02:15 -0800 This fixes the generation of the index of symbols in the API documentation. We are currently generating a single entry for all symbols starting with W (all of them), see for example: http://webkitgtk.org/reference/webkitgtk/unstable/index-all.html 947758 1 216188 cgarcia 2013-11-06 10:05:02 -0800 Created attachment 216188 Patch 947760 2 216188 mrobinson 2013-11-06 10:08:03 -0800 Comment on attachment 216188 Patch Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'? 948091 3 cgarcia 2013-11-06 23:29:17 -0800 (In reply to comment #2) > (From update of attachment 216188 [details]) > Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'? It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it. 948231 4 216295 cgarcia 2013-11-07 05:20:48 -0800 Created attachment 216295 Updated patch Use namespace. 948263 5 mrobinson 2013-11-07 08:06:31 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 216188 [details] [details]) > > Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'? > > It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it. Oh! Didn't notice that. Another quirk of gtkdoc. 948562 6 cgarcia 2013-11-08 00:10:17 -0800 Committed r158908: <http://trac.webkit.org/changeset/158908> 216188 2013-11-06 10:05:02 -0800 2013-11-07 05:20:48 -0800 Patch wkgtk-doc-index.diff text/plain 3576 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMGUy ZDNkLi45Y2NjMTIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMTEtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFBhc3MgdGhlIGxpYnJhcnkg bmFtZXNwYWNlIHRvIGd0a2RvYy1ta2RiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjM5MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSBnZW5lcmF0aW9uIG9mIHRoZSBpbmRleCBv ZiBzeW1ib2xzIGluIHRoZSBBUEkKKyAgICAgICAgZG9jdW1lbnRhdGlvbi4KKworICAgICAgICAq IGd0ay9nZW5lcmF0ZS1ndGtkb2M6CisgICAgICAgIChnZXRfd2Via2l0Ml9vcHRpb25zKTogRGVm aW5lIG5hbWUtc3BhY2UgYXMgV2ViS2l0LgorICAgICAgICAoZ2V0X3dlYmtpdDFfb3B0aW9ucyk6 IERpdHRvLgorICAgICAgICAoZ2V0X3dlYmtpdGRvbV9vcHRpb25zKTogRGVmaW5lIG5hbWUtc3Bh Y2UgYXMgV2ViS2l0RE9NLgorICAgICAgICAqIGd0ay9ndGtkb2MucHk6CisgICAgICAgIChHVEtE b2MuX19pbml0X18pOiBBZGQgbmFtZV9zcGFjZSBvcHRpb24uCisgICAgICAgIChHVEtEb2MuX3J1 bl9ndGtkb2NfbWtkYik6IFBhc3MgbmFtZV9zcGFjZSB0byBta2RiIGlmIHByZXNlbnQuCisKIDIw MTMtMTEtMDUgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtXSzJdIEFkZCBhIFdlYktpdDIgQVBJIGZvciBHZW9sb2NhdGlvbidzIGhpZ2hBY2N1cmFj eQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyBiL1Rvb2xzL2d0ay9nZW5l cmF0ZS1ndGtkb2MKaW5kZXggNzBhZmQ2MC4uNDIwN2Q5OSAxMDA3NTUKLS0tIGEvVG9vbHMvZ3Rr L2dlbmVyYXRlLWd0a2RvYworKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCkBAIC05MSw2 ICs5MSw3IEBAIGRlZiBnZXRfd2Via2l0Ml9vcHRpb25zKCk6CiAgICAgb3B0aW9ucyA9IGdldF9j b21tb25fb3B0aW9ucygpLmNvcHkoKQogICAgIG9wdGlvbnMudXBkYXRlKHsKICAgICAgICAgJ21v ZHVsZV9uYW1lJyA6ICd3ZWJraXQyZ3RrJywKKyAgICAgICAgJ25hbWVfc3BhY2UnIDogJ1dlYktp dCcsCiAgICAgICAgICdkb2NfZGlyJyA6IHNyY19wYXRoKCdkb2NzJyksCiAgICAgICAgICdvdXRw dXRfZGlyJyA6IGNvbW1vbi5idWlsZF9wYXRoKCdEb2N1bWVudGF0aW9uJywgJ3dlYmtpdDJndGsn KSwKICAgICAgICAgJ3NvdXJjZV9kaXJzJyA6IFtzcmNfcGF0aCgpLCBkZXJpdmVkX3NvdXJjZXNf cGF0aCgnd2Via2l0Mmd0aycsICd3ZWJraXQyJyksIGluamVjdGVkX2J1bmRsZV9zcmNfcGF0aCgp XSwKQEAgLTEzMSw2ICsxMzIsNyBAQCBkZWYgZ2V0X3dlYmtpdDFfb3B0aW9ucyhndGtfdmVyc2lv bik6CiAgICAgb3B0aW9ucyA9IGdldF9jb21tb25fb3B0aW9ucygpLmNvcHkoKQogICAgIG9wdGlv bnMudXBkYXRlKHsKICAgICAgICAgJ21vZHVsZV9uYW1lJyA6ICd3ZWJraXRndGsnLAorICAgICAg ICAnbmFtZV9zcGFjZScgOiAnV2ViS2l0JywKICAgICAgICAgJ2RvY19kaXInIDogc3JjX3BhdGgo J2RvY3MnKSwKICAgICAgICAgJ291dHB1dF9kaXInIDogY29tbW9uLmJ1aWxkX3BhdGgoJ0RvY3Vt ZW50YXRpb24nLCAnd2Via2l0Z3RrJyksCiAgICAgICAgICdzb3VyY2VfZGlycycgOiBbc3JjX3Bh dGgoJ3dlYmtpdCcpLCBjb21tb24uYnVpbGRfcGF0aCgnU291cmNlJywgJ1dlYktpdCcsICdndGsn LCAnd2Via2l0JyldLApAQCAtMTU3LDYgKzE1OSw3IEBAIGRlZiBnZXRfd2Via2l0ZG9tX29wdGlv bnMoKToKICAgICBvcHRpb25zID0gZ2V0X2NvbW1vbl9vcHRpb25zKCkuY29weSgpCiAgICAgb3B0 aW9ucy51cGRhdGUoewogICAgICAgICAnbW9kdWxlX25hbWUnIDogJ3dlYmtpdGRvbWd0aycsCisg ICAgICAgICduYW1lX3NwYWNlJyA6ICdXZWJLaXRET00nLAogICAgICAgICAnZG9jX2RpcicgOiBk ZXJpdmVkX3NvdXJjZXNfcGF0aCgnZG9jcycpLAogICAgICAgICAnb3V0cHV0X2RpcicgOiBjb21t b24uYnVpbGRfcGF0aCgnRG9jdW1lbnRhdGlvbicsICd3ZWJraXRkb21ndGsnKSwKICAgICAgICAg J3NvdXJjZV9kaXJzJyA6IFtkZXJpdmVkX3NvdXJjZXNfcGF0aCgpXSwKZGlmZiAtLWdpdCBhL1Rv b2xzL2d0ay9ndGtkb2MucHkgYi9Ub29scy9ndGsvZ3RrZG9jLnB5CmluZGV4IGU5Yzc5OTMuLmQ3 ODFiMjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9ndGtkb2MucHkKKysrIGIvVG9vbHMvZ3RrL2d0 a2RvYy5weQpAQCAtNDMsNiArNDMsNyBAQCBjbGFzcyBHVEtEb2Mob2JqZWN0KToKICAgICAgICAg ICAgICAgICAgICAgICAgICAgb25seSBuZWNlc3NhcnkgdG8gcHJvdmlkZSB0aGUgYmFzZW5hbWVz IG9mIHRoZXNlIGZpbGVzLgogICAgICAgICAgICAgICAgICAgICAgICAgICBUeXBpY2FsbHkgaXQg aXMgaW1wb3J0YW50IHRvIHByb3ZpZGUgYW4gdXBkYXRlZCBsaXN0IG9mCiAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlnbm9yZWQgZmlsZXMgdG8gcHJldmVudCB3YXJuaW5ncyBhYm91dCB1bmRv Y3VtZW50ZWQgc3ltYm9scy4KKyAgICBuYW1lX3NwYWNlICAgICAgICAgLS0gVGhlIGxpYnJhcnkg bmFtZXNwYWNlLgogICAgIGRlY29yYXRvciAgICAgICAgICAtLSBJZiBhIGRlY29yYXRvciBpcyB1 c2VkIHRvIHVuaGlkZSBjZXJ0YWluIHN5bWJvbHMgaW4gaGVhZGVyCiAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZpbGVzIHRoaXMgcGFyYW1ldGVyIGlzIHJlcXVpcmVkIGZvciBzdWNjZXNzZnVs IHNjYW5uaW5nLgogICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVmYXVsdCAnJykKQEAgLTg3 LDYgKzg4LDcgQEAgY2xhc3MgR1RLRG9jKG9iamVjdCk6CiAgICAgICAgIHNlbGYubW9kdWxlX25h bWUgPSAnJwogICAgICAgICBzZWxmLnNvdXJjZV9kaXJzID0gW10KICAgICAgICAgc2VsZi5pZ25v cmVkX2ZpbGVzID0gW10KKyAgICAgICAgc2VsZi5uYW1lX3NwYWNlID0gJycKICAgICAgICAgc2Vs Zi5kZWNvcmF0b3IgPSAnJwogICAgICAgICBzZWxmLmRlcHJlY2F0aW9uX2d1YXJkID0gJycKIApA QCAtMzMxLDYgKzMzMyw5IEBAIGNsYXNzIEdUS0RvYyhvYmplY3QpOgogICAgICAgICAgICAgICAg ICctLW91dHB1dC1mb3JtYXQ9eG1sJywKICAgICAgICAgICAgICAgICAnLS1zZ21sLW1vZGUnXQog CisgICAgICAgIGlmIHNlbGYubmFtZV9zcGFjZToKKyAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCct LW5hbWUtc3BhY2U9JXMnICUgc2VsZi5uYW1lX3NwYWNlKQorCiAgICAgICAgIGlnbm9yZWRfZmls ZXNfYmFzZW5hbWVzID0gc2VsZi5faWdub3JlZF9maWxlc19iYXNlbmFtZXMoKQogICAgICAgICBp ZiBpZ25vcmVkX2ZpbGVzX2Jhc2VuYW1lczoKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCctLWln bm9yZS1maWxlcz0lcycgJSBpZ25vcmVkX2ZpbGVzX2Jhc2VuYW1lcykK 216295 2013-11-07 05:20:48 -0800 2013-11-07 08:05:45 -0800 Updated patch wk-gtkdoc-namespace.diff text/plain 3566 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMGUy ZDNkLi5lYTFhYTY4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMTEtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFBhc3MgdGhlIGxpYnJhcnkg bmFtZXNwYWNlIHRvIGd0a2RvYy1ta2RiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjM5MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSBnZW5lcmF0aW9uIG9mIHRoZSBpbmRleCBv ZiBzeW1ib2xzIGluIHRoZSBBUEkKKyAgICAgICAgZG9jdW1lbnRhdGlvbi4KKworICAgICAgICAq IGd0ay9nZW5lcmF0ZS1ndGtkb2M6CisgICAgICAgIChnZXRfd2Via2l0Ml9vcHRpb25zKTogRGVm aW5lIG5hbWVzcGFjZSBhcyBXZWJLaXQuCisgICAgICAgIChnZXRfd2Via2l0MV9vcHRpb25zKTog RGl0dG8uCisgICAgICAgIChnZXRfd2Via2l0ZG9tX29wdGlvbnMpOiBEZWZpbmUgbmFtZXNwYWNl IGFzIFdlYktpdERPTS4KKyAgICAgICAgKiBndGsvZ3RrZG9jLnB5OgorICAgICAgICAoR1RLRG9j Ll9faW5pdF9fKTogQWRkIG5hbWVzcGFjZSBvcHRpb24uCisgICAgICAgIChHVEtEb2MuX3J1bl9n dGtkb2NfbWtkYik6IFBhc3MgbmFtZXNwYWNlIHRvIG1rZGIgaWYgcHJlc2VudC4KKwogMjAxMy0x MS0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W1dLMl0gQWRkIGEgV2ViS2l0MiBBUEkgZm9yIEdlb2xvY2F0aW9uJ3MgaGlnaEFjY3VyYWN5CmRp ZmYgLS1naXQgYS9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jIGIvVG9vbHMvZ3RrL2dlbmVyYXRl LWd0a2RvYwppbmRleCA3MGFmZDYwLi5iZmU5MzAwIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvZ2Vu ZXJhdGUtZ3RrZG9jCisrKyBiL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MKQEAgLTkxLDYgKzkx LDcgQEAgZGVmIGdldF93ZWJraXQyX29wdGlvbnMoKToKICAgICBvcHRpb25zID0gZ2V0X2NvbW1v bl9vcHRpb25zKCkuY29weSgpCiAgICAgb3B0aW9ucy51cGRhdGUoewogICAgICAgICAnbW9kdWxl X25hbWUnIDogJ3dlYmtpdDJndGsnLAorICAgICAgICAnbmFtZXNwYWNlJyA6ICdXZWJLaXQnLAog ICAgICAgICAnZG9jX2RpcicgOiBzcmNfcGF0aCgnZG9jcycpLAogICAgICAgICAnb3V0cHV0X2Rp cicgOiBjb21tb24uYnVpbGRfcGF0aCgnRG9jdW1lbnRhdGlvbicsICd3ZWJraXQyZ3RrJyksCiAg ICAgICAgICdzb3VyY2VfZGlycycgOiBbc3JjX3BhdGgoKSwgZGVyaXZlZF9zb3VyY2VzX3BhdGgo J3dlYmtpdDJndGsnLCAnd2Via2l0MicpLCBpbmplY3RlZF9idW5kbGVfc3JjX3BhdGgoKV0sCkBA IC0xMzEsNiArMTMyLDcgQEAgZGVmIGdldF93ZWJraXQxX29wdGlvbnMoZ3RrX3ZlcnNpb24pOgog ICAgIG9wdGlvbnMgPSBnZXRfY29tbW9uX29wdGlvbnMoKS5jb3B5KCkKICAgICBvcHRpb25zLnVw ZGF0ZSh7CiAgICAgICAgICdtb2R1bGVfbmFtZScgOiAnd2Via2l0Z3RrJywKKyAgICAgICAgJ25h bWVzcGFjZScgOiAnV2ViS2l0JywKICAgICAgICAgJ2RvY19kaXInIDogc3JjX3BhdGgoJ2RvY3Mn KSwKICAgICAgICAgJ291dHB1dF9kaXInIDogY29tbW9uLmJ1aWxkX3BhdGgoJ0RvY3VtZW50YXRp b24nLCAnd2Via2l0Z3RrJyksCiAgICAgICAgICdzb3VyY2VfZGlycycgOiBbc3JjX3BhdGgoJ3dl YmtpdCcpLCBjb21tb24uYnVpbGRfcGF0aCgnU291cmNlJywgJ1dlYktpdCcsICdndGsnLCAnd2Vi a2l0JyldLApAQCAtMTU3LDYgKzE1OSw3IEBAIGRlZiBnZXRfd2Via2l0ZG9tX29wdGlvbnMoKToK ICAgICBvcHRpb25zID0gZ2V0X2NvbW1vbl9vcHRpb25zKCkuY29weSgpCiAgICAgb3B0aW9ucy51 cGRhdGUoewogICAgICAgICAnbW9kdWxlX25hbWUnIDogJ3dlYmtpdGRvbWd0aycsCisgICAgICAg ICduYW1lc3BhY2UnIDogJ1dlYktpdERPTScsCiAgICAgICAgICdkb2NfZGlyJyA6IGRlcml2ZWRf c291cmNlc19wYXRoKCdkb2NzJyksCiAgICAgICAgICdvdXRwdXRfZGlyJyA6IGNvbW1vbi5idWls ZF9wYXRoKCdEb2N1bWVudGF0aW9uJywgJ3dlYmtpdGRvbWd0aycpLAogICAgICAgICAnc291cmNl X2RpcnMnIDogW2Rlcml2ZWRfc291cmNlc19wYXRoKCldLApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr L2d0a2RvYy5weSBiL1Rvb2xzL2d0ay9ndGtkb2MucHkKaW5kZXggZTljNzk5My4uZDFlZDlkNCAx MDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2d0a2RvYy5weQorKysgYi9Ub29scy9ndGsvZ3RrZG9jLnB5 CkBAIC00Myw2ICs0Myw3IEBAIGNsYXNzIEdUS0RvYyhvYmplY3QpOgogICAgICAgICAgICAgICAg ICAgICAgICAgICBvbmx5IG5lY2Vzc2FyeSB0byBwcm92aWRlIHRoZSBiYXNlbmFtZXMgb2YgdGhl c2UgZmlsZXMuCiAgICAgICAgICAgICAgICAgICAgICAgICAgIFR5cGljYWxseSBpdCBpcyBpbXBv cnRhbnQgdG8gcHJvdmlkZSBhbiB1cGRhdGVkIGxpc3Qgb2YKICAgICAgICAgICAgICAgICAgICAg ICAgICAgaWdub3JlZCBmaWxlcyB0byBwcmV2ZW50IHdhcm5pbmdzIGFib3V0IHVuZG9jdW1lbnRl ZCBzeW1ib2xzLgorICAgIG5hbWVzcGFjZSAgICAgICAgICAtLSBUaGUgbGlicmFyeSBuYW1lc3Bh Y2UuCiAgICAgZGVjb3JhdG9yICAgICAgICAgIC0tIElmIGEgZGVjb3JhdG9yIGlzIHVzZWQgdG8g dW5oaWRlIGNlcnRhaW4gc3ltYm9scyBpbiBoZWFkZXIKICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmlsZXMgdGhpcyBwYXJhbWV0ZXIgaXMgcmVxdWlyZWQgZm9yIHN1Y2Nlc3NmdWwgc2Nhbm5p bmcuCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWZhdWx0ICcnKQpAQCAtODcsNiArODgs NyBAQCBjbGFzcyBHVEtEb2Mob2JqZWN0KToKICAgICAgICAgc2VsZi5tb2R1bGVfbmFtZSA9ICcn CiAgICAgICAgIHNlbGYuc291cmNlX2RpcnMgPSBbXQogICAgICAgICBzZWxmLmlnbm9yZWRfZmls ZXMgPSBbXQorICAgICAgICBzZWxmLm5hbWVzcGFjZSA9ICcnCiAgICAgICAgIHNlbGYuZGVjb3Jh dG9yID0gJycKICAgICAgICAgc2VsZi5kZXByZWNhdGlvbl9ndWFyZCA9ICcnCiAKQEAgLTMzMSw2 ICszMzMsOSBAQCBjbGFzcyBHVEtEb2Mob2JqZWN0KToKICAgICAgICAgICAgICAgICAnLS1vdXRw dXQtZm9ybWF0PXhtbCcsCiAgICAgICAgICAgICAgICAgJy0tc2dtbC1tb2RlJ10KIAorICAgICAg ICBpZiBzZWxmLm5hbWVzcGFjZToKKyAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCctLW5hbWUtc3Bh Y2U9JXMnICUgc2VsZi5uYW1lc3BhY2UpCisKICAgICAgICAgaWdub3JlZF9maWxlc19iYXNlbmFt ZXMgPSBzZWxmLl9pZ25vcmVkX2ZpbGVzX2Jhc2VuYW1lcygpCiAgICAgICAgIGlmIGlnbm9yZWRf ZmlsZXNfYmFzZW5hbWVzOgogICAgICAgICAgICAgYXJncy5hcHBlbmQoJy0taWdub3JlLWZpbGVz PSVzJyAlIGlnbm9yZWRfZmlsZXNfYmFzZW5hbWVzKQo=