123899 2013-11-06 09:38:29 -0800 [GTK] Use deprecation guards around deprecated API in GObject DOM bindings 2013-11-08 00:07:33 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue gustavo mrobinson oldest_to_newest 947744 0 cgarcia 2013-11-06 09:38:29 -0800 Do not include deprecated API when compiling with WEBKIT_DISABLE_DEPRECATED option. 947745 1 216185 cgarcia 2013-11-06 09:40:08 -0800 Created attachment 216185 Patch 947752 2 216185 mrobinson 2013-11-06 09:48:55 -0800 Comment on attachment 216185 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review Looking good, with one small nit about the comment style. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009 > + push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); See below. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234 > + push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); See below. > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167 > +#endif /* WEBKIT_DISABLE_DEPRECATED */ I think we typically use C++ style comments for this sort of thing. 947755 3 cgarcia 2013-11-06 09:58:04 -0800 (In reply to comment #2) > (From update of attachment 216185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review > > Looking good, with one small nit about the comment style. > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009 > > + push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); > > See below. > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234 > > + push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); > > See below. > > > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167 > > +#endif /* WEBKIT_DISABLE_DEPRECATED */ > > I think we typically use C++ style comments for this sort of thing. Yes, that's what I thought, but I checked the feature guards and they all use /* */. 947761 4 mrobinson 2013-11-06 10:08:40 -0800 (In reply to comment #3) > Yes, that's what I thought, but I checked the feature guards and they all use /* */. I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :) 947763 5 cgarcia 2013-11-06 10:12:51 -0800 (In reply to comment #4) > (In reply to comment #3) > > > Yes, that's what I thought, but I checked the feature guards and they all use /* */. > > I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :) Yes, I guess, I'll change it before landing then. 947764 6 mrobinson 2013-11-06 10:14:41 -0800 (In reply to comment #5) > Yes, I guess, I'll change it before landing then. Cool. Thanks for the patch! 948232 7 cgarcia 2013-11-07 05:28:38 -0800 (In reply to comment #6) > (In reply to comment #5) > > > Yes, I guess, I'll change it before landing then. > > Cool. Thanks for the patch! hmm, is it really ok to use // in public headers that can be included from C code? or do you want me to change only the comments in the cpp file? 948262 8 mrobinson 2013-11-07 08:05:02 -0800 Sorry. Only the CPP code. 948561 9 cgarcia 2013-11-08 00:07:33 -0800 Committed r158907: <http://trac.webkit.org/changeset/158907> 216185 2013-11-06 09:40:08 -0800 2013-11-06 09:48:55 -0800 Patch wkdom-deprecation-guards.diff text/plain 4307 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZmQyYTI2Li5iNTI5ODYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTEtMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFVzZSBkZXByZWNhdGlvbiBndWFyZHMgYXJvdW5kIGRlcHJlY2F0 ZWQgQVBJIGluIEdPYmplY3QgRE9NIGJpbmRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM4OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgaW5jbHVkZSBkZXByZWNhdGVkIEFQSSB3aGVu IGNvbXBpbGluZyB3aXRoCisgICAgICAgIFdFQktJVF9ESVNBQkxFX0RFUFJFQ0FURUQgb3B0aW9u LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToK KyAgICAgICAgKEdlbmVyYXRlRnVuY3Rpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv dGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RFdmVudFRhcmdldC5jcHA6CisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdEV2ZW50VGFyZ2V0Lmg6CisK IDIwMTMtMTEtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBJbmxpbmVFbGVtZW50Qm94IGFuZCBzdG9wIGluc3RhbnRpYXRpbmcgSW5saW5lQm94IGRp cmVjdGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggNWI0MjkzNS4uMTViODM2MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0 LnBtCkBAIC05NTgsNiArOTU4LDEwIEBAIHN1YiBHZW5lcmF0ZUZ1bmN0aW9uIHsKIAogICAgIHB1 c2goQHN5bWJvbHMsICIkcmV0dXJuVHlwZSAkZnVuY3Rpb25OYW1lKCRzeW1ib2xTaWcpXG4iKTsK IAorICAgIGlmICgkZGVwcmVjYXRpb25WZXJzaW9uKSB7CisgICAgICAgIHB1c2goQGhCb2R5LCAi I2lmICFkZWZpbmVkKFdFQktJVF9ESVNBQkxFX0RFUFJFQ0FURUQpXG4iKTsKKyAgICB9CisKICAg ICAjIEluc2VydCBpbnRyb3NwZWN0aW9uIGFubm90YXRpb25zCiAgICAgcHVzaChAaEJvZHksICIv KipcbiIpOwogICAgIHB1c2goQGhCb2R5LCAiICogJHtmdW5jdGlvbk5hbWV9OlxuIik7CkBAIC0x MDAxLDggKzEwMDUsMTQgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb24gewogICAgICAgICBwdXNoKEBo Qm9keSwgIldFQktJVF9BUEkgIik7CiAgICAgfQogICAgIHB1c2goQGhCb2R5LCAiJHJldHVyblR5 cGVcbiRmdW5jdGlvbk5hbWUoJGZ1bmN0aW9uU2lnKTtcbiIpOworICAgIGlmICgkZGVwcmVjYXRp b25WZXJzaW9uKSB7CisgICAgICAgIHB1c2goQGhCb2R5LCAiI2VuZGlmIC8qIFdFQktJVF9ESVNB QkxFX0RFUFJFQ0FURUQgKi9cbiIpOworICAgIH0KICAgICBwdXNoKEBoQm9keSwgIlxuIik7CiAK KyAgICBpZiAoJGRlcHJlY2F0aW9uVmVyc2lvbikgeworICAgICAgICBwdXNoKEBjQm9keSwgIiNp ZiAhZGVmaW5lZChXRUJLSVRfRElTQUJMRV9ERVBSRUNBVEVEKVxuIik7CisgICAgfQogICAgIHB1 c2goQGNCb2R5LCAiJHJldHVyblR5cGUgJGZ1bmN0aW9uTmFtZSgkZnVuY3Rpb25TaWcpXG57XG4i KTsKICAgICBwdXNoKEBjQm9keSwgIiNpZiAke3BhcmVudENvbmRpdGlvbmFsU3RyaW5nfVxuIikg aWYgJHBhcmVudENvbmRpdGlvbmFsU3RyaW5nOwogICAgIHB1c2goQGNCb2R5LCAiI2lmICR7Y29u ZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7CkBAIC0xMjE4LDcgKzEy MjgsMTMgQEAgRU9GCiAgICAgICAgIHB1c2goQGNCb2R5LCAiI2VuZGlmIC8qICR7cGFyZW50Q29u ZGl0aW9uYWxTdHJpbmd9ICovXG4iKTsKICAgICB9CiAKLSAgICBwdXNoKEBjQm9keSwgIn1cblxu Iik7CisgICAgcHVzaChAY0JvZHksICJ9XG4iKTsKKworICAgIGlmICgkZGVwcmVjYXRpb25WZXJz aW9uKSB7CisgICAgICAgIHB1c2goQGNCb2R5LCAiI2VuZGlmIC8qIFdFQktJVF9ESVNBQkxFX0RF UFJFQ0FURUQgKi9cbiIpOworICAgIH0KKworICAgIHB1c2goQGNCb2R5LCAiXG4iKTsKIH0KIAog c3ViIENsYXNzSGFzRnVuY3Rpb24gewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdEV2ZW50VGFyZ2V0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RF dmVudFRhcmdldC5jcHAKaW5kZXggMzcxOWZiYS4uNjk0Y2NiZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdEV2ZW50 VGFyZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09i amVjdC9XZWJLaXRET01UZXN0RXZlbnRUYXJnZXQuY3BwCkBAIC0xNDcsNiArMTQ3LDcgQEAgV2Vi S2l0RE9NTm9kZSogd2Via2l0X2RvbV90ZXN0X2V2ZW50X3RhcmdldF9pdGVtKFdlYktpdERPTVRl c3RFdmVudFRhcmdldCogc2VsZiwKICAgICByZXR1cm4gV2ViS2l0OjpraXQoZ29iamVjdFJlc3Vs dC5nZXQoKSk7CiB9CiAKKyNpZiAhZGVmaW5lZChXRUJLSVRfRElTQUJMRV9ERVBSRUNBVEVEKQog Z2Jvb2xlYW4gd2Via2l0X2RvbV90ZXN0X2V2ZW50X3RhcmdldF9kaXNwYXRjaF9ldmVudChXZWJL aXRET01UZXN0RXZlbnRUYXJnZXQqIHNlbGYsIFdlYktpdERPTUV2ZW50KiBldnQsIEdFcnJvcioq IGVycm9yKQogewogICAgIFdlYkNvcmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKQEAg LTE2Myw0ICsxNjQsNSBAQCBnYm9vbGVhbiB3ZWJraXRfZG9tX3Rlc3RfZXZlbnRfdGFyZ2V0X2Rp c3BhdGNoX2V2ZW50KFdlYktpdERPTVRlc3RFdmVudFRhcmdldCogcwogICAgIH0KICAgICByZXR1 cm4gcmVzdWx0OwogfQorI2VuZGlmIC8qIFdFQktJVF9ESVNBQkxFX0RFUFJFQ0FURUQgKi8KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3Qv V2ViS2l0RE9NVGVzdEV2ZW50VGFyZ2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0RXZlbnRUYXJnZXQuaAppbmRleCBmNjAxYWZi Li5kODRkNmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvR09iamVjdC9XZWJLaXRET01UZXN0RXZlbnRUYXJnZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0RXZlbnRUYXJnZXQu aApAQCAtNTksNiArNTksNyBAQCB3ZWJraXRfZG9tX3Rlc3RfZXZlbnRfdGFyZ2V0X2dldF90eXBl ICh2b2lkKTsKIFdFQktJVF9BUEkgV2ViS2l0RE9NTm9kZSoKIHdlYmtpdF9kb21fdGVzdF9ldmVu dF90YXJnZXRfaXRlbShXZWJLaXRET01UZXN0RXZlbnRUYXJnZXQqIHNlbGYsIGd1bG9uZyBpbmRl eCk7CiAKKyNpZiAhZGVmaW5lZChXRUJLSVRfRElTQUJMRV9ERVBSRUNBVEVEKQogLyoqCiAgKiB3 ZWJraXRfZG9tX3Rlc3RfZXZlbnRfdGFyZ2V0X2Rpc3BhdGNoX2V2ZW50OgogICogQHNlbGY6IEEg I1dlYktpdERPTVRlc3RFdmVudFRhcmdldApAQCAtNzEsNiArNzIsNyBAQCB3ZWJraXRfZG9tX3Rl c3RfZXZlbnRfdGFyZ2V0X2l0ZW0oV2ViS2l0RE9NVGVzdEV2ZW50VGFyZ2V0KiBzZWxmLCBndWxv bmcgaW5kZXgpOwogKiovCiBXRUJLSVRfREVQUkVDQVRFRF9GT1Iod2Via2l0X2RvbV9ldmVudF90 YXJnZXRfZGlzcGF0Y2hfZXZlbnQpIGdib29sZWFuCiB3ZWJraXRfZG9tX3Rlc3RfZXZlbnRfdGFy Z2V0X2Rpc3BhdGNoX2V2ZW50KFdlYktpdERPTVRlc3RFdmVudFRhcmdldCogc2VsZiwgV2ViS2l0 RE9NRXZlbnQqIGV2dCwgR0Vycm9yKiogZXJyb3IpOworI2VuZGlmIC8qIFdFQktJVF9ESVNBQkxF X0RFUFJFQ0FURUQgKi8KIAogR19FTkRfREVDTFMKIAo=