123859 2013-11-05 20:39:00 -0800 Remove npr.org specific hack in HTMLMediaElement 2013-11-07 14:06:26 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa eric.carlson commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble simon.fraser oldest_to_newest 947495 0 rniwa 2013-11-05 20:39:00 -0800 Consider removing the site specific hack added in http://trac.webkit.org/changeset/57820 Blink removed it in https://chromium.googlesource.com/chromium/blink/+/ca27419d2e33d5702db42cdb209db42a5df7d67d I can no longer reproduce the issue reported in <rdar://problem/7902467> on npr.org 947789 1 eric.carlson 2013-11-06 11:02:58 -0800 (In reply to comment #0) > Consider removing the site specific hack added in http://trac.webkit.org/changeset/57820 > The site-specific hack was added in <http://trac.webkit.org/changeset/58586>. 948365 2 eric.carlson 2013-11-07 11:39:39 -0800 The hack was added because the npr.org <audio> player had code that called play() when it got a 'canplay' event. The code was essentially: NPR.StaticEmbedAudio.audio_player.addEventListener('canplay',function() { NPR.StaticEmbedAudio.audio_duration=NPR.StaticEmbedAudio.audio_player.duration; NPR.StaticEmbedAudio.updateDuration(NPR.StaticEmbedAudio.audio_duration); NPR.StaticEmbedAudio.audio_ready=true; NPR.StaticEmbedAudio.audio_player.play(); }, true); The WebKit changes in r57820 caused the 'canplay' event to be fired when the src attribute was set from JS, which caused all <audio> elements on their site to begin playing automatically. The npr.org player has been changed, so we should remove the code added in r58586. 948394 3 rniwa 2013-11-07 13:14:52 -0800 Yeah, I can't find any video automatically playing on npr.org so it's probably safe to remove it. 948400 4 eric.carlson 2013-11-07 13:35:11 -0800 (In reply to comment #3) > Yeah, I can't find any video automatically playing on npr.org so it's probably safe to remove it. Only audio played automatically, not video. In any case, I checked their scripts and the code that caused the problem. has been removed. 948402 5 216330 eric.carlson 2013-11-07 13:35:53 -0800 Created attachment 216330 Proposed patch 948407 6 216330 jer.noble 2013-11-07 13:40:26 -0800 Comment on attachment 216330 Proposed patch r=me 948419 7 216330 commit-queue 2013-11-07 14:06:23 -0800 Comment on attachment 216330 Proposed patch Clearing flags on attachment: 216330 Committed r158874: <http://trac.webkit.org/changeset/158874> 948420 8 commit-queue 2013-11-07 14:06:26 -0800 All reviewed patches have been landed. Closing bug. 216330 2013-11-07 13:35:53 -0800 2013-11-07 14:06:23 -0800 Proposed patch patch_1.txt text/plain 3569 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODg2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTA3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBucHIub3Jn IHNwZWNpZmljIGhhY2sgaW4gSFRNTE1lZGlhRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBzaXRlIHNwZWNpZmljIGhhY2sg YWRkZWQgaW4gcjU3ODIwLCBpdCBpcyBubyBsb25nZXIgbmVjZXNzYXJ5LgorCisgICAgICAgICog aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVs ZW1lbnQ6OkhUTUxNZWRpYUVsZW1lbnQpOiBSZW1vdmUgbV9kaXNwYXRjaGluZ0NhblBsYXlFdmVu dC4KKyAgICAgICAgKEhUTUxNZWRpYUVsZW1lbnQ6OnBsYXkpOiBEb24ndCBzcGVjaWFsIGNhc2Ug bnByLm9yZy4KKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKwogMjAxMy0xMS0w NyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFNRTGl0 ZSBqb3VybmFsIG1vZGUgV0FMIChXcml0ZUFoZWFkTG9nZ2luZykKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMTU4NzgyKQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk1 LDcgKzI5NSw2IEBAIEhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRpYUVsZW1lbnQoY29uc3QKICNp ZiBFTkFCTEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKICAgICAsIG1fbmVlZFdpZGdldFVwZGF0 ZShmYWxzZSkKICNlbmRpZgotICAgICwgbV9kaXNwYXRjaGluZ0NhblBsYXlFdmVudChmYWxzZSkK ICAgICAsIG1fbG9hZEluaXRpYXRlZEJ5VXNlckdlc3R1cmUoZmFsc2UpCiAgICAgLCBtX2NvbXBs ZXRlbHlMb2FkZWQoZmFsc2UpCiAgICAgLCBtX2hhdmVQcmVwYXJlZFRvUGxheShmYWxzZSkKQEAg LTI0ODgsMTYgKzI0ODcsNiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnBsYXkoKQogICAgIGlm IChTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSkKICAgICAgICAgcmVt b3ZlQmVoYXZpb3JzUmVzdHJpY3Rpb25zQWZ0ZXJGaXJzdFVzZXJHZXN0dXJlKCk7CiAKLSAgICBT ZXR0aW5ncyogc2V0dGluZ3MgPSBkb2N1bWVudCgpLnNldHRpbmdzKCk7Ci0gICAgaWYgKHNldHRp bmdzICYmIHNldHRpbmdzLT5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpICYmIG1fZGlzcGF0Y2hp bmdDYW5QbGF5RXZlbnQgJiYgIW1fbG9hZEluaXRpYXRlZEJ5VXNlckdlc3R1cmUpIHsKLSAgICAg ICAgLy8gSXQgc2hvdWxkIGJlIGltcG9zc2libGUgdG8gYmUgcHJvY2Vzc2luZyB0aGUgY2FucGxh eSBldmVudCB3aGlsZSBoYW5kbGluZyBhIHVzZXIgZ2VzdHVyZQotICAgICAgICAvLyBzaW5jZSBp dCBpcyBkaXNwYXRjaGVkIGFzeW5jaHJvbm91c2x5LgotICAgICAgICBBU1NFUlQoIVNjcmlwdENv bnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKTsKLSAgICAgICAgU3RyaW5nIGhvc3Qg PSBkb2N1bWVudCgpLmJhc2VVUkwoKS5ob3N0KCk7Ci0gICAgICAgIGlmIChob3N0LmVuZHNXaXRo KCIubnByLm9yZyIsIGZhbHNlKSB8fCBlcXVhbElnbm9yaW5nQ2FzZShob3N0LCAibnByLm9yZyIp KQotICAgICAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIHBsYXlJbnRlcm5hbCgpOwogfQog CkBAIC00OTU2LDI0ICs0OTQ1LDYgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVNZWRp YUNvbnRybwogICAgICAgICBtX21lZGlhQ29udHJvbGxlci0+cmVwb3J0Q29udHJvbGxlclN0YXRl KCk7CiB9CiAKLWJvb2wgSFRNTE1lZGlhRWxlbWVudDo6ZGlzcGF0Y2hFdmVudChQYXNzUmVmUHRy PEV2ZW50PiBldmVudCkKLXsKLSAgICBib29sIGRpc3BhdGNoUmVzdWx0OwotICAgIGJvb2wgaXND YW5QbGF5RXZlbnQ7Ci0KLSAgICBpc0NhblBsYXlFdmVudCA9IChldmVudC0+dHlwZSgpID09IGV2 ZW50TmFtZXMoKS5jYW5wbGF5RXZlbnQpOwotCi0gICAgaWYgKGlzQ2FuUGxheUV2ZW50KQotICAg ICAgICBtX2Rpc3BhdGNoaW5nQ2FuUGxheUV2ZW50ID0gdHJ1ZTsKLQotICAgIGRpc3BhdGNoUmVz dWx0ID0gSFRNTEVsZW1lbnQ6OmRpc3BhdGNoRXZlbnQoZXZlbnQpOwotCi0gICAgaWYgKGlzQ2Fu UGxheUV2ZW50KQotICAgICAgICBtX2Rpc3BhdGNoaW5nQ2FuUGxheUV2ZW50ID0gZmFsc2U7Ci0K LSAgICByZXR1cm4gZGlzcGF0Y2hSZXN1bHQ7Ci19Ci0KIGJvb2wgSFRNTE1lZGlhRWxlbWVudDo6 aXNCbG9ja2VkKCkgY29uc3QKIHsKICAgICAvLyBBIG1lZGlhIGVsZW1lbnQgaXMgYSBibG9ja2Vk IG1lZGlhIGVsZW1lbnQgaWYgaXRzIHJlYWR5U3RhdGUgYXR0cmlidXRlIGlzIGluIHRoZQpJbmRl eDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgJKHJldmlzaW9uIDE1ODc4MikK KysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCSh3b3JraW5nIGNvcHkp CkBAIC0zNzcsOCArMzc3LDYgQEAgcHVibGljOgogICAgIE1lZGlhQ29udHJvbGxlciogY29udHJv bGxlcigpIGNvbnN0OwogICAgIHZvaWQgc2V0Q29udHJvbGxlcihQYXNzUmVmUHRyPE1lZGlhQ29u dHJvbGxlcj4pOwogCi0gICAgdmlydHVhbCBib29sIGRpc3BhdGNoRXZlbnQoUGFzc1JlZlB0cjxF dmVudD4pIE9WRVJSSURFOwotCiAgICAgdmlydHVhbCBib29sIHdpbGxSZXNwb25kVG9Nb3VzZUNs aWNrRXZlbnRzKCkgT1ZFUlJJREU7CiAKICAgICB2b2lkIGVudGVyZWRPckV4aXRlZEZ1bGxzY3Jl ZW4oKSB7IGNvbmZpZ3VyZU1lZGlhQ29udHJvbHMoKTsgfQpAQCAtNzMyLDcgKzczMCw2IEBAIHBy aXZhdGU6CiAgICAgYm9vbCBtX25lZWRXaWRnZXRVcGRhdGUgOiAxOwogI2VuZGlmCiAKLSAgICBi b29sIG1fZGlzcGF0Y2hpbmdDYW5QbGF5RXZlbnQgOiAxOwogICAgIGJvb2wgbV9sb2FkSW5pdGlh dGVkQnlVc2VyR2VzdHVyZSA6IDE7CiAgICAgYm9vbCBtX2NvbXBsZXRlbHlMb2FkZWQgOiAxOwog ICAgIGJvb2wgbV9oYXZlUHJlcGFyZWRUb1BsYXkgOiAxOwo=