123849 2013-11-05 19:12:41 -0800 FTL should support NewObject 2013-11-05 20:38:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough commit-queue ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 947458 0 fpizlo 2013-11-05 19:12:41 -0800 Patch forthcoming. 947459 1 216109 fpizlo 2013-11-05 19:13:36 -0800 Created attachment 216109 the patch 947460 2 commit-queue 2013-11-05 19:15:56 -0800 Attachment 216109 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp', u'Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1 Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:94: JSCell_freeListNext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 947494 3 fpizlo 2013-11-05 20:38:25 -0800 Landed in http://trac.webkit.org/changeset/158717 216109 2013-11-05 19:13:36 -0800 2013-11-05 20:18:06 -0800 the patch blah.patch text/plain 7049 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NzExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTExLTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZCBzdXBwb3J0IE5ld09iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5jcHA6 CisgICAgICAgIChKU0M6OkZUTDo6QWJzdHJhY3RIZWFwUmVwb3NpdG9yeTo6QWJzdHJhY3RIZWFw UmVwb3NpdG9yeSk6CisgICAgICAgICogZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaDoK KyAgICAgICAgKiBmdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpj YW5Db21waWxlKToKKyAgICAgICAgKiBmdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5oOgorICAg ICAgICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93 ZXJERkdUb0xMVk06OmNvbXBpbGVOb2RlKToKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1Rv TExWTTo6Y29tcGlsZU5ld09iamVjdCk6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xM Vk06OmFsbG9jYXRlKToKKwogMjAxMy0xMS0wNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBvbGQgdW51c2VkIGNvZGUgZm9yIGh5cG90aGV0aWNhbCBM TFZNIGludHJpbnNpY3MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJh Y3RIZWFwUmVwb3NpdG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmNwcAkocmV2aXNpb24gMTU4NzA3KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmNwcAko d29ya2luZyBjb3B5KQpAQCAtNDUsNiArNDUsOCBAQCBBYnN0cmFjdEhlYXBSZXBvc2l0b3J5OjpB YnN0cmFjdEhlYXBSZXBvCiAgICAgRk9SX0VBQ0hfQUJTVFJBQ1RfRklFTEQoQUJTVFJBQ1RfRklF TERfSU5JVElBTElaQVRJT04pCiAjdW5kZWYgQUJTVFJBQ1RfRklFTERfSU5JVElBTElaQVRJT04K ICAgICAKKyAgICAsIEpTQ2VsbF9mcmVlTGlzdE5leHQoSlNDZWxsX3N0cnVjdHVyZSkKKyAgICAK ICNkZWZpbmUgSU5ERVhFRF9BQlNUUkFDVF9IRUFQX0lOSVRJQUxJWkFUSU9OKG5hbWUsIHNpemUp ICwgbmFtZShjb250ZXh0LCAmcm9vdCwgI25hbWUsIHNpemUpCiAgICAgRk9SX0VBQ0hfSU5ERVhF RF9BQlNUUkFDVF9IRUFQKElOREVYRURfQUJTVFJBQ1RfSEVBUF9JTklUSUFMSVpBVElPTikKICN1 bmRlZiBJTkRFWEVEX0FCU1RSQUNUX0hFQVBfSU5JVElBTElaQVRJT04KQEAgLTYxLDYgKzYzLDgg QEAgQWJzdHJhY3RIZWFwUmVwb3NpdG9yeTo6QWJzdHJhY3RIZWFwUmVwbwogICAgIAogICAgIFJF TEVBU0VfQVNTRVJUKG1fdGJhYUtpbmQpOwogICAgIFJFTEVBU0VfQVNTRVJUKHJvb3QubV90YmFh TWV0YWRhdGEpOworICAgIAorICAgIFJFTEVBU0VfQVNTRVJUKCFKU0NlbGxfZnJlZUxpc3ROZXh0 Lm9mZnNldCgpKTsKIH0KIAogQWJzdHJhY3RIZWFwUmVwb3NpdG9yeTo6fkFic3RyYWN0SGVhcFJl cG9zaXRvcnkoKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhl YXBSZXBvc2l0b3J5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmgJKHJldmlzaW9uIDE1ODcwNykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5oCSh3b3JraW5nIGNv cHkpCkBAIC01MSw2ICs1MSw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgRlRMIHsKICAg ICBtYWNybyhKU1N0cmluZ19sZW5ndGgsIEpTU3RyaW5nOjpvZmZzZXRPZkxlbmd0aCgpKSBcCiAg ICAgbWFjcm8oSlNTdHJpbmdfdmFsdWUsIEpTU3RyaW5nOjpvZmZzZXRPZlZhbHVlKCkpIFwKICAg ICBtYWNybyhKU1ZhcmlhYmxlT2JqZWN0X3JlZ2lzdGVycywgSlNWYXJpYWJsZU9iamVjdDo6b2Zm c2V0T2ZSZWdpc3RlcnMoKSkgXAorICAgIG1hY3JvKE1hcmtlZEFsbG9jYXRvcl9mcmVlTGlzdEhl YWQsIE1hcmtlZEFsbG9jYXRvcjo6b2Zmc2V0T2ZGcmVlTGlzdEhlYWQoKSkgXAogICAgIG1hY3Jv KFN0cmluZ0ltcGxfZGF0YSwgU3RyaW5nSW1wbDo6ZGF0YU9mZnNldCgpKSBcCiAgICAgbWFjcm8o U3RyaW5nSW1wbF9oYXNoQW5kRmxhZ3MsIFN0cmluZ0ltcGw6OmZsYWdzT2Zmc2V0KCkpIFwKICAg ICBtYWNybyhTdHJ1Y3R1cmVfY2xhc3NJbmZvLCBTdHJ1Y3R1cmU6OmNsYXNzSW5mb09mZnNldCgp KSBcCkBAIC05MCw2ICs5MSw4IEBAIHB1YmxpYzoKICAgICBGT1JfRUFDSF9BQlNUUkFDVF9GSUVM RChBQlNUUkFDVF9GSUVMRF9ERUNMQVJBVElPTikKICN1bmRlZiBBQlNUUkFDVF9GSUVMRF9ERUNM QVJBVElPTgogICAgIAorICAgIEFic3RyYWN0RmllbGQmIEpTQ2VsbF9mcmVlTGlzdE5leHQ7Cisg ICAgCiAjZGVmaW5lIElOREVYRURfQUJTVFJBQ1RfSEVBUF9ERUNMQVJBVElPTihuYW1lLCBzaXpl KSBJbmRleGVkQWJzdHJhY3RIZWFwIG5hbWU7CiAgICAgRk9SX0VBQ0hfSU5ERVhFRF9BQlNUUkFD VF9IRUFQKElOREVYRURfQUJTVFJBQ1RfSEVBUF9ERUNMQVJBVElPTikKICN1bmRlZiBJTkRFWEVE X0FCU1RSQUNUX0hFQVBfREVDTEFSQVRJT04KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAJKHJldmlzaW9uIDE1ODcwNykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjIsNiArNjIsNyBAQCBpbmxpbmUgQ2FwYWJpbGl0eUxldmVsIGNhbkNvbXBpbGUoTm9kZSogCiAg ICAgY2FzZSBQdXRTdHJ1Y3R1cmU6CiAgICAgY2FzZSBQaGFudG9tUHV0U3RydWN0dXJlOgogICAg IGNhc2UgR2V0QnV0dGVyZmx5OgorICAgIGNhc2UgTmV3T2JqZWN0OgogICAgIGNhc2UgR2V0QnlP ZmZzZXQ6CiAgICAgY2FzZSBQdXRCeU9mZnNldDoKICAgICBjYXNlIEdldEdsb2JhbFZhcjoKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW50cmluc2ljUmVwb3Np dG9yeS5oCShyZXZpc2lvbiAxNTg3MDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TEludHJpbnNpY1JlcG9zaXRvcnkuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCBu YW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIEZUTCB7CiAgICAgbWFjcm8odHJhcCwgImxsdm0udHJh cCIsIGZ1bmN0aW9uVHlwZSh2b2lkVHlwZSkpCiAKICNkZWZpbmUgRk9SX0VBQ0hfRlVOQ1RJT05f VFlQRShtYWNybykgXAorICAgIG1hY3JvKENfSklUT3BlcmF0aW9uX0VTdCwgZnVuY3Rpb25UeXBl KGludFB0ciwgaW50UHRyLCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oSV9KSVRPcGVyYXRpb25fRUpz cywgZnVuY3Rpb25UeXBlKGludFB0ciwgaW50UHRyLCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oSl9K SVRPcGVyYXRpb25fRSwgZnVuY3Rpb25UeXBlKGludDY0LCBpbnRQdHIpKSBcCiAgICAgbWFjcm8o Sl9KSVRPcGVyYXRpb25fRUpzc1osIGZ1bmN0aW9uVHlwZShpbnQ2NCwgaW50UHRyLCBpbnRQdHIs IGludDMyKSkgXApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1Rv TExWTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dl ckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE1ODcwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjUsNiArMzY1 LDkgQEAgcHJpdmF0ZToKICAgICAgICAgY2FzZSBQdXRCeVZhbEFsaWFzOgogICAgICAgICAgICAg Y29tcGlsZVB1dEJ5VmFsKCk7CiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBOZXdP YmplY3Q6CisgICAgICAgICAgICBjb21waWxlTmV3T2JqZWN0KCk7CisgICAgICAgICAgICBicmVh azsKICAgICAgICAgY2FzZSBHZXRCeU9mZnNldDoKICAgICAgICAgICAgIGNvbXBpbGVHZXRCeU9m ZnNldCgpOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0xODAyLDYgKzE4MDUsMzIgQEAgcHJpdmF0 ZToKICAgICAgICAgfQogICAgIH0KICAgICAKKyAgICB2b2lkIGNvbXBpbGVOZXdPYmplY3QoKQor ICAgIHsKKyAgICAgICAgU3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSBtX25vZGUtPnN0cnVjdHVyZSgp OworICAgICAgICBzaXplX3QgYWxsb2NhdGlvblNpemUgPSBKU0ZpbmFsT2JqZWN0OjphbGxvY2F0 aW9uU2l6ZShzdHJ1Y3R1cmUtPmlubGluZUNhcGFjaXR5KCkpOworICAgICAgICBNYXJrZWRBbGxv Y2F0b3IqIGFsbG9jYXRvciA9ICZ2bSgpLmhlYXAuYWxsb2NhdG9yRm9yT2JqZWN0V2l0aG91dERl c3RydWN0b3IoYWxsb2NhdGlvblNpemUpOworICAgICAgICAKKyAgICAgICAgTEJhc2ljQmxvY2sg c2xvd1BhdGggPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIk5ld09iamVjdCBzbG93IHBhdGgiKSk7 CisgICAgICAgIExCYXNpY0Jsb2NrIGNvbnRpbnVhdGlvbiA9IEZUTF9ORVdfQkxPQ0sobV9vdXQs ICgiTmV3T2JqZWN0IGNvbnRpbnVhdGlvbiIpKTsKKyAgICAgICAgCisgICAgICAgIExCYXNpY0Js b2NrIGxhc3ROZXh0ID0gbV9vdXQuaW5zZXJ0TmV3QmxvY2tzQmVmb3JlKHNsb3dQYXRoKTsKKyAg ICAgICAgCisgICAgICAgIFZhbHVlRnJvbUJsb2NrIGZhc3RSZXN1bHQgPSBtX291dC5hbmNob3Io YWxsb2NhdGUoCisgICAgICAgICAgICBtX291dC5jb25zdEludFB0cihhbGxvY2F0b3IpLCBtX291 dC5jb25zdEludFB0cihzdHJ1Y3R1cmUpLCBtX291dC5pbnRQdHJaZXJvLCBzbG93UGF0aCkpOwor ICAgICAgICAKKyAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOworICAgICAgICAKKyAg ICAgICAgbV9vdXQuYXBwZW5kVG8oc2xvd1BhdGgsIGNvbnRpbnVhdGlvbik7CisgICAgICAgIAor ICAgICAgICBWYWx1ZUZyb21CbG9jayBzbG93UmVzdWx0ID0gbV9vdXQuYW5jaG9yKHZtQ2FsbCgK KyAgICAgICAgICAgIG1fb3V0Lm9wZXJhdGlvbihvcGVyYXRpb25OZXdPYmplY3QpLCBtX2NhbGxG cmFtZSwgbV9vdXQuY29uc3RJbnRQdHIoc3RydWN0dXJlKSkpOworICAgICAgICBtX291dC5qdW1w KGNvbnRpbnVhdGlvbik7CisgICAgICAgIAorICAgICAgICBtX291dC5hcHBlbmRUbyhjb250aW51 YXRpb24sIGxhc3ROZXh0KTsKKyAgICAgICAgc2V0SlNWYWx1ZShtX291dC5waGkobV9vdXQuaW50 UHRyLCBmYXN0UmVzdWx0LCBzbG93UmVzdWx0KSk7CisgICAgfQorICAgIAogICAgIHZvaWQgY29t cGlsZUdldEJ5T2Zmc2V0KCkKICAgICB7CiAgICAgICAgIFN0b3JhZ2VBY2Nlc3NEYXRhJiBkYXRh ID0KQEAgLTIyODIsNiArMjMxMSwyOCBAQCBwcml2YXRlOgogICAgICAgICBpbmZvLm1faXNJbnZh bGlkYXRpb25Qb2ludCA9IHRydWU7CiAgICAgfQogICAgIAorICAgIExWYWx1ZSBhbGxvY2F0ZSgK KyAgICAgICAgTFZhbHVlIGFsbG9jYXRvciwgTFZhbHVlIHN0cnVjdHVyZSwgTFZhbHVlIGJ1dHRl cmZseSwgTEJhc2ljQmxvY2sgc2xvd1BhdGgpCisgICAgeworICAgICAgICBMQmFzaWNCbG9jayBz dWNjZXNzID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJhbGxvY2F0aW9uIHN1Y2Nlc3MiKSk7Cisg ICAgICAgIAorICAgICAgICBMVmFsdWUgcmVzdWx0ID0gbV9vdXQubG9hZFB0cigKKyAgICAgICAg ICAgIGFsbG9jYXRvciwgbV9oZWFwcy5NYXJrZWRBbGxvY2F0b3JfZnJlZUxpc3RIZWFkKTsKKyAg ICAgICAgCisgICAgICAgIG1fb3V0LmJyYW5jaChtX291dC5ub3ROdWxsKHJlc3VsdCksIHN1Y2Nl c3MsIHNsb3dQYXRoKTsKKyAgICAgICAgCisgICAgICAgIG1fb3V0LmFwcGVuZFRvKHN1Y2Nlc3Mp OworICAgICAgICAKKyAgICAgICAgbV9vdXQuc3RvcmVQdHIoCisgICAgICAgICAgICBtX291dC5s b2FkUHRyKHJlc3VsdCwgbV9oZWFwcy5KU0NlbGxfZnJlZUxpc3ROZXh0KSwKKyAgICAgICAgICAg IGFsbG9jYXRvciwgbV9oZWFwcy5NYXJrZWRBbGxvY2F0b3JfZnJlZUxpc3RIZWFkKTsKKyAgICAg ICAgCisgICAgICAgIG1fb3V0LnN0b3JlUHRyKHN0cnVjdHVyZSwgcmVzdWx0LCBtX2hlYXBzLkpT Q2VsbF9zdHJ1Y3R1cmUpOworICAgICAgICBtX291dC5zdG9yZVB0cihidXR0ZXJmbHksIHJlc3Vs dCwgbV9oZWFwcy5KU09iamVjdF9idXR0ZXJmbHkpOworICAgICAgICAKKyAgICAgICAgcmV0dXJu IHJlc3VsdDsKKyAgICB9CisgICAgCiAgICAgTFZhbHVlIGJvb2xpZnkoRWRnZSBlZGdlKQogICAg IHsKICAgICAgICAgc3dpdGNoIChlZGdlLnVzZUtpbmQoKSkgewo=