123826 2013-11-05 13:29:06 -0800 Build broken for architecture with 4 argument registers since r158681 2013-11-05 14:28:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo mark.lam msaboff oldest_to_newest 947320 0 jbriance 2013-11-05 13:29:06 -0800 Changeset http://trac.webkit.org/changeset/158681 breaks the build of architectures with 4 argument registers: sh4, mips and arm. 947328 1 216072 jbriance 2013-11-05 13:37:10 -0800 Created attachment 216072 Build fix Move function using GPRInfo::argumentGPR4 under #if NUMBER_OF_ARGUMENT_REGISTERS >= 5 condition 947359 2 216072 commit-queue 2013-11-05 14:28:18 -0800 Comment on attachment 216072 Build fix Clearing flags on attachment: 216072 Committed r158692: <http://trac.webkit.org/changeset/158692> 947360 3 commit-queue 2013-11-05 14:28:20 -0800 All reviewed patches have been landed. Closing bug. 216072 2013-11-05 13:37:10 -0800 2013-11-05 14:28:18 -0800 Build fix bug-123826.patch text/plain 2054 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NjkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTExLTA1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBidWlsZCBmb3IgYXJjaGl0ZWN0dXJlcyB3aXRoIDQgYXJndW1lbnQgcmVnaXN0 ZXJzIChicm9rZW4gc2luY2UgcjE1ODY4MSkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGppdC9DQ2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6 Q0NhbGxIZWxwZXJzOjpzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUpOgorICAgICAgICAoSlND OjpDQ2FsbEhlbHBlcnM6OnNldHVwQXJndW1lbnRzKToKKwogMjAxMy0xMS0wNSAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCByZWdpc3RlciBhbGxvY2F0aW9u IGluc2lkZSBjb250cm9sIGZsb3cgaW4gR2V0QnlWYWwgU3RyaW5nCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHJldmlzaW9uIDE1ODY5MCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTkx MywxMyArOTEzLDYgQEAgcHVibGljOgogICAgICAgICBtb3ZlKGFyZzQsIEdQUkluZm86OmFyZ3Vt ZW50R1BSMyk7CiAgICAgfQogICAgIAotICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3Vt ZW50cyhHUFJSZWcgYXJnMSwgVHJ1c3RlZEltbVB0ciBhcmcyLCBHUFJSZWcgYXJnMywgR1BSUmVn IGFyZzQsIFRydXN0ZWRJbW1QdHIgYXJnNSkKLSAgICB7Ci0gICAgICAgIHNldHVwVGhyZWVTdHVi QXJnc0dQUjxHUFJJbmZvOjphcmd1bWVudEdQUjAsIEdQUkluZm86OmFyZ3VtZW50R1BSMiwgR1BS SW5mbzo6YXJndW1lbnRHUFIzPihhcmcxLCBhcmczLCBhcmc0KTsKLSAgICAgICAgbW92ZShhcmcy LCBHUFJJbmZvOjphcmd1bWVudEdQUjEpOwotICAgICAgICBtb3ZlKGFyZzUsIEdQUkluZm86OmFy Z3VtZW50R1BSNCk7Ci0gICAgfQotICAgIAogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFy Z3VtZW50cyhUcnVzdGVkSW1tUHRyIGFyZzEpCiAgICAgewogICAgICAgICBtb3ZlKGFyZzEsIEdQ UkluZm86OmFyZ3VtZW50R1BSMCk7CkBAIC0xNDY0LDYgKzE0NTcsMTMgQEAgcHVibGljOgogICAg ICAgICBtb3ZlKGFyZzQsIEdQUkluZm86OmFyZ3VtZW50R1BSNCk7CiAgICAgICAgIG1vdmUoR1BS SW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CiAgICAgfQor CisgICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzKEdQUlJlZyBhcmcxLCBUcnVz dGVkSW1tUHRyIGFyZzIsIEdQUlJlZyBhcmczLCBHUFJSZWcgYXJnNCwgVHJ1c3RlZEltbVB0ciBh cmc1KQorICAgIHsKKyAgICAgICAgc2V0dXBUaHJlZVN0dWJBcmdzR1BSPEdQUkluZm86OmFyZ3Vt ZW50R1BSMCwgR1BSSW5mbzo6YXJndW1lbnRHUFIyLCBHUFJJbmZvOjphcmd1bWVudEdQUjM+KGFy ZzEsIGFyZzMsIGFyZzQpOworICAgICAgICBtb3ZlKGFyZzIsIEdQUkluZm86OmFyZ3VtZW50R1BS MSk7CisgICAgICAgIG1vdmUoYXJnNSwgR1BSSW5mbzo6YXJndW1lbnRHUFI0KTsKKyAgICB9CiAj ZW5kaWYKIAogICAgIHZvaWQgc2V0dXBSZXN1bHRzKEdQUlJlZyBkZXN0QSwgR1BSUmVnIGRlc3RC KQo=