12382 2007-01-23 09:19:22 -0800 Crash on AMD64 in dtoa.cpp 2007-01-26 06:16:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ PC Linux RESOLVED FIXED P2 Normal --- 0 Camel webkit-unassigned lars.knoll oldest_to_newest 33043 0 Camel 2007-01-23 09:19:22 -0800 When trying out WebKit/Qt ( on my AMD64 machine I got various crashes in kjs_dtoa at dtoa.cpp:3015 *s++ = '0' + (int)L; The problem seems to that the containing loop does not terminate correctly, as at the time of the crash the loop was in its 36021 iteration. The kjs version in the KDE repository had a change applied: http://websvn.kde.org/trunk/KDE/kdelibs/kjs/dtoa.cpp?rev=569434&r1=564344&r2=569434 Following the change in the WebKit "dtoa.cpp" version seems to fix the crash. See also the comment in dtoa.cpp: //#define Long int on machines with 32-bit ints and 64-bit longs. 33044 1 12627 Camel 2007-01-23 09:26:53 -0800 Created attachment 12627 a small naive patch 32601 2 lars.knoll 2007-01-25 05:34:08 -0800 Makes absolutely sense. We're using the same code in Qt and have applied the same fix there. I'd r+ it if I had the right to do so ;-) 32618 3 12666 Camel 2007-01-25 10:03:14 -0800 Created attachment 12666 a simple naive patch Added change log entry and request review :-) I could not test for regressions, since it just did not run on my computer before this change. If there is a supported platform that has int < 32bit, stdint.h would need to be included, and the patch changed to: #define Long int32_t 32628 4 12668 Camel 2007-01-25 10:34:11 -0800 Created attachment 12668 same patch...better changelog Added the reason for the change to the changelog. (I had it in there before a i did a revert on the changelog...and then forgot to add it again) 32666 5 12668 mjs 2007-01-25 22:10:00 -0800 Comment on attachment 12668 same patch...better changelog r=me 32586 6 ddkilzer 2007-01-26 06:16:51 -0800 Committed by lars in r19136. 12627 2007-01-23 09:26:53 -0800 2007-01-25 10:03:14 -0800 a small naive patch dtoa.patch text/plain 270 Camel SW5kZXg6IGR0b2EuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGR0b2EuY3BwCShyZXZpc2lvbiAxOTA0NSkK KysrIGR0b2EuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNyArMTg4LDcgQEAKIAogCiAjaWZu ZGVmIExvbmcKLSNkZWZpbmUgTG9uZyBsb25nCisjZGVmaW5lIExvbmcgaW50CiAjZW5kaWYKICNp Zm5kZWYgVUxvbmcKIHR5cGVkZWYgdW5zaWduZWQgTG9uZyBVTG9uZzsK 12666 2007-01-25 10:03:14 -0800 2007-01-25 10:34:11 -0800 a simple naive patch dtoa.patch text/plain 798 Camel SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTIzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNy0wMS0yNSAgSmFuIEtyYWVt ZXIgIDxjYW1lbEBnbXguZGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBranMvZHRvYS5jcHA6ICNkZWZpbmUgTG9uZyBpbnQgYXMgc3VnZ2VzdGVk IGluIGNvbW1lbnQKKwogMjAwNy0wMS0yNCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeGVkIHVwICNpbmNsdWRlIG9yZGVyIGZvciBzdHlsZS4gTm8gcmV2 aWV3IG5lY2Vzc2FyeS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9kdG9hLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvZHRvYS5jcHAJKHJldmlzaW9uIDE5MTIzKQorKysg SmF2YVNjcmlwdENvcmUva2pzL2R0b2EuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNyArMTg4 LDcgQEAKIAogCiAjaWZuZGVmIExvbmcKLSNkZWZpbmUgTG9uZyBsb25nCisjZGVmaW5lIExvbmcg aW50CiAjZW5kaWYKICNpZm5kZWYgVUxvbmcKIHR5cGVkZWYgdW5zaWduZWQgTG9uZyBVTG9uZzsK 12668 2007-01-25 10:34:11 -0800 2007-01-25 22:10:00 -0800 same patch...better changelog dtoa.patch text/plain 909 Camel SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTIzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDEtMjUgIEphbiBLcmFl bWVyICA8Y2FtZWxAZ214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBjcmFzaCBvbiBhcmNoaXRlY3R1cmVzIHdpdGggMzIgYml0IGludHMg YW5kCisgICAgICAgIDY0IGJpdCBsb25ncyAoRm9yIGV4YW1wbGUgTGludXggb24gQU1ENjQpCisK KyAgICAgICAgKiBranMvZHRvYS5jcHA6ICNkZWZpbmUgTG9uZyBpbnQgYXMgc3VnZ2VzdGVkIGlu IGNvbW1lbnQKKwogMjAwNy0wMS0yNCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29t PgogCiAgICAgICAgIEZpeGVkIHVwICNpbmNsdWRlIG9yZGVyIGZvciBzdHlsZS4gTm8gcmV2aWV3 IG5lY2Vzc2FyeS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9kdG9hLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvZHRvYS5jcHAJKHJldmlzaW9uIDE5MTIzKQorKysgSmF2 YVNjcmlwdENvcmUva2pzL2R0b2EuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNyArMTg4LDcg QEAKIAogCiAjaWZuZGVmIExvbmcKLSNkZWZpbmUgTG9uZyBsb25nCisjZGVmaW5lIExvbmcgaW50 CiAjZW5kaWYKICNpZm5kZWYgVUxvbmcKIHR5cGVkZWYgdW5zaWduZWQgTG9uZyBVTG9uZzsK