123807 2013-11-05 09:07:15 -0800 [mips] Make regTx registers match between JSInterfaceJIT and GPRInfo for the MIPS backend. 2013-11-05 10:04:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo mark.lam oldest_to_newest 947213 0 jbriance 2013-11-05 09:07:15 -0800 As discussed in https://bugs.webkit.org/show_bug.cgi?id=123799, it would be better for backends that JSInterfaceJIT::regTx and GPRInfo::regTx match the same actual register. 947221 1 216045 jbriance 2013-11-05 09:19:56 -0800 Created attachment 216045 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. It turns out that this patch also fixes many issues seen during run-layout-jsc tests on my MIPS board. 947223 2 216045 jbriance 2013-11-05 09:29:37 -0800 Comment on attachment 216045 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. Forgot to change the ASSERT(reg < 16) in toIndex 947224 3 216047 jbriance 2013-11-05 09:30:23 -0800 Created attachment 216047 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). 947225 4 216047 mark.lam 2013-11-05 09:32:30 -0800 Comment on attachment 216047 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). r=me 947235 5 216047 commit-queue 2013-11-05 10:03:59 -0800 Comment on attachment 216047 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). Clearing flags on attachment: 216047 Committed r158677: <http://trac.webkit.org/changeset/158677> 947236 6 commit-queue 2013-11-05 10:04:02 -0800 All reviewed patches have been landed. Closing bug. 216045 2013-11-05 09:19:56 -0800 2013-11-05 09:29:36 -0800 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. bug-123807.patch text/plain 3112 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4Njc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTExLTA1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBNYWtlIHJlZ1R4IHJlZ2lzdGVycyBtYXRjaCBiZXR3ZWVuIEpTSW50ZXJm YWNlSklUIGFuZCBHUFJJbmZvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIzODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBqaXQvR1BSSW5mby5oOgorICAgICAgICAoSlNDOjpHUFJJbmZvOjp0b0lu ZGV4KToKKyAgICAgICAgKiBqaXQvSlNJbnRlcmZhY2VKSVQuaDoKKwogMjAxMy0xMS0wNSAgSnVs aWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlQGNpc2NvLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxNTgzMTUpOiBGaXggcmVnaXN0ZXIgbWl4dXAgaW4gSklUOjpjb21waWxlT3BDYWxsLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgJKHJldmlzaW9uIDE1ODY3MikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR1BSSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC01OTks OSArNTk5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnVDAgPSBNSVBT UmVnaXN0ZXJzOjp2MDsKICAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1QxID0gTUlQU1JlZ2lz dGVyczo6djE7CiAgICAgc3RhdGljIGNvbnN0IEdQUlJlZyByZWdUMiA9IE1JUFNSZWdpc3RlcnM6 OnQ0OwotICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnVDMgPSBNSVBTUmVnaXN0ZXJzOjp0NTsK LSAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6dDY7Ci0gICAg c3RhdGljIGNvbnN0IEdQUlJlZyByZWdUNSA9IE1JUFNSZWdpc3RlcnM6OnQ3OworICAgIHN0YXRp YyBjb25zdCBHUFJSZWcgcmVnVDMgPSBNSVBTUmVnaXN0ZXJzOjpzMjsKKyAgICBzdGF0aWMgY29u c3QgR1BSUmVnIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6dDU7CisgICAgc3RhdGljIGNvbnN0IEdQ UlJlZyByZWdUNSA9IE1JUFNSZWdpc3RlcnM6OnQ2OwogICAgIC8vIFRoZXNlIHJlZ2lzdGVycyBt YXRjaCB0aGUgYmFzZWxpbmUgSklULgogICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgY2FjaGVkUmVz dWx0UmVnaXN0ZXIgPSByZWdUMDsKICAgICBzdGF0aWMgY29uc3QgR1BSUmVnIGNhY2hlZFJlc3Vs dFJlZ2lzdGVyMiA9IHJlZ1QxOwpAQCAtNjI5LDcgKzYyOSwxMSBAQCBwdWJsaWM6CiAgICAgewog ICAgICAgICBBU1NFUlQocmVnICE9IEludmFsaWRHUFJSZWcpOwogICAgICAgICBBU1NFUlQocmVn IDwgMTYpOwotICAgICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgaW5kZXhGb3JSZWdpc3Rlclsx Nl0gPSB7IEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCAwLCAxLCBJbnZhbGlkSW5kZXgsIElu dmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52 YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgMiwgMywgNCwgNSB9OworICAg ICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgaW5kZXhGb3JSZWdpc3RlclsyNF0gPSB7CisgICAg ICAgICAgICBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgMCwgMSwgSW52YWxpZEluZGV4LCBJ bnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LAorICAgICAgICAgICAgSW52 YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCAyLCA0 LCA1LCBJbnZhbGlkSW5kZXgsCisgICAgICAgICAgICBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRl eCwgMywgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZElu ZGV4LCBJbnZhbGlkSW5kZXgKKyAgICAgICAgfTsKICAgICAgICAgdW5zaWduZWQgcmVzdWx0ID0g aW5kZXhGb3JSZWdpc3RlcltyZWddOwogICAgICAgICBBU1NFUlQocmVzdWx0ICE9IEludmFsaWRJ bmRleCk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pTSW50ZXJmYWNlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KU0ludGVyZmFjZUpJVC5oCShyZXZpc2lvbiAxNTg2NzIpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTE3Niw4 ICsxNzYsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgLy8gcmVnVDMgbXVzdCBiZSBzYXZl ZCBpbiB0aGUgY2FsbGVlLCBzbyB1c2UgYW4gUyByZWdpc3Rlci4KICAgICAgICAgc3RhdGljIGNv bnN0IFJlZ2lzdGVySUQgcmVnVDMgPSBNSVBTUmVnaXN0ZXJzOjpzMjsKICAgICAgICAgCi0gICAg ICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6czM7Ci0g ICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1Q1ID0gTUlQU1JlZ2lzdGVyczo6czQ7 CisgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6 dDU7CisgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1Q1ID0gTUlQU1JlZ2lzdGVy czo6dDY7CiAKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgY2FsbEZyYW1lUmVnaXN0 ZXIgPSBNSVBTUmVnaXN0ZXJzOjpzMDsKICAgICAgICAgCg== 216047 2013-11-05 09:30:23 -0800 2013-11-05 10:03:59 -0800 Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). bug-123807_2.patch text/plain 3180 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4Njc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTExLTA1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBNYWtlIHJlZ1R4IHJlZ2lzdGVycyBtYXRjaCBiZXR3ZWVuIEpTSW50ZXJm YWNlSklUIGFuZCBHUFJJbmZvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIzODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBqaXQvR1BSSW5mby5oOgorICAgICAgICAoSlNDOjpHUFJJbmZvOjp0b0lu ZGV4KToKKyAgICAgICAgKiBqaXQvSlNJbnRlcmZhY2VKSVQuaDoKKwogMjAxMy0xMS0wNSAgSnVs aWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlQGNpc2NvLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxNTgzMTUpOiBGaXggcmVnaXN0ZXIgbWl4dXAgaW4gSklUOjpjb21waWxlT3BDYWxsLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HUFJJbmZvLmgJKHJldmlzaW9uIDE1ODY3MikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR1BSSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC01OTks OSArNTk5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnVDAgPSBNSVBT UmVnaXN0ZXJzOjp2MDsKICAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1QxID0gTUlQU1JlZ2lz dGVyczo6djE7CiAgICAgc3RhdGljIGNvbnN0IEdQUlJlZyByZWdUMiA9IE1JUFNSZWdpc3RlcnM6 OnQ0OwotICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnVDMgPSBNSVBTUmVnaXN0ZXJzOjp0NTsK LSAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6dDY7Ci0gICAg c3RhdGljIGNvbnN0IEdQUlJlZyByZWdUNSA9IE1JUFNSZWdpc3RlcnM6OnQ3OworICAgIHN0YXRp YyBjb25zdCBHUFJSZWcgcmVnVDMgPSBNSVBTUmVnaXN0ZXJzOjpzMjsKKyAgICBzdGF0aWMgY29u c3QgR1BSUmVnIHJlZ1Q0ID0gTUlQU1JlZ2lzdGVyczo6dDU7CisgICAgc3RhdGljIGNvbnN0IEdQ UlJlZyByZWdUNSA9IE1JUFNSZWdpc3RlcnM6OnQ2OwogICAgIC8vIFRoZXNlIHJlZ2lzdGVycyBt YXRjaCB0aGUgYmFzZWxpbmUgSklULgogICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgY2FjaGVkUmVz dWx0UmVnaXN0ZXIgPSByZWdUMDsKICAgICBzdGF0aWMgY29uc3QgR1BSUmVnIGNhY2hlZFJlc3Vs dFJlZ2lzdGVyMiA9IHJlZ1QxOwpAQCAtNjI4LDggKzYyOCwxMiBAQCBwdWJsaWM6CiAgICAgc3Rh dGljIHVuc2lnbmVkIHRvSW5kZXgoR1BSUmVnIHJlZykKICAgICB7CiAgICAgICAgIEFTU0VSVChy ZWcgIT0gSW52YWxpZEdQUlJlZyk7Ci0gICAgICAgIEFTU0VSVChyZWcgPCAxNik7Ci0gICAgICAg IHN0YXRpYyBjb25zdCB1bnNpZ25lZCBpbmRleEZvclJlZ2lzdGVyWzE2XSA9IHsgSW52YWxpZElu ZGV4LCBJbnZhbGlkSW5kZXgsIDAsIDEsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZh bGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFs aWRJbmRleCwgSW52YWxpZEluZGV4LCAyLCAzLCA0LCA1IH07CisgICAgICAgIEFTU0VSVChyZWcg PCAyNCk7CisgICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBpbmRleEZvclJlZ2lzdGVyWzI0 XSA9IHsKKyAgICAgICAgICAgIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCAwLCAxLCBJbnZh bGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsCisgICAg ICAgICAgICBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZhbGlk SW5kZXgsIDIsIDQsIDUsIEludmFsaWRJbmRleCwKKyAgICAgICAgICAgIEludmFsaWRJbmRleCwg SW52YWxpZEluZGV4LCAzLCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4 LCBJbnZhbGlkSW5kZXgsIEludmFsaWRJbmRleAorICAgICAgICB9OwogICAgICAgICB1bnNpZ25l ZCByZXN1bHQgPSBpbmRleEZvclJlZ2lzdGVyW3JlZ107CiAgICAgICAgIEFTU0VSVChyZXN1bHQg IT0gSW52YWxpZEluZGV4KTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklULmgJKHJldmlzaW9uIDE1ODY3MikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaAkod29ya2luZyBjb3B5 KQpAQCAtMTc2LDggKzE3Niw4IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAvLyByZWdUMyBt dXN0IGJlIHNhdmVkIGluIHRoZSBjYWxsZWUsIHNvIHVzZSBhbiBTIHJlZ2lzdGVyLgogICAgICAg ICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCByZWdUMyA9IE1JUFNSZWdpc3RlcnM6OnMyOwogICAg ICAgICAKLSAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDQgPSBNSVBTUmVnaXN0 ZXJzOjpzMzsKLSAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDUgPSBNSVBTUmVn aXN0ZXJzOjpzNDsKKyAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDQgPSBNSVBT UmVnaXN0ZXJzOjp0NTsKKyAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDUgPSBN SVBTUmVnaXN0ZXJzOjp0NjsKIAogICAgICAgICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCBjYWxs RnJhbWVSZWdpc3RlciA9IE1JUFNSZWdpc3RlcnM6OnMwOwogICAgICAgICAK