123796 2013-11-05 03:21:57 -0800 [mips] Build is broken for MIPS platforms 2013-11-05 07:30:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo gergely kilvadyb msaboff oliver oldest_to_newest 947099 0 jbriance 2013-11-05 03:21:57 -0800 Build of JavaScriptCore is broken for mips architecture. Needed changes: - add framePointerRegister, firstRegister, lastRegister, firstFPRegister and lastFPRegister in MIPS assembler part - update MIPS assembler part to handle http://trac.webkit.org/changeset/157690 change 947100 1 216018 jbriance 2013-11-05 03:29:22 -0800 Created attachment 216018 Fix build for MIPS platforms. 947161 2 216018 commit-queue 2013-11-05 07:30:31 -0800 Comment on attachment 216018 Fix build for MIPS platforms. Clearing flags on attachment: 216018 Committed r158670: <http://trac.webkit.org/changeset/158670> 947162 3 commit-queue 2013-11-05 07:30:32 -0800 All reviewed patches have been landed. Closing bug. 216018 2013-11-05 03:29:22 -0800 2013-11-05 07:30:31 -0800 Fix build for MIPS platforms. bug-123796.patch text/plain 4817 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NjYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTExLTA1ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBGaXggYnVpbGQgZm9yIE1JUFMgcGxhdGZvcm1zLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNzk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTGlua0J1ZmZl ci5jcHA6CisgICAgICAgIChKU0M6OkxpbmtCdWZmZXI6OmxpbmtDb2RlKTogQWRkIHNwZWNpZmlj IE1JUFMgY2FsbCB0byByZWxvY2F0ZUp1bXBzLgorICAgICAgICAqIGFzc2VtYmxlci9NSVBTQXNz ZW1ibGVyLmg6IFJlbW92ZSBleGVjdXRhYmxlQ29weSAoYmVjYXVzZSBvZiByMTU3NjkwKSBhbmQg c2V0IHJlbG9jYXRlSnVtcHMgZnVuY3Rpb24gcHVibGljLgorICAgICAgICAoSlNDOjpNSVBTQXNz ZW1ibGVyOjpmaXJzdFJlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6bGFz dFJlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6Zmlyc3RGUFJlZ2lzdGVy KToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6bGFzdEZQUmVnaXN0ZXIpOgorICAgICAg ICAoSlNDOjpNSVBTQXNzZW1ibGVyOjpidWZmZXIpOiBOZWVkZWQgc2luY2UgcjE1NzY5MC4KKyAg ICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6IEFkZCBmcmFtZVBvaW50ZXJS ZWdpc3Rlci4KKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpyZXZlcnRKdW1wUmVw bGFjZW1lbnRUb1BhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaCk6IFJlbW92ZSB1bnVzZWQgcGFy YW1ldGVyIHdhcm5pbmcuCisKIDIwMTMtMTEtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBpbnRlcm5hbC1qcy10ZXN0cy55YW1sL09jdGFuZS9zdHJlc3MtdGVz dHMvcGRmanMuanMuZGVmYXVsdDogQVNTRVJUSU9OIEZBSUxFRDogbV9zdGF0ZS5mb3JOb2RlKGNo aWxkKS5tX2Z1dHVyZVBvc3NpYmxlU3RydWN0dXJlLmlzU3Vic2V0T2YoU3RydWN0dXJlU2V0KHN0 cnVjdHVyZSkpIGF0IERGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcDoyNDkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAkocmV2aXNpb24g MTU4NjU0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTUxLDYgKzE1MSw5IEBAIHZvaWQgTGlua0J1ZmZlcjo6bGlu a0NvZGUodm9pZCogb3duZXJVSUQKICAgICBtX2Fzc2VtYmxlci0+bV9hc3NlbWJsZXIucHJlcGFy ZUV4ZWN1dGFibGVDb3B5KG1fY29kZSk7CiAjZW5kaWYKICAgICBtZW1jcHkobV9jb2RlLCBidWZm ZXIuZGF0YSgpLCBidWZmZXIuY29kZVNpemUoKSk7CisjaWYgQ1BVKE1JUFMpCisgICAgbV9hc3Nl bWJsZXItPm1fYXNzZW1ibGVyLnJlbG9jYXRlSnVtcHMoYnVmZmVyLmRhdGEoKSwgbV9jb2RlKTsK KyNlbmRpZgogI2VsaWYgQ1BVKEFSTV9USFVNQjIpCiAgICAgY29weUNvbXBhY3RBbmRMaW5rQ29k ZTx1aW50MTZfdD4ob3duZXJVSUQsIGVmZm9ydCk7CiAjZWxpZiBDUFUoQVJNNjQpCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAkocmV2 aXNpb24gMTU4NjU0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNz ZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1MSwxMiArMTUxLDIwIEBAIHB1YmxpYzoKICAg ICB0eXBlZGVmIE1JUFNSZWdpc3RlcnM6OkZQUmVnaXN0ZXJJRCBGUFJlZ2lzdGVySUQ7CiAgICAg dHlwZWRlZiBTZWdtZW50ZWRWZWN0b3I8QXNzZW1ibGVyTGFiZWwsIDY0PiBKdW1wczsKIAorICAg IHN0YXRpYyBSZWdpc3RlcklEIGZpcnN0UmVnaXN0ZXIoKSB7IHJldHVybiBNSVBTUmVnaXN0ZXJz OjpyMDsgfQorICAgIHN0YXRpYyBSZWdpc3RlcklEIGxhc3RSZWdpc3RlcigpIHsgcmV0dXJuIE1J UFNSZWdpc3RlcnM6OnIzMTsgfQorCisgICAgc3RhdGljIEZQUmVnaXN0ZXJJRCBmaXJzdEZQUmVn aXN0ZXIoKSB7IHJldHVybiBNSVBTUmVnaXN0ZXJzOjpmMDsgfQorICAgIHN0YXRpYyBGUFJlZ2lz dGVySUQgbGFzdEZQUmVnaXN0ZXIoKSB7IHJldHVybiBNSVBTUmVnaXN0ZXJzOjpmMzE7IH0KKwog ICAgIE1JUFNBc3NlbWJsZXIoKQogICAgICAgICA6IG1faW5kZXhPZkxhc3RXYXRjaHBvaW50KElO VF9NSU4pCiAgICAgICAgICwgbV9pbmRleE9mVGFpbE9mTGFzdFdhdGNocG9pbnQoSU5UX01JTikK ICAgICB7CiAgICAgfQogCisgICAgQXNzZW1ibGVyQnVmZmVyJiBidWZmZXIoKSB7IHJldHVybiBt X2J1ZmZlcjsgfQorCiAgICAgLy8gTUlQUyBpbnN0cnVjdGlvbiBvcGNvZGUgZmllbGQgcG9zaXRp b24KICAgICBlbnVtIHsKICAgICAgICAgT1BfU0hfUkQgPSAxMSwKQEAgLTY3NiwxNiArNjg0LDYg QEAgcHVibGljOgogICAgICAgICByZXR1cm4gbV9idWZmZXIuY29kZVNpemUoKTsKICAgICB9CiAK LSAgICBQYXNzUmVmUHRyPEV4ZWN1dGFibGVNZW1vcnlIYW5kbGU+IGV4ZWN1dGFibGVDb3B5KFZN JiB2bSwgdm9pZCogb3duZXJVSUQsIEpJVENvbXBpbGF0aW9uRWZmb3J0IGVmZm9ydCkKLSAgICB7 Ci0gICAgICAgIFJlZlB0cjxFeGVjdXRhYmxlTWVtb3J5SGFuZGxlPiByZXN1bHQgPSBtX2J1ZmZl ci5leGVjdXRhYmxlQ29weSh2bSwgb3duZXJVSUQsIGVmZm9ydCk7Ci0gICAgICAgIGlmICghcmVz dWx0KQotICAgICAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICAgICAgcmVsb2NhdGVKdW1wcyhtX2J1 ZmZlci5kYXRhKCksIHJlc3VsdC0+c3RhcnQoKSk7Ci0gICAgICAgIHJldHVybiByZXN1bHQucmVs ZWFzZSgpOwotICAgIH0KLQogICAgIHVuc2lnbmVkIGRlYnVnT2Zmc2V0KCkgeyByZXR1cm4gbV9i dWZmZXIuZGVidWdPZmZzZXQoKTsgfQogCiAgICAgLy8gQXNzZW1ibHkgaGVscGVycyBmb3IgbW92 aW5nIGRhdGEgYmV0d2VlbiBmcCBhbmQgcmVnaXN0ZXJzLgpAQCAtOTQ1LDcgKzk0Myw2IEBAIHB1 YmxpYzoKICAgICAgICAgY2FjaGVGbHVzaChpbnNuLCA0KTsKICAgICB9CiAKLXByaXZhdGU6CiAg ICAgLyogVXBkYXRlIGVhY2gganVtcCBpbiB0aGUgYnVmZmVyIG9mIG5ld0Jhc2UuICAqLwogICAg IHZvaWQgcmVsb2NhdGVKdW1wcyh2b2lkKiBvbGRCYXNlLCB2b2lkKiBuZXdCYXNlKQogICAgIHsK QEAgLTk4OCw2ICs5ODUsNyBAQCBwcml2YXRlOgogICAgICAgICB9CiAgICAgfQogCitwcml2YXRl OgogICAgIHN0YXRpYyBpbnQgbGlua1dpdGhPZmZzZXQoTUlQU1dvcmQqIGluc24sIHZvaWQqIHRv KQogICAgIHsKICAgICAgICAgQVNTRVJUKCgqaW5zbiAmIDB4ZmMwMDAwMDApID09IDB4MTAwMDAw MDAgLy8gYmVxCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyTUlQUy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHJldmlzaW9uIDE1ODY1NCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkK QEAgLTEwMSw2ICsxMDEsNyBAQCBwdWJsaWM6CiAgICAgfTsKIAogICAgIHN0YXRpYyBjb25zdCBS ZWdpc3RlcklEIHN0YWNrUG9pbnRlclJlZ2lzdGVyID0gTUlQU1JlZ2lzdGVyczo6c3A7CisgICAg c3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgZnJhbWVQb2ludGVyUmVnaXN0ZXIgPSBNSVBTUmVnaXN0 ZXJzOjpzMDsKICAgICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCByZXR1cm5BZGRyZXNzUmVnaXN0 ZXIgPSBNSVBTUmVnaXN0ZXJzOjpyYTsKIAogICAgIC8vIEludGVnZXIgYXJpdGhtZXRpYyBvcGVy YXRpb25zOgpAQCAtMjczMiw3ICsyNzMzLDcgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gQ29k ZUxvY2F0aW9uTGFiZWwoKTsKICAgICB9CiAKLSAgICBzdGF0aWMgdm9pZCByZXZlcnRKdW1wUmVw bGFjZW1lbnRUb1BhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaChDb2RlTG9jYXRpb25MYWJlbCBp bnN0cnVjdGlvblN0YXJ0LCBBZGRyZXNzLCB2b2lkKiBpbml0aWFsVmFsdWUpCisgICAgc3RhdGlj IHZvaWQgcmV2ZXJ0SnVtcFJlcGxhY2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2go Q29kZUxvY2F0aW9uTGFiZWwsIEFkZHJlc3MsIHZvaWQqKQogICAgIHsKICAgICAgICAgVU5SRUFD SEFCTEVfRk9SX1BMQVRGT1JNKCk7CiAgICAgfQo=